Fix up syncing mode

InetlliSync,Opie1.0,QtopiaNEW

3 files changed, 26 insertions, 7 deletions

diff --git a/core/launcher/qcopbridge.cpp b/core/launcher/qcopbridge.cpp
index b45f0cc..9bca360 100644
--- a/core/launcher/qcopbridge.cpp
+++ b/core/launcher/qcopbridge.cpp
@@ -152,33 +152,33 @@ void QCopBridge::closeOpenConnections()
 
 void QCopBridge::desktopMessage( const QCString &command, const QByteArray &data )
 {
     if ( command == "startSync()" ) {
 	// we need to buffer it a bit
 	sendSync = TRUE;
 	startTimer( 20000 );
     }
 
     if ( m_mode & Qtopia1_7 ) {
         // send the command to all open connections
         QCopBridgePI *pi;
         for ( pi = openConnections.first(); pi != 0; pi = openConnections.next() ) {
             pi->sendDesktopMessage( command, data );
         }
     }
-    if ( m_mode & Sharp )
+    if ( ( m_mode & Sharp ) || (m_mode & IntelliSync) )
         sendDesktopMessageOld( command, data );
 }
 
 #ifndef OPIE_NO_OLD_SYNC_CODE
 /*
  * Old compat mode
  */
 void QCopBridge::sendDesktopMessageOld( const QCString& command, const QByteArray& args) {
     command.stripWhiteSpace();
 
     int paren = command.find( "(" );
     if ( paren <= 0 ) {
 	qDebug("DesktopMessage: bad qcop syntax");
 	return;
     }
 
diff --git a/core/launcher/qcopbridge.h b/core/launcher/qcopbridge.h
index 9483d9d..d5988cd 100644
--- a/core/launcher/qcopbridge.h
+++ b/core/launcher/qcopbridge.h
@@ -24,33 +24,34 @@
 #include <qserversocket.h>
 #include <qsocket.h>
 #include <qdir.h>
 #include <qfile.h>
 #include <qbuffer.h>
 
 class QFileInfo;
 class QCopBridgePI;
 class QCopChannel;
 class QTimer;
 
 class QCopBridge : public QServerSocket
 {
     Q_OBJECT
 
 public:
-    enum Mode  { Qtopia1_7= 0x01, Sharp = 0x02, Both = Qtopia1_7 | Sharp };
+    /* can not or anymore :) */
+    enum Mode  { Qtopia1_7= 0x01, Sharp = 0x02, IntelliSync = 0x04 };
     QCopBridge( Q_UINT16 port, QObject *parent = 0, const char* name = 0 );
     virtual ~QCopBridge();
 
     void newConnection( int socket );
     void closeOpenConnections();
     void authorizeConnections();
 
 public slots:
     void closed( QCopBridgePI *pi );
     void desktopMessage( const QCString &call, const QByteArray & );
 
 signals:
     void connectionClosed( const QHostAddress & );
 
 protected:
     void timerEvent( QTimerEvent * );
diff --git a/core/launcher/transferserver.cpp b/core/launcher/transferserver.cpp
index 9cb9d7a..8367a62 100644
--- a/core/launcher/transferserver.cpp
+++ b/core/launcher/transferserver.cpp
@@ -181,41 +181,59 @@ bool SyncAuthentication::checkPassword( const QString& password )
 
     QString cpwd = QString::fromLocal8Bit( pw->pw_passwd );
     if ( cpwd == "x" && spw )
 	cpwd = QString::fromLocal8Bit( spw->sp_pwdp );
 
     // Note: some systems use more than crypt for passwords.
     QString cpassword = QString::fromLocal8Bit( crypt( password.local8Bit(), cpwd.local8Bit() ) );
     if ( cpwd == cpassword )
 	return TRUE;
 #endif
 
     static int lastdenial=0;
     static int denials=0;
     int now = time(0);
 
     Config cfg("Security");
-    cfg.setGroup("Sync");
-    QString syncapp = cfg.readEntry("syncapp","Qtopia");
+    cfg.setGroup("SyncMode");
+    int mode = cfg.readNumEntry("Mode", 0x02 );
 
-    //No password needed if the user really wants it
-    if (syncapp == "IntelliSync") {
+    //No pass word needed if the user really needs it
+    if (mode & 0x04) {
+        QMessageBox unauth(
+            tr("Sync Connection"),
+            tr("<qt><p>An unauthorized system is requesting access to this device."
+               "<p>You chose IntelliSync so you may I allow or deny this connection.</qt>" ),
+            QMessageBox::Warning,
+            QMessageBox::Ok, QMessageBox::Cancel|QMessageBox::Default, QMessageBox::NoButton,
+            0, QString::null, TRUE, WStyle_StaysOnTop);
+        unauth.setButtonText(QMessageBox::Ok, tr("Allow" ) );
+        unauth.setButtonText(QMessageBox::Cancel, tr("Deny"));
+        switch( unauth.exec() ) {
+        case QMessageBox::Ok:
     	return TRUE;
+            break;
+        case QMessageBox::Cancel:
+        default:
+            denials++;
+            lastdenial=now;
+            return FALSE;
+        }
     }
 
-    // Detect old Qtopia Desktop (no password)
+    // Detect old Qtopia Desktop (no password) and fail
     if ( password.isEmpty() ) {
 		if ( denials < 3 || now > lastdenial+600 ) {
 		    QMessageBox unauth(
 			tr("Sync Connection"),
 			tr("<p>An unauthorized system is requesting access to this device."
 			    "<p>If you are using a version of Qtopia Desktop older than 1.5.1, "
 			    "please upgrade or change the security setting to use IntelliSync." ),
 			QMessageBox::Warning,
 			QMessageBox::Cancel, QMessageBox::NoButton, QMessageBox::NoButton,
 			0, QString::null, TRUE, WStyle_StaysOnTop);
 		    unauth.setButtonText(QMessageBox::Cancel, tr("Deny"));
 		    unauth.exec();
 
 		    denials++;
 		    lastdenial=now;
 		 }