gcc3.4 fixlet

1 files changed, 7 insertions, 7 deletions

diff --git a/noncore/settings/appearance2/appearance.cpp b/noncore/settings/appearance2/appearance.cpp
index 6b9fe4d..f918767 100644
--- a/noncore/settings/appearance2/appearance.cpp
+++ b/noncore/settings/appearance2/appearance.cpp
@@ -488,403 +488,403 @@ Appearance::Appearance( QWidget* parent,  const char* name, WFlags )
     top-> addWidget ( m_sample, 1 );
 
     tw-> setCurrentTab ( styletab );
     connect ( tw, SIGNAL( currentChanged(QWidget*)), this, SLOT( tabChanged(QWidget*)));
 
     m_style_changed = m_font_changed = m_color_changed = m_deco_changed = false;
 }
 
 Appearance::~Appearance()
 {}
 
 void Appearance::tabChanged ( QWidget *w )
 {
     if ( w == m_advtab )
     {
         m_sample-> hide ( );
         updateGeometry ( ); // shouldn't be necessary ...
     }
     else
         m_sample-> show ( );
 }
 
 void Appearance::accept ( )
 {
     bool newtabpos = m_tabstyle_top-> isChecked ( );
     int newtabstyle = m_tabstyle_list-> currentItem ( );
 
     Config config ( "qpe" );
     config. setGroup ( "Appearance" );
 
     if ( m_style_changed )
     {
         StyleListItem *item = (StyleListItem *) m_style_list-> item ( m_style_list-> currentItem ( ));
         if ( item )
             config.writeEntry( "Style", item-> key ( ));
     }
 
     if ( m_deco_changed )
     {
         DecoListItem *item = (DecoListItem *) m_deco_list-> item ( m_deco_list-> currentItem ( ));
         if ( item )
             config.writeEntry( "Decoration", item-> key ( ));
     }
 
     if (( newtabstyle != m_original_tabstyle ) || ( newtabpos != m_original_tabpos ))
     {
         config. writeEntry ( "TabStyle", newtabstyle + 1 );
         config. writeEntry ( "TabPosition", newtabpos ? "Top" : "Bottom" );
     }
 
     if ( m_font_changed )
     {
         config. writeEntry ( "FontFamily", m_fontselect-> fontFamily ( ));
         config. writeEntry ( "FontStyle", m_fontselect-> fontStyle ( ));
         config. writeEntry ( "FontSize", m_fontselect-> fontSize ( ));
     }
 
 
     if ( m_color_changed )
     {
         ColorListItem *item = (ColorListItem *) m_color_list-> item ( m_color_list-> currentItem ( ));
 
         if ( item )
             item-> save ( config );
     }
 
     ODirection rot;
     if (m_rotdir_ccw-> isChecked ( ))
     {
         rot = CCW;
     }
     else if (m_rotdir_cw-> isChecked ( ))
     {
         rot = CW;
     }
     else
     {
         rot = Flip;
     }
     config. writeEntry ( "rotatedir", (int)rot );
 
     m_except-> setFocus ( ); // if the focus was on the embedded line-edit, we have to move it away first, so the contents are updated
 
     QStringList sl;
     QString exceptstr;
     for ( ExceptListItem *it = (ExceptListItem *) m_except-> firstChild ( ); it; it = (ExceptListItem *) it-> nextSibling ( ))
     {
         int fl = 0;
         fl |= ( it-> noStyle ( ) ? 0x01 : 0 );
         fl |= ( it-> noFont ( ) ? 0x02 : 0 );
         fl |= ( it-> noDeco ( ) ? 0x04 : 0 );
         exceptstr = QString::number ( fl, 32 );
         exceptstr.append( it-> pattern ( ));
         sl << exceptstr;
     }
     config. writeEntry ( "NoStyle", sl, ';' );
     config. writeEntry ( "ForceStyle", m_force-> isChecked ( ));
 
     config. write ( ); // need to flush the config info first
     Global::applyStyle ( );
 
     QDialog::accept ( );
 }
 
 void Appearance::done ( int r )
 {
     QDialog::done ( r );
     close ( );
 }
 
 
 void Appearance::styleClicked ( int index )
 {
     StyleListItem *sli = (StyleListItem *) m_style_list-> item ( index );
     m_style_settings-> setEnabled ( sli ? sli-> hasSettings ( ) : false );
 
     if ( m_sample && sli && sli-> style ( ))
     {
         int ci = m_color_list ? m_color_list-> currentItem ( ) : -1;
 
         m_sample-> setStyle2 ( sli-> style ( ), ci < 0 ? palette ( ) : ((ColorListItem *) m_color_list-> item ( ci ))-> palette ( ));
     }
 
     m_style_changed |= ( index != m_original_style );
 }
 
 void Appearance::styleSettingsClicked ( )
 {
     StyleListItem *item = (StyleListItem *) m_style_list-> item ( m_style_list-> currentItem ( ));
 
     if ( item && item-> hasSettings ( ))
     {
         QDialog *d = new QDialog ( this, "SETTINGS-DLG", true );
         QVBoxLayout *vbox = new QVBoxLayout ( d, 3, 0 );
 
         QWidget *w = item-> settings ( d );
 
         if ( w )
         {
             vbox-> addWidget ( w );
 
             d-> setCaption ( w-> caption ( ));
 
             bool accepted = ( QPEApplication::execDialog ( d ) == QDialog::Accepted );
 
             if ( item-> setSettings ( accepted ))
                 m_style_changed = true;
         }
         delete d;
     }
 }
 
 void Appearance::decoClicked ( int index )
 {
     DecoListItem *dli = (DecoListItem *) m_deco_list-> item ( index );
 
     if ( m_sample )
     {
         if ( dli && dli-> interface ( ))
             m_sample-> setDecoration ( dli-> interface ( ));
         else
             m_sample-> setDecoration ( new DefaultWindowDecoration ( ));
         m_sample-> repaint ( );
     }
     m_deco_changed |= ( index != m_original_deco );
 }
 
 void Appearance::fontClicked ( const QFont &f )
 {
     m_font_changed |= ( f != m_sample-> font ( ));
     m_sample-> setFont ( f );
 }
 
 void Appearance::colorClicked ( int index )
 {
     ColorListItem *item = (ColorListItem *) m_color_list-> item ( index );
 
     if ( item )
         m_sample-> setPalette ( item-> palette ( ));
 
     m_color_changed |= ( item-> palette ( ) != qApp-> palette ( ));
 }
 
 
 void Appearance::editSchemeClicked ( )
 {
     ColorListItem *item = (ColorListItem *) m_color_list-> item ( m_color_list-> currentItem ( ));
 
     int cnt = 0;
     QString labels [QColorGroup::NColorRoles];
     QColor colors [QColorGroup::NColorRoles];
 
-    for ( QColorGroup::ColorRole role = (QColorGroup::ColorRole) 0; role != QColorGroup::NColorRoles; ((int) role )++ )
+    for ( int role = 0; role < (int) QColorGroup::NColorRoles; ++role )
     {
-        QColor col = item-> color ( role );
+        QColor col = item->color( static_cast<QColorGroup::ColorRole>( role ) );
 
         if ( col. isValid ( ))
         {
-            labels [cnt] = item-> label ( role );
-            colors [cnt] = col;
+            labels[cnt] = item->label( static_cast<QColorGroup::ColorRole>( role ) );
+            colors[cnt] = col;
 
             cnt++;
         }
     }
 
     EditScheme* editdlg = new EditScheme( cnt, labels, colors, this, "editScheme", true );
     if ( QPEApplication::execDialog( editdlg ) == QDialog::Accepted )
     {
         ColorListItem *citem = (ColorListItem *) m_color_list-> item ( 0 );
         cnt = 0;
 
-        for ( QColorGroup::ColorRole role = (QColorGroup::ColorRole) 0; role != QColorGroup::NColorRoles; ((int) role )++ )
+        for ( int role = 0; role < (int) QColorGroup::NColorRoles; ++role )
         {
-            if ( item-> color ( role ). isValid ( ))
+            if ( item->color( static_cast<QColorGroup::ColorRole>( role ) ).isValid() )
             {
-                citem-> setColor ( role, colors [cnt] );
+                citem->setColor( static_cast<QColorGroup::ColorRole>( role ), colors[cnt] );
                 cnt++;
             }
         }
 
         m_color_list-> setCurrentItem ( 0 );
         colorClicked ( 0 );
 
         m_color_changed = true;
     }
     delete editdlg;
 }
 
 
 void Appearance::saveSchemeClicked()
 {
     ColorListItem *item = (ColorListItem *) m_color_list-> item ( m_color_list-> currentItem ( ));
 
     if ( !item )
         return;
 
     QDialog *d = new QDialog ( this, 0, true );
     d-> setCaption ( tr( "Save Scheme" ));
     QLineEdit *ed = new QLineEdit ( d );
     ( new QVBoxLayout ( d, 3, 3 ))-> addWidget ( ed );
     ed-> setFocus ( );
 
     if ( d-> exec ( ) == QDialog::Accepted )
     {
         QString schemename = ed-> text ( );
         QString filestr = QPEApplication::qpeDir();
         filestr.append( "/etc/colors/" );
         filestr.append( schemename );
         filestr.append( ".scheme" );
         QFile file ( filestr );
         if ( !file. exists ( ))
         {
             QPalette p = item-> palette ( );
 
             Config config ( file.name(), Config::File );
             config. setGroup( "Colors" );
 
             item-> save ( config );
 
             config. write ( ); // need to flush the config info first
 
             m_color_list-> insertItem ( new ColorListItem ( schemename, config ));
         }
         else
         {
             QMessageBox::information ( this, tr( "Save scheme" ), tr( "Scheme does already exist." ));
         }
     }
     delete d;
 }
 
 void Appearance::deleteSchemeClicked()
 {
     ColorListItem *item = (ColorListItem *) m_color_list-> item ( m_color_list-> currentItem ( ));
 
     if ( !item )
         return;
 
     if ( m_color_list-> currentItem ( ) > 0 )
     {
         if ( QPEMessageBox::confirmDelete ( this, tr( "Delete scheme" ), item-> text ( ) ) )
         {
             QString filestr = QPEApplication::qpeDir ( );
             filestr.append( "/etc/colors/" );
             filestr.append( item-> text ( ) );
             filestr.append( ".scheme" );
             QFile::remove ( filestr );
             delete item;
         }
     }
     else
     {
         QMessageBox::information( this, tr( "Delete scheme" ), tr( "Unable to delete current scheme." ));
     }
 }
 
 
 void Appearance::addExcept ( )
 {
     ExceptListItem *it = new ExceptListItem ( m_except, 0, tr( "<new>" ), true, true, true );
     m_except-> ensureItemVisible ( it );
     m_except-> setSelected ( it, true );
 }
 
 void Appearance::delExcept ( )
 {
     if ( m_except-> selectedItem ( ))
     {
         m_except-> setFocus ( );
         delete m_except-> selectedItem ( );
     }
 }
 
 void Appearance::upExcept ( )
 {
     ExceptListItem *it = (ExceptListItem *) m_except-> selectedItem ( );
 
     if ( it && it-> itemAbove ( ))
         it-> itemAbove ( )-> moveItem ( it );
 }
 
 void Appearance::downExcept ( )
 {
     ExceptListItem *it = (ExceptListItem *) m_except-> selectedItem ( );
 
     if ( it && it-> itemBelow ( ))
         it-> moveItem ( it-> itemBelow ( ));
 }
 
 class ExEdit : public QLineEdit
 {
 public:
     ExEdit ( ExceptListItem *item )
             : QLineEdit ( item-> listView ( )-> viewport ( ), "exedit" ), it ( item )
     {
         setFrame ( false );
 
         QRect r = it-> listView ( )-> itemRect ( it );
 
         int x = it-> listView ( )-> header ( )-> cellPos ( 3 ) - 1;
         int y = r. y ( );
         int w = it-> listView ( )-> viewport ( )-> width ( ) - x;
         int h = r. height ( ); // + 2;
 
         setText ( it-> pattern ( ));
         setGeometry ( x, y, w, h );
 
         qDebug ( "ExEdit: [%s] at %d,%d %d,%d", it->text(2).latin1(),x,y,w,h);
 
         m_out = true;
 
         show ( );
         setFocus ( );
         selectAll ( );
         end ( true );
     }
 
     virtual void focusOutEvent ( QFocusEvent * )
     {
         hide ( );
         if ( m_out )
             it-> setPattern ( text ( ));
         delete this;
     }
 
     virtual void keyPressEvent ( QKeyEvent *e )
     {
         if ( e-> key ( ) == Key_Return )
             it-> listView ( )-> setFocus ( );
         else if ( e-> key ( ) == Key_Escape )
         {
             m_out = false;
             it-> listView ( )-> setFocus ( );
         }
         else
             QLineEdit::keyPressEvent ( e );
     }
 
 private:
     ExceptListItem *it;
     bool m_out;
 };
 
 void Appearance::clickedExcept ( QListViewItem *item, const QPoint &, int c )
 {
     if ( !item || c < 0 || c > 3 )
         return;
 
     ExceptListItem *it = (ExceptListItem *) item;
 
     if ( c == 0 )
         it-> setNoStyle ( !it-> noStyle ( ));
     else if ( c == 1 )
         it-> setNoFont ( !it-> noFont ( ));
     else if ( c == 2 )
         it-> setNoDeco ( !it-> noDeco ( ));
     else if ( c == 3 )
     {
         m_except-> ensureItemVisible ( it );
         new ExEdit ( it );
     }
 }