Fix bug 1219.

If not authorized no dtp is created
so 0x000000000->close is likely to fail.

lpotter something I think Qtopia suffers from as well

1 files changed, 3 insertions, 1 deletions

diff --git a/core/launcher/transferserver.cpp b/core/launcher/transferserver.cpp
index eea9f3a..9519d11 100644
--- a/core/launcher/transferserver.cpp
+++ b/core/launcher/transferserver.cpp
@@ -156,385 +156,387 @@ int SyncAuthentication::isAuthorized(QHostAddress peeraddress)
 	//    allowed.setAddress(allowedstr);
 	//    uint auth_peer = allowed.ip4Addr();
 	uint auth_peer_bits = cfg.readNumEntry("auth_peer_bits", 24);
 	uint mask = auth_peer_bits >= 32 // shifting by 32 is not defined
 	            ? 0xffffffff : (((1 << auth_peer_bits) - 1) << (32 - auth_peer_bits));
 
 	return (peeraddress.ip4Addr() & mask) == auth_peer;
 }
 
 bool SyncAuthentication::checkUser( const QString& user )
 {
     if ( user.isEmpty() ) return FALSE;
     QString euser = loginName();
     return user == euser;
 }
 
 bool SyncAuthentication::checkPassword( const QString& password )
 {
 #ifdef ALLOW_UNIX_USER_FTP
     // First, check system password...
 
     struct passwd *pw = 0;
     struct spwd *spw = 0;
 
     pw = getpwuid( geteuid() );
     spw = getspnam( pw->pw_name );
 
     QString cpwd = QString::fromLocal8Bit( pw->pw_passwd );
     if ( cpwd == "x" && spw )
 	cpwd = QString::fromLocal8Bit( spw->sp_pwdp );
 
     // Note: some systems use more than crypt for passwords.
     QString cpassword = QString::fromLocal8Bit( crypt( password.local8Bit(), cpwd.local8Bit() ) );
     if ( cpwd == cpassword )
 	return TRUE;
 #endif
 
     static int lastdenial=0;
     static int denials=0;
     int now = time(0);
  
     Config cfg("Security");
     cfg.setGroup("Sync");    
     QString syncapp = cfg.readEntry("syncapp","Qtopia");
     
     //No password needed if the user really wants it
     if (syncapp == "IntelliSync") {
     	return TRUE;
     }	
       
     // Detect old Qtopia Desktop (no password)
     if ( password.isEmpty() ) {	
 		if ( denials < 3 || now > lastdenial+600 ) {
 		    QMessageBox unauth(
 			tr("Sync Connection"),
 			tr("<p>An unauthorized system is requesting access to this device."
 			    "<p>If you are using a version of Qtopia Desktop older than 1.5.1, "
 			    "please upgrade or change the security setting to use IntelliSync." ),
 			QMessageBox::Warning,
 			QMessageBox::Cancel, QMessageBox::NoButton, QMessageBox::NoButton,
 			0, QString::null, TRUE, WStyle_StaysOnTop);
 		    unauth.setButtonText(QMessageBox::Cancel, tr("Deny"));
 		    unauth.exec();
 
 		    denials++;
 		    lastdenial=now;
 		 } 
 		return FALSE;
 	   
     } 
 
     // Second, check sync password...
 
     static int lock=0;
     if ( lock ) return FALSE;
 
     ++lock;    
 
     /*
      *  we need to support old Sync software and QtopiaDesktop
      */
     if ( password.left(6) == "Qtopia" || password.left(6) == "rootme" ) {
 	Config cfg( "Security" );
 	cfg.setGroup("Sync");
 	QStringList pwds = cfg.readListEntry("Passwords",' ');
 	for (QStringList::ConstIterator it=pwds.begin(); it!=pwds.end(); ++it) {
 #ifndef Q_OS_WIN32
 	    QString cpassword = QString::fromLocal8Bit(
 		crypt( password.mid(8).local8Bit(), (*it).left(2).latin1() ) );
 #else
 	    // ### revise
 	    QString cpassword("");
 #endif
 	    if ( *it == cpassword ) {
 		lock--;
 		return TRUE;
 	    }
 	}
 
 	// Unrecognized system. Be careful...
 	QMessageBox unrecbox(
 	    tr("Sync Connection"),
 	    tr(	"<p>An unrecognized system is requesting access to this device."
 		"<p>If you have just initiated a Sync for the first time, this is normal."),
 		QMessageBox::Warning,
 		QMessageBox::Cancel, QMessageBox::Yes, QMessageBox::NoButton,
 		0, QString::null, TRUE, WStyle_StaysOnTop);
 	unrecbox.setButtonText(QMessageBox::Cancel, tr("Deny"));
 	unrecbox.setButtonText(QMessageBox::Yes, tr("Allow"));
 
 	if ( (denials > 2 && now < lastdenial+600)
 	    || unrecbox.exec() != QMessageBox::Yes)
 	{
 	    denials++;
 	    lastdenial=now;
 	    lock--;
 	    return FALSE;
 	} else {
 	    const char salty[]="abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789/.";
 	    char salt[2];
 	    salt[0]= salty[rand() % (sizeof(salty)-1)];
 	    salt[1]= salty[rand() % (sizeof(salty)-1)];
 #ifndef Q_OS_WIN32
 	    QString cpassword = QString::fromLocal8Bit(
 		crypt( password.mid(8).local8Bit(), salt ) );
 #else
 	    //### revise
 	    QString cpassword("");
 #endif
 	    denials=0;
 	    pwds.prepend(cpassword);
 	    cfg.writeEntry("Passwords",pwds,' ');
 	    lock--;
 	    return TRUE;
 	}
     }
     lock--;
 
     return FALSE;
 }
 
 
 ServerPI::ServerPI( int socket, QObject *parent, const char* name )
     : QSocket( parent, name ) , dtp( 0 ), serversocket( 0 ), waitsocket( 0 ),
       storFileSize(-1)
 {
     state = Connected;
 
     setSocket( socket );
 
     peerport = peerPort();
     peeraddress = peerAddress();
 
 #ifndef INSECURE
     if ( !SyncAuthentication::isAuthorized(peeraddress) ) {
 	state = Forbidden;
 	startTimer( 0 );
     } else
 #endif
     {
 	connect( this, SIGNAL( readyRead() ), SLOT( read() ) );
 	connect( this, SIGNAL( connectionClosed() ), SLOT( connectionClosed() ) );
 
 	passiv = FALSE;
 	for( int i = 0; i < 4; i++ )
 	    wait[i] = FALSE;
 
 	send( "220 Qtopia " QPE_VERSION " FTP Server" ); // No tr
 	state = Wait_USER;
 
 	dtp = new ServerDTP( this );
 	connect( dtp, SIGNAL( completed() ), SLOT( dtpCompleted() ) );
 	connect( dtp, SIGNAL( failed() ), SLOT( dtpFailed() ) );
 	connect( dtp, SIGNAL( error( int ) ), SLOT( dtpError( int ) ) );
 
 
 	directory = QDir::currentDirPath();
 
 	static int p = 1024;
 
 	while ( !serversocket || !serversocket->ok() ) {
 	    delete serversocket;
 	    serversocket = new ServerSocket( ++p, this );
 	}
 	connect( serversocket, SIGNAL( newIncomming( int ) ),
 		 SLOT( newConnection( int ) ) );
     }
 }
 
 ServerPI::~ServerPI()
 {
     close();
-    dtp->close();
+
+    if ( dtp )
+        dtp->close();
     delete dtp;
     delete serversocket;
 }
 
 bool ServerPI::verifyAuthorised()
 {
     if ( !SyncAuthentication::isAuthorized(peerAddress()) ) {
 	state = Forbidden;
 	return FALSE;
     }
     return TRUE;
 }
 
 void ServerPI::connectionClosed()
 {
     // qDebug( "Debug: Connection closed" );
     emit connectionClosed(this);
 }
 
 void ServerPI::send( const QString& msg )
 {
     QTextStream os( this );
     os << msg << endl;
     //qDebug( "Reply: %s", msg.latin1() );
 }
 
 void ServerPI::read()
 {
     while ( canReadLine() )
 	process( readLine().stripWhiteSpace() );
 }
 
 bool ServerPI::checkReadFile( const QString& file )
 {
     QString filename;
 
     if ( file[0] != "/" )
 	filename = directory.path() + "/" + file;
     else
 	filename = file;
 
     QFileInfo fi( filename );
     return ( fi.exists() && fi.isReadable() );
 }
 
 bool ServerPI::checkWriteFile( const QString& file )
 {
     QString filename;
 
     if ( file[0] != "/" )
 	filename = directory.path() + "/" + file;
     else
 	filename = file;
 
     QFileInfo fi( filename );
 
     if ( fi.exists() )
 	if ( !QFile( filename ).remove() )
 	    return FALSE;
     return TRUE;
 }
 
 void ServerPI::process( const QString& message )
 {
     //qDebug( "Command: %s", message.latin1() );
 
     // split message using "," as separator
     QStringList msg = QStringList::split( " ", message );
     if ( msg.isEmpty() ) return;
 
     // command token
     QString cmd = msg[0].upper();
 
     // argument token
     QString arg;
     if ( msg.count() >= 2 )
 	arg = msg[1];
 
     // full argument string
     QString args;
     if ( msg.count() >= 2 ) {
         QStringList copy( msg );
         // FIXME: for Qt3
         // copy.pop_front()
         copy.remove( copy.begin() );
         args = copy.join( " " );
     }
 
     //qDebug( "args: %s", args.latin1() );
 
     // we always respond to QUIT, regardless of state
     if ( cmd == "QUIT" ) {
 	send( "211 Good bye!" ); // No tr
 	close();
 	return;
     }
 
     // connected to client
     if ( Connected == state )
 	return;
 
     // waiting for user name
     if ( Wait_USER == state ) {
 
 	if ( cmd != "USER" || msg.count() < 2 || !SyncAuthentication::checkUser( arg ) ) {
 	    send( "530 Please login with USER and PASS" ); // No tr
 	    return;
 	}
 	send( "331 User name ok, need password" ); // No tr
 	state = Wait_PASS;
 	return;
     }
 
     // waiting for password
     if ( Wait_PASS == state ) {
 
 	if ( cmd != "PASS" || !SyncAuthentication::checkPassword( arg ) ) {
 	    send( "530 Please login with USER and PASS" ); // No tr
 	    return;
 	}
 	send( "230 User logged in, proceed" ); // No tr
 	state = Ready;
 	return;
     }
 
     // ACCESS CONTROL COMMANDS
 
     // Only an ALLO sent immediately before STOR is valid.
     if ( cmd != "STOR" )
 	storFileSize = -1;
 
     // account (ACCT)
     if ( cmd == "ACCT" ) {
 	// even wu-ftp does not support it
 	send( "502 Command not implemented" ); // No tr
     }
 
     // change working directory (CWD)
     else if ( cmd == "CWD" ) {
 
 	if ( !args.isEmpty() ) {
 	    if ( directory.cd( args, TRUE ) )
 		send( "250 Requested file action okay, completed" ); // No tr
 	    else
 		send( "550 Requested action not taken" ); // No tr
 	}
 	else
 	    send( "500 Syntax error, command unrecognized" ); // No tr
     }
 
     // change to parent directory (CDUP)
     else if ( cmd == "CDUP" ) {
 	if ( directory.cdUp() )
 	    send( "250 Requested file action okay, completed" ); // No tr
 	else
 	    send( "550 Requested action not taken" ); // No tr
     }
 
     // structure mount (SMNT)
     else if ( cmd == "SMNT" ) {
 	// even wu-ftp does not support it
 	send( "502 Command not implemented" ); // No tr
     }
 
     // reinitialize (REIN)
     else if ( cmd == "REIN" ) {
 	// even wu-ftp does not support it
 	send( "502 Command not implemented" ); // No tr
     }
 
 
     // TRANSFER PARAMETER COMMANDS
 
 
     // data port (PORT)
     else if ( cmd == "PORT" ) {
 	if ( parsePort( arg ) )
 	    send( "200 Command okay" ); // No tr
 	else
 	    send( "500 Syntax error, command unrecognized" ); // No tr
     }
 
     // passive (PASV)
     else if ( cmd == "PASV" ) {
 	passiv = TRUE;
 	send( "227 Entering Passive Mode (" // No tr
 	      + address().toString().replace( QRegExp( "\\." ), "," ) + ","
 	      + QString::number( ( serversocket->port() ) >> 8 ) + ","
 	      + QString::number( ( serversocket->port() ) & 0xFF ) +")" );
     }
 
     // representation type (TYPE)