Added braces round key checking if statement to fix bug that WEP settings

were never saved if WEP was enabled

2 files changed, 10 insertions, 4 deletions

diff --git a/noncore/net/networksetup/wlan/wlanimp.cpp b/noncore/net/networksetup/wlan/wlanimp.cpp
index d4b4af9..e64a633 100644
--- a/noncore/net/networksetup/wlan/wlanimp.cpp
+++ b/noncore/net/networksetup/wlan/wlanimp.cpp
@@ -11,222 +11,225 @@
 #include <qcheckbox.h>
 #include <qtabwidget.h>
 
 /* system() */
 #include <stdlib.h>
 
 #define WIRELESS_OPTS "/etc/pcmcia/wireless.opts"
 
 /**
  * Constructor, read in the wireless.opts file for parsing later.
  */ 
 WLANImp::WLANImp( QWidget* parent, const char* name, Interface *i, bool modal, WFlags fl):WLAN(parent, name, modal, fl), currentProfile("*") {
   interfaceSetup = new InterfaceSetupImp(tabWidget, "InterfaceSetupImp", i);
   tabWidget->insertTab(interfaceSetup, "TCP/IP");
 
   // Read in the config file.
   QString wlanFile = WIRELESS_OPTS;
   QFile file(wlanFile);
   if (file.open(IO_ReadOnly)){
     QTextStream stream( &file );
     QString line = "";
     while ( !stream.eof() ) {
       line += stream.readLine();
       line += "\n";
     }
     file.close();
     settingsFileText = QStringList::split("\n", line, true);
     parseSettingFile();
   }
   else
     qDebug(QString("WLANImp: Can't open file: %1 for reading.").arg(wlanFile).latin1());
 }
 
 /**
  * Change the profile for both wireless settings and network settings.
  */ 
 void WLANImp::setProfile(const QString &profile){
   interfaceSetup->setProfile(profile);
   parseSettingFile();
 }
 
 /**
  * Parses the settings file that was read in and gets any setting from it.
  */ 
 void WLANImp::parseSettingFile(){
   bool foundCase = false;
   bool found = false;
   for ( QStringList::Iterator it = settingsFileText.begin(); it != settingsFileText.end(); ++it ) {
     QString line = (*it).simplifyWhiteSpace();
     if(line.contains("case"))
       foundCase = true;
     // See if we found our scheme to write or the sceme couldn't be found
     if((foundCase && line.contains("esac")) || 
    (foundCase && line.left(currentProfile.length()+7) == currentProfile + ",*,*,*)" && line.at(0) != '#'))
       found = true;
 
     if(line.contains(";;"))
       found = false;
     if(found){
       // write out scheme
       if(line.contains("ESSID=")){
         QString id = line.mid(line.find("ESSID=")+6, line.length());
         if(id == "any"){
           essNon->setChecked(true);
           essSpecific->setChecked(false);
         }else{ 
           essSpecific->setChecked(true);
           essSpecificLineEdit->setText(id);
           essNon->setChecked(false);
         }
       }
       if(line.contains("MODE=")){
         QString mode = line.mid(line.find("MODE=")+5, line.length());
         if(mode == "Managed"){
           network802->setChecked( false );
           networkInfrastructure->setChecked( true );
         }
         else{
           network802->setChecked( true );
           networkInfrastructure->setChecked( false );
         }
       }
       if(line.contains("KEY=")){
         line.at(0) != '#' ? wepEnabled->setChecked(true) : wepEnabled->setChecked(false);
         int s = line.find("KEY=");
         line = line.mid(s+4, line.length());
         // Find first Key
         s = line.find("[1]");
         if(s != -1){
           keyLineEdit0->setText(line.mid(0, s));
           line = line.mid(s+3, line.length());
         }
         s = line.find("[2]");
         if(s != -1){
           keyLineEdit1->setText(line.mid(0, s));
           line = line.mid(s+3, line.length());
         }
         s = line.find("[3]");
         if(s != -1){
           keyLineEdit2->setText(line.mid(0, s));
           line = line.mid(s+3, line.length());
         }
         s = line.find("[4]");
         if(s != -1){
           keyLineEdit3->setText(line.mid(0, s));
           line = line.mid(s+3, line.length());
         }
         if(line.contains("key [1]")) keyRadio0->setChecked(true);
         if(line.contains("key [2]")) keyRadio1->setChecked(true);
         if(line.contains("key [3]")) keyRadio2->setChecked(true);
         if(line.contains("key [4]")) keyRadio3->setChecked(true);
         if(line.contains("open")){
           authOpen->setChecked(true);
           authShared->setChecked(false);
         }
         else{
           authOpen->setChecked(false);
           authShared->setChecked(true);
         }
       }
       if(line.contains("CHANNEL=")){
         networkChannel->setValue(line.mid(line.find("CHANNEL=")+8, line.length()).toInt());
       }
     }
   }
 }
 
 /**
  * Saves settings to the wireless.opts file using the current profile
  */ 
 void WLANImp::changeAndSaveSettingFile(){
   QString wlanFile = WIRELESS_OPTS;
   QFile::remove(wlanFile);
   QFile file(wlanFile);
 
   if (!file.open(IO_ReadWrite)){
     qDebug(QString("WLANImp::changeAndSaveSettingFile(): Can't open file: %1 for writing.").arg(wlanFile).latin1());
     return;
   }
   
   QTextStream stream( &file );
   bool foundCase = false;
   bool found = false;
   bool output = true;
   for ( QStringList::Iterator it = settingsFileText.begin(); it != settingsFileText.end(); ++it ) {
     QString line = (*it).simplifyWhiteSpace();
     if(line.contains("case"))
       foundCase = true;
     // See if we found our scheme to write or the sceme couldn't be found
     if((foundCase && line.contains("esac") && !found) || 
    (foundCase && line.left(currentProfile.length()+7) == currentProfile + ",*,*,*)" && line.at(0) != '#')){
       // write out scheme
       found = true;
       output = false;
       
       if(!line.contains("esac"))
         stream << line << "\n"; 
       
       stream << "\tESSID=" << (essNon->isChecked() == true ? QString("any") : essSpecificLineEdit->text()) << '\n';
       stream << "\tMODE=" << (networkInfrastructure->isChecked() == true  ? "Managed" : "AdHoc") << '\n';
       if(!wepEnabled->isChecked())
         stream << "#";
       stream << "\tKEY=";
       stream << keyLineEdit0->text() << " [1]";
       stream << keyLineEdit1->text() << " [2]";
       stream << keyLineEdit2->text() << " [3]";
       stream << keyLineEdit3->text() << " [4]";
       stream << " key [";
       if(keyRadio0->isChecked()) stream << "1]";
       if(keyRadio1->isChecked()) stream << "2]";
       if(keyRadio2->isChecked()) stream << "3]";
       if(keyRadio3->isChecked()) stream << "4]";
       if(authOpen->isChecked()) stream << " open";
       stream << "\n"; 
       stream << "\tCHANNEL=" << networkChannel->value() << "\n";
       stream << "\tRATE=auto\n";
       if(line.contains("esac"))
         stream << line << "\n"; 
     }
     if(line.contains(";;"))
       output = true;
     if(output)
       stream << (*it) << '\n';
   }
   file.close();
 }
 
 /**
  * Check to see if the current config is valid
  * Save wireless.opts, save interfaces
  */
 void WLANImp::accept(){
+                printf( "Accept pressed\n" );
   if(wepEnabled->isChecked()){
     if(keyLineEdit0->text().isEmpty() && keyLineEdit1->text().isEmpty() && keyLineEdit2->text().isEmpty() && keyLineEdit3->text().isEmpty() )
-    QMessageBox::information(this, "", "Please enter a key for WEP.", QMessageBox::Ok);
-    return;
+        {
+            QMessageBox::information(this, "", "Please enter a key for WEP.", QMessageBox::Ok);
+            return;
+        }
           }
   
   // Ok settings are good here, save
   changeAndSaveSettingFile();
   
   // Try to save the interfaces settings.
   if(!interfaceSetup->saveChanges())
     return;
   
   // Restart the device now that the settings have changed
   QString initpath;
   if( QDir("/etc/rc.d/init.d").exists() )
     initpath = "/etc/rc.d/init.d";
   else if( QDir("/etc/init.d").exists() )
     initpath = "/etc/init.d";
   if( initpath )
     system(QString("%1/pcmcia stop").arg(initpath));
   if( initpath )
     system(QString("%1/pcmcia start").arg(initpath));
 
   // Close out the dialog
   QDialog::accept();
 }
 
 // wlanimp.cpp
 
diff --git a/noncore/settings/networksettings/wlan/wlanimp.cpp b/noncore/settings/networksettings/wlan/wlanimp.cpp
index d4b4af9..e64a633 100644
--- a/noncore/settings/networksettings/wlan/wlanimp.cpp
+++ b/noncore/settings/networksettings/wlan/wlanimp.cpp
@@ -11,222 +11,225 @@
 #include <qcheckbox.h>
 #include <qtabwidget.h>
 
 /* system() */
 #include <stdlib.h>
 
 #define WIRELESS_OPTS "/etc/pcmcia/wireless.opts"
 
 /**
  * Constructor, read in the wireless.opts file for parsing later.
  */ 
 WLANImp::WLANImp( QWidget* parent, const char* name, Interface *i, bool modal, WFlags fl):WLAN(parent, name, modal, fl), currentProfile("*") {
   interfaceSetup = new InterfaceSetupImp(tabWidget, "InterfaceSetupImp", i);
   tabWidget->insertTab(interfaceSetup, "TCP/IP");
 
   // Read in the config file.
   QString wlanFile = WIRELESS_OPTS;
   QFile file(wlanFile);
   if (file.open(IO_ReadOnly)){
     QTextStream stream( &file );
     QString line = "";
     while ( !stream.eof() ) {
       line += stream.readLine();
       line += "\n";
     }
     file.close();
     settingsFileText = QStringList::split("\n", line, true);
     parseSettingFile();
   }
   else
     qDebug(QString("WLANImp: Can't open file: %1 for reading.").arg(wlanFile).latin1());
 }
 
 /**
  * Change the profile for both wireless settings and network settings.
  */ 
 void WLANImp::setProfile(const QString &profile){
   interfaceSetup->setProfile(profile);
   parseSettingFile();
 }
 
 /**
  * Parses the settings file that was read in and gets any setting from it.
  */ 
 void WLANImp::parseSettingFile(){
   bool foundCase = false;
   bool found = false;
   for ( QStringList::Iterator it = settingsFileText.begin(); it != settingsFileText.end(); ++it ) {
     QString line = (*it).simplifyWhiteSpace();
     if(line.contains("case"))
       foundCase = true;
     // See if we found our scheme to write or the sceme couldn't be found
     if((foundCase && line.contains("esac")) || 
    (foundCase && line.left(currentProfile.length()+7) == currentProfile + ",*,*,*)" && line.at(0) != '#'))
       found = true;
 
     if(line.contains(";;"))
       found = false;
     if(found){
       // write out scheme
       if(line.contains("ESSID=")){
         QString id = line.mid(line.find("ESSID=")+6, line.length());
         if(id == "any"){
           essNon->setChecked(true);
           essSpecific->setChecked(false);
         }else{ 
           essSpecific->setChecked(true);
           essSpecificLineEdit->setText(id);
           essNon->setChecked(false);
         }
       }
       if(line.contains("MODE=")){
         QString mode = line.mid(line.find("MODE=")+5, line.length());
         if(mode == "Managed"){
           network802->setChecked( false );
           networkInfrastructure->setChecked( true );
         }
         else{
           network802->setChecked( true );
           networkInfrastructure->setChecked( false );
         }
       }
       if(line.contains("KEY=")){
         line.at(0) != '#' ? wepEnabled->setChecked(true) : wepEnabled->setChecked(false);
         int s = line.find("KEY=");
         line = line.mid(s+4, line.length());
         // Find first Key
         s = line.find("[1]");
         if(s != -1){
           keyLineEdit0->setText(line.mid(0, s));
           line = line.mid(s+3, line.length());
         }
         s = line.find("[2]");
         if(s != -1){
           keyLineEdit1->setText(line.mid(0, s));
           line = line.mid(s+3, line.length());
         }
         s = line.find("[3]");
         if(s != -1){
           keyLineEdit2->setText(line.mid(0, s));
           line = line.mid(s+3, line.length());
         }
         s = line.find("[4]");
         if(s != -1){
           keyLineEdit3->setText(line.mid(0, s));
           line = line.mid(s+3, line.length());
         }
         if(line.contains("key [1]")) keyRadio0->setChecked(true);
         if(line.contains("key [2]")) keyRadio1->setChecked(true);
         if(line.contains("key [3]")) keyRadio2->setChecked(true);
         if(line.contains("key [4]")) keyRadio3->setChecked(true);
         if(line.contains("open")){
           authOpen->setChecked(true);
           authShared->setChecked(false);
         }
         else{
           authOpen->setChecked(false);
           authShared->setChecked(true);
         }
       }
       if(line.contains("CHANNEL=")){
         networkChannel->setValue(line.mid(line.find("CHANNEL=")+8, line.length()).toInt());
       }
     }
   }
 }
 
 /**
  * Saves settings to the wireless.opts file using the current profile
  */ 
 void WLANImp::changeAndSaveSettingFile(){
   QString wlanFile = WIRELESS_OPTS;
   QFile::remove(wlanFile);
   QFile file(wlanFile);
 
   if (!file.open(IO_ReadWrite)){
     qDebug(QString("WLANImp::changeAndSaveSettingFile(): Can't open file: %1 for writing.").arg(wlanFile).latin1());
     return;
   }
   
   QTextStream stream( &file );
   bool foundCase = false;
   bool found = false;
   bool output = true;
   for ( QStringList::Iterator it = settingsFileText.begin(); it != settingsFileText.end(); ++it ) {
     QString line = (*it).simplifyWhiteSpace();
     if(line.contains("case"))
       foundCase = true;
     // See if we found our scheme to write or the sceme couldn't be found
     if((foundCase && line.contains("esac") && !found) || 
    (foundCase && line.left(currentProfile.length()+7) == currentProfile + ",*,*,*)" && line.at(0) != '#')){
       // write out scheme
       found = true;
       output = false;
       
       if(!line.contains("esac"))
         stream << line << "\n"; 
       
       stream << "\tESSID=" << (essNon->isChecked() == true ? QString("any") : essSpecificLineEdit->text()) << '\n';
       stream << "\tMODE=" << (networkInfrastructure->isChecked() == true  ? "Managed" : "AdHoc") << '\n';
       if(!wepEnabled->isChecked())
         stream << "#";
       stream << "\tKEY=";
       stream << keyLineEdit0->text() << " [1]";
       stream << keyLineEdit1->text() << " [2]";
       stream << keyLineEdit2->text() << " [3]";
       stream << keyLineEdit3->text() << " [4]";
       stream << " key [";
       if(keyRadio0->isChecked()) stream << "1]";
       if(keyRadio1->isChecked()) stream << "2]";
       if(keyRadio2->isChecked()) stream << "3]";
       if(keyRadio3->isChecked()) stream << "4]";
       if(authOpen->isChecked()) stream << " open";
       stream << "\n"; 
       stream << "\tCHANNEL=" << networkChannel->value() << "\n";
       stream << "\tRATE=auto\n";
       if(line.contains("esac"))
         stream << line << "\n"; 
     }
     if(line.contains(";;"))
       output = true;
     if(output)
       stream << (*it) << '\n';
   }
   file.close();
 }
 
 /**
  * Check to see if the current config is valid
  * Save wireless.opts, save interfaces
  */
 void WLANImp::accept(){
+                printf( "Accept pressed\n" );
   if(wepEnabled->isChecked()){
     if(keyLineEdit0->text().isEmpty() && keyLineEdit1->text().isEmpty() && keyLineEdit2->text().isEmpty() && keyLineEdit3->text().isEmpty() )
-    QMessageBox::information(this, "", "Please enter a key for WEP.", QMessageBox::Ok);
-    return;
+        {
+            QMessageBox::information(this, "", "Please enter a key for WEP.", QMessageBox::Ok);
+            return;
+        }
           }
   
   // Ok settings are good here, save
   changeAndSaveSettingFile();
   
   // Try to save the interfaces settings.
   if(!interfaceSetup->saveChanges())
     return;
   
   // Restart the device now that the settings have changed
   QString initpath;
   if( QDir("/etc/rc.d/init.d").exists() )
     initpath = "/etc/rc.d/init.d";
   else if( QDir("/etc/init.d").exists() )
     initpath = "/etc/init.d";
   if( initpath )
     system(QString("%1/pcmcia stop").arg(initpath));
   if( initpath )
     system(QString("%1/pcmcia start").arg(initpath));
 
   // Close out the dialog
   QDialog::accept();
 }
 
 // wlanimp.cpp