Minor UI tweak - fix double entry in source feed configuration when adding a new feed

1 files changed, 1 insertions, 1 deletions

diff --git a/noncore/settings/packagemanager/oipkgconfigdlg.cpp b/noncore/settings/packagemanager/oipkgconfigdlg.cpp
index ea0aef0..25052f8 100644
--- a/noncore/settings/packagemanager/oipkgconfigdlg.cpp
+++ b/noncore/settings/packagemanager/oipkgconfigdlg.cpp
@@ -354,288 +354,288 @@ void OIpkgConfigDlg::initOptionsWidget()
     layout->addWidget( m_optForceDepends );
 
     m_optForceReinstall = new QCheckBox( tr( "Force Reinstall" ), container );
     QWhatsThis::add( m_optForceReinstall, tr( "Tap here to enable or disable the '-force-reinstall' option for Ipkg." ) );
     layout->addWidget( m_optForceReinstall );
 
     m_optForceRemove = new QCheckBox( tr( "Force Remove" ), container );
     QWhatsThis::add( m_optForceRemove, tr( "Tap here to enable or disable the '-force-removal-of-dependent-packages' option for Ipkg." ) );
     layout->addWidget( m_optForceRemove );
 
     m_optForceOverwrite = new QCheckBox( tr( "Force Overwrite" ), container );
     QWhatsThis::add( m_optForceOverwrite, tr( "Tap here to enable or disable the '-force-overwrite' option for Ipkg." ) );
     layout->addWidget( m_optForceOverwrite );
 
     QLabel *l = new QLabel( tr( "Information Level" ), container );
     QWhatsThis::add( l, tr( "Select information level for Ipkg." ) );
     layout->addWidget( l );
 
     m_optVerboseIpkg = new QComboBox( container );
     QWhatsThis::add( m_optVerboseIpkg, tr( "Select information level for Ipkg." ) );
     m_optVerboseIpkg->insertItem( tr( "Errors only" ) );
     m_optVerboseIpkg->insertItem( tr( "Normal messages" ) );
     m_optVerboseIpkg->insertItem( tr( "Informative messages" ) );
     m_optVerboseIpkg->insertItem( tr( "Troubleshooting output" ) );
     layout->addWidget( m_optVerboseIpkg );
 
     layout->addItem( new QSpacerItem( 1, 1, QSizePolicy::Minimum, QSizePolicy::Expanding ) );
 }
 
 void OIpkgConfigDlg::initData()
 {
     // Read ipkg configuration (server/destination/proxy) information
     if ( m_ipkg && !m_installOptions )
     {
         m_configs = m_ipkg->configItems();
         if ( m_configs )
         {
             for ( OConfItemListIterator configIt( *m_configs ); configIt.current(); ++configIt )
             {
                 OConfItem *config = configIt.current();
 
                 // Add configuration item to the appropriate dialog controls
                 if ( config )
                 {
                     if ( config->type() == OConfItem::Source )
                     {
                         m_serverList->insertItem( config->name() );
                     }
                     else if ( config->type() == OConfItem::Destination )
                     {
                         m_destList->insertItem( config->name() );
                     }
                     else if ( config->type() == OConfItem::Option )
                     {
                         if ( config->name() == "http_proxy" )
                         {
                             m_proxyHttpServer->setText( config->value() );
                             m_proxyHttpActive->setChecked( config->active() );
                         }
                         else if ( config->name() == "ftp_proxy" )
                         {
                             m_proxyFtpServer->setText( config->value() );
                             m_proxyFtpActive->setChecked( config->active() );
                         }
                         else if ( config->name() == "proxy_username" )
                         {
                             m_proxyUsername->setText( config->value() );
                         }
                         else if ( config->name() == "proxy_password" )
                         {
                             m_proxyPassword->setText( config->value() );
                         }
                     }
                 }
             }
         }
     }
 
     // Get Ipkg execution options
     int options = m_ipkg->ipkgExecOptions();
     if ( options & FORCE_DEPENDS )
         m_optForceDepends->setChecked( true );
     if ( options & FORCE_REINSTALL )
         m_optForceReinstall->setChecked( true );
     if ( options & FORCE_REMOVE )
         m_optForceRemove->setChecked( true );
     if ( options & FORCE_OVERWRITE )
         m_optForceOverwrite->setChecked( true );
 
     m_optVerboseIpkg->setCurrentItem( m_ipkg->ipkgExecVerbosity() );
 }
 
 OConfItem *OIpkgConfigDlg::findConfItem( OConfItem::Type type, const QString &name )
 {
     // Find selected server in list
     OConfItemListIterator configIt( *m_configs );
     OConfItem *config = 0x0;
     for ( ; configIt.current(); ++configIt )
     {
         config = configIt.current();
         if ( config->type() == type && config->name() == name )
             break;
     }
 
     if ( config && config->type() == type && config->name() == name )
         return config;
 
     return 0x0;
 }
 
 void OIpkgConfigDlg::slotServerEdit( int index )
 {
     m_serverNew = false;
     m_serverCurrent = index;
 
     // Find selected server in list
     OConfItem *server = findConfItem( OConfItem::Source, m_serverList->currentText() );
 
     // Display server details
     if ( server )
     {
         m_serverCurrName = server->name();
         m_serverName->setText( server->name() );
         m_serverLocation->setText( server->value() );
         m_serverActive->setChecked( server->active() );
         m_serverName->setFocus();
     }
 }
 
 void OIpkgConfigDlg::slotServerNew()
 {
     m_serverNew = true;
 
     m_serverName->setText( QString::null );
     m_serverLocation->setText( QString::null );
     m_serverActive->setChecked( true );
     m_serverName->setFocus();
 }
 
 void OIpkgConfigDlg::slotServerDelete()
 {
     // Find selected server in list
     OConfItem *server = findConfItem( OConfItem::Source, m_serverList->currentText() );
 
     // Delete server
     if ( server )
     {
         m_configs->removeRef( server );
         m_serverList->removeItem( m_serverCurrent );
     }
 }
 
 void OIpkgConfigDlg::slotServerUpdate()
 {
     QString newName = m_serverName->text();
 
     // Convert any spaces to underscores
     newName.replace( QRegExp( " " ), "_" );
 
     if ( !m_serverNew )
     {
         // Find selected server in list
         OConfItem *server = findConfItem( OConfItem::Source, m_serverCurrName );
 
         // Delete server
         if ( server )
         {
             // Update url
             server->setValue( m_serverLocation->text() );
             server->setActive( m_serverActive->isChecked() );
 
             // Check if server name has changed, if it has then we need to replace the key in the map
             if ( m_serverCurrName != newName )
             {
                 // Update server name
                 server->setName( newName );
 
                 // Update list box
                 m_serverList->changeItem( newName, m_serverCurrent );
             }
         }
     }
     else
     {
         // Add new destination to configuration list
         m_configs->append( new OConfItem( OConfItem::Source, newName,
                            m_serverLocation->text(), m_serverActive->isChecked() ) );
         m_configs->sort();
 
         m_serverList->insertItem( newName );
         m_serverList->setCurrentItem( m_serverList->count() );
         m_serverNew = false;
-        m_serverList->insertItem( newName );
+//        m_serverList->insertItem( newName );
     }
 }
 
 void OIpkgConfigDlg::slotDestEdit( int index )
 {
     m_destNew = false;
     m_destCurrent = index;
 
     // Find selected destination in list
     OConfItem *destination = findConfItem( OConfItem::Destination, m_destList->currentText() );
 
     // Display destination details
     if ( destination )
     {
         m_destCurrName = destination->name();
         m_destName->setText( destination->name() );
         m_destLocation->setText( destination->value() );
         m_destActive->setChecked( destination->active() );
         m_destName->setFocus();
     }
 }
 
 void OIpkgConfigDlg::slotDestNew()
 {
     m_destNew = true;
 
     m_destName->setText( QString::null );
     m_destLocation->setText( QString::null );
     m_destActive->setChecked( true );
     m_destName->setFocus();
 }
 
 void OIpkgConfigDlg::slotDestDelete()
 {
     // Find selected destination in list
     OConfItem *destination = findConfItem( OConfItem::Destination, m_destList->currentText() );
 
     // Delete destination
     if ( destination )
     {
         m_configs->removeRef( destination );
         m_destList->removeItem( m_destCurrent );
     }
 }
 
 void OIpkgConfigDlg::slotDestSelectPath()
 {
     QString path = Opie::Ui::OFileDialog::getDirectory( 0, m_destLocation->text() );
     if ( path.at( path.length() - 1 ) == '/' )
         path.truncate( path.length() - 1 );
     m_destLocation->setText( path );
 }
 
 void OIpkgConfigDlg::slotDestUpdate()
 {
     QString newName = m_destName->text();
 
     // Convert any spaces to underscores
     newName.replace( QRegExp( " " ), "_" );
 
     if ( !m_destNew )
     {
         // Find selected destination in list
         OConfItem *destination = findConfItem( OConfItem::Destination, m_destCurrName );
 
         // Display destination details
         if ( destination )
         {
             // Update url
             destination->setValue( m_destLocation->text() );
             destination->setActive( m_destActive->isChecked() );
 
             // Check if destination name has changed, if it has then we need to replace the key in the map
             if ( m_destCurrName != newName )
             {
                 // Update destination name
                 destination->setName( newName );
 
                 // Update list box
                 m_destList->changeItem( newName, m_destCurrent );
             }
         }
     }
     else
     {
         // Add new destination to configuration list
         m_configs->append( new OConfItem( OConfItem::Destination, newName,
                            m_destLocation->text(), m_destActive->isChecked() ) );
         m_configs->sort();
 
         m_destList->insertItem( newName );
         m_destList->setCurrentItem( m_destList->count() );
         m_destNew = false;
     }
 }