last selected mbox will hold so it will not called so often in outside loops

(it could cause segmentation faults, too - there is another bug in libetpan
I didn't found yet)

2 files changed, 38 insertions, 29 deletions

diff --git a/noncore/net/mail/libmailwrapper/imapwrapper.cpp b/noncore/net/mail/libmailwrapper/imapwrapper.cpp
index 23c678b..98634a3 100644
--- a/noncore/net/mail/libmailwrapper/imapwrapper.cpp
+++ b/noncore/net/mail/libmailwrapper/imapwrapper.cpp
@@ -12,4 +12,5 @@ IMAPwrapper::IMAPwrapper( IMAPaccount *a )
     account = a;
     m_imap = 0;
+    m_Lastmbox = "";
 }
 
@@ -19,4 +20,21 @@ IMAPwrapper::~IMAPwrapper()
 }
 
+/* to avoid to often select statements in loops etc.
+   we trust that we are logged in and connection is established!*/
+int IMAPwrapper::selectMbox(const QString&mbox)
+{
+    if (mbox == m_Lastmbox) {
+        return MAILIMAP_NO_ERROR;
+    }
+    int err = mailimap_select( m_imap, (char*)mbox.latin1());
+    if ( err != MAILIMAP_NO_ERROR ) {
+        qDebug("error selecting mailbox: %s",m_imap->imap_response);
+        m_Lastmbox = "";
+        return err;
+    }
+    m_Lastmbox = mbox;
+    return err;
+}
+
 void IMAPwrapper::imap_progress( size_t current, size_t maximum )
 {
@@ -103,17 +121,15 @@ void IMAPwrapper::logout()
     mailimap_free( m_imap );
     m_imap = 0;
+    m_Lastmbox = "";
 }
 
 void IMAPwrapper::listMessages(const QString&mailbox,QList<RecMail> &target )
 {
-    const char *mb = 0;
     int err = MAILIMAP_NO_ERROR;
     clist *result = 0;
     clistcell *current;
-//    mailimap_fetch_att *fetchAtt,*fetchAttFlags,*fetchAttDate,*fetchAttSize;
     mailimap_fetch_type *fetchType = 0;
     mailimap_set *set = 0;
 
-    mb = mailbox.latin1();
     login();
     if (!m_imap) {
@@ -121,7 +137,6 @@ void IMAPwrapper::listMessages(const QString&mailbox,QList<RecMail> &target )
     }
     /* select mailbox READONLY for operations */
-    err = mailimap_examine( m_imap, (char*)mb);
+    err = selectMbox(mailbox);
     if ( err != MAILIMAP_NO_ERROR ) {
-        Global::statusMessage(tr("error selecting mailbox: %1").arg(m_imap->imap_response));
         return;
     }
@@ -390,8 +405,6 @@ RecBody IMAPwrapper::fetchBody(const RecMail&mail)
         return body;
     }
-    
-    err = mailimap_select( m_imap, (char*)mb);
+    err = selectMbox(mail.getMbox());
     if ( err != MAILIMAP_NO_ERROR ) {
-        qDebug("error selecting mailbox: %s",m_imap->imap_response);
         return body;
     }
@@ -463,5 +476,4 @@ encodedString*IMAPwrapper::fetchRawPart(const RecMail&mail,const QValueList<int>
 {
     encodedString*res=new encodedString;
-    const char*mb;
     int err;
     mailimap_fetch_type *fetchType;
@@ -478,8 +490,6 @@ encodedString*IMAPwrapper::fetchRawPart(const RecMail&mail,const QValueList<int>
     }
     if (!internal_call) {
-        mb = mail.getMbox().latin1();
-        err = mailimap_select( m_imap, (char*)mb);
+        err = selectMbox(mail.getMbox());
         if ( err != MAILIMAP_NO_ERROR ) {
-            qDebug("error selecting mailbox: %s",m_imap->imap_response);
             return res;
         }
@@ -774,8 +784,6 @@ void IMAPwrapper::deleteMail(const RecMail&mail)
         return;
     }
-    const char *mb = mail.getMbox().latin1();
-    err = mailimap_select( m_imap, (char*)mb);
+    err = selectMbox(mail.getMbox());
     if ( err != MAILIMAP_NO_ERROR ) {
-        qDebug("error selecting mailbox for delete: %s",m_imap->imap_response);
         return;
     }
@@ -811,8 +819,6 @@ void IMAPwrapper::answeredMail(const RecMail&mail)
         return;
     }
-    const char *mb = mail.getMbox().latin1();
-    err = mailimap_select( m_imap, (char*)mb);
+    err = selectMbox(mail.getMbox());
     if ( err != MAILIMAP_NO_ERROR ) {
-        qDebug("error selecting mailbox for mark: %s",m_imap->imap_response);
         return;
     }
@@ -873,9 +879,9 @@ int IMAPwrapper::deleteAllMail(const Folder*folder)
     mailimap_set *set;
     mailimap_store_att_flags * store_flags;
-    int err = mailimap_select( m_imap, folder->getName().latin1());
+    int err = selectMbox(folder->getName());
     if ( err != MAILIMAP_NO_ERROR ) {
-        Global::statusMessage(tr("error selecting mailbox: %1").arg(m_imap->imap_response));
         return 0;
     }
+
     int last = m_imap->imap_selection_info->sel_exists;
     if (last == 0) {
@@ -1023,5 +1029,4 @@ encodedString* IMAPwrapper::fetchRawBody(const RecMail&mail)
 void IMAPwrapper::mvcpAllMails(Folder*fromFolder,const QString&targetFolder,AbstractMail*targetWrapper,bool moveit)
 {
-    qDebug("mvcp mail imap");
     if (targetWrapper != this) {
         AbstractMail::mvcpAllMails(fromFolder,targetFolder,targetWrapper,moveit);
@@ -1029,21 +1034,23 @@ void IMAPwrapper::mvcpAllMails(Folder*fromFolder,const QString&targetFolder,Abst
         return;
     }
-    qDebug("Using internal");
     mailimap_set *set = 0;
-
-    int err = mailimap_select( m_imap, fromFolder->getName().latin1());
+    login();
+    if (!m_imap) {
+        return;
+    }
+    int err = selectMbox(fromFolder->getName());
     if ( err != MAILIMAP_NO_ERROR ) {
-        Global::statusMessage(tr("error selecting mailbox: %1").arg(m_imap->imap_response));
         return;
     }
-
     int last = m_imap->imap_selection_info->sel_exists;
     set = mailimap_set_new_interval( 1, last );
     err = mailimap_copy(m_imap,set,targetFolder.latin1());
+    mailimap_set_free( set );
     if ( err != MAILIMAP_NO_ERROR ) {
-        Global::statusMessage(tr("error copy mails: %1").arg(m_imap->imap_response));
+        QString error_msg = tr("error copy mails: %1").arg(m_imap->imap_response);
+        Global::statusMessage(error_msg);
+        qDebug(error_msg);
         return;
     }
-    mailimap_set_free( set );
     if (moveit) {
         deleteAllMail(fromFolder);
diff --git a/noncore/net/mail/libmailwrapper/imapwrapper.h b/noncore/net/mail/libmailwrapper/imapwrapper.h
index 07c6210..99986c2 100644
--- a/noncore/net/mail/libmailwrapper/imapwrapper.h
+++ b/noncore/net/mail/libmailwrapper/imapwrapper.h
@@ -55,5 +55,6 @@ protected:
     virtual QString fetchTextPart(const RecMail&mail,const QValueList<int>&path,bool internal_call=false,const QString&enc="");
     virtual encodedString*fetchRawPart(const RecMail&mail,const QValueList<int>&path,bool internal_call);
-    
+    int selectMbox(const QString&mbox);
+
     void fillSinglePart(RecPart&target_part,mailimap_body_type_1part*Description);
     void fillSingleTextPart(RecPart&target_part,mailimap_body_type_text*which);
@@ -70,4 +71,5 @@ protected:
     IMAPaccount *account;
     mailimap *m_imap;
+    QString m_Lastmbox;
 };