author | zecke <zecke> | 2004-08-25 21:32:12 (UTC) |
---|---|---|
committer | zecke <zecke> | 2004-08-25 21:32:12 (UTC) |
commit | e4811064703ad34f42f15c3044cd8f63c0e7583c (patch) (unidiff) | |
tree | 5c2ab29a176540761b351c29b6556c852067f613 | |
parent | 656d233aa88a92b461abaa618e52db11c1f9d625 (diff) | |
download | opie-e4811064703ad34f42f15c3044cd8f63c0e7583c.zip opie-e4811064703ad34f42f15c3044cd8f63c0e7583c.tar.gz opie-e4811064703ad34f42f15c3044cd8f63c0e7583c.tar.bz2 |
-If play() is called again kill old 'looping/playing' in favor
of the new value. This deletes the timer and would fix possible
shortage on timer resources
-A small friend to hook to an internal signal to avoid problems
in Opie::Core::ODevice entering the event loop to wait for
the sound to be finished. processEvents() can give strange results as
some applications do not expect that the eventloop is entered. This
could possible deliver a Timer, or an Event from QSocketNotifier
which could give all kind of problems of wrong reentrancy.
So let us avoid it.
-rw-r--r-- | library/sound.cpp | 31 | ||||
-rw-r--r-- | library/sound.h | 2 |
2 files changed, 33 insertions, 0 deletions
diff --git a/library/sound.cpp b/library/sound.cpp index ee2aabc..d1e2388 100644 --- a/library/sound.cpp +++ b/library/sound.cpp | |||
@@ -103,4 +103,7 @@ static int WAVsoundDuration(const QString& filename) | |||
103 | 103 | ||
104 | class SoundData : public QSound { | 104 | class SoundData : public QSound { |
105 | Q_OBJECT | ||
106 | signals: | ||
107 | void stopped(); | ||
105 | public: | 108 | public: |
106 | SoundData ( const QString& name ) : | 109 | SoundData ( const QString& name ) : |
@@ -139,4 +142,13 @@ public: | |||
139 | } | 142 | } |
140 | 143 | ||
144 | /* | ||
145 | * non virtual reimplementation | ||
146 | * @internal | ||
147 | */ | ||
148 | void killTimers() { | ||
149 | QObject::killTimers(); | ||
150 | emit stopped(); | ||
151 | } | ||
152 | |||
141 | private: | 153 | private: |
142 | QString filename; | 154 | QString filename; |
@@ -147,4 +159,19 @@ private: | |||
147 | #endif | 159 | #endif |
148 | 160 | ||
161 | |||
162 | /* | ||
163 | * @internal | ||
164 | * Using sender() when the slot is called is unsafe! | ||
165 | * | ||
166 | * @param snd instance | ||
167 | * @param obj The QObject to be called | ||
168 | * @param slot connect SIGNAL(stopped()) to slot | ||
169 | */ | ||
170 | void register_qpe_sound_finished( Sound* snd, QObject* obj, const char* slot ) { | ||
171 | #ifndef QT_NO_SOUND | ||
172 | QObject::connect(snd->d, SIGNAL(stopped()), obj, slot ); | ||
173 | #endif | ||
174 | } | ||
175 | |||
149 | /*! Opens a wave sound file \a name for playing | 176 | /*! Opens a wave sound file \a name for playing |
150 | * Resource is used for finding the file | 177 | * Resource is used for finding the file |
@@ -169,4 +196,5 @@ void Sound::play() | |||
169 | { | 196 | { |
170 | #ifndef QT_NO_SOUND | 197 | #ifndef QT_NO_SOUND |
198 | d->killTimers(); | ||
171 | d->playLoop(1); | 199 | d->playLoop(1); |
172 | #endif | 200 | #endif |
@@ -221,2 +249,5 @@ void Sound::soundAlarm() | |||
221 | \ingroup qtopiaemb | 249 | \ingroup qtopiaemb |
222 | */ | 250 | */ |
251 | |||
252 | |||
253 | #include "sound.moc" | ||
diff --git a/library/sound.h b/library/sound.h index 9f35107..daef70f 100644 --- a/library/sound.h +++ b/library/sound.h | |||
@@ -23,6 +23,8 @@ | |||
23 | class QString; | 23 | class QString; |
24 | class SoundData; | 24 | class SoundData; |
25 | class QObject; | ||
25 | 26 | ||
26 | class Sound { | 27 | class Sound { |
28 | /*INTERNAL*/ friend void register_qpe_sound_finished( Sound*, QObject *obj, const char* slot); | ||
27 | public: | 29 | public: |
28 | Sound(const QString& name); | 30 | Sound(const QString& name); |