summaryrefslogtreecommitdiff
authoralwin <alwin>2004-03-02 14:00:39 (UTC)
committer alwin <alwin>2004-03-02 14:00:39 (UTC)
commit12dd57c04b42d4517061ed847b1aa041dd8af841 (patch) (side-by-side diff)
treeafbd18d5b439138256d27aecec7ef993d74a0bd7
parentac3e7c0a1ccbb984f06917ebe6156b1681b7de7f (diff)
downloadopie-12dd57c04b42d4517061ed847b1aa041dd8af841.zip
opie-12dd57c04b42d4517061ed847b1aa041dd8af841.tar.gz
opie-12dd57c04b42d4517061ed847b1aa041dd8af841.tar.bz2
fixed up todlist to work again. The segfault resulted due a real ugly code-style:
Never, realy never, use "using namespace <...>" inside a include file. Ever use "Opie::<class>" or such inside include files. Think twice, before using a "use namespace <...>" inside a c++ file. If you're using it just 3,4 times, write "Opie::<class>::<variable>" or such. If you just simple write a using namespace all the time it makes the idea of namespaces obsolete. Mostly: just integrate your OWN namespace (in that case use namespace Todo;) - but try to use all other namespaces the explicit way - so you will sure that the compiler inherits the right methods. ToDo: write this statement into the developer wiki
Diffstat (more/less context) (show whitespace changes)
-rw-r--r--core/pim/todo/mainwindow.cpp2
-rw-r--r--core/pim/todo/mainwindow.h8
-rw-r--r--core/pim/todo/quickeditimpl.cpp2
3 files changed, 5 insertions, 7 deletions
diff --git a/core/pim/todo/mainwindow.cpp b/core/pim/todo/mainwindow.cpp
index a244e58..c2f422d 100644
--- a/core/pim/todo/mainwindow.cpp
+++ b/core/pim/todo/mainwindow.cpp
@@ -65,5 +65,5 @@ using namespace Todo;
MainWindow::MainWindow( QWidget* parent,
const char* name, WFlags )
- : OPimMainWindow( "Todolist", parent, name, WType_TopLevel | WStyle_ContextHelp )
+ : Opie::OPimMainWindow( "Todolist", parent, name, WType_TopLevel | WStyle_ContextHelp )
{
if (!name)
diff --git a/core/pim/todo/mainwindow.h b/core/pim/todo/mainwindow.h
index 6a7296b..b35a42b 100644
--- a/core/pim/todo/mainwindow.h
+++ b/core/pim/todo/mainwindow.h
@@ -50,6 +50,4 @@ class QVBox;
class QLineEdit;
-using namespace Opie;
-
namespace Todo {
typedef TodoView View;
@@ -60,5 +58,5 @@ namespace Todo {
struct QuickEditBase;
- class MainWindow : public OPimMainWindow {
+ class MainWindow : public Opie::OPimMainWindow {
Q_OBJECT
friend class TodoView; // avoid QObject here....
@@ -145,5 +143,5 @@ private slots:
*m_showQuickTaskAction,
*m_effectiveAction;
- OWidgetStack *m_stack;
+ Opie::OWidgetStack *m_stack;
QPopupMenu* m_catMenu,
*m_edit,
@@ -206,5 +204,5 @@ private slots:
void show( int uid );
void edit( int uid );
- void add( const OPimRecord& );
+ void add( const Opie::OPimRecord& );
void doAlarm( const QDateTime& dt, int uid );
};
diff --git a/core/pim/todo/quickeditimpl.cpp b/core/pim/todo/quickeditimpl.cpp
index cd0684f..94ae97e 100644
--- a/core/pim/todo/quickeditimpl.cpp
+++ b/core/pim/todo/quickeditimpl.cpp
@@ -22,5 +22,5 @@ QuickEditImpl::QuickEditImpl( QWidget* parent, bool visible )
priority5 = Resource::loadPixmap( "todo/priority5" );
- m_lbl = new OClickableLabel( this );
+ m_lbl = new Opie::OClickableLabel( this );
m_lbl->setMinimumWidth( 15 );
m_lbl->setPixmap( priority3 );