author | llornkcor <llornkcor> | 2002-03-17 01:20:09 (UTC) |
---|---|---|
committer | llornkcor <llornkcor> | 2002-03-17 01:20:09 (UTC) |
commit | 2fe80a98551e89b45798369f1bf91f0368382ba6 (patch) (unidiff) | |
tree | a09d8dd51306563faf3496a05cbaca987665b365 | |
parent | 6fa31a92ee5ae6b4e9df2713b0ed7b8fb39fff49 (diff) | |
download | opie-2fe80a98551e89b45798369f1bf91f0368382ba6.zip opie-2fe80a98551e89b45798369f1bf91f0368382ba6.tar.gz opie-2fe80a98551e89b45798369f1bf91f0368382ba6.tar.bz2 |
fixed problem with remote directory not being listed after an upload, and fixed
problem with temp file poop with strewn throughout the local filesystem.
-rw-r--r-- | noncore/net/opieftp/opieftp.cpp | 79 | ||||
-rw-r--r-- | noncore/net/opieftp/opieftp.h | 6 |
2 files changed, 53 insertions, 32 deletions
diff --git a/noncore/net/opieftp/opieftp.cpp b/noncore/net/opieftp/opieftp.cpp index 042ed59..6a3a64d 100644 --- a/noncore/net/opieftp/opieftp.cpp +++ b/noncore/net/opieftp/opieftp.cpp | |||
@@ -75,5 +75,5 @@ OpieFtp::OpieFtp( ) | |||
75 | localMenu = new QPopupMenu( this ); | 75 | localMenu = new QPopupMenu( this ); |
76 | remoteMenu = new QPopupMenu( this ); | 76 | remoteMenu = new QPopupMenu( this ); |
77 | tabMenu = new QPopupMenu( this ); | 77 | tabMenu = new QPopupMenu( this ); |
78 | 78 | ||
79 | layout->addMultiCellWidget( menuBar, 0, 0, 0, 3 ); | 79 | layout->addMultiCellWidget( menuBar, 0, 0, 0, 3 ); |
@@ -84,5 +84,5 @@ OpieFtp::OpieFtp( ) | |||
84 | menuBar->insertItem( tr( "View" ), tabMenu); | 84 | menuBar->insertItem( tr( "View" ), tabMenu); |
85 | 85 | ||
86 | connectionMenu->insertItem( tr( "New" ), this, SLOT( newConnection() )); | 86 | connectionMenu->insertItem( tr( "New" ), this, SLOT( newConnection() )); |
87 | connectionMenu->insertItem( tr( "Connect" ), this, SLOT( connector() )); | 87 | connectionMenu->insertItem( tr( "Connect" ), this, SLOT( connector() )); |
88 | connectionMenu->insertItem( tr( "Disconnect" ), this, SLOT( disConnector() )); | 88 | connectionMenu->insertItem( tr( "Disconnect" ), this, SLOT( disConnector() )); |
@@ -106,5 +106,5 @@ OpieFtp::OpieFtp( ) | |||
106 | tabMenu->insertItem( tr( "Switch to Config" ), this, SLOT( switchToConfigTab() )); | 106 | tabMenu->insertItem( tr( "Switch to Config" ), this, SLOT( switchToConfigTab() )); |
107 | 107 | ||
108 | TabWidget = new QTabWidget( this, "TabWidget" ); | 108 | TabWidget = new QTabWidget( this, "TabWidget" ); |
109 | layout->addMultiCellWidget( TabWidget, 1, 1, 0, 3 ); | 109 | layout->addMultiCellWidget( TabWidget, 1, 1, 0, 3 ); |
110 | 110 | ||
@@ -149,5 +149,5 @@ OpieFtp::OpieFtp( ) | |||
149 | QPEApplication::setStylusOperation( Remote_View->viewport(),QPEApplication::RightOnHold); | 149 | QPEApplication::setStylusOperation( Remote_View->viewport(),QPEApplication::RightOnHold); |
150 | 150 | ||
151 | connect( Remote_View, SIGNAL( doubleClicked( QListViewItem*)), | 151 | connect( Remote_View, SIGNAL( doubleClicked( QListViewItem*)), |
152 | this,SLOT( remoteListClicked(QListViewItem *)) ); | 152 | this,SLOT( remoteListClicked(QListViewItem *)) ); |
153 | connect( Remote_View, SIGNAL( mouseButtonPressed( int, QListViewItem *, const QPoint&, int)), | 153 | connect( Remote_View, SIGNAL( mouseButtonPressed( int, QListViewItem *, const QPoint&, int)), |
@@ -156,5 +156,5 @@ OpieFtp::OpieFtp( ) | |||
156 | tabLayout_2->addWidget( Remote_View, 0, 0 ); | 156 | tabLayout_2->addWidget( Remote_View, 0, 0 ); |
157 | 157 | ||
158 | TabWidget->insertTab( tab_2, tr( "Remote" ) ); | 158 | TabWidget->insertTab( tab_2, tr( "Remote" ) ); |
159 | 159 | ||
160 | tab_3 = new QWidget( TabWidget, "tab_3" ); | 160 | tab_3 = new QWidget( TabWidget, "tab_3" ); |
@@ -206,17 +206,17 @@ OpieFtp::OpieFtp( ) | |||
206 | TextLabel4 = new QLabel( tab_3, "TextLabel4" ); | 206 | TextLabel4 = new QLabel( tab_3, "TextLabel4" ); |
207 | TextLabel4->setText( tr( "Port" ) ); | 207 | TextLabel4->setText( tr( "Port" ) ); |
208 | tabLayout_3->addMultiCellWidget( TextLabel4, 4, 4, 0, 1 ); | 208 | tabLayout_3->addMultiCellWidget( TextLabel4, 4, 4, 0, 1 ); |
209 | 209 | ||
210 | PortSpinBox = new QSpinBox( tab_3, "PortSpinBox" ); | 210 | PortSpinBox = new QSpinBox( tab_3, "PortSpinBox" ); |
211 | PortSpinBox->setButtonSymbols( QSpinBox::UpDownArrows ); | 211 | PortSpinBox->setButtonSymbols( QSpinBox::UpDownArrows ); |
212 | PortSpinBox->setMaxValue(32786); | 212 | PortSpinBox->setMaxValue(32786); |
213 | PortSpinBox->setValue( 4242); | 213 | PortSpinBox->setValue( 4242); |
214 | // PortSpinBox->setValue( 21); | 214 | // PortSpinBox->setValue( 21); |
215 | tabLayout_3->addMultiCellWidget( PortSpinBox, 4, 4, 1, 1); | 215 | tabLayout_3->addMultiCellWidget( PortSpinBox, 4, 4, 1, 1); |
216 | 216 | ||
217 | QSpacerItem* spacer = new QSpacerItem( 20, 20, QSizePolicy::Minimum, QSizePolicy::Expanding ); | 217 | QSpacerItem* spacer = new QSpacerItem( 20, 20, QSizePolicy::Minimum, QSizePolicy::Expanding ); |
218 | tabLayout_3->addItem( spacer, 5, 0 ); | 218 | tabLayout_3->addItem( spacer, 5, 0 ); |
219 | 219 | ||
220 | TabWidget->insertTab( tab_3, tr( "Config" ) ); | 220 | TabWidget->insertTab( tab_3, tr( "Config" ) ); |
221 | 221 | ||
222 | connect(TabWidget,SIGNAL(currentChanged(QWidget *)), | 222 | connect(TabWidget,SIGNAL(currentChanged(QWidget *)), |
@@ -229,5 +229,5 @@ OpieFtp::OpieFtp( ) | |||
229 | layout->addMultiCellWidget( currentPathEdit, 3, 3, 0, 3 ); | 229 | layout->addMultiCellWidget( currentPathEdit, 3, 3, 0, 3 ); |
230 | 230 | ||
231 | currentPathEdit->setText( currentDir.canonicalPath()); | 231 | currentPathEdit->setText( currentDir.canonicalPath()); |
232 | connect( currentPathEdit,SIGNAL(returnPressed()),this,SLOT(currentPathEditChanged())); | 232 | connect( currentPathEdit,SIGNAL(returnPressed()),this,SLOT(currentPathEditChanged())); |
233 | 233 | ||
@@ -247,7 +247,12 @@ void OpieFtp::cleanUp() | |||
247 | if(conn) | 247 | if(conn) |
248 | FtpQuit(conn); | 248 | FtpQuit(conn); |
249 | QFile f("./._temp"); | 249 | QString sfile=QDir::homeDirPath(); |
250 | if(f.exists()) | 250 | if(sfile.right(1) != "/") |
251 | f. remove(); | 251 | sfile+="/._temp"; |
252 | else | ||
253 | sfile+="._temp"; | ||
254 | QFile file( sfile); | ||
255 | if(file.exists()) | ||
256 | file.remove(); | ||
252 | } | 257 | } |
253 | 258 | ||
@@ -257,8 +262,8 @@ void OpieFtp::tabChanged(QWidget *w) | |||
257 | currentPathEdit->setText( currentDir.canonicalPath()); | 262 | currentPathEdit->setText( currentDir.canonicalPath()); |
258 | } | 263 | } |
259 | if (TabWidget->currentPageIndex() == 1) { | 264 | if (TabWidget->currentPageIndex() == 1) { |
260 | currentPathEdit->setText( currentRemoteDir ); | 265 | currentPathEdit->setText( currentRemoteDir ); |
261 | } | 266 | } |
262 | if (TabWidget->currentPageIndex() == 2) { | 267 | if (TabWidget->currentPageIndex() == 2) { |
263 | } | 268 | } |
264 | } | 269 | } |
@@ -296,5 +301,5 @@ void OpieFtp::localUpload() | |||
296 | } | 301 | } |
297 | TabWidget->setCurrentPage(1); | 302 | TabWidget->setCurrentPage(1); |
298 | populateRemoteView(); | 303 | remoteDirList( (const QString &)currentRemoteDir); //this also calls populate |
299 | QCopEnvelope ( "QPE/System", "notBusy()" ); | 304 | QCopEnvelope ( "QPE/System", "notBusy()" ); |
300 | } | 305 | } |
@@ -398,6 +403,12 @@ void OpieFtp::disConnector() | |||
398 | bool OpieFtp::remoteDirList(const QString &dir) | 403 | bool OpieFtp::remoteDirList(const QString &dir) |
399 | { | 404 | { |
405 | QString tmp = QDir::homeDirPath(); | ||
406 | if(tmp.right(1) != "/") | ||
407 | tmp+="/._temp"; | ||
408 | else | ||
409 | tmp+="._temp"; | ||
410 | // qDebug("Listing remote dir "+tmp); | ||
400 | QCopEnvelope ( "QPE/System", "busy()" ); | 411 | QCopEnvelope ( "QPE/System", "busy()" ); |
401 | if (!FtpDir( "./._temp", dir.latin1(), conn) ) { | 412 | if (!FtpDir( tmp.latin1(), dir.latin1(), conn) ) { |
402 | QString msg; | 413 | QString msg; |
403 | msg.sprintf("Unable to list the directory\n"+dir+"\n%s",FtpLastResponse(conn) ); | 414 | msg.sprintf("Unable to list the directory\n"+dir+"\n%s",FtpLastResponse(conn) ); |
@@ -407,5 +418,5 @@ bool OpieFtp::remoteDirList(const QString &dir) | |||
407 | return false; | 418 | return false; |
408 | } | 419 | } |
409 | populateRemoteView(); | 420 | populateRemoteView() ; |
410 | QCopEnvelope ( "QPE/System", "notBusy()" ); | 421 | QCopEnvelope ( "QPE/System", "notBusy()" ); |
411 | return true; | 422 | return true; |
@@ -464,13 +475,19 @@ void OpieFtp::populateLocalView() | |||
464 | } | 475 | } |
465 | 476 | ||
466 | bool OpieFtp::populateRemoteView() | 477 | bool OpieFtp::populateRemoteView( ) |
467 | { | 478 | { |
479 | // qDebug("populate remoteview"); | ||
480 | QString sfile=QDir::homeDirPath(); | ||
481 | if(sfile.right(1) != "/") | ||
482 | sfile+="/._temp"; | ||
483 | else | ||
484 | sfile+="._temp"; | ||
485 | QFile file( sfile); | ||
468 | Remote_View->clear(); | 486 | Remote_View->clear(); |
469 | QFile tmp("./._temp"); | ||
470 | QString s, File_Name; | 487 | QString s, File_Name; |
471 | QString fileL, fileS, fileDate; | 488 | QString fileL, fileS, fileDate; |
472 | new QListViewItem( Remote_View, "../"); | 489 | new QListViewItem( Remote_View, "../"); |
473 | if (tmp.open(IO_ReadOnly)) { | 490 | if ( file.open(IO_ReadOnly)) { |
474 | QTextStream t( &tmp ); // use a text stream | 491 | QTextStream t( &file ); // use a text stream |
475 | while ( !t.eof()) { | 492 | while ( !t.eof()) { |
476 | s = t.readLine(); | 493 | s = t.readLine(); |
@@ -486,7 +503,10 @@ bool OpieFtp::populateRemoteView() | |||
486 | new QListViewItem( Remote_View, fileL, fileS, fileDate); | 503 | new QListViewItem( Remote_View, fileL, fileS, fileDate); |
487 | } | 504 | } |
488 | tmp.close(); | 505 | file.close(); |
506 | if( file.exists()) | ||
507 | file. remove(); | ||
489 | } else | 508 | } else |
490 | qDebug("temp file not opened successfullly"); | 509 | qDebug("temp file not opened successfullly "+sfile); |
510 | |||
491 | return true; | 511 | return true; |
492 | } | 512 | } |
@@ -523,5 +543,4 @@ void OpieFtp::remoteListClicked(QListViewItem *selectedItem) | |||
523 | currentRemoteDir = oldRemoteCurrentDir; | 543 | currentRemoteDir = oldRemoteCurrentDir; |
524 | strItem=""; | 544 | strItem=""; |
525 | populateRemoteView(); | ||
526 | qDebug("RemoteCurrentDir1 "+oldRemoteCurrentDir); | 545 | qDebug("RemoteCurrentDir1 "+oldRemoteCurrentDir); |
527 | } | 546 | } |
@@ -533,5 +552,4 @@ void OpieFtp::remoteListClicked(QListViewItem *selectedItem) | |||
533 | qDebug("RemoteCurrentDir1 "+oldRemoteCurrentDir); | 552 | qDebug("RemoteCurrentDir1 "+oldRemoteCurrentDir); |
534 | 553 | ||
535 | populateRemoteView(); | ||
536 | } else { | 554 | } else { |
537 | currentRemoteDir = currentRemoteDir+strItem; | 555 | currentRemoteDir = currentRemoteDir+strItem; |
@@ -541,8 +559,8 @@ void OpieFtp::remoteListClicked(QListViewItem *selectedItem) | |||
541 | } | 559 | } |
542 | } | 560 | } |
561 | remoteDirList( (const QString &)currentRemoteDir); //this also calls populate | ||
543 | if(currentRemoteDir.right(1) !="/") | 562 | if(currentRemoteDir.right(1) !="/") |
544 | currentRemoteDir +="/"; | 563 | currentRemoteDir +="/"; |
545 | currentPathEdit->setText( currentRemoteDir ); | 564 | currentPathEdit->setText( currentRemoteDir ); |
546 | remoteDirList( (const QString &)currentRemoteDir); | ||
547 | QCopEnvelope ( "QPE/System", "notBusy()" ); | 565 | QCopEnvelope ( "QPE/System", "notBusy()" ); |
548 | } | 566 | } |
@@ -725,6 +743,6 @@ void OpieFtp::remoteMakDir() | |||
725 | } | 743 | } |
726 | QCopEnvelope ( "QPE/System", "notBusy()" ); | 744 | QCopEnvelope ( "QPE/System", "notBusy()" ); |
745 | remoteDirList( (const QString &)currentRemoteDir); //this also calls populate | ||
727 | } | 746 | } |
728 | populateRemoteView(); | ||
729 | } | 747 | } |
730 | 748 | ||
@@ -745,4 +763,6 @@ void OpieFtp::remoteDelete() | |||
745 | QMessageBox::message("Note",msg); | 763 | QMessageBox::message("Note",msg); |
746 | } | 764 | } |
765 | remoteDirList( (const QString &)currentRemoteDir); //this also calls populate | ||
766 | |||
747 | } | 767 | } |
748 | break; | 768 | break; |
@@ -759,4 +779,5 @@ void OpieFtp::remoteDelete() | |||
759 | QMessageBox::message("Note",msg); | 779 | QMessageBox::message("Note",msg); |
760 | } | 780 | } |
781 | remoteDirList( (const QString &)currentRemoteDir); //this also calls populate | ||
761 | } | 782 | } |
762 | break; | 783 | break; |
@@ -784,6 +805,6 @@ void OpieFtp::remoteRename() | |||
784 | } | 805 | } |
785 | QCopEnvelope ( "QPE/System", "notBusy()" ); | 806 | QCopEnvelope ( "QPE/System", "notBusy()" ); |
807 | remoteDirList( (const QString &)currentRemoteDir); //this also calls populate | ||
786 | } | 808 | } |
787 | populateRemoteView(); | ||
788 | } | 809 | } |
789 | 810 | ||
diff --git a/noncore/net/opieftp/opieftp.h b/noncore/net/opieftp/opieftp.h index e3ff334..1e5fffa 100644 --- a/noncore/net/opieftp/opieftp.h +++ b/noncore/net/opieftp/opieftp.h | |||
@@ -90,7 +90,7 @@ protected slots: | |||
90 | void localRename(); | 90 | void localRename(); |
91 | void currentPathEditChanged(); | 91 | void currentPathEditChanged(); |
92 | void switchToLocalTab(); | 92 | void switchToLocalTab(); |
93 | void switchToRemoteTab(); | 93 | void switchToRemoteTab(); |
94 | void switchToConfigTab(); | 94 | void switchToConfigTab(); |
95 | protected: | 95 | protected: |
96 | void nullifyCallBack(); | 96 | void nullifyCallBack(); |