author | erik <erik> | 2007-01-24 19:57:51 (UTC) |
---|---|---|
committer | erik <erik> | 2007-01-24 19:57:51 (UTC) |
commit | 48d9219a96096cf44df8ac24413b36d1b718b1d5 (patch) (unidiff) | |
tree | ef49f0d2b778283221ebbb8634f1a59710ddd108 | |
parent | 89e81059e832ff77c2f0ac8b9db12f80eafa03fc (diff) | |
download | opie-48d9219a96096cf44df8ac24413b36d1b718b1d5.zip opie-48d9219a96096cf44df8ac24413b36d1b718b1d5.tar.gz opie-48d9219a96096cf44df8ac24413b36d1b718b1d5.tar.bz2 |
Each file in this commit has the issue where a function can return a
negative result but the result is used in a context that can only be
positive.
-rw-r--r-- | noncore/games/kpacman/score.cpp | 4 | ||||
-rw-r--r-- | noncore/todayplugins/stockticker/libstocks/http.c | 19 |
2 files changed, 11 insertions, 12 deletions
diff --git a/noncore/games/kpacman/score.cpp b/noncore/games/kpacman/score.cpp index 6878b81..737f03b 100644 --- a/noncore/games/kpacman/score.cpp +++ b/noncore/games/kpacman/score.cpp | |||
@@ -240,9 +240,9 @@ void Score::keyPressEvent(QKeyEvent *k) | |||
240 | 240 | ||
241 | if (x != cursor.x || y != cursor.y) { | 241 | if (x != cursor.x || y != cursor.y) { |
242 | if (cursor.x != -1) | 242 | if (cursor.x != -1 && lastScore >= 0) |
243 | cursor.chr = hallOfFame[lastScore].name.at(cursor.x-14); | 243 | cursor.chr = hallOfFame[lastScore].name.at(cursor.x-14); |
244 | scrollRepeat = FALSE; | 244 | scrollRepeat = FALSE; |
245 | repaint(rect(x, y*1.25, cursor.chr), FALSE); | 245 | repaint(rect(x, y*1.25, cursor.chr), FALSE); |
246 | } else | 246 | } else if (lastScore >= 0) |
247 | hallOfFame[lastScore].name.at(cursor.x-14) = cursor.chr; | 247 | hallOfFame[lastScore].name.at(cursor.x-14) = cursor.chr; |
248 | 248 | ||
diff --git a/noncore/todayplugins/stockticker/libstocks/http.c b/noncore/todayplugins/stockticker/libstocks/http.c index cc78ab7..155ce4b 100644 --- a/noncore/todayplugins/stockticker/libstocks/http.c +++ b/noncore/todayplugins/stockticker/libstocks/http.c | |||
@@ -85,7 +85,7 @@ libstocks_return_code http_get(char *http_file, char *http_server, char **pdata) | |||
85 | server.sin_port = (unsigned short) htons( http_proxy_server ? http_proxy_port : 80 ); | 85 | server.sin_port = (unsigned short) htons( http_proxy_server ? http_proxy_port : 80 ); |
86 | 86 | ||
87 | } else | 87 | } |
88 | else | ||
88 | { | 89 | { |
89 | |||
90 | #ifdef DEBUG | 90 | #ifdef DEBUG |
91 | printf(" gethostbyname : NOK\n"); | 91 | printf(" gethostbyname : NOK\n"); |
@@ -97,5 +97,4 @@ libstocks_return_code http_get(char *http_file, char *http_server, char **pdata) | |||
97 | if ((s = socket(AF_INET, SOCK_STREAM, 0)) < 0) | 97 | if ((s = socket(AF_INET, SOCK_STREAM, 0)) < 0) |
98 | { | 98 | { |
99 | |||
100 | #ifdef DEBUG | 99 | #ifdef DEBUG |
101 | printf(" create socket : NOK\n"); | 100 | printf(" create socket : NOK\n"); |
@@ -160,5 +159,5 @@ libstocks_return_code http_get(char *http_file, char *http_server, char **pdata) | |||
160 | #endif | 159 | #endif |
161 | 160 | ||
162 | if (r) | 161 | if (r > 0) |
163 | { | 162 | { |
164 | if(!data_lgr) | 163 | if(!data_lgr) |
@@ -166,6 +165,6 @@ libstocks_return_code http_get(char *http_file, char *http_server, char **pdata) | |||
166 | if((data = malloc(r+1))==NULL) | 165 | if((data = malloc(r+1))==NULL) |
167 | { | 166 | { |
168 | fprintf(stderr,"Memory allocating error (%s line %d)\n" | 167 | fprintf(stderr,"Memory allocating error (%s line %d)\n", |
169 | ,__FILE__, __LINE__); | 168 | __FILE__, __LINE__); |
170 | exit(1); | 169 | exit(1); |
171 | } | 170 | } |
@@ -179,6 +178,6 @@ libstocks_return_code http_get(char *http_file, char *http_server, char **pdata) | |||
179 | if((temp = malloc(r+data_lgr+1))==NULL) | 178 | if((temp = malloc(r+data_lgr+1))==NULL) |
180 | { | 179 | { |
181 | fprintf(stderr,"Memory allocating error (%s line %d)\n" | 180 | fprintf(stderr,"Memory allocating error (%s line %d)\n", |
182 | ,__FILE__, __LINE__); | 181 | __FILE__, __LINE__); |
183 | exit(1); | 182 | exit(1); |
184 | } | 183 | } |
@@ -241,6 +240,6 @@ libstocks_return_code http_get(char *http_file, char *http_server, char **pdata) | |||
241 | { | 240 | { |
242 | free(data); | 241 | free(data); |
243 | fprintf(stderr,"Memory allocating error (%s line %d)\n" | 242 | fprintf(stderr,"Memory allocating error (%s line %d)\n", |
244 | ,__FILE__, __LINE__); | 243 | __FILE__, __LINE__); |
245 | exit(1); | 244 | exit(1); |
246 | } | 245 | } |