summaryrefslogtreecommitdiff
authorzecke <zecke>2004-09-18 01:08:08 (UTC)
committer zecke <zecke>2004-09-18 01:08:08 (UTC)
commit5096f9bd9f1a06e5238e2206eee195c43a2bdb6b (patch) (side-by-side diff)
tree57281b88624984d3b2dc7950cd2a5f586f06f076
parent081f8a3c3a6c6d45743f451cd9dc966a135b8156 (diff)
downloadopie-5096f9bd9f1a06e5238e2206eee195c43a2bdb6b.zip
opie-5096f9bd9f1a06e5238e2206eee195c43a2bdb6b.tar.gz
opie-5096f9bd9f1a06e5238e2206eee195c43a2bdb6b.tar.bz2
The following change is untested on a real device. So please try and
bitch if I broke something!!! Make unmounting of sdcards more robust. If we find a /dev/mmcard1 or /dev/mmc/1 or /dev/mmc* we will remember that device name and if the user asks us to eject it we will use that name.
Diffstat (more/less context) (show whitespace changes)
-rw-r--r--core/applets/cardmon/cardmon.cpp15
-rw-r--r--core/applets/cardmon/cardmon.h1
2 files changed, 6 insertions, 10 deletions
diff --git a/core/applets/cardmon/cardmon.cpp b/core/applets/cardmon/cardmon.cpp
index 48146ab..43ccce2 100644
--- a/core/applets/cardmon/cardmon.cpp
+++ b/core/applets/cardmon/cardmon.cpp
@@ -117,55 +117,50 @@ void CardMonitor::mousePressEvent( QMouseEvent * ) {
if ( cardInPcmcia0 ) {
menu->
insertItem( QIconSet
( Resource::loadPixmap( "cardmon/" + cardInPcmcia0Type ) ),
tr( "Eject card 0: %1" ).arg( cardInPcmcia0Name ), 1 );
}
if ( cardInPcmcia1 ) {
menu->
insertItem( QIconSet
( Resource::loadPixmap( "cardmon/" + cardInPcmcia1Type ) ),
tr( "Eject card 1: %1" ).arg( cardInPcmcia1Name ), 2 );
}
QPoint p = mapToGlobal( QPoint( 0, 0 ) );
QSize s = menu->sizeHint();
int opt = menu->exec( QPoint( p.x() + ( width() / 2 ) - ( s.width() / 2 ),
p.y() - s.height() ), 0 );
if ( opt == 1 ) {
m_commandOrig = 1;
execCommand("/sbin/cardctl eject 0");
} else if ( opt == 0 ) {
- if ( ODevice::inst() ->system() == System_Familiar ) {
- cmd = "umount /dev/mmc/part1";
- } else {
- cmd = "umount /dev/mmcda1";
- }
m_commandOrig = 2;
- execCommand( cmd );
+ execCommand( QString("umount %1").arg(cardSdName));
} else if ( opt == 2 ) {
m_commandOrig = 3;
execCommand( "/sbin/cardctl eject 1" );
}
delete menu;
}
void CardMonitor::cardMessage( const QCString & msg, const QByteArray & ) {
if ( msg == "stabChanged()" ) {
// odebug << "Pcmcia: stabchanged" << oendl;
getStatusPcmcia();
} else if ( msg == "mtabChanged()" ) {
// odebug << "CARDMONAPPLET: mtabchanged" << oendl;
getStatusSd();
}
}
bool CardMonitor::getStatusPcmcia( int showPopUp ) {
bool cardWas0 = cardInPcmcia0; // remember last state
bool cardWas1 = cardInPcmcia1;
QString fileName;
@@ -261,53 +256,54 @@ bool CardMonitor::getStatusPcmcia( int showPopUp ) {
// no file found
odebug << "no file found" << oendl;
cardInPcmcia0 = FALSE;
cardInPcmcia1 = FALSE;
}
repaint( FALSE );
return ( ( cardWas0 == cardInPcmcia0
&& cardWas1 == cardInPcmcia1 ) ? FALSE : TRUE );
}
bool CardMonitor::getStatusSd( int showPopUp ) {
bool cardWas = cardInSd; // remember last state
cardInSd = FALSE;
#if defined(_OS_LINUX_) || defined(Q_OS_LINUX)
struct mntent *me;
FILE *mntfp = setmntent( "/etc/mtab", "r" );
if ( mntfp ) {
while ( ( me = getmntent( mntfp ) ) != 0 ) {
- QString fs = me->mnt_fsname;
+ QString fs = QFile::decodeName( me->mnt_fsname );
//odebug << fs << oendl;
if ( fs.left( 14 ) == "/dev/mmc/part1" || fs.left( 7 ) == "/dev/sd"
|| fs.left( 9 ) == "/dev/mmcd" ) {
cardInSd = TRUE;
+ cardSdName = fs;
show();
}
// else {
// cardInSd = FALSE;
// }
}
endmntent( mntfp );
}
if ( !showPopUp && cardWas != cardInSd ) {
QString text = QString::null;
QString what = QString::null;
if ( cardInSd ) {
text += "New card: SD/MMC";
what = "on";
} else {
text += "Ejected: SD/MMC";
what = "off";
}
//odebug << "TEXT: " + text << oendl;
#ifndef QT_NO_SOUND
QSound::play( Resource::findSound( "cardmon/card" + what ) );
#endif
@@ -317,64 +313,63 @@ bool CardMonitor::getStatusSd( int showPopUp ) {
#error "Not on Linux"
#endif
repaint( FALSE );
return ( ( cardWas == cardInSd ) ? FALSE : TRUE );
}
void CardMonitor::paintEvent( QPaintEvent * ) {
QPainter p( this );
if ( cardInPcmcia0 || cardInPcmcia1 || cardInSd ) {
p.drawPixmap( 0, 0, pm );
show();
} else {
//p.eraseRect(rect());
hide();
}
}
int CardMonitor::position() {
return 7;
}
void CardMonitor::execCommand( const QString &command ) {
+ delete m_process;
+ m_process = 0;
if ( m_process == 0 ) {
m_process = new OProcess();
QStringList strList = QStringList::split( " ", command );
for ( QStringList::Iterator it = strList.begin(); it != strList.end(); ++it ) {
*m_process << *it;
}
connect(m_process, SIGNAL( processExited(Opie::Core::OProcess*) ),
this, SLOT( slotExited(Opie::Core::OProcess* ) ) );
if(!m_process->start(OProcess::NotifyOnExit, OProcess::AllOutput ) ) {
delete m_process;
m_process = 0;
}
}
}
void CardMonitor::slotExited( OProcess* ) {
if( m_process->normalExit() ) {
int ret = m_process->exitStatus();
if( ret != 0 ) {
if ( m_commandOrig == 1 ) {
popUp( tr( "CF/PCMCIA card eject failed!" ) );
} else if ( m_commandOrig == 2 ) {
popUp( tr( "SD/MMC card eject failed!" ) );
} else if ( m_commandOrig == 3 ) {
popUp( tr( "CF/PCMCIA card eject failed!" ) );
}
}
}
-
- delete m_process;
- m_process = 0;
}
EXPORT_OPIE_APPLET_v1( CardMonitor )
diff --git a/core/applets/cardmon/cardmon.h b/core/applets/cardmon/cardmon.h
index 19d0394..b02c8b1 100644
--- a/core/applets/cardmon/cardmon.h
+++ b/core/applets/cardmon/cardmon.h
@@ -38,32 +38,33 @@ public:
bool getStatusSd( int showPopUp = FALSE );
static int position();
private slots:
void cardMessage( const QCString &msg, const QByteArray & );
void slotExited( Opie::Core::OProcess* proc );
void popupTimeout();
protected:
void paintEvent( QPaintEvent* );
void mousePressEvent( QMouseEvent * );
private:
void execCommand( const QString &command );
int m_commandOrig;
QPixmap pm;
// pcmcia socket 0
bool cardInPcmcia0;
QString cardInPcmcia0Name;
QString cardInPcmcia0Type;
// pcmcia socket 1
bool cardInPcmcia1;
QString cardInPcmcia1Name;
QString cardInPcmcia1Type;
bool cardInSd;
+ QString cardSdName; // the device which is mounted
void iconShow();
QPopupMenu *popupMenu;
void popUp(QString message, QString icon = QString::null );
Opie::Core::OProcess* m_process;
};
#endif