fix bug 0001185

and state that syncing system time depends on AlarmServer
using atd or opie-alarm

2 files changed, 17 insertions, 12 deletions

diff --git a/library/alarmserver.cpp b/library/alarmserver.cpp
index 2ea4025..a75fc7e 100644
--- a/library/alarmserver.cpp
+++ b/library/alarmserver.cpp
@@ -283,73 +283,73 @@ void TimerReceiverObject::timerEvent( QTimerEvent * )
 		if ( nearestTimerEvent->UTCtime
 		        <= TimeConversion::toUTC(QDateTime::currentDateTime()) ) {
 #ifndef QT_NO_COP
 			QCopEnvelope e( nearestTimerEvent->channel,
 			                nearestTimerEvent->message );
 			e << TimeConversion::fromUTC( nearestTimerEvent->UTCtime )
 			<< nearestTimerEvent->data;
 #endif
 
 			timerEventList.remove( nearestTimerEvent );
 			needSave = TRUE;
 		}
 		setNearestTimerEvent();
 	}
 	else {
 		resetTimer();
 	}
 	if ( needSave )
 		saveState();
 }
 
 /*!
   \class AlarmServer alarmserver.h
   \brief The AlarmServer class allows alarms to be scheduled and unscheduled.
- 
+
     Applications can schedule alarms with addAlarm() and can
     unschedule alarms with deleteAlarm(). When the time for an alarm
     to go off is reached the specified \link qcop.html QCop\endlink
     message is sent on the specified channel (optionally with
     additional data).
- 
+
     Scheduling an alarm using this class is important (rather just using
     a QTimer) since the machine may be asleep and needs to get woken up using
     the Linux kernel which implements this at the kernel level to minimize
     battery usage while asleep.
- 
+
     \ingroup qtopiaemb
     \sa QCopEnvelope
 */
 
 /*!
   Schedules an alarm to go off at (or soon after) time \a when. When
   the alarm goes off, the \link qcop.html QCop\endlink \a message will
   be sent to \a channel, with \a data as a parameter.
- 
+
   If this function is called with exactly the same data as a previous
   call the subsequent call is ignored, so there is only ever one alarm
   with a given set of parameters.
- 
+
   \sa deleteAlarm()
 */
 void AlarmServer::addAlarm ( QDateTime when, const QCString& channel,
                              const QCString& message, int data)
 {
 	if ( qApp->type() == QApplication::GuiServer ) {
 		bool needSave = FALSE;
 		// Here we are the server so either it has been directly called from
 		// within the server or it has been sent to us from a client via QCop
 		if (!timerEventReceiver)
 			timerEventReceiver = new TimerReceiverObject;
 
 		timerEventItem *newTimerEventItem = new timerEventItem;
 		newTimerEventItem->UTCtime = TimeConversion::toUTC( when );
 		newTimerEventItem->channel = channel;
 		newTimerEventItem->message = message;
 		newTimerEventItem->data = data;
 		// explore the case of already having the event in here...
 		QListIterator<timerEventItem> it( timerEventList );
 		for ( ; *it; ++it )
 			if ( *(*it) == *newTimerEventItem )
 				return ;
 		// if we made it here, it is okay to add the item...
 		timerEventList.append( newTimerEventItem );
@@ -360,90 +360,93 @@ void AlarmServer::addAlarm ( QDateTime when, const QCString& channel,
 				nearestTimerEvent = newTimerEventItem;
 				timerEventReceiver->killTimers();
 				timerEventReceiver->resetTimer();
 			}
 		}
 		else {
 			nearestTimerEvent = newTimerEventItem;
 			timerEventReceiver->resetTimer();
 		}
 		if ( needSave )
 			saveState();
 	}
 	else {
 #ifndef QT_NO_COP
 		QCopEnvelope e( "QPE/System", "addAlarm(QDateTime,QCString,QCString,int)" );
 		e << when << channel << message << data;
 #endif
 
 	}
 }
 
 /*!
   Deletes previously scheduled alarms which match \a when, \a channel,
   \a message, and \a data.
- 
+
   Passing null values for \a when, \a channel, or for the \link
   qcop.html QCop\endlink \a message, acts as a wildcard meaning "any".
   Similarly, passing -1 for \a data indicates "any".
- 
+
   If there is no matching alarm, nothing happens.
- 
+
   \sa addAlarm()
- 
+
 */
 void AlarmServer::deleteAlarm (QDateTime when, const QCString& channel, const QCString& message, int data)
 {
 	if ( qApp->type() == QApplication::GuiServer) {
 		bool needSave = FALSE;
 		if ( timerEventReceiver != NULL ) {
 			timerEventReceiver->killTimers();
 
 			// iterate over the list of events
 			QListIterator<timerEventItem> it( timerEventList );
 			time_t deleteTime = TimeConversion::toUTC( when );
 			for ( ; *it; ++it ) {
 				// if its a match, delete it
 				if ( ( (*it)->UTCtime == deleteTime || when.isNull() )
 				        && ( channel.isNull() || (*it)->channel == channel )
 				        && ( message.isNull() || (*it)->message == message )
 				        && ( data == -1 || (*it)->data == data ) ) {
 					// if it's first, then we need to update the timer
 					if ( (*it) == nearestTimerEvent ) {
 						timerEventList.remove(*it);
 						setNearestTimerEvent();
 					}
 					else {
 						timerEventList.remove(*it);
 					}
 					needSave = TRUE;
 				}
 			}
 			if ( nearestTimerEvent )
 				timerEventReceiver->resetTimer();
 		}
 		if ( needSave )
 			saveState();
 	}
 	else {
 #ifndef QT_NO_COP
 		QCopEnvelope e( "QPE/System", "deleteAlarm(QDateTime,QCString,QCString,int)" );
 		e << when << channel << message << data;
 #endif
 
 	}
 }
 
 /*!
-  Writes the system clock to the hardware clock.
+  The implementation depends on the mode of AlarmServer. If the AlarmServer
+  uses atd the current system time will be written to the hardware clock.
+  If the AlarmServer relies on opie-alarm the time will be written once the
+  device gets suspended. opie-alarm is used by the Zaurus, iPAQs and SIMpad
 */
 void Global::writeHWClock()
 {
 #ifdef USE_ATD
 	if ( !triggerAtd( TRUE ) ) {
 		// atd not running? set it ourselves
 		system("/sbin/hwclock --systohc"); // ##### UTC?
 	}
 #else
 	// hwclock is written on suspend
 #endif
 }
diff --git a/library/global.cpp b/library/global.cpp
index 5c89430..90954fe 100644
--- a/library/global.cpp
+++ b/library/global.cpp
@@ -192,50 +192,52 @@ static QString dictDir()
   The execute() function runs an application.
 
   \section1 Word list related
 
   A list of words relevant to the current locale is maintained by the
   system. The list is held in a \link qdawg.html DAWG\endlink
   (implemented by the QDawg class). This list is used, for example, by
   the pickboard input method.
 
   The global QDawg is returned by fixedDawg(); this cannot be updated.
   An updatable copy of the global QDawg is returned by addedDawg().
   Applications may have their own word lists stored in \l{QDawg}s
   which are returned by dawg(). Use addWords() to add words to the
   updateable copy of the global QDawg or to named application
   \l{QDawg}s.
 
   \section1 Quoting
 
   The shellQuote() function quotes a string suitable for passing to a
   shell. The stringQuote() function backslash escapes '\' and '"'
   characters.
 
   \section1 Hardware
 
-  The writeHWClock() function sets the hardware clock to the system
-  clock's date and time.
+  The implementation of the writeHWClock() function depends on the AlarmServer
+  implementation. If the AlarmServer is using atd the clock will be synced to
+  hardware. If opie-alarm is used the hardware clock will be synced before
+  suspending the device. opie-alarm is used by iPAQ and Zaurii implementation
 
   \ingroup qtopiaemb
 */
 
 /*!
   \internal
 */
 Global::Global()
 {
 }
 
 /*!
   Returns the unchangeable QDawg that contains general
   words for the current locale.
 
   \sa addedDawg()
 */
 const QDawg& Global::fixedDawg()
 {
     if ( !fixed_dawg ) {
 	if ( !docDirCreated )
 	    createDocDir();
 
 	fixed_dawg = new QDawg;