author | zecke <zecke> | 2005-03-06 23:30:41 (UTC) |
---|---|---|
committer | zecke <zecke> | 2005-03-06 23:30:41 (UTC) |
commit | f312f32d624c6198c63890e141e8658bc492cf37 (patch) (unidiff) | |
tree | c76e9caad09226113e42e0477d08e13d6388af2e | |
parent | 578cc81bc489015320351efd4fabcbed3355ac23 (diff) | |
download | opie-f312f32d624c6198c63890e141e8658bc492cf37.zip opie-f312f32d624c6198c63890e141e8658bc492cf37.tar.gz opie-f312f32d624c6198c63890e141e8658bc492cf37.tar.bz2 |
The mainwidget could be deleted before the qpeapplication will be destructed or
the event loop will be left.
Use a QGuardedPtr to not save widget coordinates on a not anymore existing
mainwidget
-rw-r--r-- | library/qpeapplication.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/library/qpeapplication.cpp b/library/qpeapplication.cpp index 2bd7cbe..953f9d0 100644 --- a/library/qpeapplication.cpp +++ b/library/qpeapplication.cpp | |||
@@ -146,49 +146,49 @@ public: | |||
146 | bool notbusysent : 1; | 146 | bool notbusysent : 1; |
147 | bool preloaded : 1; | 147 | bool preloaded : 1; |
148 | bool forceshow : 1; | 148 | bool forceshow : 1; |
149 | bool nomaximize : 1; | 149 | bool nomaximize : 1; |
150 | bool keep_running : 1; | 150 | bool keep_running : 1; |
151 | bool qcopQok : 1; | 151 | bool qcopQok : 1; |
152 | 152 | ||
153 | QCString fontFamily; | 153 | QCString fontFamily; |
154 | int fontSize; | 154 | int fontSize; |
155 | int smallIconSize; | 155 | int smallIconSize; |
156 | int bigIconSize; | 156 | int bigIconSize; |
157 | 157 | ||
158 | QString appName; | 158 | QString appName; |
159 | struct QCopRec | 159 | struct QCopRec |
160 | { | 160 | { |
161 | QCopRec( const QCString &ch, const QCString &msg, | 161 | QCopRec( const QCString &ch, const QCString &msg, |
162 | const QByteArray &d ) : | 162 | const QByteArray &d ) : |
163 | channel( ch ), message( msg ), data( d ) | 163 | channel( ch ), message( msg ), data( d ) |
164 | { } | 164 | { } |
165 | 165 | ||
166 | QCString channel; | 166 | QCString channel; |
167 | QCString message; | 167 | QCString message; |
168 | QByteArray data; | 168 | QByteArray data; |
169 | }; | 169 | }; |
170 | QWidget* qpe_main_widget; | 170 | QGuardedPtr<QWidget> qpe_main_widget; |
171 | QGuardedPtr<QWidget> lastraised; | 171 | QGuardedPtr<QWidget> lastraised; |
172 | QQueue<QCopRec> qcopq; | 172 | QQueue<QCopRec> qcopq; |
173 | QString styleName; | 173 | QString styleName; |
174 | QString decorationName; | 174 | QString decorationName; |
175 | 175 | ||
176 | void enqueueQCop( const QCString &ch, const QCString &msg, | 176 | void enqueueQCop( const QCString &ch, const QCString &msg, |
177 | const QByteArray &data ) | 177 | const QByteArray &data ) |
178 | { | 178 | { |
179 | qcopq.enqueue( new QCopRec( ch, msg, data ) ); | 179 | qcopq.enqueue( new QCopRec( ch, msg, data ) ); |
180 | } | 180 | } |
181 | void sendQCopQ() | 181 | void sendQCopQ() |
182 | { | 182 | { |
183 | if (!qcopQok ) | 183 | if (!qcopQok ) |
184 | return; | 184 | return; |
185 | 185 | ||
186 | QCopRec * r; | 186 | QCopRec * r; |
187 | 187 | ||
188 | while((r=qcopq.dequeue())) { | 188 | while((r=qcopq.dequeue())) { |
189 | // remove from queue before sending... | 189 | // remove from queue before sending... |
190 | // event loop can come around again before getting | 190 | // event loop can come around again before getting |
191 | // back from sendLocally | 191 | // back from sendLocally |
192 | #ifndef QT_NO_COP | 192 | #ifndef QT_NO_COP |
193 | QCopChannel::sendLocally( r->channel, r->message, r->data ); | 193 | QCopChannel::sendLocally( r->channel, r->message, r->data ); |
194 | #endif | 194 | #endif |
@@ -298,48 +298,51 @@ public: | |||
298 | if ( wHeight > maxY ) { | 298 | if ( wHeight > maxY ) { |
299 | s.setHeight( maxY - (w->frameGeometry().height() - w->geometry().height() ) ); | 299 | s.setHeight( maxY - (w->frameGeometry().height() - w->geometry().height() ) ); |
300 | wHeight = maxY; | 300 | wHeight = maxY; |
301 | } | 301 | } |
302 | 302 | ||
303 | // any smaller than this and the maximize/close/help buttons will be overlapping | 303 | // any smaller than this and the maximize/close/help buttons will be overlapping |
304 | if ( wWidth < 80 || wHeight < 60 ) | 304 | if ( wWidth < 80 || wHeight < 60 ) |
305 | return FALSE; | 305 | return FALSE; |
306 | 306 | ||
307 | if ( p.x() < 0 ) | 307 | if ( p.x() < 0 ) |
308 | p.setX(0); | 308 | p.setX(0); |
309 | if ( p.y() < 0 ) | 309 | if ( p.y() < 0 ) |
310 | p.setY(0); | 310 | p.setY(0); |
311 | 311 | ||
312 | if ( p.x() + wWidth > maxX ) | 312 | if ( p.x() + wWidth > maxX ) |
313 | p.setX( maxX - wWidth ); | 313 | p.setX( maxX - wWidth ); |
314 | if ( p.y() + wHeight > maxY ) | 314 | if ( p.y() + wHeight > maxY ) |
315 | p.setY( maxY - wHeight ); | 315 | p.setY( maxY - wHeight ); |
316 | 316 | ||
317 | return TRUE; | 317 | return TRUE; |
318 | } | 318 | } |
319 | 319 | ||
320 | static void store_widget_rect(QWidget *w, QString &app) | 320 | static void store_widget_rect(QWidget *w, QString &app) |
321 | { | 321 | { |
322 | if( !w ) | ||
323 | return; | ||
324 | |||
322 | // 350 is the trigger in qwsdefaultdecoration for providing a resize button | 325 | // 350 is the trigger in qwsdefaultdecoration for providing a resize button |
323 | if ( qApp->desktop()->width() <= 350 ) | 326 | if ( qApp->desktop()->width() <= 350 ) |
324 | return; | 327 | return; |
325 | // we use these to map the offset of geometry and pos. ( we can only use normalGeometry to | 328 | // we use these to map the offset of geometry and pos. ( we can only use normalGeometry to |
326 | // get the non-maximized version, so we have to do it the hard way ) | 329 | // get the non-maximized version, so we have to do it the hard way ) |
327 | int offsetX = w->x() - w->geometry().left(); | 330 | int offsetX = w->x() - w->geometry().left(); |
328 | int offsetY = w->y() - w->geometry().top(); | 331 | int offsetY = w->y() - w->geometry().top(); |
329 | 332 | ||
330 | QRect r; | 333 | QRect r; |
331 | if ( w->isMaximized() ) | 334 | if ( w->isMaximized() ) |
332 | r = ( (HackWidget *) w)->normalGeometry(); | 335 | r = ( (HackWidget *) w)->normalGeometry(); |
333 | else | 336 | else |
334 | r = w->geometry(); | 337 | r = w->geometry(); |
335 | 338 | ||
336 | // Stores the window placement as pos(), size() (due to the offset mapping) | 339 | // Stores the window placement as pos(), size() (due to the offset mapping) |
337 | Config cfg( "qpe" ); | 340 | Config cfg( "qpe" ); |
338 | cfg.setGroup("ApplicationPositions"); | 341 | cfg.setGroup("ApplicationPositions"); |
339 | QString s; | 342 | QString s; |
340 | s.sprintf("%d,%d,%d,%d,%d", r.left() + offsetX, r.top() + offsetY, r.width(), r.height(), w->isMaximized() ); | 343 | s.sprintf("%d,%d,%d,%d,%d", r.left() + offsetX, r.top() + offsetY, r.width(), r.height(), w->isMaximized() ); |
341 | cfg.writeEntry( app, s ); | 344 | cfg.writeEntry( app, s ); |
342 | } | 345 | } |
343 | 346 | ||
344 | static bool setWidgetCaptionFromAppName( QWidget* /*mw*/, const QString& /*appName*/, const QString& /*appsPath*/ ) | 347 | static bool setWidgetCaptionFromAppName( QWidget* /*mw*/, const QString& /*appName*/, const QString& /*appsPath*/ ) |
345 | { | 348 | { |