Fixing bug #1161: No space between jobtitle and organization

2 files changed, 8 insertions, 16 deletions

diff --git a/libopie/pim/ocontact.cpp b/libopie/pim/ocontact.cpp
index 0f05b65..fcf3b26 100644
--- a/libopie/pim/ocontact.cpp
+++ b/libopie/pim/ocontact.cpp
@@ -67,781 +67,777 @@ OContact::OContact( const QMap<int, QString> &fromMap ) :
     if ( !cats.isEmpty() )
 	setCategories( idsFromString( cats ) );
 
     QString uidStr = find( Qtopia::AddressUid );
 
     if ( uidStr.isEmpty() || (uidStr.toInt() == 0) ){
 	    qWarning( "Invalid UID found. Generate new one.." );
 	setUid( uidGen().generate() );
     }else
 	setUid( uidStr.toInt() );
 
 //     if ( !uidStr.isEmpty() )
 // 	setUid( uidStr.toInt() );
 }
 
 /*!
   Destroys a contact.
 */
 OContact::~OContact()
 {
 }
 
 /*! \fn void OContact::setTitle( const QString &str )
   Sets the title of the contact to \a str.
 */
 
 /*! \fn void OContact::setFirstName( const QString &str )
   Sets the first name of the contact to \a str.
 */
 
 /*! \fn void OContact::setMiddleName( const QString &str )
   Sets the middle name of the contact to \a str.
 */
 
 /*! \fn void OContact::setLastName( const QString &str )
   Sets the last name of the contact to \a str.
 */
 
 /*! \fn void OContact::setSuffix( const QString &str )
   Sets the suffix of the contact to \a str.
 */
 
 /*! \fn void OContact::setFileAs( const QString &str )
   Sets the contact to filed as \a str.
 */
 
 /*! \fn void OContact::setDefaultEmail( const QString &str )
   Sets the default email of the contact to \a str.
 */
 
 /*! \fn void OContact::setHomeStreet( const QString &str )
   Sets the home street address of the contact to \a str.
 */
 
 /*! \fn void OContact::setHomeCity( const QString &str )
   Sets the home city of the contact to \a str.
 */
 
 /*! \fn void OContact::setHomeState( const QString &str )
   Sets the home state of the contact to \a str.
 */
 
 /*! \fn void OContact::setHomeZip( const QString &str )
   Sets the home zip code of the contact to \a str.
 */
 
 /*! \fn void OContact::setHomeCountry( const QString &str )
   Sets the home country of the contact to \a str.
 */
 
 /*! \fn void OContact::setHomePhone( const QString &str )
   Sets the home phone number of the contact to \a str.
 */
 
 /*! \fn void OContact::setHomeFax( const QString &str )
   Sets the home fax number of the contact to \a str.
 */
 
 /*! \fn void OContact::setHomeMobile( const QString &str )
   Sets the home mobile phone number of the contact to \a str.
 */
 
 /*! \fn void OContact::setHomeWebpage( const QString &str )
   Sets the home webpage of the contact to \a str.
 */
 
 /*! \fn void OContact::setCompany( const QString &str )
   Sets the company for contact to \a str.
 */
 
 /*! \fn void OContact::setJobTitle( const QString &str )
   Sets the job title of the contact to \a str.
 */
 
 /*! \fn void OContact::setDepartment( const QString &str )
   Sets the department for contact to \a str.
 */
 
 /*! \fn void OContact::setOffice( const QString &str )
   Sets the office for contact to \a str.
 */
 
 /*! \fn void OContact::setBusinessStreet( const QString &str )
   Sets the business street address of the contact to \a str.
 */
 
 /*! \fn void OContact::setBusinessCity( const QString &str )
   Sets the business city of the contact to \a str.
 */
 
 /*! \fn void OContact::setBusinessState( const QString &str )
   Sets the business state of the contact to \a str.
 */
 
 /*! \fn void OContact::setBusinessZip( const QString &str )
   Sets the business zip code of the contact to \a str.
 */
 
 /*! \fn void OContact::setBusinessCountry( const QString &str )
   Sets the business country of the contact to \a str.
 */
 
 /*! \fn void OContact::setBusinessPhone( const QString &str )
   Sets the business phone number of the contact to \a str.
 */
 
 /*! \fn void OContact::setBusinessFax( const QString &str )
   Sets the business fax number of the contact to \a str.
 */
 
 /*! \fn void OContact::setBusinessMobile( const QString &str )
   Sets the business mobile phone number of the contact to \a str.
 */
 
 /*! \fn void OContact::setBusinessPager( const QString &str )
   Sets the business pager number of the contact to \a str.
 */
 
 /*! \fn void OContact::setBusinessWebpage( const QString &str )
   Sets the business webpage of the contact to \a str.
 */
 
 /*! \fn void OContact::setProfession( const QString &str )
   Sets the profession of the contact to \a str.
 */
 
 /*! \fn void OContact::setAssistant( const QString &str )
   Sets the assistant of the contact to \a str.
 */
 
 /*! \fn void OContact::setManager( const QString &str )
   Sets the manager of the contact to \a str.
 */
 
 /*! \fn void OContact::setSpouse( const QString &str )
   Sets the spouse of the contact to \a str.
 */
 
 /*! \fn void OContact::setGender( const QString &str )
   Sets the gender of the contact to \a str.
 */
 
 /*! \fn void OContact::setNickname( const QString &str )
   Sets the nickname of the contact to \a str.
 */
 
 /*! \fn void OContact::setNotes( const QString &str )
   Sets the notes about the contact to \a str.
 */
 
 /*! \fn QString OContact::title() const
   Returns the title of the contact.
 */
 
 /*! \fn QString OContact::firstName() const
   Returns the first name of the contact.
 */
 
 /*! \fn QString OContact::middleName() const
   Returns the middle name of the contact.
 */
 
 /*! \fn QString OContact::lastName() const
   Returns the last name of the contact.
 */
 
 /*! \fn QString OContact::suffix() const
   Returns the suffix of the contact.
 */
 
 /*! \fn QString OContact::fileAs() const
   Returns the string the contact is filed as.
 */
 
 /*! \fn QString OContact::defaultEmail() const
   Returns the default email address of the contact.
 */
 
 /*! \fn QString OContact::emails() const
   Returns the list of email address for a contact separated by ';'s in a single
   string.
 */
 
 /*! \fn QString OContact::homeStreet() const
   Returns the home street address of the contact.
 */
 
 /*! \fn QString OContact::homeCity() const
   Returns the home city of the contact.
 */
 
 /*! \fn QString OContact::homeState() const
   Returns the home state of the contact.
 */
 
 /*! \fn QString OContact::homeZip() const
   Returns the home zip of the contact.
 */
 
 /*! \fn QString OContact::homeCountry() const
   Returns the home country of the contact.
 */
 
 /*! \fn QString OContact::homePhone() const
   Returns the home phone number of the contact.
 */
 
 /*! \fn QString OContact::homeFax() const
   Returns the home fax number of the contact.
 */
 
 /*! \fn QString OContact::homeMobile() const
   Returns the home mobile number of the contact.
 */
 
 /*! \fn QString OContact::homeWebpage() const
   Returns the home webpage of the contact.
 */
 
 /*! \fn QString OContact::company() const
   Returns the company for the contact.
 */
 
 /*! \fn QString OContact::department() const
   Returns the department for the contact.
 */
 
 /*! \fn QString OContact::office() const
   Returns the office for the contact.
 */
 
 /*! \fn QString OContact::jobTitle() const
   Returns the job title of the contact.
 */
 
 /*! \fn QString OContact::profession() const
   Returns the profession of the contact.
 */
 
 /*! \fn QString OContact::assistant() const
   Returns the assistant of the contact.
 */
 
 /*! \fn QString OContact::manager() const
   Returns the manager of the contact.
 */
 
 /*! \fn QString OContact::businessStreet() const
   Returns the business street address of the contact.
 */
 
 /*! \fn QString OContact::businessCity() const
   Returns the business city of the contact.
 */
 
 /*! \fn QString OContact::businessState() const
   Returns the business state of the contact.
 */
 
 /*! \fn QString OContact::businessZip() const
   Returns the business zip of the contact.
 */
 
 /*! \fn QString OContact::businessCountry() const
   Returns the business country of the contact.
 */
 
 /*! \fn QString OContact::businessPhone() const
   Returns the business phone number of the contact.
 */
 
 /*! \fn QString OContact::businessFax() const
   Returns the business fax number of the contact.
 */
 
 /*! \fn QString OContact::businessMobile() const
   Returns the business mobile number of the contact.
 */
 
 /*! \fn QString OContact::businessPager() const
   Returns the business pager number of the contact.
 */
 
 /*! \fn QString OContact::businessWebpage() const
   Returns the business webpage of the contact.
 */
 
 /*! \fn QString OContact::spouse() const
   Returns the spouse of the contact.
 */
 
 /*! \fn QString OContact::gender() const
   Returns the gender of the contact.
 */
 
 /*! \fn QString OContact::nickname() const
   Returns the nickname of the contact.
 */
 
 /*! \fn QString OContact::children() const
   Returns the children of the contact.
 */
 
 /*! \fn QString OContact::notes() const
   Returns the notes relating to the the contact.
 */
 
 /*! \fn QString OContact::groups() const
   \internal
   Returns the groups for the contact.
 */
 
 /*! \fn QStringList OContact::groupList() const
   \internal
 */
 
 /*! \fn QString OContact::field(int) const
   \internal
 */
 
 /*! \fn void OContact::saveJournal( journal_action, const QString & = QString::null )
   \internal
 */
 
 /*! \fn void OContact::setUid( int id )
   \internal
   Sets the uid for this record to \a id.
 */
 
 /*! \enum OContact::journal_action
   \internal
 */
 
 /*!
   \internal
 */
 QMap<int, QString> OContact::toMap() const
 {
     QMap<int, QString> map = mMap;
     QString cats = idsToString( categories() );
     if ( !cats.isEmpty() )
 	map.insert( Qtopia::AddressCategory, cats );
     return map;
 }
 
 /*!
   Returns a rich text formatted QString representing the contents the contact.
 */
 QString OContact::toRichText() const
 {
     QString text;
     QString value, comp, state;
     QString str;
     bool marker = false;
 
     Config cfg("qpe");
     cfg.setGroup("Appearance");
     int addressformat = cfg.readNumEntry( "AddressFormat", Zip_City_State );
 
     // name, jobtitle and company
     if ( !(value = fullName()).isEmpty() )
 	text += "<b><h3><img src=\"addressbook/AddressBook\"> " + Qtopia::escapeString(value) + "</h3></b>";
     
     if ( !(value = jobTitle()).isEmpty() )
-	text += Qtopia::escapeString(value);
+	text += Qtopia::escapeString(value) + " ";
 
     comp = company();
     if ( !(value = department()).isEmpty() ) {
 	text += Qtopia::escapeString(value);
 	if ( comp )
-	    text += ", ";
-	else
-	    text += "<br>";
-    }
-    if ( !comp.isEmpty() )
-	text += Qtopia::escapeString(comp);
-
+		text += ", " + Qtopia::escapeString(comp);
+    }else if ( comp )
+	    text += "<br>" + Qtopia::escapeString(comp);
     text += "<br><hr>";
 
     // defailt email
     QString defEmail = defaultEmail();
     if ( !defEmail.isEmpty() ){
 	text += "<b><img src=\"addressbook/email\"> " + QObject::tr("Default Email: ") + "</b>"
 		+ Qtopia::escapeString(defEmail);
 	marker = true;
     }
 
     // business address
     if ( !businessStreet().isEmpty() || !businessCity().isEmpty() ||
 	 !businessZip().isEmpty() || !businessCountry().isEmpty() ) {
 	text += QObject::tr( "<br><b>Work Address:</b>" );
 	marker = true;
     }
 
     if ( !(value = businessStreet()).isEmpty() ){
 	    text += "<br>" + Qtopia::escapeString(value);
 	    marker = true;
     }
 
     switch( addressformat ){
     case Zip_City_State:{ //  Zip_Code City, State
 	    state =  businessState();
 	    if ( !(value = businessZip()).isEmpty() ){
 		    text += "<br>" + Qtopia::escapeString(value) + " ";
 		    marker = true;
 		    
 	    }
 	    if ( !(value = businessCity()).isEmpty() ) {
 		    marker = true;
 		    if ( businessZip().isEmpty() && !businessStreet().isEmpty() )
 			    text += "<br>";
 		    text += Qtopia::escapeString(value);
 		    if ( state )
 			    text += ", " + Qtopia::escapeString(state);
 	    } else if ( !state.isEmpty() ){
 		    text += "<br>" + Qtopia::escapeString(state);
 		    marker = true;
 	    }
 	    break;
     }
     case City_State_Zip:{ // City, State Zip_Code 
 	    state =  businessState();
 	    if ( !(value = businessCity()).isEmpty() ) {
 		    marker = true;
 		    text += "<br>" + Qtopia::escapeString(value);
 		    if ( state )
 			    text += ", " + Qtopia::escapeString(state);
 	    } else if ( !state.isEmpty() ){
 		    text += "<br>" + Qtopia::escapeString(state);
 		    marker = true;
 	    }
 	    if ( !(value = businessZip()).isEmpty() ){
 		    text += " " + Qtopia::escapeString(value);
 		    marker = true;
 	    }
 	    break;
     }
     }
 
     if ( !(value = businessCountry()).isEmpty() ){
 	text += "<br>" + Qtopia::escapeString(value);
 	marker = true;
     }
 
     // rest of Business data
     str = office();
     if ( !str.isEmpty() ){
 	text += "<br><b>" + QObject::tr("Office: ") + "</b>"
 		+ Qtopia::escapeString(str);
 	marker = true;
     }
     str = businessWebpage();
     if ( !str.isEmpty() ){
 	text += "<br><b><img src=\"addressbook/webpagework\"> " + QObject::tr("Business Web Page: ") + "</b>"
 		+ Qtopia::escapeString(str);
 	marker = true;
     }
     str = businessPhone();
     if ( !str.isEmpty() ){
 	text += "<br><b><img src=\"addressbook/phonework\"> " + QObject::tr("Business Phone: ") + "</b>"
 		+ Qtopia::escapeString(str);
 	marker = true;
     }
     str = businessFax();
     if ( !str.isEmpty() ){
 	text += "<br><b><img src=\"addressbook/faxwork\"> " + QObject::tr("Business Fax: ") + "</b>"
 		+ Qtopia::escapeString(str);
 	marker = true;
     }
     str = businessMobile();
     if ( !str.isEmpty() ){
 	text += "<br><b><img src=\"addressbook/mobilework\"> " + QObject::tr("Business Mobile: ") + "</b>"
 		+ Qtopia::escapeString(str);
 	marker = true;
     }
     str = businessPager();
     if ( !str.isEmpty() ){
 	text += "<br><b>" + QObject::tr("Business Pager: ") + "</b>"
 		+ Qtopia::escapeString(str);
 	marker = true;
     }
 
     // text += "<br>";
 
     // home address
     if ( !homeStreet().isEmpty() || !homeCity().isEmpty() ||
 	 !homeZip().isEmpty() || !homeCountry().isEmpty() ) {
 	text += QObject::tr( "<br><b>Home Address:</b>" );
 	marker = true;
     }
 
     if ( !(value = homeStreet()).isEmpty() ){
 	text += "<br>" + Qtopia::escapeString(value);
 	marker = true;
     }
 
     switch( addressformat ){
     case Zip_City_State:{ //  Zip_Code City, State
 	    state =  homeState();
 	    if ( !(value = homeZip()).isEmpty() ){
 		    text += "<br>" + Qtopia::escapeString(value) + " ";
 		    marker = true;
 	    }
 	    if ( !(value = homeCity()).isEmpty() ) {
 		    marker = true;
 		    if ( homeZip().isEmpty() && !homeStreet().isEmpty() )
 			    text += "<br>";
 		    text += Qtopia::escapeString(value);
 		    if ( !state.isEmpty() )
 			    text += ", " + Qtopia::escapeString(state);
 	    } else if (!state.isEmpty()) {
 		    text += "<br>" + Qtopia::escapeString(state);
 		    marker = true;
 	    }
 	    break;
     }
     case City_State_Zip:{ // City, State Zip_Code 
 	    state =  homeState();
 	    if ( !(value = homeCity()).isEmpty() ) {
 		    marker = true;
 		    text += "<br>" + Qtopia::escapeString(value);
 		    if ( state )
 			    text += ", " + Qtopia::escapeString(state);
 	    } else if ( !state.isEmpty() ){
 		    text += "<br>" + Qtopia::escapeString(state);
 		    marker = true;
 	    }
 	    if ( !(value = homeZip()).isEmpty() ){
 		    text += " " + Qtopia::escapeString(value);
 		    marker = true;
 	    }
 	    break;
     }
     }
 	    
     if ( !(value = homeCountry()).isEmpty() ){
 	text += "<br>" + Qtopia::escapeString(value);
 	marker = true;
     }
 
     // rest of Home data
     str = homeWebpage();
     if ( !str.isEmpty() ){
 	text += "<br><b><img src=\"addressbook/webpagehome\"> " + QObject::tr("Home Web Page: ") + "</b>"
 		+ Qtopia::escapeString(str);
 	marker = true;
     }
     str = homePhone();
     if ( !str.isEmpty() ){
 	text += "<br><b><img src=\"addressbook/phonehome\"> " + QObject::tr("Home Phone: ") + "</b>"
 		+ Qtopia::escapeString(str);
 	marker = true;
     }
     str = homeFax();
     if ( !str.isEmpty() ){
 	text += "<br><b><img src=\"addressbook/faxhome\"> " + QObject::tr("Home Fax: ") + "</b>"
 		+ Qtopia::escapeString(str);
 	marker = true;
     }
     str = homeMobile();
     if ( !str.isEmpty() ){
 	text += "<br><b><img src=\"addressbook/mobilehome\"> " + QObject::tr("Home Mobile: ") + "</b>"
 		+ Qtopia::escapeString(str);
 	marker = true;
     }
 
     if ( marker )
 	    text += "<br><hr>";
 
     // the rest...
     str = emails();
     if ( !str.isEmpty() && ( str != defEmail ) )
 	text += "<br><b>" + QObject::tr("All Emails: ") + "</b>"
 		+ Qtopia::escapeString(str);
     str = profession();
     if ( !str.isEmpty() )
 	text += "<br><b>" + QObject::tr("Profession: ") + "</b>"
 		+ Qtopia::escapeString(str);
     str = assistant();
     if ( !str.isEmpty() )
 	text += "<br><b>" + QObject::tr("Assistant: ") + "</b>"
 		+ Qtopia::escapeString(str);
     str = manager();
     if ( !str.isEmpty() )
 	text += "<br><b>" + QObject::tr("Manager: ") + "</b>"
 		+ Qtopia::escapeString(str);
     str = gender();
     if ( !str.isEmpty() && str.toInt() != 0 ) {
 	    text += "<br>";
 	    if ( str.toInt() == 1 )
 		    str = QObject::tr( "Male" );
 	    else if ( str.toInt() == 2 )
 		    str = QObject::tr( "Female" );
 	    text += "<b>" + QObject::tr("Gender: ") + "</b>" + str;
     }
     str = spouse();
     if ( !str.isEmpty() )
 	text += "<br><b>" + QObject::tr("Spouse: ") + "</b>"
 		+ Qtopia::escapeString(str);
     if ( birthday().isValid() ){
 	    str = TimeString::numberDateString( birthday() );
 	    text += "<br><b>" + QObject::tr("Birthday: ") + "</b>"
 		    + Qtopia::escapeString(str);
     }
     if ( anniversary().isValid() ){
 	    str = TimeString::numberDateString( anniversary() );
 	    text += "<br><b>" + QObject::tr("Anniversary: ") + "</b>"
 		    + Qtopia::escapeString(str);
     }
     str = children();
     if ( !str.isEmpty() )
 	text += "<br><b>" + QObject::tr("Children: ") + "</b>"
 		+ Qtopia::escapeString(str);
 
     str = nickname();
     if ( !str.isEmpty() )
 	text += "<br><b>" + QObject::tr("Nickname: ") + "</b>"
 		+ Qtopia::escapeString(str);
 
     // categories
     if ( categoryNames("Contacts").count() ){
 	    text += "<br><b>" + QObject::tr( "Category:") + "</b> ";
 	    text += categoryNames("Contacts").join(", ");
     }
 
     // notes last
     if ( !(value = notes()).isEmpty() ) {
 	    text += "<br><hr><b>" + QObject::tr( "Notes:") + "</b> ";
 	    QRegExp reg("\n");
 
 	    //QString tmp = Qtopia::escapeString(value);
 	    QString tmp = QStyleSheet::convertFromPlainText(value);
 	    //tmp.replace( reg, "<br>" );
 	    text += "<br>" + tmp + "<br>";
     }
     return text;
 }
 
 /*!
   \internal
 */
 void OContact::insert( int key, const QString &v )
 {
     QString value = v.stripWhiteSpace();
     if ( value.isEmpty() )
 	mMap.remove( key );
     else
 	mMap.insert( key, value );
 }
 
 /*!
   \internal
 */
 void OContact::replace( int key, const QString & v )
 {
     QString value = v.stripWhiteSpace();
     if ( value.isEmpty() )
 	mMap.remove( key );
     else
 	mMap.replace( key, value );
 }
 
 /*!
   \internal
 */
 QString OContact::find( int key ) const
 {
     return mMap[key];
 }
 
 /*!
   \internal
 */
 QString OContact::displayAddress( const QString &street,
 				 const QString &city,
 				 const QString &state,
 				 const QString &zip,
 				 const QString &country ) const
 {
     QString s = street;
     if ( !street.isEmpty() )
 	s+= "\n";
     s += city;
     if ( !city.isEmpty() && !state.isEmpty() )
 	s += ", ";
     s += state;
     if ( !state.isEmpty() && !zip.isEmpty() )
 	s += "  ";
     s += zip;
     if ( !country.isEmpty() && !s.isEmpty() )
 	s += "\n";
     s += country;
     return s;
 }
 
 /*!
   \internal
 */
 QString OContact::displayBusinessAddress() const
 {
     return displayAddress( businessStreet(), businessCity(),
 			   businessState(), businessZip(),
 			   businessCountry() );
 }
 
 /*!
   \internal
 */
 QString OContact::displayHomeAddress() const
 {
     return displayAddress( homeStreet(), homeCity(),
 			   homeState(), homeZip(),
 			   homeCountry() );
 }
 
 /*!
   Returns the full name of the contact
 */
 QString OContact::fullName() const
 {
     QString title = find( Qtopia::Title );
     QString firstName = find( Qtopia::FirstName );
     QString middleName = find( Qtopia::MiddleName );
     QString lastName = find( Qtopia::LastName );
     QString suffix = find( Qtopia::Suffix );
 
     QString name = title;
     if ( !firstName.isEmpty() ) {
 	if ( !name.isEmpty() )
 	    name += " ";
 	name += firstName;
     }
     if ( !middleName.isEmpty() ) {
 	if ( !name.isEmpty() )
 	    name += " ";
 	name += middleName;
     }
     if ( !lastName.isEmpty() ) {
 	if ( !name.isEmpty() )
 	    name += " ";
 	name += lastName;
     }
     if ( !suffix.isEmpty() ) {
 	if ( !name.isEmpty() )
 	    name += " ";
 	name += suffix;
     }
     return name.simplifyWhiteSpace();
 }
 
 /*!
   Returns a list of the names of the children of the contact.
 */
 QStringList OContact::childrenList() const
 {
     return QStringList::split( " ", find( Qtopia::Children ) );
 }
 
 /*! \fn void OContact::insertEmail( const QString &email )
 
   Insert \a email into the email list. Ensures \a email can only be added
diff --git a/libopie2/opiepim/ocontact.cpp b/libopie2/opiepim/ocontact.cpp
index 0f05b65..fcf3b26 100644
--- a/libopie2/opiepim/ocontact.cpp
+++ b/libopie2/opiepim/ocontact.cpp
@@ -67,781 +67,777 @@ OContact::OContact( const QMap<int, QString> &fromMap ) :
     if ( !cats.isEmpty() )
 	setCategories( idsFromString( cats ) );
 
     QString uidStr = find( Qtopia::AddressUid );
 
     if ( uidStr.isEmpty() || (uidStr.toInt() == 0) ){
 	    qWarning( "Invalid UID found. Generate new one.." );
 	setUid( uidGen().generate() );
     }else
 	setUid( uidStr.toInt() );
 
 //     if ( !uidStr.isEmpty() )
 // 	setUid( uidStr.toInt() );
 }
 
 /*!
   Destroys a contact.
 */
 OContact::~OContact()
 {
 }
 
 /*! \fn void OContact::setTitle( const QString &str )
   Sets the title of the contact to \a str.
 */
 
 /*! \fn void OContact::setFirstName( const QString &str )
   Sets the first name of the contact to \a str.
 */
 
 /*! \fn void OContact::setMiddleName( const QString &str )
   Sets the middle name of the contact to \a str.
 */
 
 /*! \fn void OContact::setLastName( const QString &str )
   Sets the last name of the contact to \a str.
 */
 
 /*! \fn void OContact::setSuffix( const QString &str )
   Sets the suffix of the contact to \a str.
 */
 
 /*! \fn void OContact::setFileAs( const QString &str )
   Sets the contact to filed as \a str.
 */
 
 /*! \fn void OContact::setDefaultEmail( const QString &str )
   Sets the default email of the contact to \a str.
 */
 
 /*! \fn void OContact::setHomeStreet( const QString &str )
   Sets the home street address of the contact to \a str.
 */
 
 /*! \fn void OContact::setHomeCity( const QString &str )
   Sets the home city of the contact to \a str.
 */
 
 /*! \fn void OContact::setHomeState( const QString &str )
   Sets the home state of the contact to \a str.
 */
 
 /*! \fn void OContact::setHomeZip( const QString &str )
   Sets the home zip code of the contact to \a str.
 */
 
 /*! \fn void OContact::setHomeCountry( const QString &str )
   Sets the home country of the contact to \a str.
 */
 
 /*! \fn void OContact::setHomePhone( const QString &str )
   Sets the home phone number of the contact to \a str.
 */
 
 /*! \fn void OContact::setHomeFax( const QString &str )
   Sets the home fax number of the contact to \a str.
 */
 
 /*! \fn void OContact::setHomeMobile( const QString &str )
   Sets the home mobile phone number of the contact to \a str.
 */
 
 /*! \fn void OContact::setHomeWebpage( const QString &str )
   Sets the home webpage of the contact to \a str.
 */
 
 /*! \fn void OContact::setCompany( const QString &str )
   Sets the company for contact to \a str.
 */
 
 /*! \fn void OContact::setJobTitle( const QString &str )
   Sets the job title of the contact to \a str.
 */
 
 /*! \fn void OContact::setDepartment( const QString &str )
   Sets the department for contact to \a str.
 */
 
 /*! \fn void OContact::setOffice( const QString &str )
   Sets the office for contact to \a str.
 */
 
 /*! \fn void OContact::setBusinessStreet( const QString &str )
   Sets the business street address of the contact to \a str.
 */
 
 /*! \fn void OContact::setBusinessCity( const QString &str )
   Sets the business city of the contact to \a str.
 */
 
 /*! \fn void OContact::setBusinessState( const QString &str )
   Sets the business state of the contact to \a str.
 */
 
 /*! \fn void OContact::setBusinessZip( const QString &str )
   Sets the business zip code of the contact to \a str.
 */
 
 /*! \fn void OContact::setBusinessCountry( const QString &str )
   Sets the business country of the contact to \a str.
 */
 
 /*! \fn void OContact::setBusinessPhone( const QString &str )
   Sets the business phone number of the contact to \a str.
 */
 
 /*! \fn void OContact::setBusinessFax( const QString &str )
   Sets the business fax number of the contact to \a str.
 */
 
 /*! \fn void OContact::setBusinessMobile( const QString &str )
   Sets the business mobile phone number of the contact to \a str.
 */
 
 /*! \fn void OContact::setBusinessPager( const QString &str )
   Sets the business pager number of the contact to \a str.
 */
 
 /*! \fn void OContact::setBusinessWebpage( const QString &str )
   Sets the business webpage of the contact to \a str.
 */
 
 /*! \fn void OContact::setProfession( const QString &str )
   Sets the profession of the contact to \a str.
 */
 
 /*! \fn void OContact::setAssistant( const QString &str )
   Sets the assistant of the contact to \a str.
 */
 
 /*! \fn void OContact::setManager( const QString &str )
   Sets the manager of the contact to \a str.
 */
 
 /*! \fn void OContact::setSpouse( const QString &str )
   Sets the spouse of the contact to \a str.
 */
 
 /*! \fn void OContact::setGender( const QString &str )
   Sets the gender of the contact to \a str.
 */
 
 /*! \fn void OContact::setNickname( const QString &str )
   Sets the nickname of the contact to \a str.
 */
 
 /*! \fn void OContact::setNotes( const QString &str )
   Sets the notes about the contact to \a str.
 */
 
 /*! \fn QString OContact::title() const
   Returns the title of the contact.
 */
 
 /*! \fn QString OContact::firstName() const
   Returns the first name of the contact.
 */
 
 /*! \fn QString OContact::middleName() const
   Returns the middle name of the contact.
 */
 
 /*! \fn QString OContact::lastName() const
   Returns the last name of the contact.
 */
 
 /*! \fn QString OContact::suffix() const
   Returns the suffix of the contact.
 */
 
 /*! \fn QString OContact::fileAs() const
   Returns the string the contact is filed as.
 */
 
 /*! \fn QString OContact::defaultEmail() const
   Returns the default email address of the contact.
 */
 
 /*! \fn QString OContact::emails() const
   Returns the list of email address for a contact separated by ';'s in a single
   string.
 */
 
 /*! \fn QString OContact::homeStreet() const
   Returns the home street address of the contact.
 */
 
 /*! \fn QString OContact::homeCity() const
   Returns the home city of the contact.
 */
 
 /*! \fn QString OContact::homeState() const
   Returns the home state of the contact.
 */
 
 /*! \fn QString OContact::homeZip() const
   Returns the home zip of the contact.
 */
 
 /*! \fn QString OContact::homeCountry() const
   Returns the home country of the contact.
 */
 
 /*! \fn QString OContact::homePhone() const
   Returns the home phone number of the contact.
 */
 
 /*! \fn QString OContact::homeFax() const
   Returns the home fax number of the contact.
 */
 
 /*! \fn QString OContact::homeMobile() const
   Returns the home mobile number of the contact.
 */
 
 /*! \fn QString OContact::homeWebpage() const
   Returns the home webpage of the contact.
 */
 
 /*! \fn QString OContact::company() const
   Returns the company for the contact.
 */
 
 /*! \fn QString OContact::department() const
   Returns the department for the contact.
 */
 
 /*! \fn QString OContact::office() const
   Returns the office for the contact.
 */
 
 /*! \fn QString OContact::jobTitle() const
   Returns the job title of the contact.
 */
 
 /*! \fn QString OContact::profession() const
   Returns the profession of the contact.
 */
 
 /*! \fn QString OContact::assistant() const
   Returns the assistant of the contact.
 */
 
 /*! \fn QString OContact::manager() const
   Returns the manager of the contact.
 */
 
 /*! \fn QString OContact::businessStreet() const
   Returns the business street address of the contact.
 */
 
 /*! \fn QString OContact::businessCity() const
   Returns the business city of the contact.
 */
 
 /*! \fn QString OContact::businessState() const
   Returns the business state of the contact.
 */
 
 /*! \fn QString OContact::businessZip() const
   Returns the business zip of the contact.
 */
 
 /*! \fn QString OContact::businessCountry() const
   Returns the business country of the contact.
 */
 
 /*! \fn QString OContact::businessPhone() const
   Returns the business phone number of the contact.
 */
 
 /*! \fn QString OContact::businessFax() const
   Returns the business fax number of the contact.
 */
 
 /*! \fn QString OContact::businessMobile() const
   Returns the business mobile number of the contact.
 */
 
 /*! \fn QString OContact::businessPager() const
   Returns the business pager number of the contact.
 */
 
 /*! \fn QString OContact::businessWebpage() const
   Returns the business webpage of the contact.
 */
 
 /*! \fn QString OContact::spouse() const
   Returns the spouse of the contact.
 */
 
 /*! \fn QString OContact::gender() const
   Returns the gender of the contact.
 */
 
 /*! \fn QString OContact::nickname() const
   Returns the nickname of the contact.
 */
 
 /*! \fn QString OContact::children() const
   Returns the children of the contact.
 */
 
 /*! \fn QString OContact::notes() const
   Returns the notes relating to the the contact.
 */
 
 /*! \fn QString OContact::groups() const
   \internal
   Returns the groups for the contact.
 */
 
 /*! \fn QStringList OContact::groupList() const
   \internal
 */
 
 /*! \fn QString OContact::field(int) const
   \internal
 */
 
 /*! \fn void OContact::saveJournal( journal_action, const QString & = QString::null )
   \internal
 */
 
 /*! \fn void OContact::setUid( int id )
   \internal
   Sets the uid for this record to \a id.
 */
 
 /*! \enum OContact::journal_action
   \internal
 */
 
 /*!
   \internal
 */
 QMap<int, QString> OContact::toMap() const
 {
     QMap<int, QString> map = mMap;
     QString cats = idsToString( categories() );
     if ( !cats.isEmpty() )
 	map.insert( Qtopia::AddressCategory, cats );
     return map;
 }
 
 /*!
   Returns a rich text formatted QString representing the contents the contact.
 */
 QString OContact::toRichText() const
 {
     QString text;
     QString value, comp, state;
     QString str;
     bool marker = false;
 
     Config cfg("qpe");
     cfg.setGroup("Appearance");
     int addressformat = cfg.readNumEntry( "AddressFormat", Zip_City_State );
 
     // name, jobtitle and company
     if ( !(value = fullName()).isEmpty() )
 	text += "<b><h3><img src=\"addressbook/AddressBook\"> " + Qtopia::escapeString(value) + "</h3></b>";
     
     if ( !(value = jobTitle()).isEmpty() )
-	text += Qtopia::escapeString(value);
+	text += Qtopia::escapeString(value) + " ";
 
     comp = company();
     if ( !(value = department()).isEmpty() ) {
 	text += Qtopia::escapeString(value);
 	if ( comp )
-	    text += ", ";
-	else
-	    text += "<br>";
-    }
-    if ( !comp.isEmpty() )
-	text += Qtopia::escapeString(comp);
-
+		text += ", " + Qtopia::escapeString(comp);
+    }else if ( comp )
+	    text += "<br>" + Qtopia::escapeString(comp);
     text += "<br><hr>";
 
     // defailt email
     QString defEmail = defaultEmail();
     if ( !defEmail.isEmpty() ){
 	text += "<b><img src=\"addressbook/email\"> " + QObject::tr("Default Email: ") + "</b>"
 		+ Qtopia::escapeString(defEmail);
 	marker = true;
     }
 
     // business address
     if ( !businessStreet().isEmpty() || !businessCity().isEmpty() ||
 	 !businessZip().isEmpty() || !businessCountry().isEmpty() ) {
 	text += QObject::tr( "<br><b>Work Address:</b>" );
 	marker = true;
     }
 
     if ( !(value = businessStreet()).isEmpty() ){
 	    text += "<br>" + Qtopia::escapeString(value);
 	    marker = true;
     }
 
     switch( addressformat ){
     case Zip_City_State:{ //  Zip_Code City, State
 	    state =  businessState();
 	    if ( !(value = businessZip()).isEmpty() ){
 		    text += "<br>" + Qtopia::escapeString(value) + " ";
 		    marker = true;
 		    
 	    }
 	    if ( !(value = businessCity()).isEmpty() ) {
 		    marker = true;
 		    if ( businessZip().isEmpty() && !businessStreet().isEmpty() )
 			    text += "<br>";
 		    text += Qtopia::escapeString(value);
 		    if ( state )
 			    text += ", " + Qtopia::escapeString(state);
 	    } else if ( !state.isEmpty() ){
 		    text += "<br>" + Qtopia::escapeString(state);
 		    marker = true;
 	    }
 	    break;
     }
     case City_State_Zip:{ // City, State Zip_Code 
 	    state =  businessState();
 	    if ( !(value = businessCity()).isEmpty() ) {
 		    marker = true;
 		    text += "<br>" + Qtopia::escapeString(value);
 		    if ( state )
 			    text += ", " + Qtopia::escapeString(state);
 	    } else if ( !state.isEmpty() ){
 		    text += "<br>" + Qtopia::escapeString(state);
 		    marker = true;
 	    }
 	    if ( !(value = businessZip()).isEmpty() ){
 		    text += " " + Qtopia::escapeString(value);
 		    marker = true;
 	    }
 	    break;
     }
     }
 
     if ( !(value = businessCountry()).isEmpty() ){
 	text += "<br>" + Qtopia::escapeString(value);
 	marker = true;
     }
 
     // rest of Business data
     str = office();
     if ( !str.isEmpty() ){
 	text += "<br><b>" + QObject::tr("Office: ") + "</b>"
 		+ Qtopia::escapeString(str);
 	marker = true;
     }
     str = businessWebpage();
     if ( !str.isEmpty() ){
 	text += "<br><b><img src=\"addressbook/webpagework\"> " + QObject::tr("Business Web Page: ") + "</b>"
 		+ Qtopia::escapeString(str);
 	marker = true;
     }
     str = businessPhone();
     if ( !str.isEmpty() ){
 	text += "<br><b><img src=\"addressbook/phonework\"> " + QObject::tr("Business Phone: ") + "</b>"
 		+ Qtopia::escapeString(str);
 	marker = true;
     }
     str = businessFax();
     if ( !str.isEmpty() ){
 	text += "<br><b><img src=\"addressbook/faxwork\"> " + QObject::tr("Business Fax: ") + "</b>"
 		+ Qtopia::escapeString(str);
 	marker = true;
     }
     str = businessMobile();
     if ( !str.isEmpty() ){
 	text += "<br><b><img src=\"addressbook/mobilework\"> " + QObject::tr("Business Mobile: ") + "</b>"
 		+ Qtopia::escapeString(str);
 	marker = true;
     }
     str = businessPager();
     if ( !str.isEmpty() ){
 	text += "<br><b>" + QObject::tr("Business Pager: ") + "</b>"
 		+ Qtopia::escapeString(str);
 	marker = true;
     }
 
     // text += "<br>";
 
     // home address
     if ( !homeStreet().isEmpty() || !homeCity().isEmpty() ||
 	 !homeZip().isEmpty() || !homeCountry().isEmpty() ) {
 	text += QObject::tr( "<br><b>Home Address:</b>" );
 	marker = true;
     }
 
     if ( !(value = homeStreet()).isEmpty() ){
 	text += "<br>" + Qtopia::escapeString(value);
 	marker = true;
     }
 
     switch( addressformat ){
     case Zip_City_State:{ //  Zip_Code City, State
 	    state =  homeState();
 	    if ( !(value = homeZip()).isEmpty() ){
 		    text += "<br>" + Qtopia::escapeString(value) + " ";
 		    marker = true;
 	    }
 	    if ( !(value = homeCity()).isEmpty() ) {
 		    marker = true;
 		    if ( homeZip().isEmpty() && !homeStreet().isEmpty() )
 			    text += "<br>";
 		    text += Qtopia::escapeString(value);
 		    if ( !state.isEmpty() )
 			    text += ", " + Qtopia::escapeString(state);
 	    } else if (!state.isEmpty()) {
 		    text += "<br>" + Qtopia::escapeString(state);
 		    marker = true;
 	    }
 	    break;
     }
     case City_State_Zip:{ // City, State Zip_Code 
 	    state =  homeState();
 	    if ( !(value = homeCity()).isEmpty() ) {
 		    marker = true;
 		    text += "<br>" + Qtopia::escapeString(value);
 		    if ( state )
 			    text += ", " + Qtopia::escapeString(state);
 	    } else if ( !state.isEmpty() ){
 		    text += "<br>" + Qtopia::escapeString(state);
 		    marker = true;
 	    }
 	    if ( !(value = homeZip()).isEmpty() ){
 		    text += " " + Qtopia::escapeString(value);
 		    marker = true;
 	    }
 	    break;
     }
     }
 	    
     if ( !(value = homeCountry()).isEmpty() ){
 	text += "<br>" + Qtopia::escapeString(value);
 	marker = true;
     }
 
     // rest of Home data
     str = homeWebpage();
     if ( !str.isEmpty() ){
 	text += "<br><b><img src=\"addressbook/webpagehome\"> " + QObject::tr("Home Web Page: ") + "</b>"
 		+ Qtopia::escapeString(str);
 	marker = true;
     }
     str = homePhone();
     if ( !str.isEmpty() ){
 	text += "<br><b><img src=\"addressbook/phonehome\"> " + QObject::tr("Home Phone: ") + "</b>"
 		+ Qtopia::escapeString(str);
 	marker = true;
     }
     str = homeFax();
     if ( !str.isEmpty() ){
 	text += "<br><b><img src=\"addressbook/faxhome\"> " + QObject::tr("Home Fax: ") + "</b>"
 		+ Qtopia::escapeString(str);
 	marker = true;
     }
     str = homeMobile();
     if ( !str.isEmpty() ){
 	text += "<br><b><img src=\"addressbook/mobilehome\"> " + QObject::tr("Home Mobile: ") + "</b>"
 		+ Qtopia::escapeString(str);
 	marker = true;
     }
 
     if ( marker )
 	    text += "<br><hr>";
 
     // the rest...
     str = emails();
     if ( !str.isEmpty() && ( str != defEmail ) )
 	text += "<br><b>" + QObject::tr("All Emails: ") + "</b>"
 		+ Qtopia::escapeString(str);
     str = profession();
     if ( !str.isEmpty() )
 	text += "<br><b>" + QObject::tr("Profession: ") + "</b>"
 		+ Qtopia::escapeString(str);
     str = assistant();
     if ( !str.isEmpty() )
 	text += "<br><b>" + QObject::tr("Assistant: ") + "</b>"
 		+ Qtopia::escapeString(str);
     str = manager();
     if ( !str.isEmpty() )
 	text += "<br><b>" + QObject::tr("Manager: ") + "</b>"
 		+ Qtopia::escapeString(str);
     str = gender();
     if ( !str.isEmpty() && str.toInt() != 0 ) {
 	    text += "<br>";
 	    if ( str.toInt() == 1 )
 		    str = QObject::tr( "Male" );
 	    else if ( str.toInt() == 2 )
 		    str = QObject::tr( "Female" );
 	    text += "<b>" + QObject::tr("Gender: ") + "</b>" + str;
     }
     str = spouse();
     if ( !str.isEmpty() )
 	text += "<br><b>" + QObject::tr("Spouse: ") + "</b>"
 		+ Qtopia::escapeString(str);
     if ( birthday().isValid() ){
 	    str = TimeString::numberDateString( birthday() );
 	    text += "<br><b>" + QObject::tr("Birthday: ") + "</b>"
 		    + Qtopia::escapeString(str);
     }
     if ( anniversary().isValid() ){
 	    str = TimeString::numberDateString( anniversary() );
 	    text += "<br><b>" + QObject::tr("Anniversary: ") + "</b>"
 		    + Qtopia::escapeString(str);
     }
     str = children();
     if ( !str.isEmpty() )
 	text += "<br><b>" + QObject::tr("Children: ") + "</b>"
 		+ Qtopia::escapeString(str);
 
     str = nickname();
     if ( !str.isEmpty() )
 	text += "<br><b>" + QObject::tr("Nickname: ") + "</b>"
 		+ Qtopia::escapeString(str);
 
     // categories
     if ( categoryNames("Contacts").count() ){
 	    text += "<br><b>" + QObject::tr( "Category:") + "</b> ";
 	    text += categoryNames("Contacts").join(", ");
     }
 
     // notes last
     if ( !(value = notes()).isEmpty() ) {
 	    text += "<br><hr><b>" + QObject::tr( "Notes:") + "</b> ";
 	    QRegExp reg("\n");
 
 	    //QString tmp = Qtopia::escapeString(value);
 	    QString tmp = QStyleSheet::convertFromPlainText(value);
 	    //tmp.replace( reg, "<br>" );
 	    text += "<br>" + tmp + "<br>";
     }
     return text;
 }
 
 /*!
   \internal
 */
 void OContact::insert( int key, const QString &v )
 {
     QString value = v.stripWhiteSpace();
     if ( value.isEmpty() )
 	mMap.remove( key );
     else
 	mMap.insert( key, value );
 }
 
 /*!
   \internal
 */
 void OContact::replace( int key, const QString & v )
 {
     QString value = v.stripWhiteSpace();
     if ( value.isEmpty() )
 	mMap.remove( key );
     else
 	mMap.replace( key, value );
 }
 
 /*!
   \internal
 */
 QString OContact::find( int key ) const
 {
     return mMap[key];
 }
 
 /*!
   \internal
 */
 QString OContact::displayAddress( const QString &street,
 				 const QString &city,
 				 const QString &state,
 				 const QString &zip,
 				 const QString &country ) const
 {
     QString s = street;
     if ( !street.isEmpty() )
 	s+= "\n";
     s += city;
     if ( !city.isEmpty() && !state.isEmpty() )
 	s += ", ";
     s += state;
     if ( !state.isEmpty() && !zip.isEmpty() )
 	s += "  ";
     s += zip;
     if ( !country.isEmpty() && !s.isEmpty() )
 	s += "\n";
     s += country;
     return s;
 }
 
 /*!
   \internal
 */
 QString OContact::displayBusinessAddress() const
 {
     return displayAddress( businessStreet(), businessCity(),
 			   businessState(), businessZip(),
 			   businessCountry() );
 }
 
 /*!
   \internal
 */
 QString OContact::displayHomeAddress() const
 {
     return displayAddress( homeStreet(), homeCity(),
 			   homeState(), homeZip(),
 			   homeCountry() );
 }
 
 /*!
   Returns the full name of the contact
 */
 QString OContact::fullName() const
 {
     QString title = find( Qtopia::Title );
     QString firstName = find( Qtopia::FirstName );
     QString middleName = find( Qtopia::MiddleName );
     QString lastName = find( Qtopia::LastName );
     QString suffix = find( Qtopia::Suffix );
 
     QString name = title;
     if ( !firstName.isEmpty() ) {
 	if ( !name.isEmpty() )
 	    name += " ";
 	name += firstName;
     }
     if ( !middleName.isEmpty() ) {
 	if ( !name.isEmpty() )
 	    name += " ";
 	name += middleName;
     }
     if ( !lastName.isEmpty() ) {
 	if ( !name.isEmpty() )
 	    name += " ";
 	name += lastName;
     }
     if ( !suffix.isEmpty() ) {
 	if ( !name.isEmpty() )
 	    name += " ";
 	name += suffix;
     }
     return name.simplifyWhiteSpace();
 }
 
 /*!
   Returns a list of the names of the children of the contact.
 */
 QStringList OContact::childrenList() const
 {
     return QStringList::split( " ", find( Qtopia::Children ) );
 }
 
 /*! \fn void OContact::insertEmail( const QString &email )
 
   Insert \a email into the email list. Ensures \a email can only be added