fixed bug #250

5 files changed, 36 insertions, 16 deletions

diff --git a/noncore/apps/opie-sheet/ChangeLog b/noncore/apps/opie-sheet/ChangeLog
index c12a6db..90060e2 100644
--- a/noncore/apps/opie-sheet/ChangeLog
+++ b/noncore/apps/opie-sheet/ChangeLog
@@ -1,7 +1,16 @@
+October 08, 2002
+
+	* Release 1.0.2 (by thufir)
+	- Fixed bug #250 (exhibiting re-calculation error in multi-level calculation). (by thufir)
+
+October 06, 2002
+
+	- Fixed data edit box clear problem. (by thufir)
+
 October 05, 2002
 
-	- Fixed bug #252. (by thufir)
+	- Fixed bug #252 (starting up in 'mouse button' mode). (by thufir)
 
 August 31, 2002
 
 	- Fixed and updated opie-sheet.pro file. (by cniehaus)
diff --git a/noncore/apps/opie-sheet/mainwindow.cpp b/noncore/apps/opie-sheet/mainwindow.cpp
index 2f07bae..b9f8e57 100644
--- a/noncore/apps/opie-sheet/mainwindow.cpp
+++ b/noncore/apps/opie-sheet/mainwindow.cpp
@@ -194,8 +194,9 @@ void MainWindow::selectorFileNew(const DocLnk &lnkDoc)
 
   if (documentModified && saveCurrentFile()==QMessageBox::Cancel) return;
   if (currentDoc) delete currentDoc;
   currentDoc = new DocLnk(lnkDoc);
+  editData->clear();
   listSheets.clear();
   comboSheets->clear();
 
   typeSheet *newSheet=createNewSheet();
@@ -532,9 +533,9 @@ void MainWindow::slotHelpAbout()
   QDialog dialogAbout(this, 0, TRUE);
   dialogAbout.resize(width()-40, height()-80);
   dialogAbout.setCaption(tr("About Opie Sheet"));
 
-  QLabel label(tr("Opie Sheet\nSpreadsheet Software for Opie\nQWDC Beta Winner (as Sheet/Qt)\n\nDeveloped by: Serdar Ozler\nRelease 1.0.1\nRelease Date: July 04, 2002\n\nThis product is licensed under GPL. It is freely distributable. If you want to get the latest version and also the source code, please visit the web site.\n\nhttp://qtopia.sitebest.com"), &dialogAbout);
+  QLabel label(tr("Opie Sheet\nSpreadsheet Software for Opie\nQWDC Beta Winner (as Sheet/Qt)\n\nDeveloped by: Serdar Ozler\nRelease 1.0.2\nRelease Date: October 08, 2002\n\nThis product is licensed under GPL. It is freely distributable. If you want to get the latest version and also the source code, please visit the web site.\n\nhttp://qtopia.sitebest.com"), &dialogAbout);
   label.setGeometry(dialogAbout.rect());
   label.setAlignment(Qt::AlignCenter | Qt::WordBreak);
 
   dialogAbout.exec();
diff --git a/noncore/apps/opie-sheet/opie-sheet.control b/noncore/apps/opie-sheet/opie-sheet.control
index 38f9083..cc322bb 100644
--- a/noncore/apps/opie-sheet/opie-sheet.control
+++ b/noncore/apps/opie-sheet/opie-sheet.control
@@ -2,9 +2,9 @@ Files: bin/sheetqt apps/Applications/opie-sheet.desktop help/sheetqt.html help/s
 Priority: optional
 Section: opie/applications
 Maintainer: Serdar Ozler <sozler@sitebest.com>
 Architecture: arm
-Version: 1.0.1
+Version: 1.0.2
 Depends: opie-base ($QPE_VERSION)
 License: Public Domain
 Description: Opie Sheet
  Spreadsheet software for Opie.
diff --git a/noncore/apps/opie-sheet/sheet.cpp b/noncore/apps/opie-sheet/sheet.cpp
index be4046b..c2563c2 100644
--- a/noncore/apps/opie-sheet/sheet.cpp
+++ b/noncore/apps/opie-sheet/sheet.cpp
@@ -87,9 +87,9 @@ void Sheet::slotCellChanged(int row, int col)
   typeCellData *cellData=findCellData(row, col);
   if (!cellData) cellData=createCellData(row, col);
   if (cellData) cellData->data=text(row, col);
   for (cellData=sheetData.first(); cellData; cellData=sheetData.next())
-    setText(cellData->row, cellData->col, dataParser(cellData->data));
+    setText(cellData->row, cellData->col, dataParser(findCellName(cellData->row, cellData->col), cellData->data));
   emit sheetModified();
 }
 
 void Sheet::swapCells(int row1, int col1, int row2, int col2)
@@ -101,10 +101,10 @@ void Sheet::swapCells(int row1, int col1, int row2, int col2)
   {
     QString tempData(cellData1->data);
     cellData1->data=cellData2->data;
     cellData2->data=tempData;
-    setText(cellData1->row, cellData1->col, dataParser(cellData1->data));
-    setText(cellData2->row, cellData2->col, dataParser(cellData2->data));
+    setText(cellData1->row, cellData1->col, dataParser(findCellName(cellData1->row, cellData1->col), cellData1->data));
+    setText(cellData2->row, cellData2->col, dataParser(findCellName(cellData2->row, cellData2->col), cellData2->data));
     emit sheetModified();
   }
 }
 
@@ -165,9 +165,9 @@ double Sheet::calculateVariable(const QString &variable)
   double tempResult=variable.toDouble(&ok);
   if (ok) return tempResult;
 
   int row, col;
-  return (findRowColumn(variable, &row, &col, TRUE) ? text(row, col).toDouble() : 0);
+  return (findRowColumn(variable, &row, &col, TRUE) ? dataParser(variable, text(row, col)).toDouble() : 0);
 }
 
 double Sheet::functionSum(const QString &param1, const QString &param2)
 {
@@ -419,13 +419,15 @@ QString Sheet::dataParserHelper(const QString &data)
     tempElement.prepend(popStringStack(&stackElements)+",");
   return tempElement;
 }
 
-QString Sheet::dataParser(const QString &data)
+QString Sheet::dataParser(const QString &cell, const QString &data)
 {
   QString strippedData(data);
   strippedData.replace(QRegExp("\\s"), "");
   if (strippedData.isEmpty() || strippedData[0]!='=') return data;
+  if (listDataParser.find(cell)!=listDataParser.end()) return "0";
+  listDataParser.append(cell);
   strippedData=dataParserHelper(strippedData.remove(0, 1).upper().replace(QRegExp(":"), ","));
 
   int i=0;
   QString tempParameter(getParameter(strippedData, i)), result="";
@@ -434,8 +436,9 @@ QString Sheet::dataParser(const QString &data)
     result+=","+QString::number(calculateVariable(tempParameter));
     tempParameter=getParameter(strippedData, ++i);
   }
   while (!tempParameter.isNull());
+  listDataParser.remove(cell);
   return result.mid(1);
 }
 
 void Sheet::setData(const QString &data)
@@ -538,16 +541,21 @@ void Sheet::viewportMouseReleaseEvent(QMouseEvent *e)
     oldSelection.expandTo(rowAt(ce.pos().y()), columnAt(ce.pos().x()));
     removeSelection(selectionNo);
     selectionNo=-1;
     if (oldSelection.topRow()==oldSelection.bottomRow() && oldSelection.leftCol()==oldSelection.rightCol())
-      emit cellClicked(getHeaderString(oldSelection.leftCol()+1)+QString::number(oldSelection.topRow()+1));
+      emit cellClicked(findCellName(oldSelection.topRow(), oldSelection.leftCol()));
     else
-      emit cellClicked(getHeaderString(oldSelection.leftCol()+1)+QString::number(oldSelection.topRow()+1)+','+getHeaderString(oldSelection.rightCol()+1)+QString::number(oldSelection.bottomRow()+1));
+      emit cellClicked(findCellName(oldSelection.topRow(), oldSelection.leftCol())+','+findCellName(oldSelection.bottomRow(), oldSelection.rightCol()));
   }
   else
     QTable::contentsMouseReleaseEvent(&ce);
 }
 
+QString Sheet::findCellName(int row, int col)
+{
+  return (getHeaderString(col+1)+QString::number(row+1));
+}
+
 void Sheet::copySheetData(QList<typeCellData> *destSheetData)
 {
   typeCellData *tempCellData, *newCellData;
   destSheetData->clear();
@@ -575,9 +583,9 @@ void Sheet::setSheetData(QList<typeCellData> *srcSheetData)
   {
     newCellData=new typeCellData;
     *newCellData=*tempCellData;
     sheetData.append(newCellData);
-    setText(newCellData->row, newCellData->col, dataParser(newCellData->data));
+    setText(newCellData->row, newCellData->col, dataParser(findCellName(newCellData->row, newCellData->col), newCellData->data));
   }
   emit sheetModified();
 }
 
@@ -755,9 +763,9 @@ void Sheet::editPaste(bool onlyContents)
         *cellData=*tempCellData;
         cellData->row+=row1;
         cellData->col+=col1;
       }
-      setText(cellData->row, cellData->col, dataParser(cellData->data));
+      setText(cellData->row, cellData->col, dataParser(findCellName(cellData->row, cellData->col), cellData->data));
       emit sheetModified();
     }
   }
 }
@@ -778,9 +786,9 @@ void Sheet::insertRows(int no, bool allColumns)
   for (tempCellData=sheetData.first(); tempCellData; tempCellData=sheetData.next())
     if (tempCellData->row>=row && (allColumns || tempCellData->col==col))
     {
       updateCell(tempCellData->row-no, tempCellData->col);
-      setText(tempCellData->row, tempCellData->col, dataParser(tempCellData->data));
+      setText(tempCellData->row, tempCellData->col, dataParser(findCellName(tempCellData->row, tempCellData->col), tempCellData->data));
     }
  emit sheetModified();
 }
 
@@ -804,9 +812,9 @@ void Sheet::insertColumns(int no, bool allRows)
   for (tempCellData=sheetData.first(); tempCellData; tempCellData=sheetData.next())
     if (tempCellData->col>=col && (allRows || tempCellData->row==row))
     {
       updateCell(tempCellData->row, tempCellData->col-no);
-      setText(tempCellData->row, tempCellData->col, dataParser(tempCellData->data));
+      setText(tempCellData->row, tempCellData->col, dataParser(findCellName(tempCellData->row, tempCellData->col), tempCellData->data));
     }
   emit sheetModified();
 }
 
@@ -831,9 +839,9 @@ void Sheet::dataFindReplace(const QString &findStr, const QString &replaceStr, b
         setCurrentCell(tempCellData->row, tempCellData->col);
         if (replace)
         {
           tempCellData->data=cellItem->text().replace(QRegExp(findStr, matchCase), replaceStr);
-          setText(tempCellData->row, tempCellData->col, dataParser(tempCellData->data));
+          setText(tempCellData->row, tempCellData->col, dataParser(findCellName(tempCellData->row, tempCellData->col), tempCellData->data));
         }
         if (!replace || !replaceAll) break;
       }
     }
diff --git a/noncore/apps/opie-sheet/sheet.h b/noncore/apps/opie-sheet/sheet.h
index f78a684..f4e9d38 100644
--- a/noncore/apps/opie-sheet/sheet.h
+++ b/noncore/apps/opie-sheet/sheet.h
@@ -46,19 +46,21 @@ class Sheet: public QTable
 
   // QT objects
   QList<typeCellData> sheetData, clipboardData;
   QString pressedCell, releasedCell, sheetName;
+  QStringList listDataParser;
 
   // Private functions
   int getOperatorPriority(char oper);
   bool findRowColumn(const QString &variable, int *row, int *col, bool giveError=FALSE);
+  QString findCellName(int row, int col);
   bool findRange(const QString &variable1, const QString &variable2, int *row1, int *col1, int *row2, int *col2);
   double calculateVariable(const QString &variable);
   double calculateFunction(const QString &function, const QString &parameters);
   QChar popCharStack(QStack<QChar> *stackChars);
   QString popStringStack(QStack<QString> *stackStrings);
   QString getParameter(const QString &parameters, int paramNo, bool giveError=FALSE, const QString funcName="");
-  QString dataParser(const QString &data);
+  QString dataParser(const QString &cell, const QString &data);
   QString dataParserHelper(const QString &data);
   typeCellData *createCellData(int row, int col);
   typeCellData *findCellData(int row, int col);
   void pushCharStack(QStack<QChar> *stackChars, const QChar &character);