Comment on virtual method and maybe the lack of them

2 files changed, 8 insertions, 3 deletions

diff --git a/libopie2/opieui/okeyconfigwidget.h b/libopie2/opieui/okeyconfigwidget.h
index d11054c..3d2260c 100644
--- a/libopie2/opieui/okeyconfigwidget.h
+++ b/libopie2/opieui/okeyconfigwidget.h
@@ -35,9 +35,13 @@ namespace Internal {
  * be configured by the user.
  * There are two ways you can use this widget. Either in a tab were
  * all changes are immediately getting into effect or in a queue
  * were you ask for saving. Save won't write the data but only set
- * it to the OKeyConfigManager
+ * it to the OKeyConfigManager.
+ *
+ * Normally subclassing this widget does not make much sense as the widget content
+ * as such is immutable. If I'm wrong I'm willing to learn and you could mail me which
+ * functions do make sense with virtual on it (zecke@handhelds.org).
  *
  * @since 1.2
  */
 class OKeyConfigWidget : public QWidget {
@@ -49,9 +53,9 @@ public:
      * Queue Save all items and then apply when you save()
      */
     enum ChangeMode { Imediate, Queue };
     OKeyConfigWidget( QWidget* parent = 0, const char* name = 0, WFlags fl = 0 );
-    ~OKeyConfigWidget();
+    virtual ~OKeyConfigWidget();
 
     void setChangeMode( enum ChangeMode );
     ChangeMode changeMode()const;
 
@@ -59,9 +63,9 @@ public:
 
     void load();
     void save();
 
-private slots:
+protected slots:
     void slotListViewItem(  QListViewItem* );
     void slotNoKey();
     void slotDefaultKey();
     void slotCustomKey();
diff --git a/libopie2/opieui/otaskbarapplet.h b/libopie2/opieui/otaskbarapplet.h
index ec7b9c4..77cc461 100644
--- a/libopie2/opieui/otaskbarapplet.h
+++ b/libopie2/opieui/otaskbarapplet.h
@@ -110,8 +110,9 @@ class OTaskbarApplet : public QWidget
   public:
     OTaskbarApplet( QWidget* parent, const char* name = 0 );
     virtual ~OTaskbarApplet();
 
+
   protected:
     virtual void popup( QWidget* widget );
 private:
     class Private;