summaryrefslogtreecommitdiff
authormickeyl <mickeyl>2003-12-05 21:24:53 (UTC)
committer mickeyl <mickeyl>2003-12-05 21:24:53 (UTC)
commit650d6e3ec023759f1c6566d7562857d8dd0e8028 (patch) (side-by-side diff)
treeb028807a522b553aa4cfae8bdb6fa174f9a7fe2b
parent978b8c98ba1e206dd683b2f1f0a743b8d2ce290f (diff)
downloadopie-650d6e3ec023759f1c6566d7562857d8dd0e8028.zip
opie-650d6e3ec023759f1c6566d7562857d8dd0e8028.tar.gz
opie-650d6e3ec023759f1c6566d7562857d8dd0e8028.tar.bz2
add some comments to Zaurus class
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--libopie/odevice.cpp17
1 files changed, 17 insertions, 0 deletions
diff --git a/libopie/odevice.cpp b/libopie/odevice.cpp
index 71ed9e4..9373ef9 100644
--- a/libopie/odevice.cpp
+++ b/libopie/odevice.cpp
@@ -1492,8 +1492,21 @@ int iPAQ::lightSensorResolution ( ) const
*
**************************************************/
// Check whether this device is the sharp zaurus..
+// FIXME This gets unnecessary complicated. We should think about splitting the Zaurus
+// class up into individual classes. We need three classes
+//
+// Zaurus-Collie (SA-model w/ 320x240 lcd, for SL5500 and SL5000)
+// Zaurus-Poodle (PXA-model w/ 320x240 lcd, for SL5600)
+// Zaurus-Corgi (PXA-model w/ 640x480 lcd, for C700, C750, C760, and C860)
+//
+// Only question right now is: Do we really need to do it? Because as soon
+// as the OpenZaurus kernel is ready, there will be a unified interface for all
+// Zaurus models (concerning apm, backlight, buttons, etc.)
+//
+// Comments? - mickeyl.
+
bool Zaurus::isZaurus()
{
// If the special devices by embedix exist, it is quite simple: it is a Zaurus !
@@ -1622,8 +1635,9 @@ void Zaurus::init ( )
// Note: need to 1) set flipstate based on physical screen orientation
// and 2) check to see if the user overrode the rotation direction
// using appearance, and if so, remove that item from the Config to
// ensure the rotate applet flips us back to the previous state.
+ // treke said he has patches for detecting the phys. so where are they, treke? -mickeyl.
if ( flipstate ) {
// 480x640
d-> m_rotation = Rot0;
d-> m_direction = CW;
@@ -1935,8 +1949,11 @@ bool Zaurus::setSoftSuspend ( bool soft )
bool Zaurus::setDisplayBrightness ( int bright )
{
+// FIXME The C7x0 have a proc-interface (/proc/drivers/corgi-bl) which
+// is nice to use. Currently it exposes 16+1 levels. Implement this!
+// (or wait for kergoth unifying the interfaces in the OpenZaurus kernel.)
bool res = false;
int fd;
if ( bright > 255 )