Added several checks to ensure we have a valid server or destination. Fixes bug #727, and also prevents several other segfault situations.

1 files changed, 72 insertions, 42 deletions

diff --git a/noncore/settings/aqpkg/settingsimpl.cpp b/noncore/settings/aqpkg/settingsimpl.cpp
index 9f611da..e2afada 100644
--- a/noncore/settings/aqpkg/settingsimpl.cpp
+++ b/noncore/settings/aqpkg/settingsimpl.cpp
@@ -285,12 +285,22 @@ void SettingsImpl :: setupData()
 void SettingsImpl :: editServer( int sel )
 {
     currentSelectedServer = sel;
     Server *s = dataMgr->getServer( servers->currentText() );
-    serverName = s->getServerName();
-    servername->setText( s->getServerName() );
-    serverurl->setText( s->getServerUrl() );
-    active->setChecked( s->isServerActive() );
+    if ( s )
+    {
+        serverName = s->getServerName();
+        servername->setText( s->getServerName() );
+        serverurl->setText( s->getServerUrl() );
+        active->setChecked( s->isServerActive() );
+    }
+    else
+    {
+        serverName = "";
+        servername->setText( "" );
+        serverurl->setText( "" );
+        active->setChecked( false );
+    }
 }
 
 void SettingsImpl :: newServer()
 {
@@ -304,10 +314,13 @@ void SettingsImpl :: newServer()
 void SettingsImpl :: removeServer()
 {
     changed = true;
     Server *s = dataMgr->getServer( servers->currentText() );
-    dataMgr->getServerList().removeRef( s );
-    servers->removeItem( currentSelectedServer );
+    if ( s )
+    {
+        dataMgr->getServerList().removeRef( s );
+        servers->removeItem( currentSelectedServer );
+    }
 }
 
 void SettingsImpl :: changeServerDetails()
 {
@@ -331,23 +344,24 @@ void SettingsImpl :: changeServerDetails()
 	
 	if ( !newserver )
 	{
 		Server *s = dataMgr->getServer( servers->currentText() );
-
-		// Update url
-		s->setServerUrl( serverurl->text() );
-        s->setActive( active->isChecked() );
-
-
-		// Check if server name has changed, if it has then we need to replace the key in the map
-		if ( serverName != newName )
+		if ( s )
 		{
-			// Update server name
-			s->setServerName( newName );
-		}
+			// Update url
+			s->setServerUrl( serverurl->text() );
+			s->setActive( active->isChecked() );
+
+			// Check if server name has changed, if it has then we need to replace the key in the map
+			if ( serverName != newName )
+			{
+				// Update server name
+				s->setServerName( newName );
+			}
 		
-		// Update list box
-		servers->changeItem( newName, currentSelectedServer );
+			// Update list box
+			servers->changeItem( newName, currentSelectedServer );
+		}
 	}
 	else
 	{
         Server s( newName, serverurl->text() );
@@ -362,14 +376,24 @@ void SettingsImpl :: changeServerDetails()
 //------------------ Destinations tab ----------------------
 
 void SettingsImpl :: editDestination( int sel )
 {
-	currentSelectedDestination = sel;
+    currentSelectedDestination = sel;
     Destination *d = dataMgr->getDestination( destinations->currentText() );
-    destinationName = d->getDestinationName();
-    destinationname->setText( d->getDestinationName() );
-    destinationurl->setText( d->getDestinationPath() );
-    linkToRoot->setChecked( d->linkToRoot() );
+    if ( d )
+    {
+        destinationName = d->getDestinationName();
+        destinationname->setText( d->getDestinationName() );
+        destinationurl->setText( d->getDestinationPath() );
+        linkToRoot->setChecked( d->linkToRoot() );
+    }
+    else
+    {
+        destinationName = "";
+        destinationname->setText( "" );
+        destinationurl->setText( "" );
+        linkToRoot->setChecked( false );
+    }
 }
 
 void SettingsImpl :: newDestination()
 {
@@ -383,10 +407,13 @@ void SettingsImpl :: newDestination()
 void SettingsImpl :: removeDestination()
 {
     changed = true;
     Destination *d = dataMgr->getDestination( destinations->currentText() );
-    dataMgr->getDestinationList().removeRef( d );
-	destinations->removeItem( currentSelectedDestination );
+    if ( d )
+    {
+        dataMgr->getDestinationList().removeRef( d );
+        destinations->removeItem( currentSelectedDestination );
+    }
 }
 
 void SettingsImpl :: changeDestinationDetails()
 {
@@ -400,28 +427,31 @@ void SettingsImpl :: changeDestinationDetails()
     QString newName = destinationname->text();
 	if ( !newdestination )
 	{
 		Destination *d = dataMgr->getDestination( destinations->currentText() );
+		if ( d )
+		{
+			// Update url
+			d->setDestinationPath( destinationurl->text() );
+        	d->linkToRoot( linkToRoot->isChecked() );
 
-		// Update url
-		d->setDestinationPath( destinationurl->text() );
-        d->linkToRoot( linkToRoot->isChecked() );
+			// Check if server name has changed, if it has then we need to replace the key in the map
+			if ( destinationName != newName )
+			{
+				// Update server name
+				d->setDestinationName( newName );
 
-		// Check if server name has changed, if it has then we need to replace the key in the map
-		if ( destinationName != newName )
-		{
-			// Update server name
-			d->setDestinationName( newName );
+				// Update list box
+				destinations->changeItem( newName, currentSelectedDestination );
+			}
 
-			// Update list box
-			destinations->changeItem( newName, currentSelectedDestination );
-		}
 #ifdef QWS
-        QString key = newName;
-        key += "_linkToRoot";
-        int val = d->linkToRoot();
-        cfg.writeEntry( key, val );
-#endif        
+			QString key = newName;
+			key += "_linkToRoot";
+			int val = d->linkToRoot();
+			cfg.writeEntry( key, val );
+#endif      
+		}  
 	}
 	else
 	{
 		dataMgr->getDestinationList().append( new Destination( newName, destinationurl->text() ) );