Fixing bug #1236: VCARD contained empty WORK and HOME addressfields..

1 files changed, 26 insertions, 14 deletions

diff --git a/libopie2/opiepim/backend/ocontactaccessbackend_vcard.cpp b/libopie2/opiepim/backend/ocontactaccessbackend_vcard.cpp
index f3b6d56..0ffbb67 100644
--- a/libopie2/opiepim/backend/ocontactaccessbackend_vcard.cpp
+++ b/libopie2/opiepim/backend/ocontactaccessbackend_vcard.cpp
@@ -451,15 +451,21 @@ VObject* OPimContactAccessBackend_VCard::createVObject( const OPimContact &c )
     safeAddPropValue( name, VCNamePrefixesProp, c.title() );
     safeAddPropValue( name, VCNameSuffixesProp, c.suffix() );
 
     // home properties
-    VObject *home_adr= safeAddProp( vcard, VCAdrProp );
-    safeAddProp( home_adr, VCHomeProp );
-    safeAddPropValue( home_adr, VCStreetAddressProp, c.homeStreet() );
-    safeAddPropValue( home_adr, VCCityProp, c.homeCity() );
-    safeAddPropValue( home_adr, VCRegionProp, c.homeState() );
-    safeAddPropValue( home_adr, VCPostalCodeProp, c.homeZip() );
-    safeAddPropValue( home_adr, VCCountryNameProp, c.homeCountry() );
+    if ( !( c.homeStreet().isEmpty() 
+           && c.homeCity().isEmpty() 
+           && c.homeState().isEmpty() 
+           && c.homeZip().isEmpty() 
+           && c.homeCountry().isEmpty() ) ){
+            VObject *home_adr= safeAddProp( vcard, VCAdrProp );
+            safeAddProp( home_adr, VCHomeProp );
+            safeAddPropValue( home_adr, VCStreetAddressProp, c.homeStreet() );
+            safeAddPropValue( home_adr, VCCityProp, c.homeCity() );
+            safeAddPropValue( home_adr, VCRegionProp, c.homeState() );
+            safeAddPropValue( home_adr, VCPostalCodeProp, c.homeZip() );
+            safeAddPropValue( home_adr, VCCountryNameProp, c.homeCountry() );
+    }
 
     VObject *home_phone = safeAddPropValue( vcard, VCTelephoneProp, c.homePhone() );
     safeAddProp( home_phone, VCHomeProp );
     home_phone = safeAddPropValue( vcard, VCTelephoneProp, c.homeMobile() );
@@ -472,15 +478,21 @@ VObject* OPimContactAccessBackend_VCard::createVObject( const OPimContact &c )
     VObject *url = safeAddPropValue( vcard, VCURLProp, c.homeWebpage() );
     safeAddProp( url, VCHomeProp );
 
     // work properties
-    VObject *work_adr= safeAddProp( vcard, VCAdrProp );
-    safeAddProp( work_adr, VCWorkProp );
-    safeAddPropValue( work_adr, VCStreetAddressProp, c.businessStreet() );
-    safeAddPropValue( work_adr, VCCityProp, c.businessCity() );
-    safeAddPropValue( work_adr, VCRegionProp, c.businessState() );
-    safeAddPropValue( work_adr, VCPostalCodeProp, c.businessZip() );
-    safeAddPropValue( work_adr, VCCountryNameProp, c.businessCountry() );
+    if ( !( c.businessStreet().isEmpty() 
+           && c.businessCity().isEmpty() 
+           && c.businessState().isEmpty() 
+           && c.businessZip().isEmpty() 
+           && c.businessCountry().isEmpty() ) ){
+            VObject *work_adr= safeAddProp( vcard, VCAdrProp );
+            safeAddProp( work_adr, VCWorkProp );
+            safeAddPropValue( work_adr, VCStreetAddressProp, c.businessStreet() );
+            safeAddPropValue( work_adr, VCCityProp, c.businessCity() );
+            safeAddPropValue( work_adr, VCRegionProp, c.businessState() );
+            safeAddPropValue( work_adr, VCPostalCodeProp, c.businessZip() );
+            safeAddPropValue( work_adr, VCCountryNameProp, c.businessCountry() );
+    }
 
     VObject *work_phone = safeAddPropValue( vcard, VCTelephoneProp, c.businessPhone() );
     safeAddProp( work_phone, VCWorkProp );
     work_phone = safeAddPropValue( vcard, VCTelephoneProp, c.businessMobile() );