Workaround for a possible race condition in the QWS server (mostly OZ)

(clipboard handling in Qt/E is a mess)

1 files changed, 15 insertions, 2 deletions

diff --git a/core/applets/clipboardapplet/clipboard.cpp b/core/applets/clipboardapplet/clipboard.cpp
index 4fbdf6f..3099a84 100644
--- a/core/applets/clipboardapplet/clipboard.cpp
+++ b/core/applets/clipboardapplet/clipboard.cpp
@@ -83,160 +83,173 @@ static const char * paste_xpm[] = {
 "h	c #FAF2E6",
 "i	c #8E8E8E",
 "j	c #C6BCAE",
 "k	c #DEDEDE",
 "l	c #BEBEBE",
 "m	c #464646",
 "n	c #BEAE92",
 "o	c #262626",
 "p	c #F2E2CE",
 "q	c #C2A175",
 "r	c #CACACA",
 "s	c #969696",
 "t	c #8A8A8A",
 "u	c #828282",
 "v	c #6A6A6A",
 "w	c #BEB6AE",
 "x	c #E2E0E0",
 "y	c #7A7A7A",
 "    *{>;      ",
 " }}}@e:!;}}}  ",
 "<x8=&:#@+;ll, ",
 "}k/=;;3}337|o ",
 "<k's24444m45o ",
 "}8'ss4xkkk]}a ",
 "<1s224keee|b4 ",
 "}r2itmkeee]]44",
 "<9iitmkeeehkw.",
 "<lt-u4keeb)pn.",
 "<fu-umkebhp(0.",
 "<cugg4kbh)_(q.",
 "<cyyymk))p(%q.",
 ",5vvv4k)p_%[q.",
 " ...$mljnn0qd.",
 "     4.......,"};
 
 
 ClipboardApplet::ClipboardApplet( QWidget *parent, const char *name ) : QWidget( parent, name )
 {
 	setFixedWidth ( 14 );
 	setFixedHeight ( 18 );
 	m_clipboardPixmap = QPixmap ( paste_xpm );
 
 	m_timer = new QTimer ( this );
 	
 	connect ( QApplication::clipboard ( ), SIGNAL( dataChanged ( )), this, SLOT( newData ( )));
 	connect ( m_timer, SIGNAL( timeout ( )), this, SLOT( newData ( )));
 	connect ( qApp, SIGNAL( aboutToQuit ( )), this, SLOT( shutdown ( )));
 
-	m_timer-> start ( 1500 );
-	
 	m_menu = 0;
 	m_dirty = true;
 	m_lasttext = QString::null;
+	
+	m_timer-> start ( 0, true );
 }
 
 ClipboardApplet::~ClipboardApplet ( )
 {
 }
 
 void ClipboardApplet::shutdown ( )
 {
 	// the timer has to be stopped, or Qt/E will hang on quit()
 	// see launcher/desktop.cpp
 
 	m_timer-> stop ( );
 }
 
 void ClipboardApplet::mousePressEvent ( QMouseEvent *)
 {
 	if ( m_dirty ) {
 		delete m_menu;
 	
 		m_menu = new QPopupMenu ( this );
 		m_menu-> setCheckable ( true );
 
 		if ( m_history. count ( )) {	
 			for ( unsigned int i = 0; i < m_history. count ( ); i++ ) {
 				QString str = m_history [i];
 				
 				if ( str. length ( ) > 20 )
 					str = str. left ( 20 ) + "...";
 			
 				m_menu-> insertItem ( QString ( "%1: %2" ). arg ( i + 1 ). arg ( str ), i );
 				m_menu-> setItemChecked ( i, false );
 			}
 			m_menu-> setItemChecked ( m_history. count ( ) - 1, true );		
 			m_menu-> insertSeparator ( );
 		}
 		m_menu-> insertItem ( QIconSet ( Resource::loadPixmap ( "cut" )), tr( "Cut" ), 100 );
 		m_menu-> insertItem ( QIconSet ( Resource::loadPixmap ( "copy" )), tr( "Copy" ), 101 );
 		m_menu-> insertItem ( QIconSet ( Resource::loadPixmap ( "paste" )), tr( "Paste" ), 102 );
 		
 		connect ( m_menu, SIGNAL( activated ( int )), this, SLOT( action ( int )));
 		
 		m_dirty = false;
 	}
 	QPoint p = mapToGlobal ( QPoint ( 0, 0 ));
 	QSize s = m_menu-> sizeHint ( );
 	
 	m_menu-> popup ( QPoint ( p. x ( ) + ( width ( ) / 2 ) - ( s. width ( ) / 2 ), p. y ( ) - s. height ( )));
 }
 
 void ClipboardApplet::action(int id)
 {
 	ushort unicode = 0;
 	int scan = 0;
 
 	switch ( id ) {
 		case 100:
 			unicode = 'X' - '@'; 
 			scan    = Key_X; // Cut
 			break;
 		case 101:
 			unicode = 'C' - '@'; 
 			scan    = Key_C; // Copy
 			break;
 		case 102:
 			unicode = 'V' - '@'; 
 			scan    = Key_V; // Paste
 			break;
 			
 		default:
 			if (( id >= 0 ) && ( uint( id ) < m_history. count ( ))) {
 				QApplication::clipboard ( )-> setText ( m_history [id] );
 				
 				for ( uint i = 0; i < m_history. count ( ); i++ ) 
 					m_menu-> setItemChecked ( i, i == uint( id ));
 				
 				unicode = 'V' - '@';
 				scan    = Key_V;
 			}
 			break;
 	}
 		
 	if ( scan ) {
 		qwsServer-> sendKeyEvent ( unicode, scan, ControlButton, true, false );
 		qwsServer-> sendKeyEvent ( unicode, scan, ControlButton, false, false );
 	}
 }
 
 void ClipboardApplet::paintEvent ( QPaintEvent* )
 {
 	QPainter p ( this );
 	p. drawPixmap ( 0, 1, m_clipboardPixmap );
 }
 
 void ClipboardApplet::newData ( )
 {
+	static bool excllock = false;
+	
+	if ( excllock )
+		return;
+	else
+		excllock = true;
+	
+	m_timer-> stop ( ); 
+	
 	QCString type = "plain";
 	QString txt = QApplication::clipboard ( )-> text ( type );
 
 	if ( !txt. isEmpty ( ) && !m_history. contains ( txt )) {
 		m_history. append ( txt );
 
 		if ( m_history. count ( ) > 5 )
 			m_history. remove ( m_history. begin ( ));
 		
 		m_dirty = true;
 	}
+	
+	m_timer-> start ( 1500, true );
+	
+	excllock = false;
 }