author | mickeyl <mickeyl> | 2004-04-23 14:43:53 (UTC) |
---|---|---|
committer | mickeyl <mickeyl> | 2004-04-23 14:43:53 (UTC) |
commit | d8a8c7bf9559dd1ad6a72c9e5582d72a176c97f6 (patch) (unidiff) | |
tree | 1a069ffb791230709e5be8ce230afb6e8d510af9 | |
parent | 8e32516bbda3fda10314f2afe4ee00eb9a49c013 (diff) | |
download | opie-d8a8c7bf9559dd1ad6a72c9e5582d72a176c97f6.zip opie-d8a8c7bf9559dd1ad6a72c9e5582d72a176c97f6.tar.gz opie-d8a8c7bf9559dd1ad6a72c9e5582d72a176c97f6.tar.bz2 |
disambiguate the API (triggered by gcc 3.4 ;)
-rw-r--r-- | libopie2/opienet/opcap.cpp | 4 | ||||
-rw-r--r-- | libopie2/opienet/opcap.h | 4 |
2 files changed, 3 insertions, 5 deletions
diff --git a/libopie2/opienet/opcap.cpp b/libopie2/opienet/opcap.cpp index 067d6b7..f8ebe6b 100644 --- a/libopie2/opienet/opcap.cpp +++ b/libopie2/opienet/opcap.cpp | |||
@@ -1238,100 +1238,98 @@ bool OPacketCapturer::open( const QString& name ) | |||
1238 | else // close the last opened device | 1238 | else // close the last opened device |
1239 | { | 1239 | { |
1240 | close(); | 1240 | close(); |
1241 | } | 1241 | } |
1242 | } | 1242 | } |
1243 | 1243 | ||
1244 | _name = name; | 1244 | _name = name; |
1245 | 1245 | ||
1246 | // open libpcap | 1246 | // open libpcap |
1247 | pcap_t* handle = pcap_open_live( const_cast<char*>( (const char*) name ), 1024, 0, 0, &_errbuf[0] ); | 1247 | pcap_t* handle = pcap_open_live( const_cast<char*>( (const char*) name ), 1024, 0, 0, &_errbuf[0] ); |
1248 | 1248 | ||
1249 | if ( !handle ) | 1249 | if ( !handle ) |
1250 | { | 1250 | { |
1251 | owarn << "OPacketCapturer::open(): can't open libpcap with '" << name << "': " << _errbuf << oendl; | 1251 | owarn << "OPacketCapturer::open(): can't open libpcap with '" << name << "': " << _errbuf << oendl; |
1252 | return false; | 1252 | return false; |
1253 | } | 1253 | } |
1254 | 1254 | ||
1255 | odebug << "OPacketCapturer::open(): libpcap [" << name << "] opened successfully." << oendl; | 1255 | odebug << "OPacketCapturer::open(): libpcap [" << name << "] opened successfully." << oendl; |
1256 | _pch = handle; | 1256 | _pch = handle; |
1257 | _open = true; | 1257 | _open = true; |
1258 | _stats.clear(); | 1258 | _stats.clear(); |
1259 | 1259 | ||
1260 | // in case we have an application object, create a socket notifier | 1260 | // in case we have an application object, create a socket notifier |
1261 | if ( qApp ) //TODO: I don't like this here... | 1261 | if ( qApp ) //TODO: I don't like this here... |
1262 | { | 1262 | { |
1263 | _sn = new QSocketNotifier( fileno(), QSocketNotifier::Read ); | 1263 | _sn = new QSocketNotifier( fileno(), QSocketNotifier::Read ); |
1264 | connect( _sn, SIGNAL( activated(int) ), this, SLOT( readyToReceive() ) ); | 1264 | connect( _sn, SIGNAL( activated(int) ), this, SLOT( readyToReceive() ) ); |
1265 | } | 1265 | } |
1266 | 1266 | ||
1267 | return true; | 1267 | return true; |
1268 | } | 1268 | } |
1269 | 1269 | ||
1270 | 1270 | ||
1271 | bool OPacketCapturer::openDumpFile( const QString& filename ) | 1271 | bool OPacketCapturer::openDumpFile( const QString& filename ) |
1272 | { | 1272 | { |
1273 | pcap_dumper_t* dump = pcap_dump_open( _pch, const_cast<char*>( (const char*) filename ) ); | 1273 | pcap_dumper_t* dump = pcap_dump_open( _pch, const_cast<char*>( (const char*) filename ) ); |
1274 | if ( !dump ) | 1274 | if ( !dump ) |
1275 | { | 1275 | { |
1276 | owarn << "OPacketCapturer::open(): can't open dump with '" << filename << "': " << _errbuf << oendl; | 1276 | owarn << "OPacketCapturer::open(): can't open dump with '" << filename << "': " << _errbuf << oendl; |
1277 | return false; | 1277 | return false; |
1278 | } | 1278 | } |
1279 | odebug << "OPacketCapturer::open(): dump [" << filename << "] opened successfully." << oendl; | 1279 | odebug << "OPacketCapturer::open(): dump [" << filename << "] opened successfully." << oendl; |
1280 | _pcd = dump; | 1280 | _pcd = dump; |
1281 | 1281 | ||
1282 | return true; | 1282 | return true; |
1283 | } | 1283 | } |
1284 | 1284 | ||
1285 | 1285 | ||
1286 | bool OPacketCapturer::open( const QFile& file ) | 1286 | bool OPacketCapturer::openCaptureFile( const QString& name ) |
1287 | { | 1287 | { |
1288 | QString name = file.name(); | ||
1289 | |||
1290 | if ( _open ) | 1288 | if ( _open ) |
1291 | { | 1289 | { |
1292 | close(); | 1290 | close(); |
1293 | if ( name == _name ) // ignore opening an already openend device | 1291 | if ( name == _name ) // ignore opening an already openend device |
1294 | { | 1292 | { |
1295 | return true; | 1293 | return true; |
1296 | } | 1294 | } |
1297 | else // close the last opened device | 1295 | else // close the last opened device |
1298 | { | 1296 | { |
1299 | close(); | 1297 | close(); |
1300 | } | 1298 | } |
1301 | } | 1299 | } |
1302 | 1300 | ||
1303 | _name = name; | 1301 | _name = name; |
1304 | 1302 | ||
1305 | pcap_t* handle = pcap_open_offline( const_cast<char*>( (const char*) name ), &_errbuf[0] ); | 1303 | pcap_t* handle = pcap_open_offline( const_cast<char*>( (const char*) name ), &_errbuf[0] ); |
1306 | 1304 | ||
1307 | if ( handle ) | 1305 | if ( handle ) |
1308 | { | 1306 | { |
1309 | odebug << "OPacketCapturer::open(): libpcap opened successfully." << oendl; | 1307 | odebug << "OPacketCapturer::open(): libpcap opened successfully." << oendl; |
1310 | _pch = handle; | 1308 | _pch = handle; |
1311 | _open = true; | 1309 | _open = true; |
1312 | 1310 | ||
1313 | // in case we have an application object, create a socket notifier | 1311 | // in case we have an application object, create a socket notifier |
1314 | if ( qApp ) | 1312 | if ( qApp ) |
1315 | { | 1313 | { |
1316 | _sn = new QSocketNotifier( fileno(), QSocketNotifier::Read ); | 1314 | _sn = new QSocketNotifier( fileno(), QSocketNotifier::Read ); |
1317 | connect( _sn, SIGNAL( activated(int) ), this, SLOT( readyToReceive() ) ); | 1315 | connect( _sn, SIGNAL( activated(int) ), this, SLOT( readyToReceive() ) ); |
1318 | } | 1316 | } |
1319 | 1317 | ||
1320 | return true; | 1318 | return true; |
1321 | } | 1319 | } |
1322 | else | 1320 | else |
1323 | { | 1321 | { |
1324 | odebug << "OPacketCapturer::open(): can't open libpcap with '" << name << "': " << _errbuf << oendl; | 1322 | odebug << "OPacketCapturer::open(): can't open libpcap with '" << name << "': " << _errbuf << oendl; |
1325 | return false; | 1323 | return false; |
1326 | } | 1324 | } |
1327 | 1325 | ||
1328 | } | 1326 | } |
1329 | 1327 | ||
1330 | 1328 | ||
1331 | bool OPacketCapturer::isOpen() const | 1329 | bool OPacketCapturer::isOpen() const |
1332 | { | 1330 | { |
1333 | return _open; | 1331 | return _open; |
1334 | } | 1332 | } |
1335 | 1333 | ||
1336 | 1334 | ||
1337 | void OPacketCapturer::readyToReceive() | 1335 | void OPacketCapturer::readyToReceive() |
diff --git a/libopie2/opienet/opcap.h b/libopie2/opienet/opcap.h index 2dbe030..9e718d5 100644 --- a/libopie2/opienet/opcap.h +++ b/libopie2/opienet/opcap.h | |||
@@ -618,99 +618,99 @@ class OPacketCapturer : public QObject | |||
618 | */ | 618 | */ |
619 | ~OPacketCapturer(); | 619 | ~OPacketCapturer(); |
620 | /** | 620 | /** |
621 | * Set the packet capturer to use blocking or non-blocking IO. This can be useful when | 621 | * Set the packet capturer to use blocking or non-blocking IO. This can be useful when |
622 | * not using the socket notifier, e.g. without an application object. | 622 | * not using the socket notifier, e.g. without an application object. |
623 | */ | 623 | */ |
624 | void setBlocking( bool ); | 624 | void setBlocking( bool ); |
625 | /** | 625 | /** |
626 | * @returns true if the packet capturer uses blocking IO calls. | 626 | * @returns true if the packet capturer uses blocking IO calls. |
627 | */ | 627 | */ |
628 | bool blocking() const; | 628 | bool blocking() const; |
629 | /** | 629 | /** |
630 | * Close the packet capturer. This is automatically done in the destructor. | 630 | * Close the packet capturer. This is automatically done in the destructor. |
631 | */ | 631 | */ |
632 | void close(); | 632 | void close(); |
633 | /** | 633 | /** |
634 | * Close the output capture file. | 634 | * Close the output capture file. |
635 | */ | 635 | */ |
636 | void closeDumpFile(); | 636 | void closeDumpFile(); |
637 | /** | 637 | /** |
638 | * @returns the data link type. | 638 | * @returns the data link type. |
639 | * @see <pcap.h> for possible values. | 639 | * @see <pcap.h> for possible values. |
640 | */ | 640 | */ |
641 | int dataLink() const; | 641 | int dataLink() const; |
642 | /** | 642 | /** |
643 | * Dump a packet to the output capture file. | 643 | * Dump a packet to the output capture file. |
644 | */ | 644 | */ |
645 | void dump( OPacket* ); | 645 | void dump( OPacket* ); |
646 | /** | 646 | /** |
647 | * @returns the file descriptor of the packet capturer. This is only useful, if | 647 | * @returns the file descriptor of the packet capturer. This is only useful, if |
648 | * not using the socket notifier, e.g. without an application object. | 648 | * not using the socket notifier, e.g. without an application object. |
649 | */ | 649 | */ |
650 | int fileno() const; | 650 | int fileno() const; |
651 | /** | 651 | /** |
652 | * @returns the next @ref OPacket from the packet capturer. | 652 | * @returns the next @ref OPacket from the packet capturer. |
653 | * @note If blocking mode is true then this call might block. | 653 | * @note If blocking mode is true then this call might block. |
654 | */ | 654 | */ |
655 | OPacket* next(); | 655 | OPacket* next(); |
656 | /** | 656 | /** |
657 | * @returns the next @ref OPacket from the packet capturer, if | 657 | * @returns the next @ref OPacket from the packet capturer, if |
658 | * one arrives within @a time milliseconds. | 658 | * one arrives within @a time milliseconds. |
659 | */ | 659 | */ |
660 | OPacket* next( int time ); | 660 | OPacket* next( int time ); |
661 | /** | 661 | /** |
662 | * Open the packet capturer to capture packets in live-mode from @a interface. | 662 | * Open the packet capturer to capture packets in live-mode from @a interface. |
663 | */ | 663 | */ |
664 | bool open( const QString& interface ); | 664 | bool open( const QString& interface ); |
665 | /** | 665 | /** |
666 | * Open the packet capturer to capture packets in offline-mode from @a file. | 666 | * Open the packet capturer to capture packets in offline-mode from @a filename. |
667 | */ | 667 | */ |
668 | bool open( const QFile& file ); | 668 | bool openCaptureFile( const QString& filename ); |
669 | /** | 669 | /** |
670 | * Open a prerecorded tcpdump compatible capture file for use with @ref dump() | 670 | * Open a prerecorded tcpdump compatible capture file for use with @ref dump() |
671 | */ | 671 | */ |
672 | bool openDumpFile( const QString& filename ); | 672 | bool openDumpFile( const QString& filename ); |
673 | /** | 673 | /** |
674 | * @returns true if the packet capturer is open | 674 | * @returns true if the packet capturer is open |
675 | */ | 675 | */ |
676 | bool isOpen() const; | 676 | bool isOpen() const; |
677 | /** | 677 | /** |
678 | * @returns the snapshot length of this packet capturer | 678 | * @returns the snapshot length of this packet capturer |
679 | */ | 679 | */ |
680 | int snapShot() const; | 680 | int snapShot() const; |
681 | /** | 681 | /** |
682 | * @returns true if the input capture file has a different byte-order | 682 | * @returns true if the input capture file has a different byte-order |
683 | * than the byte-order of the running system. | 683 | * than the byte-order of the running system. |
684 | */ | 684 | */ |
685 | bool swapped() const; | 685 | bool swapped() const; |
686 | /** | 686 | /** |
687 | * @returns the libpcap version string used to write the input capture file. | 687 | * @returns the libpcap version string used to write the input capture file. |
688 | */ | 688 | */ |
689 | QString version() const; | 689 | QString version() const; |
690 | /** | 690 | /** |
691 | * @returns the packet statistic database. | 691 | * @returns the packet statistic database. |
692 | * @see QMap | 692 | * @see QMap |
693 | */ | 693 | */ |
694 | const QMap<QString,int>& statistics() const; | 694 | const QMap<QString,int>& statistics() const; |
695 | /** | 695 | /** |
696 | * Enable or disable the auto-delete option. | 696 | * Enable or disable the auto-delete option. |
697 | * If auto-delete is enabled, then the packet capturer will delete a packet right | 697 | * If auto-delete is enabled, then the packet capturer will delete a packet right |
698 | * after it has been emit'ted. This is the default, which is useful if the packet | 698 | * after it has been emit'ted. This is the default, which is useful if the packet |
699 | * capturer has the only reference to the packets. If you pass the packet for adding | 699 | * capturer has the only reference to the packets. If you pass the packet for adding |
700 | * into a collection or do processing after the SLOT, the auto delete must be disabled. | 700 | * into a collection or do processing after the SLOT, the auto delete must be disabled. |
701 | */ | 701 | */ |
702 | void setAutoDelete( bool enable ); | 702 | void setAutoDelete( bool enable ); |
703 | /** | 703 | /** |
704 | * @returns the auto-delete value. | 704 | * @returns the auto-delete value. |
705 | */ | 705 | */ |
706 | bool autoDelete() const; | 706 | bool autoDelete() const; |
707 | 707 | ||
708 | signals: | 708 | signals: |
709 | /** | 709 | /** |
710 | * This signal is emitted, when a packet has been received. | 710 | * This signal is emitted, when a packet has been received. |
711 | */ | 711 | */ |
712 | void receivedPacket( Opie::Net::OPacket* ); | 712 | void receivedPacket( Opie::Net::OPacket* ); |
713 | 713 | ||
714 | protected slots: | 714 | protected slots: |
715 | void readyToReceive(); | 715 | void readyToReceive(); |
716 | 716 | ||