- Save album in PNG format instead of XPM

- Small fixes

4 files changed, 24 insertions, 16 deletions

diff --git a/noncore/graphics/drawpad/drawpad.cpp b/noncore/graphics/drawpad/drawpad.cpp
index aae9ab0..1375792 100644
--- a/noncore/graphics/drawpad/drawpad.cpp
+++ b/noncore/graphics/drawpad/drawpad.cpp
@@ -150,12 +150,13 @@ DrawPad::DrawPad(QWidget* parent, const char* name)
 
     m_pFilledRectangleToolAction = new QAction(tr("Draw Filled Rectangle"), Resource::loadIconSet("drawpad/filledrectangle.png"), "", 0, this);
     connect(m_pFilledRectangleToolAction, SIGNAL(activated()), this, SLOT(setFilledRectangleTool()));
     m_pFilledRectangleToolAction->addTo(rectanglePopupMenu);
 
     m_pRectangleToolButton->setPopup(rectanglePopupMenu);
+    m_pRectangleToolButton->setPopupDelay(0);
 
     m_pEllipseToolButton = new QToolButton(drawModeToolBar);
     m_pEllipseToolButton->setToggleButton(true);
 
     QPopupMenu* ellipsePopupMenu = new QPopupMenu(m_pEllipseToolButton);
 
@@ -165,12 +166,13 @@ DrawPad::DrawPad(QWidget* parent, const char* name)
 
     m_pFilledEllipseToolAction = new QAction(tr("Draw Filled Ellipse"), Resource::loadIconSet("drawpad/filledellipse.png"), "", 0, this);
     connect(m_pFilledEllipseToolAction, SIGNAL(activated()), this, SLOT(setFilledEllipseTool()));
     m_pFilledEllipseToolAction->addTo(ellipsePopupMenu);
 
     m_pEllipseToolButton->setPopup(ellipsePopupMenu);
+    m_pEllipseToolButton->setPopupDelay(0);
 
     m_pFillToolAction = new QAction(tr("Fill Region"), Resource::loadIconSet("drawpad/fill.png"), QString::null, 0, this);
     m_pFillToolAction->setToggleAction(true);
     connect(m_pFillToolAction, SIGNAL(activated()), this, SLOT(setFillTool()));
     m_pFillToolAction->addTo(drawModeToolBar);
 
diff --git a/noncore/graphics/drawpad/drawpadcanvas.cpp b/noncore/graphics/drawpad/drawpadcanvas.cpp
index 8818c03..b8a1c2e 100644
--- a/noncore/graphics/drawpad/drawpadcanvas.cpp
+++ b/noncore/graphics/drawpad/drawpadcanvas.cpp
@@ -51,12 +51,13 @@ private:
         Unknown,
         InData
     };
 
     State m_state;
     ulong m_dataLenght;
+    QString m_dataFormat;
     QList<QPixmap> m_pixmaps;
 };
 
 DrawPadCanvasXmlHandler::DrawPadCanvasXmlHandler()
 {
     m_state = Unknown;
@@ -77,12 +78,17 @@ bool DrawPadCanvasXmlHandler::startElement(const QString& namespaceURI, const QS
     Q_CONST_UNUSED(namespaceURI)
     Q_CONST_UNUSED(localName)
 
     if (qName.compare("data") == 0) {
         m_state = InData;
         m_dataLenght = atts.value("length").toULong();
+        m_dataFormat = atts.value("format");
+
+        if (m_dataFormat.isEmpty()) {
+            m_dataFormat = "XPM";
+        }
     }
 
     return true;
 }
 
 bool DrawPadCanvasXmlHandler::endElement(const QString& namespaceURI, const QString& localName,
@@ -130,13 +136,13 @@ bool DrawPadCanvasXmlHandler::characters(const QString& ch)
         }
 
         QByteArray byteArrayUnzipped(m_dataLenght);
         ::uncompress((uchar*)byteArrayUnzipped.data(), &m_dataLenght, (uchar*)byteArray.data(), byteArray.size());
 
         QImage image;
-        image.loadFromData((const uchar*)byteArrayUnzipped.data(), m_dataLenght, "XPM");
+        image.loadFromData((const uchar*)byteArrayUnzipped.data(), m_dataLenght, m_dataFormat);
 
         QPixmap* pixmap = new QPixmap(image.width(), image.height());
         pixmap->convertFromImage(image);
         m_pixmaps.append(pixmap);
     }
 
@@ -212,24 +218,24 @@ void DrawPadCanvas::save(QIODevice* ioDevice)
     for (bufferIterator.toFirst(); bufferIterator.current() != 0; ++bufferIterator) {
         textStream << "        <image>" << endl;
 
         QImage image = bufferIterator.current()->convertToImage();
         QByteArray byteArray;
         QBuffer buffer(byteArray);
-        QImageIO imageIO(&buffer, "XPM");
+        QImageIO imageIO(&buffer, "PNG");
 
         buffer.open(IO_WriteOnly);
         imageIO.setImage(image);
         imageIO.write();
         buffer.close();
 
         ulong size = byteArray.size() * 2;
         QByteArray byteArrayZipped(size);
         ::compress((uchar*)byteArrayZipped.data(), &size, (uchar*)byteArray.data(), byteArray.size());
 
-        textStream << "            <data length=\"" << byteArray.size() << "\">";
+        textStream << "            <data length=\"" << byteArray.size() << "\" format=\"PNG\">";
 
         static const char hexchars[] = "0123456789abcdef";
 
         for (int i = 0; i < (int)size; i++ ) {
             uchar s = (uchar)byteArrayZipped[i];
             textStream << hexchars[s >> 4];
diff --git a/noncore/graphics/drawpad/newpagedialog.cpp b/noncore/graphics/drawpad/newpagedialog.cpp
index b1b26ef..5c31978 100644
--- a/noncore/graphics/drawpad/newpagedialog.cpp
+++ b/noncore/graphics/drawpad/newpagedialog.cpp
@@ -17,37 +17,37 @@
 #include <qgroupbox.h>
 #include <qlabel.h>
 #include <qlayout.h>
 #include <qradiobutton.h>
 #include <qspinbox.h>
 
-NewPageDialog::NewPageDialog(uint width, uint height, const QColor& foregroundColor,
-                             const QColor& backgroundColor, QWidget* parent, const char* name)
+NewPageDialog::NewPageDialog(uint width, uint height, const QColor& penColor,
+                             const QColor& brushColor, QWidget* parent, const char* name)
     : QDialog(parent, name, true)
 {
     setCaption(tr("New Page"));
 
-    m_foregroundColor = foregroundColor;
-    m_backgroundColor = backgroundColor;
+    m_penColor = penColor;
+    m_brushColor = brushColor;
 
     QGroupBox* sizeGroupBox = new QGroupBox(0, Qt::Vertical, tr("Page Size"), this);
 
     QLabel* widthLabel = new QLabel(tr("Width :"), sizeGroupBox);
     QLabel* heightLabel = new QLabel(tr("Height :"), sizeGroupBox);
 
     m_pWidthSpinBox = new QSpinBox(1, 1024, 1, sizeGroupBox);
     m_pHeightSpinBox = new QSpinBox(1, 1024, 1, sizeGroupBox);
 
     m_pWidthSpinBox->setValue(width);
     m_pHeightSpinBox->setValue(height);
 
-    m_pContentButtonGroup = new QButtonGroup(0, Qt::Vertical, tr("Contents"), this);
+    m_pContentButtonGroup = new QButtonGroup(0, Qt::Vertical, tr("Background"), this);
 
     QRadioButton* whiteColorRadioButton = new QRadioButton(tr("White"), m_pContentButtonGroup);
-    QRadioButton* foregroundColorRadioButton = new QRadioButton(tr("Foreground Color"), m_pContentButtonGroup);
-    QRadioButton* backgroundColorRadioButton = new QRadioButton(tr("Background Color"), m_pContentButtonGroup);
+    QRadioButton* penColorRadioButton = new QRadioButton(tr("Pen Color"), m_pContentButtonGroup);
+    QRadioButton* brushColorRadioButton = new QRadioButton(tr("Brush Color"), m_pContentButtonGroup);
 
     m_pContentButtonGroup->setButton(0);
 
     QVBoxLayout* mainLayout = new QVBoxLayout(this, 4, 4);
     sizeGroupBox->layout()->setSpacing(4);
     m_pContentButtonGroup->layout()->setSpacing(4);
@@ -59,14 +59,14 @@ NewPageDialog::NewPageDialog(uint width, uint height, const QColor& foregroundCo
     sizeLayout->addWidget(m_pWidthSpinBox, 0, 1);
     sizeLayout->addWidget(m_pHeightSpinBox, 1, 1);
 
     sizeLayout->setColStretch(1, 1);
 
     contentLayout->addWidget(whiteColorRadioButton);
-    contentLayout->addWidget(foregroundColorRadioButton);
-    contentLayout->addWidget(backgroundColorRadioButton);
+    contentLayout->addWidget(penColorRadioButton);
+    contentLayout->addWidget(brushColorRadioButton);
 
     mainLayout->addWidget(sizeGroupBox);
     mainLayout->addWidget(m_pContentButtonGroup);
 }
 
 NewPageDialog::~NewPageDialog()
@@ -87,16 +87,16 @@ const QColor& NewPageDialog::selectedColor()
 {
     switch (m_pContentButtonGroup->id(m_pContentButtonGroup->selected())) {
         case 0:
             return (Qt::white);
             break;
         case 1:
-            return (m_foregroundColor);
+            return (m_penColor);
             break;
         case 2:
-            return (m_backgroundColor);
+            return (m_brushColor);
             break;
         default:
             return (Qt::white);
             break;
     }
 }
diff --git a/noncore/graphics/drawpad/newpagedialog.h b/noncore/graphics/drawpad/newpagedialog.h
index f418340..d680394 100644
--- a/noncore/graphics/drawpad/newpagedialog.h
+++ b/noncore/graphics/drawpad/newpagedialog.h
@@ -33,13 +33,13 @@ public:
     const QColor& selectedColor();
 
 private:
     QSpinBox* m_pWidthSpinBox;
     QSpinBox* m_pHeightSpinBox;
 
-    QColor m_foregroundColor;
-    QColor m_backgroundColor;
+    QColor m_penColor;
+    QColor m_brushColor;
 
     QButtonGroup* m_pContentButtonGroup;
 };
 
 #endif // NEWPAGEDIALOG_H