more work on configuring unsupported cards

5 files changed, 53 insertions, 17 deletions

diff --git a/noncore/applets/pcmcia/configdialog.cpp b/noncore/applets/pcmcia/configdialog.cpp
index e161d18..9fcf58c 100644
--- a/noncore/applets/pcmcia/configdialog.cpp
+++ b/noncore/applets/pcmcia/configdialog.cpp
@@ -29,52 +29,70 @@
 
 #include "configdialog.h"
 
 /* OPIE */
 #include <opie2/oconfig.h>
 #include <opie2/odebug.h>
+#include <opie2/opcmciasystem.h>
 using namespace Opie::Core;
 
 /* QT */
 #include <qcombobox.h>
 #include <qdir.h>
 #include <qfile.h>
+#include <qgroupbox.h>
 #include <qlabel.h>
 #include <qtextstream.h>
 
-ConfigDialog::ConfigDialog( const QString& cardname, QWidget* parent )
+ConfigDialog::ConfigDialog( const OPcmciaSocket* card, QWidget* parent )
              :ConfigDialogBase( parent, "pcmcia config dialog", true )
 {
-    //setCaption( tr( "Configure %1" ).arg( cardname ) );
-    txtCardName->setText( cardname );
+    gbDetails->setTitle( QString( "Details for '%1'" ).arg( card->identity() ) );
+    txtCardName->setText( card->productIdentity().join( " " ) );
+    txtManfid->setText( card->manufacturerIdentity() );
+    txtFunction->setText( card->function() );
 
     OConfig cfg( "PCMCIA" );
     cfg.setGroup( "Global" );
     int nCards = cfg.readNumEntry( "nCards", 0 );
     QString insert;
 
     for ( int i = 0; i < nCards; ++i )
     {
         QString cardSection = QString( "Card_%1" ).arg( i );
         cfg.setGroup( cardSection );
         QString name = cfg.readEntry( "name" );
-        odebug << "comparing card '" << cardname << "' with known card '" << name << "'" << oendl;
-        if ( cardname == name )
+        odebug << "comparing card '" << card->name() << "' with known card '" << name << "'" << oendl;
+        if ( card->name() == name )
         {
             insert = cfg.readEntry( "insert" );
             break;
         }
     }
-    odebug << "preferred action for card '" << cardname << "' seems to be '" << insert << "'" << oendl;
+    odebug << "preferred action for card '" << card->name() << "' seems to be '" << insert << "'" << oendl;
 
     if ( !insert.isEmpty() )
     {
         for ( int i; i < cbAction->count(); ++i )
             if ( cbAction->text( i ) == insert ) cbAction->setCurrentItem( i );
     }
 
+    if ( !card->isUnsupported() )
+    {
+        odebug << "card is recognized - hiding bindings" << oendl;
+        textBindTo->hide();
+        cbBindTo->hide();
+        return;
+    }
+    else
+    {
+        odebug << "card is unsupported yet - showing possible bindings" << oendl;
+        textBindTo->show();
+        cbBindTo->show();
+    }
+
     // parse possible bind entries out of /etc/pcmcia/*.conf
     typedef QMap<QString,QString> StringMap;
     StringMap bindEntries;
 
     QDir pcmciaconfdir( "/etc/pcmcia", "*.conf" );
 
@@ -105,13 +123,13 @@ ConfigDialog::ConfigDialog( const QString& cardname, QWidget* parent )
             continue;
         }
     }
 
     for ( StringMap::Iterator it = bindEntries.begin(); it != bindEntries.end(); ++it )
     {
-        odebug << "found device '" << it.key() << "' defined in '" << it.data().latin1() << "'" << oendl;
+        odebug << "found binding '" << it.key() << "' defined in '" << it.data().latin1() << "'" << oendl;
         cbBindTo->insertItem( it.key() );
     }
 }
 
 ConfigDialog::~ConfigDialog()
 {
diff --git a/noncore/applets/pcmcia/configdialog.h b/noncore/applets/pcmcia/configdialog.h
index f79d7a6..3c7fe85 100644
--- a/noncore/applets/pcmcia/configdialog.h
+++ b/noncore/applets/pcmcia/configdialog.h
@@ -29,16 +29,18 @@
 
 #ifndef CONFIGDIALOG_H
 #define CONFIGDIALOG_H
 
 #include "configdialogbase.h"
 
+namespace Opie { namespace Core { class OPcmciaSocket; }; };
+
 class ConfigDialog : public ConfigDialogBase
 {
   Q_OBJECT
   public:
 
-    ConfigDialog( const QString& cardname, QWidget* parent );
+    ConfigDialog( const Opie::Core::OPcmciaSocket* card, QWidget* parent );
     ~ConfigDialog();
 };
 
 #endif
diff --git a/noncore/applets/pcmcia/configdialogbase.ui b/noncore/applets/pcmcia/configdialogbase.ui
index a0760d6..7ec3a75 100644
--- a/noncore/applets/pcmcia/configdialogbase.ui
+++ b/noncore/applets/pcmcia/configdialogbase.ui
@@ -8,14 +8,14 @@
     </property>
     <property stdset="1">
         <name>geometry</name>
         <rect>
             <x>0</x>
             <y>0</y>
-            <width>232</width>
-            <height>206</height>
+            <width>197</width>
+            <height>154</height>
         </rect>
     </property>
     <property stdset="1">
         <name>caption</name>
         <string>Configure PCMCIA/CF Card</string>
     </property>
@@ -50,13 +50,13 @@
             <property stdset="1">
                 <name>name</name>
                 <cstring>TextLabel2</cstring>
             </property>
             <property stdset="1">
                 <name>text</name>
-                <string>Upon insertion,</string>
+                <string>On insertion,</string>
             </property>
         </widget>
         <widget row="2"  column="1" >
             <class>QComboBox</class>
             <item>
                 <property>
@@ -91,15 +91,26 @@
             <class>QComboBox</class>
             <property stdset="1">
                 <name>name</name>
                 <cstring>cbBindTo</cstring>
             </property>
             <property stdset="1">
+                <name>sizePolicy</name>
+                <sizepolicy>
+                    <hsizetype>5</hsizetype>
+                    <vsizetype>0</vsizetype>
+                </sizepolicy>
+            </property>
+            <property stdset="1">
                 <name>editable</name>
                 <bool>true</bool>
             </property>
+            <property stdset="1">
+                <name>autoResize</name>
+                <bool>false</bool>
+            </property>
         </widget>
         <widget row="3"  column="0" >
             <class>QLabel</class>
             <property stdset="1">
                 <name>name</name>
                 <cstring>textBindTo</cstring>
@@ -110,13 +121,13 @@
             </property>
         </widget>
         <widget row="0"  column="0"  rowspan="1"  colspan="3" >
             <class>QGroupBox</class>
             <property stdset="1">
                 <name>name</name>
-                <cstring>GroupBox1</cstring>
+                <cstring>gbDetails</cstring>
             </property>
             <property stdset="1">
                 <name>title</name>
                 <string>Details</string>
             </property>
             <property>
diff --git a/noncore/applets/pcmcia/pcmcia.cpp b/noncore/applets/pcmcia/pcmcia.cpp
index 6c18e86..fac7065 100644
--- a/noncore/applets/pcmcia/pcmcia.cpp
+++ b/noncore/applets/pcmcia/pcmcia.cpp
@@ -71,12 +71,13 @@ PcmciaManager::PcmciaManager( QWidget * parent ) : QWidget( parent )
              SLOT( cardMessage(const QCString&,const QByteArray&) ) );
 
     setFocusPolicy( NoFocus );
     setFixedWidth ( AppLnk::smallIconSize() );
     setFixedHeight ( AppLnk::smallIconSize() );
     pm = Opie::Core::OResource::loadPixmap( "cardmon/pcmcia", Opie::Core::OResource::SmallIcon );
+    configuring = false;
 }
 
 
 PcmciaManager::~PcmciaManager()
 {
 }
@@ -107,13 +108,13 @@ void PcmciaManager::popUp( QString message, QString icon )
 
 void PcmciaManager::popupTimeout()
 {
     popupMenu->hide();
 }
 
-enum { EJECT, INSERT, SUSPEND, RESUME, CONFIGURE };
+enum { EJECT, INSERT, SUSPEND, RESUME, RESET, CONFIGURE };
 
 void PcmciaManager::mousePressEvent( QMouseEvent* )
 {
     QPopupMenu* menu = new QPopupMenu( this );
     QStringList cmd;
     bool execute = true;
@@ -127,19 +128,20 @@ void PcmciaManager::mousePressEvent( QMouseEvent* )
     {
         QPopupMenu* submenu = new QPopupMenu( menu );
         submenu->insertItem( "&Eject",     EJECT+i*100 );
         submenu->insertItem( "&Insert",    INSERT+i*100 );
         submenu->insertItem( "&Suspend",   SUSPEND+i*100 );
         submenu->insertItem( "&Resume",    RESUME+i*100 );
+        submenu->insertItem( "Rese&t",     RESET+i*100 );
         submenu->insertItem( "&Configure", CONFIGURE+i*100 );
 
         submenu->setItemEnabled( EJECT+i*100, !it.current()->isEmpty() );
         submenu->setItemEnabled( INSERT+i*100, it.current()->isEmpty() );
         submenu->setItemEnabled( SUSPEND+i*100, !it.current()->isEmpty() && !it.current()->isSuspended() );
         submenu->setItemEnabled( RESUME+i*100, !it.current()->isEmpty() && it.current()->isSuspended() );
-        submenu->setItemEnabled( CONFIGURE+i*100, !it.current()->isEmpty() );
+        submenu->setItemEnabled( CONFIGURE+i*100, !it.current()->isEmpty() && !configuring );
 
         connect( submenu, SIGNAL(activated(int)), this, SLOT(userCardAction(int)) );
         menu->insertItem( tr( "%1: %2" ).arg( i++ ).arg( it.current()->identity() ), submenu, 1 );
         ++it;
     }
 
@@ -268,14 +270,16 @@ void PcmciaManager::userCardAction( int action )
         default: odebug << "not yet implemented";
     }
 }
 
 void PcmciaManager::configure( OPcmciaSocket* card )
 {
-    ConfigDialog dialog( card->identity(), qApp->desktop() );
-    int configresult = dialog.exec();
+    configuring = true;
+    ConfigDialog dialog( card, qApp->desktop() );
+    int configresult = QPEApplication::execDialog( &dialog, false );
+    configuring = false;
     odebug << "pcmcia: configresult = " << configresult << oendl;
 }
 
 
 EXPORT_OPIE_APPLET_v1( PcmciaManager )
 
diff --git a/noncore/applets/pcmcia/pcmcia.h b/noncore/applets/pcmcia/pcmcia.h
index ed86579..a453c1b 100644
--- a/noncore/applets/pcmcia/pcmcia.h
+++ b/noncore/applets/pcmcia/pcmcia.h
@@ -56,13 +56,14 @@ class PcmciaManager : public QWidget
   private:
     void configure( Opie::Core::OPcmciaSocket* );
     void execCommand( const QStringList &command );
     void popUp(QString message, QString icon = QString::null );
 
   private:
-    int m_commandOrig;
+    bool configuring;
+    int commandOrig;
     QPixmap pm;
     QPopupMenu *popupMenu;
 
 };
 
 #endif