settings...

3 files changed, 204 insertions, 71 deletions

diff --git a/noncore/settings/netsystemtime/ntp.cpp b/noncore/settings/netsystemtime/ntp.cpp
index b2f192a..52fc6be 100644
--- a/noncore/settings/netsystemtime/ntp.cpp
+++ b/noncore/settings/netsystemtime/ntp.cpp
@@ -3,12 +3,13 @@
 #include <qregexp.h>
 #include <qtable.h>
 #include <qlabel.h>
 #include <qsocket.h>
 #include <qlineedit.h>
 #include <qspinbox.h>
+#include <qmessagebox.h>
 #include <qmultilineedit.h>
 #include <opie/oprocess.h>
 #include <qpe/config.h>
 #include <qpe/global.h>
 #include <qpe/timeconversion.h>
 #include <qpe/tzselect.h>
@@ -23,14 +24,14 @@ Ntp::Ntp( QWidget* parent,  const char* name, WFlags fl )
     : SetDateTime( parent, name, fl )
 {
 	Config cfg("ntp",Config::User);
   cfg.setGroup("settings");
 // 	_maxOffset = cfg.readNumEntry("maxOffset",5);
 //  _minLookupDiff = cfg.readNumEntry("minLookupDiff",10);
-	SpinBoxMinDelay->setValue( cfg.readNumEntry("minLookupDiff",10) );
-	SpinBoxMinDelay->setMinValue( 7 );
+	SpinBoxMinLookupDelay->setValue( cfg.readNumEntry("minLookupDiff",60) );
+	SpinBoxNtpDelay->setValue( cfg.readNumEntry("ntpRefreshFreq",60) );
   LineEditNtpSrv->setText( cfg.readEntry("ntpServer", tr("time.fu-berlin.de")) );
  	ntpProcess = new OProcess( );
 
   QSocket *ntpSock = new QSocket( this );
   ntpSock->connectToHost( LineEditNtpSrv->text() ,123);
   connect( ntpSock, SIGNAL( error(int) ),
@@ -49,18 +50,37 @@ Ntp::Ntp( QWidget* parent,  const char* name, WFlags fl )
 
 Ntp::~Ntp()
 {
 	Config cfg("ntp",Config::User);
   cfg.setGroup("settings");
   cfg.writeEntry("ntpServer", LineEditNtpSrv->text());
-  cfg.writeEntry( "minLookupDiff", SpinBoxMinDelay->value() );
+  cfg.writeEntry( "minLookupDiff", SpinBoxMinLookupDelay->value() );
+ 	cfg.writeEntry( "ntpRefreshFreq", SpinBoxNtpDelay->value() );
 }
 
 
 void Ntp::slotRunNtp()
 {
+	Config cfg("ntp",Config::User);
+  cfg.setGroup("lookups");
+  int lookupDiff = TimeConversion::toUTC(QDateTime::currentDateTime()) - cfg.readNumEntry("time",0);
+
+  if ( lookupDiff < SpinBoxNtpDelay->value()*60 )
+  {
+  	switch (
+   	 QMessageBox::warning(this, tr("Run ntp?"),
+     tr("You asked for a delay of ")+SpinBoxNtpDelay->text()+tr(" minutes, but only ")+
+     QString::number(lookupDiff%60)+tr(" minutes elapsed since last loopup.")+
+     "<br>"+tr("Rerun ntp?"),
+     QMessageBox::Ok,QMessageBox::Cancel)
+   	) {
+	    	case QMessageBox::Ok:     break;
+  	   	case QMessageBox::Cancel: return;
+    	  default: return;
+      }
+  }
 	TextLabelStartTime->setText(QDateTime::currentDateTime().toString());
 	ntpProcess->clearArguments();
 	*ntpProcess << "ntpdate" << LineEditNtpSrv->text();
 	bool ret = ntpProcess->start(OProcess::NotifyOnExit,OProcess::AllOutput);
   if ( !ret ) {
      qDebug("Error while executing ntp");
@@ -92,47 +112,26 @@ void  Ntp::ntpFinished(OProcess*)
   cfg.writeEntry("time", time);
  	
   float timeShift = getTimeShift();
   if (timeShift == 0.0) return;
  	int secsSinceLast = time - lastLookup;
   TextLabelNewTime->setText(QDateTime::currentDateTime().toString());
-  if ( lastLookup > 0 && secsSinceLast > 60*24* SpinBoxMinDelay->value())
+  TextLabelTimeShift->setText(QString::number(timeShift)+tr(" seconds"));
+  if ( lastLookup > 0 && secsSinceLast > 60* SpinBoxMinLookupDelay->value())
   {
 	  lookupCount++;
    	cfg.writeEntry("count",lookupCount);
 	  cfg.setGroup("lookup_"+QString::number(lookupCount));
     _shiftPerSec =  timeShift / secsSinceLast;
 //    float nextCorr = _maxOffset / _shiftPerSec;
    	qDebug("secs since last lookup %i", secsSinceLast);qDebug("timeshift since last lookup %f", timeShift);qDebug("timeshift since per sec %f", _shiftPerSec);
 		cfg.writeEntry("secsSinceLast",secsSinceLast);
 		cfg.writeEntry("timeShift",QString::number(timeShift));
   }
 }
 
-//void Ntp::correctClock()
-//{
-//	qDebug("current time: %s",QDateTime::currentDateTime().toString().latin1());
-//	Config cfg("ntp",Config::User);
-//  cfg.setGroup("correction");
-// 	int lastTime = cfg.readNumEntry("time",0);
-//  if ( lastTime == 0 )
-//  {
-//   	return;
-//  }
-//  int now = TimeConversion::toUTC( QDateTime::currentDateTime() );
-//  int corr = int((now - lastTime) * _shiftPerSec);
-//  struct timeval myTv;
-//  myTv.tv_sec = TimeConversion::toUTC( QDateTime::currentDateTime().addSecs(corr) );
-//  myTv.tv_usec = 0;
-//
-//  if ( myTv.tv_sec != -1 )
-//      ::settimeofday( &myTv, 0 );
-//  Global::writeHWClock();
-//  cfg.writeEntry("time",now);
-//	qDebug("current time: %s",QDateTime::currentDateTime().toString().latin1());
-//}
 
 float Ntp::getTimeShift()
 {
 	QString _offset = "offset";
   QString _sec = "sec";
   QRegExp _reOffset = QRegExp(_offset);
@@ -140,13 +139,12 @@ float Ntp::getTimeShift()
   int posOffset = _reOffset.match( _ntpOutput );
   int posEndOffset = _reEndOffset.match( _ntpOutput, posOffset );
   posOffset += _offset.length() + 1;
   QString diff = _ntpOutput.mid(posOffset, posEndOffset-posOffset-1);
   qDebug("%s", _ntpOutput.latin1());
   qDebug("diff = >%s<",diff.latin1());
-  TextLabelTimeShift->setText(diff);
   return diff.toFloat();
 }
 
 void Ntp::readLookups()
 {
 	Config cfg("ntp",Config::User);
@@ -161,12 +159,14 @@ void Ntp::readLookups()
   TableLookups->horizontalHeader()->setLabel(0,"shift/s");
   int cw = 50;//TableLookups->width()/4;
   qDebug("column width %i",cw);
   TableLookups->setColumnWidth( 0, cw+30 );
   TableLookups->setColumnWidth( 1, cw );
   TableLookups->setColumnWidth( 2, cw );
+  TableLookups->sortColumn(0, false, true );
+ // TableLookups->setSorting( true );
   for (int i=0; i < lookupCount; i++)
   {
 	  cfg.setGroup("lookup_"+QString::number(i));
    	last = cfg.readEntry("secsSinceLast",0).toFloat();
     shift = QString(cfg.readEntry("timeShift",0)).toFloat();
 //   	qDebug("%i last %f",i,last);
@@ -175,13 +175,13 @@ void Ntp::readLookups()
     _shiftPerSec += shiftPerSec;
 		TableLookups->setText( i,0,QString::number(shiftPerSec));
 		TableLookups->setText( i,2,QString::number(shift));
 	  TableLookups->setText( i,1,QString::number(last));
   }
   _shiftPerSec /= lookupCount+1;
-  TextLabelShift->setText(QString::number(_shiftPerSec));
+  TextLabelShift->setText(QString::number(_shiftPerSec)+tr(" seconds"));
 }
 
 void Ntp::preditctTime()
 {
 	qDebug("current time: %s",QDateTime::currentDateTime().toString().latin1());
 	Config cfg("ntp",Config::User);
@@ -189,13 +189,13 @@ void Ntp::preditctTime()
  	int lastTime = cfg.readNumEntry("time",0);
   setenv( "TZ", tz->currentZone(), 1 );
   int now = TimeConversion::toUTC( QDateTime::currentDateTime() );
   int corr = int((now - lastTime) * _shiftPerSec);
   predictedTime = QDateTime::currentDateTime().addSecs(corr);
  	TextLabelPredTime->setText(predictedTime.toString());
-  TextLabelMainPredTime->setText(predictedTime.toString());
+  TextLabelMainPredTime->setText(tr("Predicted time:")+"<br><b>"+predictedTime.toString()+"</b>");
 }
 
 void Ntp::setPredictTime()
 {
   preditctTime();
  	setTime( predictedTime );
@@ -207,10 +207,10 @@ void Ntp::slotCheckNtp(int i)
  	{
     TextLabelMainPredTime->hide();
     ButtonSetTime->setText( tr("Get time from network") );
 	  connect( ButtonSetTime, SIGNAL(clicked()), SLOT(slotRunNtp()) );
   }else{
 	  preditctTime();
-		ButtonSetTime->setText( tr("Predict time") );
+		ButtonSetTime->setText( tr("Set predicted time") );
   	connect( ButtonSetTime, SIGNAL(clicked()), SLOT(setPredictTime()) );
   };
 }
diff --git a/noncore/settings/netsystemtime/ntpbase.ui b/noncore/settings/netsystemtime/ntpbase.ui
index e444065..8d32849 100644
--- a/noncore/settings/netsystemtime/ntpbase.ui
+++ b/noncore/settings/netsystemtime/ntpbase.ui
@@ -8,14 +8,14 @@
     </property>
     <property stdset="1">
         <name>geometry</name>
         <rect>
             <x>0</x>
             <y>0</y>
-            <width>276</width>
-            <height>337</height>
+            <width>330</width>
+            <height>419</height>
         </rect>
     </property>
     <property stdset="1">
         <name>caption</name>
         <string>Network Time</string>
     </property>
@@ -29,13 +29,13 @@
         <property stdset="1">
             <name>margin</name>
             <number>2</number>
         </property>
         <property stdset="1">
             <name>spacing</name>
-            <number>1</number>
+            <number>2</number>
         </property>
         <widget row="0"  column="0" >
             <class>QTabWidget</class>
             <property stdset="1">
                 <name>name</name>
                 <cstring>TabWidgetMain</cstring>
@@ -56,17 +56,17 @@
                     <name>title</name>
                     <string>Main</string>
                 </attribute>
                 <grid>
                     <property stdset="1">
                         <name>margin</name>
-                        <number>3</number>
+                        <number>2</number>
                     </property>
                     <property stdset="1">
                         <name>spacing</name>
-                        <number>3</number>
+                        <number>2</number>
                     </property>
                     <widget row="0"  column="0" >
                         <class>QFrame</class>
                         <property stdset="1">
                             <name>name</name>
                             <cstring>FrameSystemTime</cstring>
@@ -92,17 +92,17 @@
                     <name>title</name>
                     <string>NTP</string>
                 </attribute>
                 <grid>
                     <property stdset="1">
                         <name>margin</name>
-                        <number>3</number>
+                        <number>1</number>
                     </property>
                     <property stdset="1">
                         <name>spacing</name>
-                        <number>3</number>
+                        <number>2</number>
                     </property>
                     <widget row="1"  column="0" >
                         <class>QPushButton</class>
                         <property stdset="1">
                             <name>name</name>
                             <cstring>runNtp</cstring>
@@ -126,20 +126,23 @@
                             <name>frameShadow</name>
                             <enum>Raised</enum>
                         </property>
                         <property>
                             <name>layoutMargin</name>
                         </property>
+                        <property>
+                            <name>layoutSpacing</name>
+                        </property>
                         <grid>
                             <property stdset="1">
                                 <name>margin</name>
-                                <number>11</number>
+                                <number>2</number>
                             </property>
                             <property stdset="1">
                                 <name>spacing</name>
-                                <number>6</number>
+                                <number>2</number>
                             </property>
                             <widget row="0"  column="0" >
                                 <class>QLayoutWidget</class>
                                 <property stdset="1">
                                     <name>name</name>
                                     <cstring>Layout4</cstring>
@@ -250,15 +253,25 @@
                                 <class>QMultiLineEdit</class>
                                 <property stdset="1">
                                     <name>name</name>
                                     <cstring>MultiLineEditntpOutPut</cstring>
                                 </property>
                                 <property stdset="1">
+                                    <name>font</name>
+                                    <font>
+                                        <pointsize>7</pointsize>
+                                    </font>
+                                </property>
+                                <property stdset="1">
                                     <name>wordWrap</name>
                                     <enum>WidgetWidth</enum>
                                 </property>
+                                <property stdset="1">
+                                    <name>text</name>
+                                    <string></string>
+                                </property>
                             </widget>
                         </grid>
                     </widget>
                 </grid>
             </widget>
             <widget>
@@ -379,17 +392,17 @@
                     <name>title</name>
                     <string>Settings</string>
                 </attribute>
                 <grid>
                     <property stdset="1">
                         <name>margin</name>
-                        <number>3</number>
+                        <number>2</number>
                     </property>
                     <property stdset="1">
                         <name>spacing</name>
-                        <number>3</number>
+                        <number>2</number>
                     </property>
                     <widget row="0"  column="0" >
                         <class>QFrame</class>
                         <property stdset="1">
                             <name>name</name>
                             <cstring>FrameSettings</cstring>
@@ -399,20 +412,26 @@
                             <enum>StyledPanel</enum>
                         </property>
                         <property stdset="1">
                             <name>frameShadow</name>
                             <enum>Raised</enum>
                         </property>
+                        <property>
+                            <name>layoutMargin</name>
+                        </property>
+                        <property>
+                            <name>layoutSpacing</name>
+                        </property>
                         <grid>
                             <property stdset="1">
                                 <name>margin</name>
-                                <number>11</number>
+                                <number>3</number>
                             </property>
                             <property stdset="1">
                                 <name>spacing</name>
-                                <number>6</number>
+                                <number>11</number>
                             </property>
                             <widget row="0"  column="0" >
                                 <class>QLayoutWidget</class>
                                 <property stdset="1">
                                     <name>name</name>
                                     <cstring>Layout6</cstring>
@@ -423,13 +442,62 @@
                                         <number>0</number>
                                     </property>
                                     <property stdset="1">
                                         <name>spacing</name>
                                         <number>6</number>
                                     </property>
-                                    <spacer row="2"  column="0" >
+                                    <widget row="0"  column="0" >
+                                        <class>QLabel</class>
+                                        <property stdset="1">
+                                            <name>name</name>
+                                            <cstring>TextLabel7_2</cstring>
+                                        </property>
+                                        <property stdset="1">
+                                            <name>text</name>
+                                            <string>Use</string>
+                                        </property>
+                                    </widget>
+                                    <widget row="0"  column="2" >
+                                        <class>QLabel</class>
+                                        <property stdset="1">
+                                            <name>name</name>
+                                            <cstring>TextLabel2_2</cstring>
+                                        </property>
+                                        <property stdset="1">
+                                            <name>text</name>
+                                            <string>as</string>
+                                        </property>
+                                    </widget>
+                                    <widget row="1"  column="0"  rowspan="1"  colspan="2" >
+                                        <class>QLabel</class>
+                                        <property stdset="1">
+                                            <name>name</name>
+                                            <cstring>TextLabel1_3</cstring>
+                                        </property>
+                                        <property stdset="1">
+                                            <name>text</name>
+                                            <string>NTP server to get the time from the network.</string>
+                                        </property>
+                                        <property stdset="1">
+                                            <name>alignment</name>
+                                            <set>WordBreak|AlignVCenter|AlignLeft</set>
+                                        </property>
+                                        <property>
+                                            <name>wordwrap</name>
+                                        </property>
+                                    </widget>
+                                    <widget row="0"  column="1" >
+                                        <class>QLineEdit</class>
+                                        <property stdset="1">
+                                            <name>name</name>
+                                            <cstring>LineEditNtpSrv</cstring>
+                                        </property>
+                                    </widget>
+                                </grid>
+                            </widget>
+                            <spacer row="3"  column="0" >
                                         <property>
                                             <name>name</name>
                                             <cstring>Spacer2</cstring>
                                         </property>
                                         <property stdset="1">
                                             <name>orientation</name>
@@ -444,92 +512,153 @@
                                             <size>
                                                 <width>20</width>
                                                 <height>20</height>
                                             </size>
                                         </property>
                                     </spacer>
-                                    <widget row="1"  column="0" >
+                            <widget row="2"  column="0" >
                                         <class>QLayoutWidget</class>
                                         <property stdset="1">
                                             <name>name</name>
-                                            <cstring>Layout6</cstring>
+                                    <cstring>Layout7</cstring>
                                         </property>
-                                        <hbox>
+                                <grid>
                                             <property stdset="1">
                                                 <name>margin</name>
                                                 <number>0</number>
                                             </property>
                                             <property stdset="1">
                                                 <name>spacing</name>
                                                 <number>6</number>
                                             </property>
-                                            <widget>
+                                    <widget row="0"  column="0" >
                                                 <class>QLabel</class>
                                                 <property stdset="1">
                                                     <name>name</name>
-                                                    <cstring>TextLabel7_2</cstring>
+                                            <cstring>TextLabel1_2</cstring>
                                                 </property>
                                                 <property stdset="1">
                                                     <name>text</name>
-                                                    <string>NTP Server:</string>
+                                            <string>Insure a delay of</string>
                                                 </property>
                                             </widget>
-                                            <widget>
-                                                <class>QLineEdit</class>
+                                    <widget row="0"  column="2" >
+                                        <class>QLabel</class>
                                                 <property stdset="1">
                                                     <name>name</name>
-                                                    <cstring>LineEditNtpSrv</cstring>
+                                            <cstring>TextLabel2</cstring>
+                                        </property>
+                                        <property stdset="1">
+                                            <name>text</name>
+                                            <string>minutes until</string>
                                                 </property>
                                             </widget>
-                                        </hbox>
+                                    <widget row="1"  column="0"  rowspan="1"  colspan="3" >
+                                        <class>QLabel</class>
+                                        <property stdset="1">
+                                            <name>name</name>
+                                            <cstring>TextLabel3_3</cstring>
+                                        </property>
+                                        <property stdset="1">
+                                            <name>text</name>
+                                            <string>a new NTP lookup will be used to predict the time.</string>
+                                        </property>
+                                        <property stdset="1">
+                                            <name>alignment</name>
+                                            <set>WordBreak|AlignVCenter|AlignLeft</set>
+                                        </property>
+                                        <property>
+                                            <name>wordwrap</name>
+                                        </property>
                                     </widget>
-                                    <widget row="0"  column="0" >
+                                    <widget row="0"  column="1" >
+                                        <class>QSpinBox</class>
+                                        <property stdset="1">
+                                            <name>name</name>
+                                            <cstring>SpinBoxMinLookupDelay</cstring>
+                                        </property>
+                                        <property stdset="1">
+                                            <name>maxValue</name>
+                                            <number>9999999</number>
+                                        </property>
+                                        <property stdset="1">
+                                            <name>minValue</name>
+                                            <number>42</number>
+                                        </property>
+                                    </widget>
+                                </grid>
+                            </widget>
+                            <widget row="1"  column="0" >
                                         <class>QLayoutWidget</class>
                                         <property stdset="1">
                                             <name>name</name>
-                                            <cstring>Layout5</cstring>
+                                    <cstring>Layout7_2</cstring>
                                         </property>
-                                        <hbox>
+                                <grid>
                                             <property stdset="1">
                                                 <name>margin</name>
                                                 <number>0</number>
                                             </property>
                                             <property stdset="1">
                                                 <name>spacing</name>
                                                 <number>6</number>
                                             </property>
-                                            <widget>
+                                    <widget row="0"  column="0" >
                                                 <class>QLabel</class>
                                                 <property stdset="1">
                                                     <name>name</name>
-                                                    <cstring>TextLabel1_2</cstring>
+                                            <cstring>TextLabel1_2_2</cstring>
                                                 </property>
                                                 <property stdset="1">
                                                     <name>text</name>
-                                                    <string>Min. delay:</string>
+                                            <string>Wait for</string>
                                                 </property>
                                             </widget>
-                                            <widget>
-                                                <class>QSpinBox</class>
+                                    <widget row="0"  column="2" >
+                                        <class>QLabel</class>
                                                 <property stdset="1">
                                                     <name>name</name>
-                                                    <cstring>SpinBoxMinDelay</cstring>
+                                            <cstring>TextLabel2_3</cstring>
+                                        </property>
+                                        <property stdset="1">
+                                            <name>text</name>
+                                            <string>minutes until</string>
                                                 </property>
                                             </widget>
-                                            <widget>
+                                    <widget row="1"  column="0"  rowspan="1"  colspan="3" >
                                                 <class>QLabel</class>
                                                 <property stdset="1">
                                                     <name>name</name>
-                                                    <cstring>TextLabel2</cstring>
+                                            <cstring>TextLabel3_3_2</cstring>
                                                 </property>
                                                 <property stdset="1">
                                                     <name>text</name>
-                                                    <string>minutes</string>
+                                            <string>NTP syncronises the clock with the network</string>
+                                        </property>
+                                        <property stdset="1">
+                                            <name>alignment</name>
+                                            <set>WordBreak|AlignVCenter|AlignLeft</set>
+                                        </property>
+                                        <property>
+                                            <name>wordwrap</name>
                                                 </property>
                                             </widget>
-                                        </hbox>
+                                    <widget row="0"  column="1" >
+                                        <class>QSpinBox</class>
+                                        <property stdset="1">
+                                            <name>name</name>
+                                            <cstring>SpinBoxNtpDelay</cstring>
+                                        </property>
+                                        <property stdset="1">
+                                            <name>maxValue</name>
+                                            <number>9999999</number>
+                                        </property>
+                                        <property stdset="1">
+                                            <name>minValue</name>
+                                            <number>0</number>
+                                        </property>
                                     </widget>
                                 </grid>
                             </widget>
                         </grid>
                     </widget>
                 </grid>
diff --git a/noncore/settings/netsystemtime/settime.cpp b/noncore/settings/netsystemtime/settime.cpp
index b456012..2398c08 100644
--- a/noncore/settings/netsystemtime/settime.cpp
+++ b/noncore/settings/netsystemtime/settime.cpp
@@ -258,22 +258,22 @@ void  SetDateTime::setTime(QDateTime dt)
 	  cfg.writeEntry("time", t );
 	  myTv.tv_usec = 0;
 
   if ( myTv.tv_sec != -1 )
       ::settimeofday( &myTv, 0 );
   Global::writeHWClock();
+  // since time has changed quickly load in the datebookdb
+  // to allow the alarm server to get a better grip on itself
+  // (example re-trigger alarms for when we travel back in time)
+  DateBookDB db;
 }
 
 void SetDateTime::updateSystem(int i)
 {
 	qDebug("SetDateTime::updateSystem(int %i)",i);
  	writeSettings();
-  // since time has changed quickly load in the datebookdb
-  // to allow the alarm server to get a better grip on itself
-  // (example re-trigger alarms for when we travel back in time)
- // DateBookDB db;
 
     // set the timezone for everyone else...
     QCopEnvelope setTimeZone( "QPE/System", "timeChange(QString)" );
     setTimeZone << tz->currentZone();
 
     // AM/PM setting and notify time changed
@@ -288,12 +288,16 @@ void SetDateTime::updateSystem(int i)
     QCopEnvelope setDateFormat( "QPE/System", "setDateFormat(DateFormat)" );
     setDateFormat << date_formats[dateFormatCombo->currentItem()];
 
     // Restore screensaver
     QCopEnvelope enableScreenSaver( "QPE/System", "setScreenSaverIntervals(int,int,int)" );
     enableScreenSaver << -1 << -1 << -1;
+  // since time has changed quickly load in the datebookdb
+  // to allow the alarm server to get a better grip on itself
+  // (example re-trigger alarms for when we travel back in time)
+  DateBookDB db;
 
 }
 
 void SetDateTime::tzChange( const QString &tz )
 {
 	qDebug("SetDateTime::tzChange");