Change the way categories can be selected, combo box is much more useful than a menu for many different categories

2 files changed, 45 insertions, 84 deletions

diff --git a/libopie2/opiepim/ui/opimmainwindow.cpp b/libopie2/opiepim/ui/opimmainwindow.cpp
index d46df69..a72d174 100644
--- a/libopie2/opiepim/ui/opimmainwindow.cpp
+++ b/libopie2/opiepim/ui/opimmainwindow.cpp
@@ -40,12 +40,13 @@
 #include <qpe/resource.h>
 #include <qpe/sound.h>
 
 /* QT */
 #include <qaction.h>
 #include <qapplication.h>
+#include <qcombobox.h>
 #include <qcopchannel_qws.h>
 #include <qdatetime.h>
 #include <qmenubar.h>
 #include <qobjectlist.h>
 #include <qpopupmenu.h>
 #include <qtoolbar.h>
@@ -236,100 +237,53 @@ void OPimMainWindow::insertItemMenuItems( QActionGroup *items ) {
 
 void OPimMainWindow::insertViewMenuItems( QActionGroup *items ) {
     // Insert menu items into View menu
     if ( items ) {
         // Rebuild Item menu
         m_viewMenu->clear();
-        m_viewMenuCategories->addTo( m_viewMenu );
-        m_viewMenu->insertSeparator();
         m_viewMenuGroup->addTo( m_viewMenu );
         m_viewMenu->insertSeparator();
         m_viewMenuAppGroup = items;
         m_viewMenuAppGroup->addTo( m_viewMenu );
     }
 }
 
-void OPimMainWindow::slotViewCategory( QAction *category ) {
+void OPimMainWindow::slotViewCategory( const QString &category ) {
     // Set application caption
     QString caption = m_appName;
-    if ( category->text() != tr( "All" ) )
-        caption.append( QString( " - %1" ).arg( category->text() ) );
+    if ( category != tr( "All" ) )
+        caption.append( QString( " - %1" ).arg( category ) );
     setCaption( caption );
 
     // Notify application
-    emit categorySelected( category->text() );
+    emit categorySelected( category );
 }
 
 void OPimMainWindow::setViewCategory( const QString &category ) {
-        // Find category in menu
-        QObjectListIt kidIt( *(m_viewMenuCategories->children()) );
-        QObject *obj;
-        while ( (obj=kidIt.current()) != 0 ) {
-            QAction *currAction = reinterpret_cast<QAction*>(obj);
-            if ( currAction->text() == category ) {
-                // Category was found, enable it
-                currAction->setOn( true );
-                return;
-            }
-            ++kidIt;
+    // Find category in list
+    for ( int i = 0; i < m_catSelect->count(); i++ ) {
+        if ( m_catSelect->text( i ) == category ) {
+            m_catSelect->setCurrentItem( i );
+            slotViewCategory( category );
+            return;
         }
+    }
 }
 
 void OPimMainWindow::reloadCategories() {
-    QString selected;
-
-    // Remove old categories from View menu
-    if ( m_viewMenuCategories ) {
-        QObjectListIt kidIt( *(m_viewMenuCategories->children()) );
-        QObject *obj;
-        while ( (obj=kidIt.current()) != 0 ) {
-            QAction *currAction = reinterpret_cast<QAction*>(obj);
-            if ( currAction->isOn() )
-                selected = currAction->text();
-            ++kidIt;
-            delete currAction;
-        }
-    }
-    else {
-        m_viewMenuCategories = new QActionGroup( this );
-        connect( m_viewMenuCategories, SIGNAL(selected(QAction*)), this, SLOT(slotViewCategory(QAction*)) );
+    QString selected = m_catSelect->currentText();
 
-        selected = tr( "All" );
-    }
-
-    m_viewMenu->clear();
-    
-    // Add categories to View menu
-    QAction *a = new QAction( tr( "All" ), QString::null, 0, m_viewMenuCategories, QString::null, true );
-    a->setWhatsThis( tr( "Click here to view all items." ) );
-    a->setOn( selected == tr( "All" ) );
+    // Remove old categories from list
+    m_catSelect->clear();
 
+    // Add categories to list
     Categories cats;
     cats.load( categoryFileName() );
-    QStringList catList = cats.labels( m_catGroupName );
-    for ( QStringList::Iterator it = catList.begin(); it != catList.end(); ++it ) {
-        a = new QAction( tr( (*it) ), QString::null, 0, m_viewMenuCategories, QString::null, true );
-        a->setWhatsThis( tr( "Click here to view items belonging to %1." ).arg( (*it) ) );
-        a->setOn( selected == (*it) );
-    }
-    
-    a = new QAction( tr( "Unfiled" ), QString::null, 0, m_viewMenuCategories, QString::null, true );
-    a->setWhatsThis( tr( "Click here to view all unfiled items." ) );
-    a->setOn( selected == tr( "Unfiled" ) );
-    
-    m_viewMenuCategories->addTo( m_viewMenu );
-
-    // Add default items to View menu
-    m_viewMenu->insertSeparator();
-    m_viewMenuGroup->addTo( m_viewMenu );
-
-    // Insert application-specific items (if any)
-    if ( m_viewMenuAppGroup ) {
-        m_viewMenu->insertSeparator();
-        m_viewMenuAppGroup->addTo( m_viewMenu );
-    }
+    m_catSelect->insertItem( tr( "All" ) );
+    m_catSelect->insertStringList( cats.labels( m_catGroupName ) );
+    m_catSelect->insertItem( tr( "Unfiled" ) );
 }
 
 void OPimMainWindow::initBars( const QString &itemName ) {
     QString itemStr = itemName.lower();
 
     setToolBarsMovable( false );
@@ -339,27 +293,26 @@ void OPimMainWindow::initBars( const QString &itemName ) {
     mbHold->setHorizontalStretchable( true );
     QMenuBar *menubar = new QMenuBar( mbHold );
     menubar->setMargin( 0 );
 
     // Create application menu bar
     QToolBar *toolbar = new QToolBar( this );
-    
+
     // Create sub-menus
     m_itemMenu = new QPopupMenu( this );
     m_itemMenu->setCheckable( true );
     menubar->insertItem( itemName, m_itemMenu );
     m_viewMenu = new QPopupMenu( this );
     m_viewMenu->setCheckable( true );
     menubar->insertItem( tr( "View" ), m_viewMenu );
 
-    m_viewMenuCategories = 0l;
     m_viewMenuAppGroup = 0l;
-    
+
     // Item menu
     m_itemMenuGroup1 = new QActionGroup( this, QString::null, false );
-    
+
     QAction *a = new QAction( tr( "New" ), Resource::loadPixmap( "new" ),
                               QString::null, 0, m_itemMenuGroup1, 0 );
     connect( a, SIGNAL(activated()), this, SLOT(slotItemNew()) );
     a->setWhatsThis( tr( "Click here to create a new item." ) );
     a->addTo( toolbar );
 
@@ -370,13 +323,13 @@ void OPimMainWindow::initBars( const QString &itemName ) {
     m_itemEditAction->addTo( toolbar );
 
     m_itemDuplicateAction = new QAction( tr( "Duplicate" ), Resource::loadPixmap( "copy" ),
                                          QString::null, 0, m_itemMenuGroup1, 0 );
     connect( m_itemDuplicateAction, SIGNAL(activated()), this, SLOT(slotItemDuplicate()) );
     m_itemDuplicateAction->setWhatsThis( tr( "Click here to duplicate the selected item." ) );
-    
+
     m_itemDeleteAction = new QAction( tr( "Delete" ), Resource::loadPixmap( "trash" ),
                                       QString::null, 0, m_itemMenuGroup1, 0 );
     connect( m_itemDeleteAction, SIGNAL(activated()), this, SLOT(slotItemDelete()) );
     m_itemDeleteAction->setWhatsThis( tr( "Click here to delete the selected item." ) );
     m_itemDeleteAction->addTo( toolbar );
 
@@ -392,34 +345,40 @@ void OPimMainWindow::initBars( const QString &itemName ) {
     m_itemMenuGroup1->addTo( m_itemMenu );
 
     m_itemMenu->insertSeparator();
 
     m_itemMenuGroup2 = new QActionGroup( this, QString::null, false );
 
-    a = new QAction( tr( "Find" ), Resource::loadPixmap( "find" ),
-                     QString::null, 0, m_itemMenuGroup2, 0 );
-    connect( a, SIGNAL(activated()), this, SLOT(slotItemFind()) );
-    a->setWhatsThis( tr( "Click here to search for an item." ) );
-    a->addTo( toolbar );
+//     a = new QAction( tr( "Find" ), Resource::loadPixmap( "find" ),
+//                      QString::null, 0, m_itemMenuGroup2, 0 );
+//     connect( a, SIGNAL(activated()), this, SLOT(slotItemFind()) );
+//     a->setWhatsThis( tr( "Click here to search for an item." ) );
+//     a->addTo( toolbar );
 
     a = new QAction( tr( "Configure" ), Resource::loadPixmap( "SettingsIcon" ),
                      QString::null, 0, m_itemMenuGroup2, 0 );
     connect( a, SIGNAL(activated()), this, SLOT(slotConfigure()) );
     a->setWhatsThis( tr( "Click here to set your preferences for this application." ) );
 
     m_itemMenuGroup2->addTo( m_itemMenu );
-    
+
     // View menu
     m_viewMenuGroup = new QActionGroup( this, QString::null, false );
-    
+
     a = new QAction( tr( "Filter" ), QString::null, 0, m_viewMenuGroup, 0 );
     connect( a, SIGNAL(activated()), this, SLOT(slotViewFilter()) );
     a->setWhatsThis( tr( "Click here to filter the items displayed." ) );
-    
+
     a = new QAction( tr( "Filter Settings" ), QString::null, 0, m_viewMenuGroup, 0 );
     connect( a, SIGNAL(activated()), this, SLOT(slotViewFilterSettings()) );
     a->setWhatsThis( tr( "Click here to modify the current filter settings." ) );
 
+    // Create view toolbar
+    toolbar = new QToolBar( this );
+    m_catSelect = new QComboBox( toolbar );
+    connect( m_catSelect, SIGNAL(activated(const QString&)), this, SLOT(slotViewCategory(const QString&)) );
+
+    // Do initial load of categories
     reloadCategories();
 }
 
 } // namespace Opie
diff --git a/libopie2/opiepim/ui/opimmainwindow.h b/libopie2/opiepim/ui/opimmainwindow.h
index 4aed8b8..ffc7feb 100644
--- a/libopie2/opiepim/ui/opimmainwindow.h
+++ b/libopie2/opiepim/ui/opimmainwindow.h
@@ -35,12 +35,13 @@
 #include <qpe/config.h>
 
 #include <qmainwindow.h>
 
 class QAction;
 class QActionGroup;
+class QComboBox;
 class QCopChannel;
 class QDateTime;
 class QPopupMenu;
 
 namespace Opie {
 /**
@@ -104,13 +105,13 @@ protected slots:
     /** UI-related slots */
     virtual void slotItemNew() = 0;
     virtual void slotItemEdit() = 0;
     virtual void slotItemDuplicate() = 0;
     virtual void slotItemDelete() = 0;
     virtual void slotItemBeam() = 0;
-    virtual void slotItemFind() = 0;
+    //virtual void slotItemFind() = 0;
     virtual void slotConfigure() = 0;
 
 protected:
     /**
      * start to play soundAlarm()
      * @param count How many times the alarm is played
@@ -118,26 +119,26 @@ protected:
     void startAlarm( int count = 10 );
     void killAlarm();
     void timerEvent( QTimerEvent* );
 
     /** UI-related functions */
     QPopupMenu *itemContextMenu();
-    
+
     void insertItemMenuItems( QActionGroup *items );
     void insertViewMenuItems( QActionGroup *items );
 
     void setViewCategory( const QString &category );
     void reloadCategories();
-    
+
 private slots:
     void appMessage( const QCString&, const QByteArray& );
     void setDocument( const QString& );
 
     /** UI-related slots */
-    void slotViewCategory( QAction *category );
-    
+    void slotViewCategory( const QString &category );
+
 private:
     class Private;
     Private* d;
 
     int m_rtti;
     QCopChannel* m_channel;
@@ -157,17 +158,18 @@ private:
     QPopupMenu   *m_itemMenu;            // Pointer to item menu
     QPopupMenu   *m_viewMenu;            // Pointer to view menu
     QActionGroup *m_itemMenuGroup1;      // Action group containing default items in Item menu
     QActionGroup *m_itemMenuGroup2;      // Action group containing default items in Item menu
     QActionGroup *m_viewMenuAppGroup;    // Action group containing application items in View menu
     QActionGroup *m_viewMenuGroup;       // Action group containing default items in View menu
-    QActionGroup *m_viewMenuCategories;  // Pointer to action group containing categories in View menu
     QAction      *m_itemEditAction;      // Edit current item action
     QAction      *m_itemDuplicateAction; // Duplicate current item action
     QAction      *m_itemDeleteAction;    // Delete current item action
 
+    QComboBox    *m_catSelect;           // Category selection combo box
+
     /* I would love to do this as a template
      * but can't think of a right way
      * because I need signal and slots -zecke
      */
     virtual OPimRecord* record( int rtti, const QByteArray& ) ;
     int service();