(layout) fixes from zecke (for 0.99)

and some minor things...

9 files changed, 46 insertions, 32 deletions

diff --git a/core/pim/osearch/adresssearch.cpp b/core/pim/osearch/adresssearch.cpp
index 2cd545f..f117fe6 100644
--- a/core/pim/osearch/adresssearch.cpp
+++ b/core/pim/osearch/adresssearch.cpp
@@ -11,24 +11,25 @@
 //
 //
 #include "adresssearch.h"
 
 #include <qstring.h>
 #include <qiconset.h>
-#include <qwhatsthis.h>
+//#include <qwhatsthis.h>
 #include <qpe/resource.h>
 #include <opie/ocontactaccess.h>
 
 #include "contactitem.h"
 
 AdressSearch::AdressSearch(QListView* parent, QString name):
 	SearchGroup(parent, name)
 {
 	_contacts = 0;
 	QIconSet is = Resource::loadIconSet( "addressbook/AddressBook" );
 	setPixmap( 0, is.pixmap( QIconSet::Small, true ) );
+//	QWhatsThis::add( this, QObject::tr("Search the addressbook") );
 /*	QPixmap pix = Resource::loadPixmap( "addressbook/AddressBook" );
 	QImage img = pix.convertToImage();
 	img.smoothScale( 14, 14 );
 	pix.convertFromImage( img );
 	setPixmap( 0, pix );*/
 }
@@ -45,13 +46,13 @@ void AdressSearch::load()
 }
 
 int AdressSearch::search()
 {
 	ORecordList<OContact> results = _contacts->matchRegexp(_search);
 	for (uint i = 0; i < results.count(); i++) {
-		new ContactItem( this, new OContact( results[i] ));
+		(void)new ContactItem( this, new OContact( results[i] ));
 	}
 	return results.count();
 }
 
 void AdressSearch::insertItem( void* )
 {
diff --git a/core/pim/osearch/applnksearch.cpp b/core/pim/osearch/applnksearch.cpp
index 403c719..b15275a 100644
--- a/core/pim/osearch/applnksearch.cpp
+++ b/core/pim/osearch/applnksearch.cpp
@@ -54,13 +54,13 @@ int AppLnkSearch::search()
 	}
 	return _resultCount;
 }
 
 void AppLnkSearch::insertItem( void *rec )
 {
-	new AppLnkItem( this, (AppLnk*)rec );
+	(void)new AppLnkItem( this, (AppLnk*)rec );
 	_resultCount++;
 }
 
 void AppLnkSearch::setSearch(QRegExp re)
 {
 	setOpen( false );
diff --git a/core/pim/osearch/datebooksearch.cpp b/core/pim/osearch/datebooksearch.cpp
index 5da7ae9..be2bf25 100644
--- a/core/pim/osearch/datebooksearch.cpp
+++ b/core/pim/osearch/datebooksearch.cpp
@@ -73,13 +73,13 @@ void DatebookSearch::insertItem( void *rec )
 	      !ev->recurrence().doesRecur()
 	    ) return;
 	if ( !actionSearchInDates->isOn() && (
 	      ev->lastHitField() == Qtopia::StartDateTime ||
  	      ev->lastHitField() == Qtopia::EndDateTime )
 	    ) return;
-	new EventItem( this, ev );
+	(void)new EventItem( this, ev );
 	_resultCount++;
 }
 
 QPopupMenu* DatebookSearch::popupMenu()
 {
 	if (!_popupMenu){
diff --git a/core/pim/osearch/doclnksearch.cpp b/core/pim/osearch/doclnksearch.cpp
index 321d011..3428798 100644
--- a/core/pim/osearch/doclnksearch.cpp
+++ b/core/pim/osearch/doclnksearch.cpp
@@ -73,13 +73,13 @@ bool DocLnkSearch::searchFile( AppLnk *app )
     	}
 	return found;
 }
 
 void DocLnkSearch::insertItem( void *rec )
 {
-	new DocLnkItem( this, (DocLnk*)rec );
+	(void)new DocLnkItem( this, (DocLnk*)rec );
 	_resultCount++;
 }
 
 
 QPopupMenu* DocLnkSearch::popupMenu()
 {
diff --git a/core/pim/osearch/eventitem.cpp b/core/pim/osearch/eventitem.cpp
index 24ce8e8..3228093 100644
--- a/core/pim/osearch/eventitem.cpp
+++ b/core/pim/osearch/eventitem.cpp
@@ -13,12 +13,13 @@
 #include "eventitem.h"
 
 #include <qdatetime.h>
 #include <qpixmap.h>
 #include <qpe/resource.h>
 #include <qpe/qcopenvelope_qws.h>
+//#include <qwhatsthis.h>
 #include <opie/oevent.h>
 
 EventItem::EventItem(OListViewItem* parent, OEvent *event)
  : ResultItem(parent)
 {
 	_event = event;
@@ -59,12 +60,13 @@ QIntDict<QString> EventItem::actions()
 void EventItem::setIcon()
 {
 	QPixmap icon;
 	switch ( _event->lastHitField() ) {
 	case -1:
 		icon = Resource::loadPixmap( "reset" );
+//		QWhatsThis::add( icon, QObject::tr("Enter your search terms here") );
 		break;
 	case Qtopia::DatebookDescription:
 		icon = Resource::loadPixmap( "osearch/summary" );
  		break;
  	case Qtopia::Notes:
 		icon = Resource::loadPixmap( "txt" );
diff --git a/core/pim/osearch/mainwindow.cpp b/core/pim/osearch/mainwindow.cpp
index c6934db..aa52061 100644
--- a/core/pim/osearch/mainwindow.cpp
+++ b/core/pim/osearch/mainwindow.cpp
@@ -16,16 +16,18 @@
 #include <qpopupmenu.h>
 #include <qtoolbutton.h>
 #include <qstring.h>
 #include <qlabel.h>
 #include <qfile.h>
 #include <qhbuttongroup.h>
+#include <qhbox.h>
 #include <qpushbutton.h>
 #include <qintdict.h>
 #include <qlayout.h>
 #include <qlineedit.h>
+#include <qsignalmapper.h>
 #include <qtextbrowser.h>
 #include <qregexp.h>
 #include <qwhatsthis.h>
 #include <qpe/qpemenubar.h>
 #include <qpe/qpemessagebox.h>
 #include <qpe/resource.h>
@@ -68,21 +70,20 @@ MainWindow::MainWindow( QWidget *parent, const char *name, WFlags f ) :
   QVBoxLayout *detailsLayout = new QVBoxLayout( detailsFrame );
   richEdit = new QTextView( detailsFrame );
   QWhatsThis::add( richEdit, tr("The details of the current result") );
   richEdit->setSizePolicy( QSizePolicy( QSizePolicy::MinimumExpanding, QSizePolicy::MinimumExpanding));
   detailsLayout->addWidget( richEdit );
 
-  buttonGroupActions = new QHButtonGroup( this );
-  buttonGroupActions->hide();
-  _buttonCount = 0;
+  buttonBox = new QHBox( mainFrame, "Button Box" );
 
-  buttonLayout = new QHBoxLayout( detailsFrame );
-  detailsLayout->addLayout( buttonLayout );
+  _buttonCount = 0;
 
   mainLayout->addWidget( detailsFrame );
+  mainLayout->addWidget( buttonBox );
   detailsFrame->hide();
+  buttonBox->hide();
 
   searches.append( new AppLnkSearch( resultsList, tr("applications") ) );
   searches.append( new DocLnkSearch( resultsList, tr("documents") ) );
   searches.append( new TodoSearch( resultsList, tr("todo") ) );
   searches.append( new DatebookSearch( resultsList, tr("datebook") ) );
   searches.append( new AdressSearch( resultsList, tr("adressbook") ) );
@@ -93,13 +94,16 @@ MainWindow::MainWindow( QWidget *parent, const char *name, WFlags f ) :
   searchTimer = new QTimer();
 
   connect(popupTimer, SIGNAL(timeout()), SLOT(showPopup()));
   connect(searchTimer, SIGNAL(timeout()), SLOT(searchStringChanged()));
   connect(resultsList, SIGNAL(pressed(QListViewItem*)), SLOT(setCurrent(QListViewItem*)));
   connect(resultsList, SIGNAL(clicked(QListViewItem*)), SLOT(stopTimer(QListViewItem*)));
-  connect(buttonGroupActions, SIGNAL(clicked(int)), SLOT( slotAction(int) ) );
+
+  signalMapper = new QSignalMapper( this );
+
+  connect(signalMapper, SIGNAL(mapped(int)), SLOT( slotAction(int) ) );
 
   makeMenu();
 
    Config cfg( "osearch", Config::User );
    cfg.setGroup( "search_settings" );
    actionCaseSensitiv->setOn( cfg.readBoolEntry( "caseSensitiv", false ) );
@@ -180,28 +184,35 @@ void MainWindow::setCurrent(QListViewItem *item)
 		ResultItem *res = (ResultItem*)item;
 //		ResultItem *res = dynamic_cast<ResultItem*>(item);
 		richEdit->setText( res->toRichText() );
 		QIntDict<QString> acts = res->actions();
 		QButton *button;
 		for (uint i = 0; i < acts.count(); i++){
-			button = buttonGroupActions->find( i );
+			button = buttonMap[i];
 			if (!button) {
-				button = new QPushButton( detailsFrame );
-				buttonLayout->addWidget( button, 0 );
-				buttonGroupActions->insert( button, i);
+			    qWarning(" no button for %s", (*acts[i]).latin1() );
+			    button = new QPushButton( buttonBox );
+			    buttonMap.insert( i,  button );
+                            signalMapper->setMapping(button, i );
+                            connect(button, SIGNAL(clicked() ), signalMapper, SLOT(map() ) );
 			}
 			button->setText( *acts[i] );
 			button->show();
 		}
 		for (uint i = acts.count(); i < _buttonCount; i++){
-			button = buttonGroupActions->find( i );
+			button = buttonMap[i];
 			if (button) button->hide();
 		}
 		_buttonCount = acts.count();
 		detailsFrame->show();
-	}else detailsFrame->hide();
+                buttonBox->show();
+
+	}else {
+            detailsFrame->hide();
+            buttonBox->hide();
+        }
 	popupTimer->start( 300, true );
 }
 
 void MainWindow::stopTimer(QListViewItem*)
 {
         popupTimer->stop();
@@ -250,17 +261,17 @@ void MainWindow::searchAll()
 		//resultsList->repaint();
 	}
 }
 
 void MainWindow::slotAction( int act )
 {
-	if (_currentItem->rtti() == OListViewItem::Result){
+	if ( _currentItem && _currentItem->rtti() == OListViewItem::Result){
 		ResultItem *res = (ResultItem*)_currentItem;
 //		ResultItem *res = dynamic_cast<ResultItem*>(item);
 		res->action(act);
 	}
 }
 
-void MainWindow::optionChanged(int i)
+void MainWindow::optionChanged(int )
 {
 	searchStringChanged();
 }
diff --git a/core/pim/osearch/mainwindow.h b/core/pim/osearch/mainwindow.h
index cba11c5..1f5c4bb 100644
--- a/core/pim/osearch/mainwindow.h
+++ b/core/pim/osearch/mainwindow.h
@@ -10,28 +10,27 @@
 // (c) 2002 Patrick S. Vogt <tille@handhelds.org>
 
 #ifndef MAINWINDOW_H
 #define MAINWINDOW_H
 
 #include <qmainwindow.h>
-#include <qdialog.h>
-#include <qaction.h>
 #include <qlist.h>
-#include <qtimer.h>
-#include <qpopupmenu.h>
+#include <qmap.h>
 
+class QAction;
 class QPEToolBar;
+class QHBox;
 class QVBoxLayout;
-class QHBoxLayout;
 class QTextView;
 class QFrame;
-class QListViewItem;
 class OListView;
 class OListViewItem;
-class QHButtonGroup;
-
+class QListViewItem;
+class QPopupMenu;
+class QSignalMapper;
+class QTimer;
 class SearchGroup;
 
 class MainWindow : public QMainWindow
 {
     Q_OBJECT
 
@@ -49,26 +48,27 @@ public slots:
 protected slots:
   void slotAction(int);
   void showPopup();
   void stopTimer( QListViewItem* );
   void searchStringChanged();
   void optionChanged(int);
-  
+
 private:
+  QHBox *buttonBox;
+  QMap<int, QButton*> buttonMap;
+  QSignalMapper* signalMapper;
   OListView *resultsList;
   QTextView *richEdit;
   OListViewItem *_currentItem;
   QVBoxLayout *mainLayout;
-  QHBoxLayout *buttonLayout;
   QFrame *detailsFrame;
   QTimer *popupTimer;
   QTimer *searchTimer;
 
   QString _searchString;
   QList<SearchGroup> searches;
-  QHButtonGroup *buttonGroupActions;
   QAction *SearchAllAction;
   QAction *actionCaseSensitiv;
   QAction *actionWildcards;
   //QAction *actionWholeWordsOnly;
   uint _buttonCount;
   void makeMenu();
diff --git a/core/pim/osearch/searchgroup.h b/core/pim/osearch/searchgroup.h
index ad37d4e..de74efb 100644
--- a/core/pim/osearch/searchgroup.h
+++ b/core/pim/osearch/searchgroup.h
@@ -37,13 +37,13 @@ protected:
 	virtual void load() = 0;
 	virtual int search() = 0;
 	virtual void insertItem( void* ) = 0;
 	QRegExp _search;
 	QRegExp _lastSearch;
 	QString _name;
-	bool loaded;
+	bool loaded : 1;
 	int _resultCount;
 private:
 	int realSearch();
 };
 
 #endif
diff --git a/core/pim/osearch/todosearch.cpp b/core/pim/osearch/todosearch.cpp
index 08bbe93..5c1d7a5 100644
--- a/core/pim/osearch/todosearch.cpp
+++ b/core/pim/osearch/todosearch.cpp
@@ -63,13 +63,13 @@ int TodoSearch::search()
 
 void TodoSearch::insertItem( void *rec )
 {
 	OTodo *todo = (OTodo*)rec;
 	if (!actionShowCompleted->isOn() &&
 		todo->isCompleted() ) return;
-	new TodoItem( this, todo );
+	(void)new TodoItem( this, todo );
 	_resultCount++;
 }
 
 QPopupMenu* TodoSearch::popupMenu()
 {
 	if (!_popupMenu){