changed copy method from clunky to using sendfile(). should be 1. faster and 2. require less memory

1 files changed, 48 insertions, 23 deletions

diff --git a/noncore/apps/advancedfm/advancedfmMenu.cpp b/noncore/apps/advancedfm/advancedfmMenu.cpp
index 93203cd..eae86a4 100644
--- a/noncore/apps/advancedfm/advancedfmMenu.cpp
+++ b/noncore/apps/advancedfm/advancedfmMenu.cpp
@@ -41,13 +41,14 @@
 #include <qlistview.h>
 
 #include <stdlib.h>
 #include <unistd.h>
 #include <sys/stat.h>
 #include <dirent.h>
-
+#include <sys/sendfile.h>
+#include <fcntl.h>
 
 void AdvancedFm::doDirChange()
 {
   ListClicked( CurrentView()->currentItem());
 }
 
@@ -309,13 +310,13 @@ void AdvancedFm::copy()
   bool doMsg=true;
   int count=curFileList.count();
   if( count > 0) {
     if(count > 1 ){
       QString msg;
       msg=tr("Really copy\n%1 files?").arg(count);
-      switch ( QMessageBox::warning(this,tr("Delete"),msg
+      switch ( QMessageBox::warning(this,tr("Copy"),msg
                                     ,tr("Yes"),tr("No"),0,0,1) )
         {
         case 0:
           doMsg=false;
           break;
         case 1:
@@ -517,39 +518,63 @@ void AdvancedFm::move()
       populateView();
 //      populateLocalView();
 }
 
 bool AdvancedFm::copyFile( const QString & src, const QString & dest )
 {
-  char bf[ 50000 ];
-  int  bytesRead;
-  bool success = TRUE;
+//    char bf[ 50000 ];
+//    int  bytesRead;
+   bool success = true;
   struct stat status;
 
-  QFile s( src );
-  QFile d( dest );
-
-  if( s.open( IO_ReadOnly | IO_Raw ) &&  d.open( IO_WriteOnly | IO_Raw ) )
-    {
-      while( (bytesRead = s.readBlock( bf, sizeof( bf ) )) == sizeof( bf ) )
-        {
-        if( d.writeBlock( bf, sizeof( bf ) ) != sizeof( bf ) ){
-          success = FALSE;
-          break;
-        }
-      }
-      if( success && (bytesRead > 0) )
-        {
-          d.writeBlock( bf, bytesRead );
+//    QFile s( src );
+//    QFile d( dest );
+
+   int read_fd=0;
+   int write_fd=0;
+   struct stat stat_buf;
+   off_t offset = 0;
+   read_fd = ::open(src.latin1(), O_RDONLY);
+   if(read_fd != -1) {
+      fstat (read_fd, &stat_buf);
+      write_fd = ::open(dest.latin1(), O_WRONLY | O_CREAT, stat_buf.st_mode);
+      if(write_fd != -1) {
+         if(sendfile(write_fd, read_fd, &offset, stat_buf.st_size) == -1) {
+            success = false;
         }
+      } else {
+         success = false;
     }
-  else
-    {
-      success = FALSE;
+   } else {
+      success = false;
     }
 
+   ::close (read_fd);
+   ::close (write_fd);
+
+
+//    if( s.open( IO_ReadOnly | IO_Raw ) &&  d.open( IO_WriteOnly | IO_Raw ) )
+// {
+//    while( (bytesRead = s.readBlock( bf, sizeof( bf ) )) == sizeof( bf ) )
+//         {
+//         if( d.writeBlock( bf, sizeof( bf ) ) != sizeof( bf ) ){
+//           success = FALSE;
+//           break;
+//         }
+//       }
+//       if( success && (bytesRead > 0) )
+//         {
+//           d.writeBlock( bf, bytesRead );
+//         }
+
+//     }
+//   else
+//     {
+//       success = FALSE;
+//     }
+
     // Set file permissions
   if( stat( (const char *) src, &status ) == 0 )
     {
       chmod( (const char *) dest, status.st_mode );
     }