summaryrefslogtreecommitdiff
authorkergoth <kergoth>2003-04-15 00:46:48 (UTC)
committer kergoth <kergoth>2003-04-15 00:46:48 (UTC)
commit79e83da7936995f247f7ad7ad0f768b6e2545cf1 (patch) (unidiff)
treea0c1d7c382d6374c2c941b30a00515cbdcfd9270
parentf3905e771c1abd5fdc430aba364934b717dfa115 (diff)
downloadopie-79e83da7936995f247f7ad7ad0f768b6e2545cf1.zip
opie-79e83da7936995f247f7ad7ad0f768b6e2545cf1.tar.gz
opie-79e83da7936995f247f7ad7ad0f768b6e2545cf1.tar.bz2
Only restart interface if it was UP previously.
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--noncore/settings/networksettings/interfaces/interfacesetupimp.cpp54
1 files changed, 27 insertions, 27 deletions
diff --git a/noncore/settings/networksettings/interfaces/interfacesetupimp.cpp b/noncore/settings/networksettings/interfaces/interfacesetupimp.cpp
index 8d78828..49a47ae 100644
--- a/noncore/settings/networksettings/interfaces/interfacesetupimp.cpp
+++ b/noncore/settings/networksettings/interfaces/interfacesetupimp.cpp
@@ -42,46 +42,46 @@ InterfaceSetupImp::~InterfaceSetupImp(){
42 * Save the current settings, then write out the interfaces file and close. 42 * Save the current settings, then write out the interfaces file and close.
43 */ 43 */
44bool InterfaceSetupImp::saveChanges(){ 44bool InterfaceSetupImp::saveChanges(){
45 bool error; 45 bool error;
46 QString iface = interfaces->getInterfaceName(error); 46 QString iface = interfaces->getInterfaceName(error);
47 if(!saveSettings()) 47 if(!saveSettings())
48 return false; 48 return false;
49 49
50 qWarning("restarting interface %s\n", iface.latin1());
51 interfaces->write(); 50 interfaces->write();
52 51
53 QString ifup; 52 if (interface->getStatus()) {
54 ifup += "ifdown "; 53 QString ifup;
55 ifup += iface; 54 ifup += "ifdown ";
56 ifup += "; ifup "; 55 ifup += iface;
57 ifup += iface; 56 ifup += "; ifup ";
58 ifup += ";"; 57 ifup += iface;
59 58 ifup += ";";
60 OProcess restart; 59
61 restart << "sh"; 60 OProcess restart;
62 restart << "-c"; 61 restart << "sh";
63 restart << ifup; 62 restart << "-c";
64 63 restart << ifup;
65 OWait *owait = new OWait(); 64
66 Global::statusMessage( tr( "Restarting interface" ) ); 65 OWait *owait = new OWait();
67 66 Global::statusMessage( tr( "Restarting interface" ) );
68 owait->show(); 67
69 qApp->processEvents(); 68 owait->show();
70 69 qApp->processEvents();
71 if (!restart.start(OProcess::Block, OProcess::NoCommunication) ) { 70
72 qWarning("unstable to spawn ifdown/ifup"); 71 if (!restart.start(OProcess::Block, OProcess::NoCommunication) ) {
72 qWarning("unstable to spawn ifdown/ifup");
73 }
74
75 owait->hide();
76 delete owait;
77
78 interface->refresh();
73 } 79 }
74
75 owait->hide();
76 delete owait;
77
78 interface->refresh();
79
80 return true; 80 return true;
81} 81}
82 82
83/** 83/**
84 * Save the settings for the current Interface. 84 * Save the settings for the current Interface.
85 * @return bool true if successfull, false otherwise 85 * @return bool true if successfull, false otherwise
86 */ 86 */
87bool InterfaceSetupImp::saveSettings(){ 87bool InterfaceSetupImp::saveSettings(){