Fixed compiler warnings

8 files changed, 42 insertions, 14 deletions

diff --git a/noncore/net/networksetup/interface.cpp b/noncore/net/networksetup/interface.cpp
index b9b09ad..f6eed00 100644
--- a/noncore/net/networksetup/interface.cpp
+++ b/noncore/net/networksetup/interface.cpp
@@ -190,17 +190,17 @@ bool Interface::refresh(){
   }
   while ( !stream.eof() ) {
     line = stream.readLine();
   }
   file.close();
   long time = 0;
   // Grab the start time  
   //                     pid com state ppid pgrp session tty_nr tpgid flags
-  int r = sscanf(line.latin1(), "%*d %*s %*c   %*d  %*d  %*d     %*d    %*d   %*u "
+  sscanf(line.latin1(), "%*d %*s %*c   %*d  %*d  %*d     %*d    %*d   %*u "
   //   minflt cminflt majflt cmajflt utime stime cutime cstime priority
       "%*u    %*u    %*u    %*u     %*u   %*u   %*d   %*d   %*d "
   //   nice 0   itrealvalue starttime
       "%*d  %*d %*d %lu", (long*) &time);
   time = time/100;
   
   QDateTime datetime(QDateTime::currentDateTime());
 
diff --git a/noncore/net/networksetup/interfaceinformationimp.h b/noncore/net/networksetup/interfaceinformationimp.h
index 6fc2384..c8a478e 100644
--- a/noncore/net/networksetup/interfaceinformationimp.h
+++ b/noncore/net/networksetup/interfaceinformationimp.h
@@ -13,19 +13,19 @@ public:
   ~InterfaceInformationImp(){};
   
 private slots:
   void start();
   void stop();
   void refresh();
   void restart();
   void advanced();
-  Interface *interface;
 
 private:
+  Interface *interface;
   void updateInterface();
   
 };
 
 #endif
 
 // addserviceimp.h
 
diff --git a/noncore/net/networksetup/mainwindowimp.cpp b/noncore/net/networksetup/mainwindowimp.cpp
index 3c13143..ad9362f 100644
--- a/noncore/net/networksetup/mainwindowimp.cpp
+++ b/noncore/net/networksetup/mainwindowimp.cpp
@@ -1,12 +1,15 @@
 #include "mainwindowimp.h"

 #include "addserviceimp.h"

 #include "interfaceinformationimp.h"

 #include "interfacesetupimp.h"

+#include "interface.h"

+#include "kprocess.h"

+#include "module.h"

 

 #include <qpushbutton.h>

 #include <qdir.h>

 #include <qtabwidget.h>

 #include <qmainwindow.h>

 #include <qmessagebox.h>

 #include <qlistbox.h>

 #include <qpe/config.h>

@@ -45,22 +48,30 @@ MainWindowImp::MainWindowImp(QWidget *parent, const char *name) : MainWindow(par
     qDebug(QString("MainWindowImp: ERROR: %1 %2").arg(__FILE__).arg(__LINE__).latin1());

     return;

   }

 

   // Load any saved services.

   loadModules(path);

   getInterfaceList();

   serviceList->header()->hide();

+

+

+  Config cfg("NetworkSetup");

+  profiles = QStringList::split(" ", cfg.readEntry("Profiles", "All"));

 }

 

 /**

- * Deconstructor.  Unload libraries and save.

+ * Deconstructor.  Unload libraries and save profile list.

  */

 MainWindowImp::~MainWindowImp(){

+  if(profiles.count() > 1){

+    Config cfg("NetworkSetup");

+    cfg.writeEntry("Profiles", profiles.join(" "));

+  }

 }

 

 void MainWindowImp::loadModules(QString path){

 }

 

 /**

  * Attempt to load a function and resolve a function.

  * @param pluginFileName - the name of the file in which to attempt to load

@@ -247,17 +258,17 @@ void MainWindowImp::jobDone(KProcess *process){
       i->setInterfaceName(interfaceName);

 

       QString hardName = "Ethernet";

       int hardwareName = line.find("Link encap:");

       int macAddress = line.find("HWaddr");

       if(macAddress == -1)

         macAddress = line.length();

       if(hardwareName != -1)

-        i->setHardwareName(line.mid(hardwareName+11, macAddress-(hardwareName+11)));

+        i->setHardwareName(line.mid(hardwareName+11, macAddress-(hardwareName+11)) + QString(" (%1)").arg(i->getInterfaceName()));

       // We have found an interface

       //qDebug(QString("MainWindowImp: Found Interface: %1").arg(line).latin1());

       interfaceNames.insert(i->getInterfaceName(), i);

       updateInterface(i);

     }

   }

   file.close();

   QFile::remove(fileName);

diff --git a/noncore/net/networksetup/mainwindowimp.h b/noncore/net/networksetup/mainwindowimp.h
index 95ec2a1..0618dd2 100644
--- a/noncore/net/networksetup/mainwindowimp.h
+++ b/noncore/net/networksetup/mainwindowimp.h
@@ -1,18 +1,19 @@
 #ifndef MAINWINOWIMP_H

 #define MAINWINOWIMP_H

 

 #include "mainwindow.h"

-#include "module.h"

-#include "interface.h"

-#include "kprocess.h"

 #include <qmap.h>

+#include <qstringlist.h>

 

+class Module;

+class Interface;

 class QLibrary;

+class KProcess;

 

 class MainWindowImp : public MainWindow {

   Q_OBJECT

 

 public:

   MainWindowImp(QWidget *parent=0, const char *name=0);

   ~MainWindowImp();

   

@@ -40,14 +41,16 @@ private:
   QMap<QString, Interface*> interfaceNames;

 

   QMap<Module*, QLibrary*> libraries;

   QMap<Interface*, Module*> modules;

   QMap<Interface*, QListViewItem*> items;

   QMap<QListViewItem*, Interface*> interfaceItems;

   

   QMap<KProcess*, QString> threads;

+  QStringList profiles;

+

 };

 

 #endif

 

 // mainwindowimp.h

 

diff --git a/noncore/settings/networksettings/interface.cpp b/noncore/settings/networksettings/interface.cpp
index b9b09ad..f6eed00 100644
--- a/noncore/settings/networksettings/interface.cpp
+++ b/noncore/settings/networksettings/interface.cpp
@@ -190,17 +190,17 @@ bool Interface::refresh(){
   }
   while ( !stream.eof() ) {
     line = stream.readLine();
   }
   file.close();
   long time = 0;
   // Grab the start time  
   //                     pid com state ppid pgrp session tty_nr tpgid flags
-  int r = sscanf(line.latin1(), "%*d %*s %*c   %*d  %*d  %*d     %*d    %*d   %*u "
+  sscanf(line.latin1(), "%*d %*s %*c   %*d  %*d  %*d     %*d    %*d   %*u "
   //   minflt cminflt majflt cmajflt utime stime cutime cstime priority
       "%*u    %*u    %*u    %*u     %*u   %*u   %*d   %*d   %*d "
   //   nice 0   itrealvalue starttime
       "%*d  %*d %*d %lu", (long*) &time);
   time = time/100;
   
   QDateTime datetime(QDateTime::currentDateTime());
 
diff --git a/noncore/settings/networksettings/interfaceinformationimp.h b/noncore/settings/networksettings/interfaceinformationimp.h
index 6fc2384..c8a478e 100644
--- a/noncore/settings/networksettings/interfaceinformationimp.h
+++ b/noncore/settings/networksettings/interfaceinformationimp.h
@@ -13,19 +13,19 @@ public:
   ~InterfaceInformationImp(){};
   
 private slots:
   void start();
   void stop();
   void refresh();
   void restart();
   void advanced();
-  Interface *interface;
 
 private:
+  Interface *interface;
   void updateInterface();
   
 };
 
 #endif
 
 // addserviceimp.h
 
diff --git a/noncore/settings/networksettings/mainwindowimp.cpp b/noncore/settings/networksettings/mainwindowimp.cpp
index 3c13143..ad9362f 100644
--- a/noncore/settings/networksettings/mainwindowimp.cpp
+++ b/noncore/settings/networksettings/mainwindowimp.cpp
@@ -1,12 +1,15 @@
 #include "mainwindowimp.h"

 #include "addserviceimp.h"

 #include "interfaceinformationimp.h"

 #include "interfacesetupimp.h"

+#include "interface.h"

+#include "kprocess.h"

+#include "module.h"

 

 #include <qpushbutton.h>

 #include <qdir.h>

 #include <qtabwidget.h>

 #include <qmainwindow.h>

 #include <qmessagebox.h>

 #include <qlistbox.h>

 #include <qpe/config.h>

@@ -45,22 +48,30 @@ MainWindowImp::MainWindowImp(QWidget *parent, const char *name) : MainWindow(par
     qDebug(QString("MainWindowImp: ERROR: %1 %2").arg(__FILE__).arg(__LINE__).latin1());

     return;

   }

 

   // Load any saved services.

   loadModules(path);

   getInterfaceList();

   serviceList->header()->hide();

+

+

+  Config cfg("NetworkSetup");

+  profiles = QStringList::split(" ", cfg.readEntry("Profiles", "All"));

 }

 

 /**

- * Deconstructor.  Unload libraries and save.

+ * Deconstructor.  Unload libraries and save profile list.

  */

 MainWindowImp::~MainWindowImp(){

+  if(profiles.count() > 1){

+    Config cfg("NetworkSetup");

+    cfg.writeEntry("Profiles", profiles.join(" "));

+  }

 }

 

 void MainWindowImp::loadModules(QString path){

 }

 

 /**

  * Attempt to load a function and resolve a function.

  * @param pluginFileName - the name of the file in which to attempt to load

@@ -247,17 +258,17 @@ void MainWindowImp::jobDone(KProcess *process){
       i->setInterfaceName(interfaceName);

 

       QString hardName = "Ethernet";

       int hardwareName = line.find("Link encap:");

       int macAddress = line.find("HWaddr");

       if(macAddress == -1)

         macAddress = line.length();

       if(hardwareName != -1)

-        i->setHardwareName(line.mid(hardwareName+11, macAddress-(hardwareName+11)));

+        i->setHardwareName(line.mid(hardwareName+11, macAddress-(hardwareName+11)) + QString(" (%1)").arg(i->getInterfaceName()));

       // We have found an interface

       //qDebug(QString("MainWindowImp: Found Interface: %1").arg(line).latin1());

       interfaceNames.insert(i->getInterfaceName(), i);

       updateInterface(i);

     }

   }

   file.close();

   QFile::remove(fileName);

diff --git a/noncore/settings/networksettings/mainwindowimp.h b/noncore/settings/networksettings/mainwindowimp.h
index 95ec2a1..0618dd2 100644
--- a/noncore/settings/networksettings/mainwindowimp.h
+++ b/noncore/settings/networksettings/mainwindowimp.h
@@ -1,18 +1,19 @@
 #ifndef MAINWINOWIMP_H

 #define MAINWINOWIMP_H

 

 #include "mainwindow.h"

-#include "module.h"

-#include "interface.h"

-#include "kprocess.h"

 #include <qmap.h>

+#include <qstringlist.h>

 

+class Module;

+class Interface;

 class QLibrary;

+class KProcess;

 

 class MainWindowImp : public MainWindow {

   Q_OBJECT

 

 public:

   MainWindowImp(QWidget *parent=0, const char *name=0);

   ~MainWindowImp();

   

@@ -40,14 +41,16 @@ private:
   QMap<QString, Interface*> interfaceNames;

 

   QMap<Module*, QLibrary*> libraries;

   QMap<Interface*, Module*> modules;

   QMap<Interface*, QListViewItem*> items;

   QMap<QListViewItem*, Interface*> interfaceItems;

   

   QMap<KProcess*, QString> threads;

+  QStringList profiles;

+

 };

 

 #endif

 

 // mainwindowimp.h