Small Bug in sorted fixed

2 files changed, 12 insertions, 6 deletions

diff --git a/libopie/pim/ocontactaccessbackend_xml.h b/libopie/pim/ocontactaccessbackend_xml.h
index 8b95102..adc8dc3 100644
--- a/libopie/pim/ocontactaccessbackend_xml.h
+++ b/libopie/pim/ocontactaccessbackend_xml.h
@@ -1,115 +1,118 @@
 /*
  * XML Backend for the OPIE-Contact Database.
  *
  * Copyright (c) 2002 by Stefan Eilers (Eilers.Stefan@epost.de)
  *
  * =====================================================================
          *This program is free software; you can redistribute it and/or
          *modify it under the terms of the GNU Library General Public
  *      License as published by the Free Software Foundation; either
  *      version 2 of the License, or (at your option) any later version.
  * =====================================================================
  * ToDo: XML-Backend: Automatic reload if something was changed...
  *
  *
  * =====================================================================
  * Version: $Id$
  * =====================================================================
  * History:
  * $Log$
+ * Revision 1.7  2002/11/13 15:02:46  eilers
+ * Small Bug in sorted fixed
+ *
  * Revision 1.6  2002/11/13 14:14:51  eilers
  * Added sorted for Contacts..
  *
  * Revision 1.5  2002/11/01 15:10:42  eilers
  * Added regExp-search in database for all fields in a contact.
  *
  * Revision 1.4  2002/10/16 10:52:40  eilers
  * Added some docu to the interface and now using the cache infrastucture by zecke.. :)
  *
  * Revision 1.3  2002/10/14 16:21:54  eilers
  * Some minor interface updates
  *
  * Revision 1.2  2002/10/07 17:34:24  eilers
  * added OBackendFactory for advanced backend access
  *
  * Revision 1.1  2002/09/27 17:11:44  eilers
  * Added API for accessing the Contact-Database ! It is compiling, but
  * please do not expect that anything is working !
  * I will debug that stuff in the next time ..
  * Please read README_COMPILE for compiling !
  *
  *
  */
 
 #ifndef _OContactAccessBackend_XML_
 #define _OContactAccessBackend_XML_
 
 #include <qasciidict.h>
 #include <qdatetime.h>
 #include <qfile.h>
 #include <qfileinfo.h>
 #include <qregexp.h>
 #include <qarray.h>
 #include <qmap.h>
 
 #include <qpe/global.h>
 
 #include <opie/xmltree.h>
 #include "ocontactaccessbackend.h"
 #include "ocontactaccess.h"
 
 #include <stdlib.h>
 #include <errno.h>
 
 using namespace Opie;
 
 /* the default xml implementation */
 class OContactAccessBackend_XML : public OContactAccessBackend {
  public:
         OContactAccessBackend_XML ( QString appname, QString filename = 0l ):
                 m_changed( false )
                 {
                         m_appName = appname;
                         
                         /* Set journalfile name ... */
                         m_journalName = getenv("HOME");
                         m_journalName +="/.abjournal" + appname;
                         
                         /* Expecting to access the default filename if nothing else is set */
                         if ( filename.isEmpty() ){
                                 m_fileName = Global::applicationFileName( "addressbook","addressbook.xml" );
                         } else
                                 m_fileName = filename;
                         
                         /* Load Database now */
                         load ();
                 }
         
         bool save() {
 
                 if ( !m_changed )
                         return true;
 
                 QString strNewFile = m_fileName + ".new";
                 QFile f( strNewFile );
                 if ( !f.open( IO_WriteOnly|IO_Raw ) )
                         return false;
                 
                 int total_written;
                 QString out;
                 out = "<?xml version=\"1.0\" encoding=\"UTF-8\"?><!DOCTYPE Addressbook ><AddressBook>\n"
                         " <Groups>\n"
                         " </Groups>\n"
                         " <Contacts>\n";
                 //QValueList<Contact>::iterator it;
                 QValueListConstIterator<OContact> it;
                 for ( it = m_contactList.begin(); it != m_contactList.end(); ++it ) {
                         out += "<Contact ";
                         (*it).save( out );
                         out += "/>\n";
                         QCString cstr = out.utf8();
                         total_written = f.writeBlock( cstr.data(), cstr.length() );
                         if ( total_written != int(cstr.length()) ) {
                                 f.close();
                                 QFile::remove( strNewFile );
                                 return false;
@@ -219,198 +222,198 @@ class OContactAccessBackend_XML : public OContactAccessBackend {
                         bool allcorrect = true;
                         for ( int i = 0; i < Qtopia::rid; i++ ) {
                                 /* Just compare fields which are not empty in the query object */
                                 if ( !query.field(i).isEmpty() ){
                                         switch ( settings & ~OContactAccess::IgnoreCase ){
                                         case OContactAccess::RegExp:{
                                                 QRegExp expr ( query.field(i),
                                                                !(settings & OContactAccess::IgnoreCase),
                                                                false );
                                                 if ( expr.find ( (*it).field(i), 0 ) == -1 )
                                                         allcorrect = false;
                                         }
                                                 break;
                                         case OContactAccess::WildCards:{
                                                 QRegExp expr ( query.field(i),
                                                                !(settings & OContactAccess::IgnoreCase),
                                                                true );
                                                 if ( expr.find ( (*it).field(i), 0 ) == -1 )
                                                         allcorrect = false;
                                         }
                                                 break;
                                         case OContactAccess::ExactMatch:{
                                                 if (settings & OContactAccess::IgnoreCase){
                                                         if ( query.field(i).upper() !=
                                                              (*it).field(i).upper() )
                                                                 allcorrect = false;
                                                 }else{
                                                         if ( query.field(i) != (*it).field(i) )
                                                                 allcorrect = false;
                                                 }
                                         }
                                                 break;
                                         }
                                 }
                         }
                         if ( allcorrect ){
                                 m_currentQuery[arraycounter++] = (*it).uid();
                         }
                 }
                         
                 // Shrink to fit..
                 m_currentQuery.resize(arraycounter);
         
                 return m_currentQuery;
         }
 
         QArray<int> matchRegexp(  const QRegExp &r ) const{
                 QArray<int> m_currentQuery( m_contactList.count() );
                 QValueListConstIterator<OContact> it;
                 uint arraycounter = 0;
                 
                 for( it = m_contactList.begin(); it != m_contactList.end(); ++it ){
                         if ( (*it).match( r ) ){
                                 m_currentQuery[arraycounter++] = (*it).uid();
                         }
                         
                 }
                 // Shrink to fit..
                 m_currentQuery.resize(arraycounter);
 
                 return m_currentQuery;
         }
         
         const uint querySettings()
                 {
                         return ( OContactAccess::WildCards
                                  & OContactAccess::IgnoreCase
                                  & OContactAccess::RegExp
                                  & OContactAccess::ExactMatch );
                 }
         
         bool hasQuerySettings (uint querySettings) const
                 {
                         /* OContactAccess::IgnoreCase may be added with one
                          * of the other settings, but never used alone.
                          * The other settings are just valid alone...
                          */
                         switch ( querySettings & ~OContactAccess::IgnoreCase ){
                         case OContactAccess::RegExp:
                                 return ( true );
                         case OContactAccess::WildCards:
                                 return ( true );
                         case OContactAccess::ExactMatch:
                                 return ( true );
                         default:
                                 return ( false );
                         }
                 }
         
         // Currently only asc implemented.. 
         QArray<int> sorted( bool asc,  int , int ,  int ) 
                 {
                         QMap<QString, int> nameToUid;
                         QStringList names;
                         QArray<int> m_currentQuery( m_contactList.count() );
 
-                        // First fill map and StringList with all Names ( better LastNames ? )
+                        // First fill map and StringList with all Names 
                         // Afterwards sort namelist and use map to fill array to return..
                         QValueListConstIterator<OContact> it;
                         for( it = m_contactList.begin(); it != m_contactList.end(); ++it ){
-                                names.append( (*it).lastName() );
-                                nameToUid.insert( (*it).lastName(), (*it).uid() );
+                                names.append( (*it).fileAs() );
+                                nameToUid.insert( (*it).fileAs(), (*it).uid() );
                         }
                         names.sort();
 
                         int i = 0;
                         if ( asc ){
                                 for ( QStringList::Iterator it = names.begin(); it != names.end(); ++it )
                                         m_currentQuery[i++] = nameToUid[ (*it) ];
                         }else{
                                 for ( QStringList::Iterator it = names.end(); it != names.begin(); --it )
                                         m_currentQuery[i++] = nameToUid[ (*it) ];
                         }
                         
                         return m_currentQuery;
                         
                 }
         bool add ( const OContact &newcontact )
                 {
                         //qWarning("odefaultbackend: ACTION::ADD");
                         updateJournal (newcontact, OContact::ACTION_ADD);
                         addContact_p( newcontact );
                         
                         m_changed = true;
 
                         return true;
                 }
         
         bool replace ( const OContact &contact )
                 {
                         m_changed = true;
 
                         bool found = false;
                         
                         QValueListIterator<OContact> it;
                         for( it = m_contactList.begin(); it != m_contactList.end(); ++it ){
                                 if ( (*it).uid() == contact.uid() ){
                                         found = true;
                                         break;
                                 }
                         }
                         if (found) {
                                 updateJournal (contact, OContact::ACTION_REPLACE);
                                 m_contactList.remove (it);
                                 m_contactList.append (contact);
                                 return true;
                         } else
                                 return false;
                 }
         
         bool remove ( int uid )
                 {
                         m_changed = true;
 
                         bool found = false;
                         QValueListIterator<OContact> it;
                         for( it = m_contactList.begin(); it != m_contactList.end(); ++it ){
                                 if ((*it).uid() == uid){
                                         found = true;
                                         break;
                                 }
                         }
                         if (found) {
                                 updateJournal ( *it, OContact::ACTION_REMOVE);
                                 m_contactList.remove (it);
                                 return true;
                         } else
                                 return false;
                 }
         
         bool reload(){
                 /* Reload is the same as load in this implementation */
                 return ( load() );
         }
         
  private:
         void addContact_p( const OContact &newcontact ){
                 m_contactList.append (newcontact);
         }
         
         /* This function loads the xml-database and the journalfile */
         bool load( const QString filename, bool isJournal ) {
                 
                 /* We use the time of the last read to check if the file was
                  * changed externally.
                  */
                 if ( !isJournal ){
                         QFileInfo fi( filename );
                         m_readtime = fi.lastModified ();
                 }
                 
                 const int JOURNALACTION = Qtopia::Notes + 1;
                 const int JOURNALROW = JOURNALACTION + 1;
                 
                 bool foundAction = false;
                 OContact::journal_action action = OContact::ACTION_ADD;
                 int journalKey = 0;
                 QMap<int, QString> contactMap;
diff --git a/libopie2/opiepim/backend/ocontactaccessbackend_xml.h b/libopie2/opiepim/backend/ocontactaccessbackend_xml.h
index 8b95102..adc8dc3 100644
--- a/libopie2/opiepim/backend/ocontactaccessbackend_xml.h
+++ b/libopie2/opiepim/backend/ocontactaccessbackend_xml.h
@@ -1,115 +1,118 @@
 /*
  * XML Backend for the OPIE-Contact Database.
  *
  * Copyright (c) 2002 by Stefan Eilers (Eilers.Stefan@epost.de)
  *
  * =====================================================================
          *This program is free software; you can redistribute it and/or
          *modify it under the terms of the GNU Library General Public
  *      License as published by the Free Software Foundation; either
  *      version 2 of the License, or (at your option) any later version.
  * =====================================================================
  * ToDo: XML-Backend: Automatic reload if something was changed...
  *
  *
  * =====================================================================
  * Version: $Id$
  * =====================================================================
  * History:
  * $Log$
+ * Revision 1.7  2002/11/13 15:02:46  eilers
+ * Small Bug in sorted fixed
+ *
  * Revision 1.6  2002/11/13 14:14:51  eilers
  * Added sorted for Contacts..
  *
  * Revision 1.5  2002/11/01 15:10:42  eilers
  * Added regExp-search in database for all fields in a contact.
  *
  * Revision 1.4  2002/10/16 10:52:40  eilers
  * Added some docu to the interface and now using the cache infrastucture by zecke.. :)
  *
  * Revision 1.3  2002/10/14 16:21:54  eilers
  * Some minor interface updates
  *
  * Revision 1.2  2002/10/07 17:34:24  eilers
  * added OBackendFactory for advanced backend access
  *
  * Revision 1.1  2002/09/27 17:11:44  eilers
  * Added API for accessing the Contact-Database ! It is compiling, but
  * please do not expect that anything is working !
  * I will debug that stuff in the next time ..
  * Please read README_COMPILE for compiling !
  *
  *
  */
 
 #ifndef _OContactAccessBackend_XML_
 #define _OContactAccessBackend_XML_
 
 #include <qasciidict.h>
 #include <qdatetime.h>
 #include <qfile.h>
 #include <qfileinfo.h>
 #include <qregexp.h>
 #include <qarray.h>
 #include <qmap.h>
 
 #include <qpe/global.h>
 
 #include <opie/xmltree.h>
 #include "ocontactaccessbackend.h"
 #include "ocontactaccess.h"
 
 #include <stdlib.h>
 #include <errno.h>
 
 using namespace Opie;
 
 /* the default xml implementation */
 class OContactAccessBackend_XML : public OContactAccessBackend {
  public:
         OContactAccessBackend_XML ( QString appname, QString filename = 0l ):
                 m_changed( false )
                 {
                         m_appName = appname;
                         
                         /* Set journalfile name ... */
                         m_journalName = getenv("HOME");
                         m_journalName +="/.abjournal" + appname;
                         
                         /* Expecting to access the default filename if nothing else is set */
                         if ( filename.isEmpty() ){
                                 m_fileName = Global::applicationFileName( "addressbook","addressbook.xml" );
                         } else
                                 m_fileName = filename;
                         
                         /* Load Database now */
                         load ();
                 }
         
         bool save() {
 
                 if ( !m_changed )
                         return true;
 
                 QString strNewFile = m_fileName + ".new";
                 QFile f( strNewFile );
                 if ( !f.open( IO_WriteOnly|IO_Raw ) )
                         return false;
                 
                 int total_written;
                 QString out;
                 out = "<?xml version=\"1.0\" encoding=\"UTF-8\"?><!DOCTYPE Addressbook ><AddressBook>\n"
                         " <Groups>\n"
                         " </Groups>\n"
                         " <Contacts>\n";
                 //QValueList<Contact>::iterator it;
                 QValueListConstIterator<OContact> it;
                 for ( it = m_contactList.begin(); it != m_contactList.end(); ++it ) {
                         out += "<Contact ";
                         (*it).save( out );
                         out += "/>\n";
                         QCString cstr = out.utf8();
                         total_written = f.writeBlock( cstr.data(), cstr.length() );
                         if ( total_written != int(cstr.length()) ) {
                                 f.close();
                                 QFile::remove( strNewFile );
                                 return false;
@@ -219,198 +222,198 @@ class OContactAccessBackend_XML : public OContactAccessBackend {
                         bool allcorrect = true;
                         for ( int i = 0; i < Qtopia::rid; i++ ) {
                                 /* Just compare fields which are not empty in the query object */
                                 if ( !query.field(i).isEmpty() ){
                                         switch ( settings & ~OContactAccess::IgnoreCase ){
                                         case OContactAccess::RegExp:{
                                                 QRegExp expr ( query.field(i),
                                                                !(settings & OContactAccess::IgnoreCase),
                                                                false );
                                                 if ( expr.find ( (*it).field(i), 0 ) == -1 )
                                                         allcorrect = false;
                                         }
                                                 break;
                                         case OContactAccess::WildCards:{
                                                 QRegExp expr ( query.field(i),
                                                                !(settings & OContactAccess::IgnoreCase),
                                                                true );
                                                 if ( expr.find ( (*it).field(i), 0 ) == -1 )
                                                         allcorrect = false;
                                         }
                                                 break;
                                         case OContactAccess::ExactMatch:{
                                                 if (settings & OContactAccess::IgnoreCase){
                                                         if ( query.field(i).upper() !=
                                                              (*it).field(i).upper() )
                                                                 allcorrect = false;
                                                 }else{
                                                         if ( query.field(i) != (*it).field(i) )
                                                                 allcorrect = false;
                                                 }
                                         }
                                                 break;
                                         }
                                 }
                         }
                         if ( allcorrect ){
                                 m_currentQuery[arraycounter++] = (*it).uid();
                         }
                 }
                         
                 // Shrink to fit..
                 m_currentQuery.resize(arraycounter);
         
                 return m_currentQuery;
         }
 
         QArray<int> matchRegexp(  const QRegExp &r ) const{
                 QArray<int> m_currentQuery( m_contactList.count() );
                 QValueListConstIterator<OContact> it;
                 uint arraycounter = 0;
                 
                 for( it = m_contactList.begin(); it != m_contactList.end(); ++it ){
                         if ( (*it).match( r ) ){
                                 m_currentQuery[arraycounter++] = (*it).uid();
                         }
                         
                 }
                 // Shrink to fit..
                 m_currentQuery.resize(arraycounter);
 
                 return m_currentQuery;
         }
         
         const uint querySettings()
                 {
                         return ( OContactAccess::WildCards
                                  & OContactAccess::IgnoreCase
                                  & OContactAccess::RegExp
                                  & OContactAccess::ExactMatch );
                 }
         
         bool hasQuerySettings (uint querySettings) const
                 {
                         /* OContactAccess::IgnoreCase may be added with one
                          * of the other settings, but never used alone.
                          * The other settings are just valid alone...
                          */
                         switch ( querySettings & ~OContactAccess::IgnoreCase ){
                         case OContactAccess::RegExp:
                                 return ( true );
                         case OContactAccess::WildCards:
                                 return ( true );
                         case OContactAccess::ExactMatch:
                                 return ( true );
                         default:
                                 return ( false );
                         }
                 }
         
         // Currently only asc implemented.. 
         QArray<int> sorted( bool asc,  int , int ,  int ) 
                 {
                         QMap<QString, int> nameToUid;
                         QStringList names;
                         QArray<int> m_currentQuery( m_contactList.count() );
 
-                        // First fill map and StringList with all Names ( better LastNames ? )
+                        // First fill map and StringList with all Names 
                         // Afterwards sort namelist and use map to fill array to return..
                         QValueListConstIterator<OContact> it;
                         for( it = m_contactList.begin(); it != m_contactList.end(); ++it ){
-                                names.append( (*it).lastName() );
-                                nameToUid.insert( (*it).lastName(), (*it).uid() );
+                                names.append( (*it).fileAs() );
+                                nameToUid.insert( (*it).fileAs(), (*it).uid() );
                         }
                         names.sort();
 
                         int i = 0;
                         if ( asc ){
                                 for ( QStringList::Iterator it = names.begin(); it != names.end(); ++it )
                                         m_currentQuery[i++] = nameToUid[ (*it) ];
                         }else{
                                 for ( QStringList::Iterator it = names.end(); it != names.begin(); --it )
                                         m_currentQuery[i++] = nameToUid[ (*it) ];
                         }
                         
                         return m_currentQuery;
                         
                 }
         bool add ( const OContact &newcontact )
                 {
                         //qWarning("odefaultbackend: ACTION::ADD");
                         updateJournal (newcontact, OContact::ACTION_ADD);
                         addContact_p( newcontact );
                         
                         m_changed = true;
 
                         return true;
                 }
         
         bool replace ( const OContact &contact )
                 {
                         m_changed = true;
 
                         bool found = false;
                         
                         QValueListIterator<OContact> it;
                         for( it = m_contactList.begin(); it != m_contactList.end(); ++it ){
                                 if ( (*it).uid() == contact.uid() ){
                                         found = true;
                                         break;
                                 }
                         }
                         if (found) {
                                 updateJournal (contact, OContact::ACTION_REPLACE);
                                 m_contactList.remove (it);
                                 m_contactList.append (contact);
                                 return true;
                         } else
                                 return false;
                 }
         
         bool remove ( int uid )
                 {
                         m_changed = true;
 
                         bool found = false;
                         QValueListIterator<OContact> it;
                         for( it = m_contactList.begin(); it != m_contactList.end(); ++it ){
                                 if ((*it).uid() == uid){
                                         found = true;
                                         break;
                                 }
                         }
                         if (found) {
                                 updateJournal ( *it, OContact::ACTION_REMOVE);
                                 m_contactList.remove (it);
                                 return true;
                         } else
                                 return false;
                 }
         
         bool reload(){
                 /* Reload is the same as load in this implementation */
                 return ( load() );
         }
         
  private:
         void addContact_p( const OContact &newcontact ){
                 m_contactList.append (newcontact);
         }
         
         /* This function loads the xml-database and the journalfile */
         bool load( const QString filename, bool isJournal ) {
                 
                 /* We use the time of the last read to check if the file was
                  * changed externally.
                  */
                 if ( !isJournal ){
                         QFileInfo fi( filename );
                         m_readtime = fi.lastModified ();
                 }
                 
                 const int JOURNALACTION = Qtopia::Notes + 1;
                 const int JOURNALROW = JOURNALACTION + 1;
                 
                 bool foundAction = false;
                 OContact::journal_action action = OContact::ACTION_ADD;
                 int journalKey = 0;
                 QMap<int, QString> contactMap;