Each file in this commit has the issue where a function can return a

negative result but the result is used in a context that can only be
positive.

2 files changed, 11 insertions, 12 deletions

diff --git a/noncore/games/kpacman/score.cpp b/noncore/games/kpacman/score.cpp
index 6878b81..737f03b 100644
--- a/noncore/games/kpacman/score.cpp
+++ b/noncore/games/kpacman/score.cpp
@@ -239,11 +239,11 @@ void Score::keyPressEvent(QKeyEvent *k)
     }
 
     if (x != cursor.x || y != cursor.y) {
-        if (cursor.x != -1)
+        if (cursor.x != -1 && lastScore >= 0)
             cursor.chr = hallOfFame[lastScore].name.at(cursor.x-14);
         scrollRepeat = FALSE;
         repaint(rect(x, y*1.25, cursor.chr), FALSE);
-    } else
+    } else if (lastScore >= 0)
         hallOfFame[lastScore].name.at(cursor.x-14) = cursor.chr;
 
     if (key == UpKey || key == Key_Up || key == DownKey || key == Key_Down)
diff --git a/noncore/todayplugins/stockticker/libstocks/http.c b/noncore/todayplugins/stockticker/libstocks/http.c
index cc78ab7..155ce4b 100644
--- a/noncore/todayplugins/stockticker/libstocks/http.c
+++ b/noncore/todayplugins/stockticker/libstocks/http.c
@@ -84,9 +84,9 @@ libstocks_return_code http_get(char *http_file, char *http_server, char **pdata)
       server.sin_family = host->h_addrtype;
       server.sin_port = (unsigned short) htons( http_proxy_server ? http_proxy_port : 80 );
 
-    } else 
+    }
+  else
       {
-
 #ifdef DEBUG
   printf(" gethostbyname : NOK\n");
 #endif
@@ -96,7 +96,6 @@ libstocks_return_code http_get(char *http_file, char *http_server, char **pdata)
   /* create socket */
   if ((s = socket(AF_INET, SOCK_STREAM, 0)) < 0) 
     {
-
 #ifdef DEBUG
       printf(" create socket : NOK\n");
 #endif
@@ -159,14 +158,14 @@ libstocks_return_code http_get(char *http_file, char *http_server, char **pdata)
       r=recv(s,buf,BUF_SIZE,0);
 #endif      
       
-      if (r)
+      if (r > 0)
   {
     if(!data_lgr)
       {
         if((data = malloc(r+1))==NULL)
     {
-      fprintf(stderr,"Memory allocating error (%s line %d)\n"
-        ,__FILE__, __LINE__);
+                  fprintf(stderr,"Memory allocating error (%s line %d)\n",
+                          __FILE__, __LINE__);
       exit(1);
     }
         
@@ -178,8 +177,8 @@ libstocks_return_code http_get(char *http_file, char *http_server, char **pdata)
       {
         if((temp = malloc(r+data_lgr+1))==NULL)
     {
-      fprintf(stderr,"Memory allocating error (%s line %d)\n"
-        ,__FILE__, __LINE__);
+                  fprintf(stderr,"Memory allocating error (%s line %d)\n",
+                          __FILE__, __LINE__);
       exit(1);
     }
         memcpy(temp, data, data_lgr);
@@ -240,8 +239,8 @@ libstocks_return_code http_get(char *http_file, char *http_server, char **pdata)
   if ((csv_ptr = malloc(strlen(temp)+1))==NULL)
     {
       free(data);
-      fprintf(stderr,"Memory allocating error (%s line %d)\n"
-        ,__FILE__, __LINE__);
+      fprintf(stderr,"Memory allocating error (%s line %d)\n",
+              __FILE__, __LINE__);
       exit(1);
     }