- add skeleton for the last missing parts in the 802.11 decoding framework

- fix huge memory leak in packet capturer
- add more fine granular 802.11 subtype handling

3 files changed, 104 insertions, 29 deletions

diff --git a/libopie2/opienet/802_11_user.h b/libopie2/opienet/802_11_user.h
index ffdcb93..f596bd8 100644
--- a/libopie2/opienet/802_11_user.h
+++ b/libopie2/opienet/802_11_user.h
@@ -255,6 +255,18 @@ struct ieee_802_11_data_header {
         //      u_int8_tgap[8];
 };
 
+struct ieee_802_11_control_header {
+                u_int16_tframe_control;
+                u_int16_tduration;
+                u_int8_tmac1[6];
+                u_int8_tmac2[6];
+                u_int8_tmac3[6];
+                u_int16_tSeqCtl;
+                u_int8_tmac4[6];
+        //      u_int16_tgapLen;
+        //      u_int8_tgap[8];
+};
+
 #define CAPABILITY_ESS(cap)     ((cap) & 0x0001)
 #define CAPABILITY_IBSS(cap)    ((cap) & 0x0002)
 #define CAPABILITY_CFP(cap)     ((cap) & 0x0004)
@@ -362,6 +374,10 @@ struct ieee_802_11_data_body {
 //FIXME
 };
 
+struct ieee_802_11_control_body {
+//FIXME
+};
+
 struct ctrl_rts_t {
           u_int16_tfc;
           u_int16_tduration;
diff --git a/libopie2/opienet/opcap.cpp b/libopie2/opienet/opcap.cpp
index 40aac2c..5c464cf 100644
--- a/libopie2/opienet/opcap.cpp
+++ b/libopie2/opienet/opcap.cpp
@@ -44,23 +44,28 @@
  * OPacket
  *======================================================================================*/
 
-OPacket::OPacket( packetheaderstruct header, const unsigned char* data, QObject* parent )
+OPacket::OPacket( int datalink, packetheaderstruct header, const unsigned char* data, QObject* parent )
         :QObject( parent, "Generic" ), _hdr( header ), _data( data )
 {
-    qDebug( "OPacket::OPacket(): (Len %d, CapLen %d)" /*, ctime((const time_t*) header.ts.tv_sec)*/, header.len, header.caplen );
+    //qDebug( "OPacket::OPacket(): (Len %d, CapLen %d)" /*, ctime((const time_t*) header.ts.tv_sec)*/, header.len, header.caplen );
 
     _end = (unsigned char*) data + header.len;
-    qDebug( "OPacket::data @ %0x, end @ %0x", data, _end );
+    //qDebug( "OPacket::data @ %0x, end @ %0x", data, _end );
 
-    if ( packetCapturer()->dataLink() == DLT_EN10MB )
+    switch ( datalink )
     {
+        case DLT_EN10MB:
         qDebug( "OPacket::OPacket(): Received Packet. Datalink = ETHERNET" );
         new OEthernetPacket( _end, (const struct ether_header*) data, this );
-    }
-    else
-    {
+            break;
+
+        case DLT_IEEE802_11:
         qDebug( "OPacket::OPacket(): Received Packet. Datalink = IEEE802.11" );
         new OWaveLanPacket( _end, (const struct ieee_802_11_header*) data, this );
+            break;
+
+        default:
+            qWarning( "OPacket::OPacket(): Received Packet over unsupported datalink '%s'!", datalink );
     }
 }
 
@@ -70,12 +75,6 @@ OPacket::~OPacket()
 }
 
 
-OPacketCapturer* OPacket::packetCapturer() const
-{
-    return parent()->inherits( "OPacketCapturer" ) ? static_cast<OPacketCapturer*>( parent() ) : 0;
-}
-
-
 timevalstruct OPacket::timeval() const
 {
     return _hdr.ts;
@@ -316,7 +315,7 @@ OWaveLanPacket::OWaveLanPacket( const unsigned char* end, const struct ieee_802_
     qDebug( "subType: %0X", subType() );
     qDebug( "duration: %d", duration() );
     qDebug( "powermanagement: %d", usesPowerManagement() );
-    qDebug( "wep: %d", usesWep() );
+    qDebug( "payload is encrypted: %s", usesWep() ? "yes" : "no" );
     qDebug( "MAC1: %s", (const char*) macAddress1().toString() );
     qDebug( "MAC2: %s", (const char*) macAddress2().toString() );
     qDebug( "MAC3: %s", (const char*) macAddress3().toString() );
@@ -326,8 +325,8 @@ OWaveLanPacket::OWaveLanPacket( const unsigned char* end, const struct ieee_802_
     {
         case T_MGMT: new OWaveLanManagementPacket( end, (const struct ieee_802_11_mgmt_header*) data, this ); break;
         case T_DATA: new OWaveLanDataPacket( end, (const struct ieee_802_11_data_header*) data, this ); break;
-        //case T_CTRL: new OWaveLanControlPacket( end, (const struct ieee_802_11_ctrl_header*) data, this ); break;
-        default: qDebug( "OWaveLanPacket::OWaveLanPacket(): Warning: Unknown type!" );
+        case T_CTRL: new OWaveLanControlPacket( end, (const struct ieee_802_11_control_header*) data, this ); break;
+        default: qDebug( "OWaveLanPacket::OWaveLanPacket(): Warning: Unknown major type '%d'!", type() );
     }
 }
 
@@ -417,14 +416,7 @@ OWaveLanManagementPacket::OWaveLanManagementPacket( const unsigned char* end, co
                 _body( (const struct ieee_802_11_mgmt_body*) (data+1) )
 {
     qDebug( "OWaveLanManagementPacket::OWaveLanManagementPacket(): decoding frame..." );
-
-    switch ( ((OWaveLanPacket*) this->parent() )->subType() )
-    {
-        case ST_BEACON:
-        {
-            // nice, received a beacon...
-        }
-    }
+    qDebug( "Detected subtype is '%s'", (const char*) managementType() );
 
     // grab tagged values
     const unsigned char* ptr = (const unsigned char*) (_body+1);
@@ -452,6 +444,28 @@ OWaveLanManagementPacket::~OWaveLanManagementPacket()
 }
 
 
+QString OWaveLanManagementPacket::managementType() const
+{
+    switch ( FC_SUBTYPE( EXTRACT_LE_16BITS( &_header->fc ) ) )
+    {
+        case ST_ASSOC_REQUEST: return "AssociationRequest"; break;
+        case ST_ASSOC_RESPONSE: return "AssociationResponse"; break;
+        case ST_REASSOC_REQUEST: return "ReassociationRequest"; break;
+        case ST_REASSOC_RESPONSE: return "ReassociationResponse"; break;
+        case ST_PROBE_REQUEST: return "ProbeRequest"; break;
+        case ST_PROBE_RESPONSE: return "ProbeResponse"; break;
+        case ST_BEACON: return "Beacon"; break;
+        case ST_ATIM: return "Atim"; break;
+        case ST_DISASSOC: return "Disassociation"; break;
+        case ST_AUTH: return "Authentication"; break;
+        case ST_DEAUTH: return "Deathentication"; break;
+        default:
+            qWarning( "OWaveLanManagementPacket::managementType(): unhandled subtype %d", FC_SUBTYPE( EXTRACT_LE_16BITS( &_header->fc ) ) );
+            return "Unknown";
+    }
+}
+
+
 int OWaveLanManagementPacket::beaconInterval() const
 {
     return EXTRACT_LE_16BITS( &_body->beacon_interval );
@@ -682,6 +696,24 @@ OLLCPacket::~OLLCPacket()
 {
 }
 
+
+/*======================================================================================
+ * OWaveLanControlPacket
+ *======================================================================================*/
+
+OWaveLanControlPacket::OWaveLanControlPacket( const unsigned char* end, const struct ieee_802_11_control_header* data, OWaveLanPacket* parent )
+                :QObject( parent, "802.11 Data" ), _header( data )
+{
+    qDebug( "OWaveLanControlPacket::OWaveLanDataControl(): decoding frame..." );
+    //TODO: Implement this
+}
+
+
+OWaveLanControlPacket::~OWaveLanControlPacket()
+{
+}
+
+
 /*======================================================================================
  * OPacketCapturer
  *======================================================================================*/
@@ -770,10 +802,18 @@ OPacket* OPacketCapturer::next()
     qDebug( "<== OPacketCapturer::next()" );
 
     if ( header.len )
-        return new OPacket( header, pdata, this );
+    {
+        return new OPacket( dataLink(), header, pdata, 0 );
+        // packets shouldn't be inserted in the QObject child-parent hierarchy,
+        // because due to memory constraints they will be deleted as soon
+        // as possible - that is right after they have been processed
+        // by emit() [ see below ]
+    }
     else
+    {
         return 0;
 }
+}
 
 
 bool OPacketCapturer::open( const QString& name )
@@ -827,6 +867,9 @@ bool OPacketCapturer::isOpen() const
 void OPacketCapturer::readyToReceive()
 {
     qDebug( "OPacketCapturer::readyToReceive(): about to emit 'receivePacket(...)'" );
-    emit receivedPacket( next() );
+    OPacket* p = next();
+    emit receivedPacket( p );
+    // emit is synchronous - packet has been dealt with, now it's safe to delete
+    delete p;
 }
 
diff --git a/libopie2/opienet/opcap.h b/libopie2/opienet/opcap.h
index 04d22ff..ddef278 100644
--- a/libopie2/opienet/opcap.h
+++ b/libopie2/opienet/opcap.h
@@ -71,13 +71,11 @@ class OPacket : public QObject
   Q_OBJECT
 
   public:
-    OPacket( packetheaderstruct, const unsigned char*, QObject* parent );
+    OPacket( int datalink, packetheaderstruct, const unsigned char*, QObject* parent );
     virtual ~OPacket();
 
     timevalstruct timeval() const;
 
-    OPacketCapturer* packetCapturer() const;
-
     int caplen() const;
     int len() const;
     QString dump( int = 32 ) const;
@@ -151,6 +149,8 @@ class OWaveLanManagementPacket : public QObject
     OWaveLanManagementPacket( const unsigned char*, const struct ieee_802_11_mgmt_header*, OWaveLanPacket* parent = 0 );
     virtual ~OWaveLanManagementPacket();
 
+    QString managementType() const;
+
     int beaconInterval() const;
     int capabilities() const; // generic
 
@@ -315,6 +315,22 @@ class OWaveLanDataPacket : public QObject
 };
 
 /*======================================================================================
+ * OWaveLanControlPacket - type: control (T_CTRL)
+ *======================================================================================*/
+
+class OWaveLanControlPacket : public QObject
+{
+  Q_OBJECT
+
+  public:
+    OWaveLanControlPacket( const unsigned char*, const struct ieee_802_11_control_header*, OWaveLanPacket* parent = 0 );
+    virtual ~OWaveLanControlPacket();
+
+  private:
+    const struct ieee_802_11_control_header* _header;
+};
+
+/*======================================================================================
  * OLLCPacket - IEEE 802.2 Link Level Control
  *======================================================================================*/