- ported the device button handling to the new ODevice based framework

 - removed the key re-grabbing in runningsappbar (not necessary anymore)
 - added a few new QCops to make all "special" launcher functions available
   via qcop
 - added the devicebuttons to the opie-taskbar ipk

8 files changed, 186 insertions, 243 deletions

diff --git a/core/launcher/desktop.cpp b/core/launcher/desktop.cpp
index 6c67056..fa9736f 100644
--- a/core/launcher/desktop.cpp
+++ b/core/launcher/desktop.cpp
@@ -58,6 +58,7 @@
 #include <unistd.h>
 #include <fcntl.h>
 
+
 using namespace Opie;
 
 class QCopKeyRegister
@@ -65,7 +66,7 @@ class QCopKeyRegister
 public:
   QCopKeyRegister() : keyCode( 0 )
   { }
-  QCopKeyRegister( int k, const QString &c, const QString &m )
+        QCopKeyRegister( int k, const QCString &c, const QCString &m )
       : keyCode( k ), channel( c ), message( m )
   { }
 
@@ -73,18 +74,18 @@ public:
   {
     return keyCode;
   }
-  QString getChannel() const
+        QCString getChannel() const
   {
     return channel;
   }
-  QString getMessage() const
+        QCString getMessage() const
   {
     return message;
   }
 
 private:
   int keyCode;
-  QString channel, message;
+        QCString channel, message;
 };
 
 typedef QValueList<QCopKeyRegister> KeyRegisterList;
@@ -189,24 +190,35 @@ DesktopApplication::DesktopApplication( int& argc, char **argv, Type appType )
         connect( m_timer, SIGNAL( timeout() ), this, SLOT( apmTimeout() ) );
         m_timer->start( 5000 );
   
-        channel = new QCopChannel( "QPE/Desktop", this );
-        connect( channel, SIGNAL( received( const QCString&, const QByteArray& ) ),
-                 this, SLOT( desktopMessage( const QCString&, const QByteArray& ) ) );
+        m_last_button = 0;
+        m_button_timer = new QTimer ( );
+        connect ( m_button_timer, SIGNAL( timeout ( )), this, SLOT( sendHeldAction ( )));
 
         channel = new QCopChannel( "QPE/System", this );
         connect( channel, SIGNAL( received( const QCString&, const QByteArray& ) ),
                  this, SLOT( systemMessage( const QCString&, const QByteArray& ) ) );
 
+        channel = new QCopChannel( "QPE/Launcher", this );
+        connect( channel, SIGNAL( received( const QCString&, const QByteArray& ) ),
+                 this, SLOT( launcherMessage( const QCString&, const QByteArray& ) ) );
+
         m_screensaver = new OpieScreenSaver ( );
                 m_screensaver-> setInterval ( -1 );
         QWSServer::setScreenSaver( m_screensaver );
         
+        rereadVolumes();
+        connect( qApp, SIGNAL( volumeChanged( bool ) ), this, SLOT( rereadVolumes() ) );
+        
         apmTimeout ( );
+        
+        grabKeyboard ( );
 }
 
 
 DesktopApplication::~DesktopApplication()
 {
+        ungrabKeyboard ( );
+
         delete m_ps;
         delete m_ps_last;
         delete pa;
@@ -236,21 +248,6 @@ void DesktopApplication::apmTimeout()
         }
 }
 
-void DesktopApplication::desktopMessage( const QCString &msg, const QByteArray &data )
-{
-  QDataStream stream( data, IO_ReadOnly );
-  if ( msg == "keyRegister(int key, QString channel, QString message)" ) {
-    int k;
-    QString c, m;
-    stream >> k;
-    stream >> c;
-    stream >> m;
-
-    qWarning( "KeyRegisterReceived: %i, %s, %s", k, ( const char* ) c, ( const char * ) m );
-    keyRegisterList.append( QCopKeyRegister( k, c, m ) );
-  }
-}
-
 
 void DesktopApplication::systemMessage( const QCString & msg, const QByteArray & data )
 {
@@ -287,9 +284,20 @@ void DesktopApplication::systemMessage( const QCString & msg, const QByteArray &
   else if ( msg == "suspend()" ) {
     emit power();
   }
+        else if ( msg == "sendBusinessCard()" ) {
+                QString card = ::getenv ( "HOME" );
+                card += "/Applications/addressbook/businesscard.vcf";
+
+                if ( QFile::exists( card ) ) {
+                        QCopEnvelope e ( "QPE/Obex", "send(QString,QString,QString)" );
+                        QString mimetype = "text/x-vCard";
+                        e << tr( "business card" ) << card << mimetype;
+                }
+        }
 }
 
-void DesktopApplication::reloadPowerWarnSettings() {
+void DesktopApplication::reloadPowerWarnSettings()
+{
     Config cfg( "apm" );
     cfg.setGroup( "Warnings" );
 
@@ -301,127 +309,152 @@ void DesktopApplication::reloadPowerWarnSettings() {
 
 enum MemState { Unknown, VeryLow, Low, Normal } memstate = Unknown;
 
-#ifdef Q_WS_QWS
-bool DesktopApplication::qwsEventFilter( QWSEvent *e )
+
+void DesktopApplication::launcherMessage( const QCString & msg, const QByteArray & data )
 {
-  qpedesktop->checkMemory();
+        QDataStream stream ( data, IO_ReadOnly );
 
-  if ( e->type == QWSEvent::Key ) {
-    QWSKeyEvent * ke = ( QWSKeyEvent * ) e;
-    if ( !loggedin && ke->simpleData.keycode != Key_F34 )
-      return TRUE;
-    bool press = ke->simpleData.is_press;
-    bool autoRepeat = ke->simpleData.is_auto_repeat;
+        if ( msg == "deviceButton(int,int,int)" ) {
+                int keycode, press, autoRepeat;
+                stream >> keycode >> press >> autoRepeat;
 
-    /*
-      app that registers key/message to be sent back to the app, when it doesn't have focus,
-      when user presses key, unless keyboard has been requested from app.
-      will not send multiple repeats if user holds key
-      i.e. one shot
-     */
-    if ( !keyRegisterList.isEmpty() &&  ke->simpleData.keycode !=0 && press) {
-//        qDebug("<<<<<<<<<<<<<keycode %d", ke->simpleData.keycode);
-      KeyRegisterList::Iterator it;
-      for ( it = keyRegisterList.begin(); it != keyRegisterList.end(); ++it ) {
-        if ( ( *it ).getKeyCode() == ke->simpleData.keycode && !autoRepeat && !keyboardGrabbed() ) {
-          if ( press )
-            qDebug( "press" );
-          else
-            qDebug( "release" );
-          QCopEnvelope( ( *it ).getChannel().utf8(), ( *it ).getMessage().utf8() );
+                const ODeviceButton *db = ODevice::inst ( )-> buttonForKeycode ( keycode );
+                
+                if ( db )
+                    checkButtonAction ( db, keycode, press, autoRepeat );
         }
+        else if ( msg == "keyRegister(int,QCString,QCString)" ) {
+                int k;
+                QCString c, m;
+                stream >> k >> c >> m;
+
+                keyRegisterList.append ( QCopKeyRegister ( k, c, m ));
       }
     }
 
-    if ( !keyboardGrabbed() ) {
-      if ( ke->simpleData.keycode == Key_F9 ) {
-        if ( press )
-          emit datebook();
-        return TRUE;
+void DesktopApplication::sendHeldAction ( )
+{
+        if ( m_last_button ) {
+                m_last_button-> heldAction ( ). send ( );
+                m_last_button = 0;
       }
-      if ( ke->simpleData.keycode == Key_F10 ) {
-        if ( !press && cardSendTimer ) {
-          emit contacts();
-          delete cardSendTimer;
         }
-        else if ( press ) {
-          cardSendTimer = new QTimer();
-          cardSendTimer->start( 2000, TRUE );
-          connect( cardSendTimer, SIGNAL( timeout() ), this, SLOT( sendCard() ) );
+
+
+
+void DesktopApplication::checkButtonAction ( const ODeviceButton *db, int keycode, bool press, bool autoRepeat )
+        {       
+        if ( db ) {
+                if ( !press && !autoRepeat && m_button_timer-> isActive ( )) {
+                        m_button_timer-> stop ( );
+                        if ( !db-> pressedAction ( ). channel ( ). isEmpty ( )) {
+                                db-> pressedAction ( ). send ( );
         }
-        return TRUE;
       }
+                else if ( press && !autoRepeat ) {
+                        m_button_timer-> stop ( );
 
-      if ( ke->simpleData.keycode == Key_F11 ) {
-        if ( press ) emit menu();
-        return TRUE;
+                        if ( !db-> heldAction ( ). channel ( ). isEmpty ( )) {
+                                m_last_button = db;
+                                m_button_timer-> start ( ODevice::inst ( )-> buttonHoldTime ( ), true );
+                        }
+                }
+        }
       }
 
-      if ( ke->simpleData.keycode == Key_F12 ) {
-        while ( activePopupWidget() )
-          activePopupWidget() ->close();
-        if ( press )
-          emit launch();
-        return TRUE;
+bool DesktopApplication::eventFilter ( QObject *o, QEvent *e )
+{
+        if ( e-> type ( ) == QEvent::KeyPress || e-> type ( ) == QEvent::KeyRelease ) {
+                QKeyEvent *ke = (QKeyEvent *) e;
+        
+                const ODeviceButton *db = ODevice::inst ( )-> buttonForKeycode ( ke-> key ( ));
+        
+                if ( db ) {
+                        checkButtonAction ( db, ke-> key ( ), e-> type ( ) == QEvent::KeyPress, ke-> isAutoRepeat ( ));
+                        return true;
+                }
+        }
+        return QPEApplication::eventFilter ( o, e );
+}
+
+#ifdef Q_WS_QWS
+
+bool DesktopApplication::qwsEventFilter( QWSEvent *e )
+{
+        qpedesktop->checkMemory();
+
+        if ( e->type == QWSEvent::Key ) {
+                QWSKeyEvent * ke = (QWSKeyEvent *) e;
+                ushort keycode = ke-> simpleData. keycode;
+
+                if ( !loggedin && keycode != Key_F34 )
+                        return true;
+                        
+                bool press = ke-> simpleData. is_press;
+                bool autoRepeat = ke-> simpleData. is_auto_repeat;
+
+                if ( !keyboardGrabbed ( )) {
+                        // app that registers key/message to be sent back to the app, when it doesn't have focus,
+                        // when user presses key, unless keyboard has been requested from app.
+                        // will not send multiple repeats if user holds key
+                        // i.e. one shot
+                 
+                        if ( keycode != 0 && press && !autoRepeat ) {
+                                for ( KeyRegisterList::Iterator it = keyRegisterList.begin(); it != keyRegisterList.end(); ++it ) {
+                                        if (( *it ). getKeyCode ( ) == keycode ) {
+                                                QCopEnvelope (( *it ). getChannel ( ), ( *it ). getMessage ( ));
+                                                return true;
+                                        }
       }
-      if ( ke->simpleData.keycode == Key_F13 ) {
-        if ( press )
-          emit email();
-        return TRUE;
       }
     }
 
-    if ( ke->simpleData.keycode == Key_F34 ) {
+                if ( keycode == HardKey_Suspend ) {
       if ( press )
         emit power();
-      return TRUE;
+                        return true;
     }
-    // This was used for the iPAQ PowerButton
-    // See main.cpp for new KeyboardFilter
-    //
-    //    if ( ke->simpleData.keycode == Key_SysReq ) {
-    //      if ( press ) emit power();
-    //      return TRUE;
-    //    }
-    if ( ke->simpleData.keycode == Key_F35 ) {
+                else if ( keycode == HardKey_Backlight ) {
       if ( press )
         emit backlight();
-      return TRUE;
+                        return true;
     }
-    if ( ke->simpleData.keycode == Key_F32 ) {
+                else if ( keycode == Key_F32 ) {
       if ( press )
         QCopEnvelope e( "QPE/Desktop", "startSync()" );
-      return TRUE;
+                        return true;
     }
-    if ( ke->simpleData.keycode == Key_F31 && !ke->simpleData.modifiers ) {
+                else if ( keycode == Key_F31 && !ke-> simpleData. modifiers ) { // Symbol Key -> show Unicode IM
       if ( press )
         emit symbol();
-      return TRUE;
+                        return true;
     }
-    if ( ke->simpleData.keycode == Key_NumLock ) {
+                else if ( keycode == Key_NumLock ) {
       if ( press )
         emit numLockStateToggle();
     }
-    if ( ke->simpleData.keycode == Key_CapsLock ) {
+                else if ( keycode == Key_CapsLock ) {
       if ( press )
         emit capsLockStateToggle();
     }
-    if ( ( press && !autoRepeat ) || ( !press && autoRepeat ) )
-      qpedesktop->keyClick();
+                if (( press && !autoRepeat ) || ( !press && autoRepeat )) {
+                        if ( m_keyclick_sound )
+                                ODevice::inst ( )-> keySound ( );
   }
-  else {
-    if ( e->type == QWSEvent::Mouse ) {
+        }
+        else if ( e-> type == QWSEvent::Mouse ) {
       QWSMouseEvent * me = ( QWSMouseEvent * ) e;
-      static bool up = TRUE;
+                static bool up = true;
+
       if ( me->simpleData.state & LeftButton ) {
         if ( up ) {
-          up = FALSE;
-          qpedesktop->screenClick();
+                                up = false;
+                                if ( m_screentap_sound )
+                                        ODevice::inst ( ) -> touchSound ( );
         }
       }
       else {
-        up = TRUE;
-      }
+                        up = true;
     }
   }
 
@@ -430,19 +463,6 @@ bool DesktopApplication::qwsEventFilter( QWSEvent *e )
 #endif
 
 
-void DesktopApplication::sendCard()
-{
-  delete cardSendTimer;
-  cardSendTimer = 0;
-  QString card = getenv( "HOME" );
-  card += "/Applications/addressbook/businesscard.vcf";
-
-  if ( QFile::exists( card ) ) {
-    QCopEnvelope e( "QPE/Obex", "send(QString,QString,QString)" );
-    QString mimetype = "text/x-vCard";
-    e << tr( "business card" ) << card << mimetype;
-  }
-}
 
 #if defined(QPE_HAVE_MEMALERTER)
 QPE_MEMALERTER_IMPL
@@ -486,10 +506,8 @@ Desktop::Desktop() :
   // start services
   startTransferServer();
   ( void ) new IrServer( this );
-  rereadVolumes();
 
   packageSlave = new PackageSlave( this );
-  connect( qApp, SIGNAL( volumeChanged( bool ) ), this, SLOT( rereadVolumes() ) );
 
   qApp->installEventFilter( this );
 
@@ -583,28 +601,6 @@ static bool hasVisibleWindow( const QString& clientname )
   return FALSE;
 }
 
-void Desktop::raiseLauncher()
-{
-  Config cfg( "qpe" ); //F12 'Home'
-  cfg.setGroup( "AppsKey" );
-  QString tempItem;
-  tempItem = cfg.readEntry( "Middle", "Home" );
-  if ( tempItem == "Home" || tempItem.isEmpty() ) {
-    home ( );
-  }
-  else {
-    QCopEnvelope e( "QPE/System", "execute(QString)" );
-    e << tempItem;
-  }
-}
-
-void Desktop::home ( )
-{
-    if ( isVisibleWindow( launcher->winId() ) )
-      launcher->nextView();
-    else
-      launcher->raise();
-}
 
 void Desktop::executeOrModify( const QString& appLnkFile )
 {
@@ -625,61 +621,6 @@ void Desktop::executeOrModify( const QString& appLnkFile )
   }
 }
 
-void Desktop::raiseDatebook()
-{
-  Config cfg( "qpe" ); //F9 'Activity'
-  cfg.setGroup( "AppsKey" );
-  QString tempItem;
-  tempItem = cfg.readEntry( "LeftEnd" , "Calendar" );
-  if ( tempItem == "Calendar" || tempItem.isEmpty() ) {
-    tempItem = "datebook";
-  }
-  QCopEnvelope e( "QPE/System", "execute(QString)" );
-  e << tempItem;
-}
-
-void Desktop::raiseContacts()
-{
-  Config cfg( "qpe" ); //F10, 'Contacts'
-  cfg.setGroup( "AppsKey" );
-  QString tempItem;
-  tempItem = cfg.readEntry( "Left2nd", "Address Book" );
-  if ( tempItem == "Address Book" || tempItem.isEmpty() ) {
-    tempItem = "addressbook";
-  }
-  QCopEnvelope e( "QPE/System", "execute(QString)" );
-  e << tempItem;
-}
-
-void Desktop::raiseMenu()
-{
-  Config cfg( "qpe" ); //F11, 'Menu
-  cfg.setGroup( "AppsKey" );
-  QString tempItem;
-  tempItem = cfg.readEntry( "Right2nd" , "Popup Menu" );
-  if ( tempItem == "Popup Menu" || tempItem.isEmpty() ) {
-    Global::terminateBuiltin( "calibrate" );
-    tb->startMenu() ->launch();
-  }
-  else {
-    QCopEnvelope e( "QPE/System", "execute(QString)" );
-    e << tempItem;
-  }
-}
-
-void Desktop::raiseEmail()
-{
-  Config cfg( "qpe" ); //F13, 'Mail' // only in zaurus, on ipaq mail key is F11
-  cfg.setGroup( "AppsKey" );
-  QString tempItem;
-  tempItem = cfg.readEntry( "RightEnd", "Mail" );
-  if ( tempItem == "Mail" || tempItem == "qtmail" || tempItem.isEmpty() ) {
-    tempItem = "mail";
-  }
-  QCopEnvelope e( "QPE/System", "execute(QString)" );
-  e << tempItem;
-}
-
 // autoStarts apps on resume and start
 void Desktop::execAutoStart()
 {
@@ -727,6 +668,7 @@ void Desktop::togglePower()
   suspendTime = QDateTime::currentDateTime();
 
 #ifdef QWS
+
   if ( Password::needToAuthenticate ( true ) && qt_screen ) {
     // Should use a big black window instead.
     // But this would not show up fast enough
@@ -876,30 +818,24 @@ void Desktop::terminateServers()
   qcopBridge = 0;
 }
 
-void Desktop::rereadVolumes()
+void DesktopApplication::rereadVolumes()
 {
   Config cfg( "qpe" );
   cfg.setGroup( "Volume" );
-  touchclick = cfg.readBoolEntry( "TouchSound" );
-  keyclick = cfg.readBoolEntry( "KeySound" );
-  alarmsound = cfg.readBoolEntry( "AlarmSound" );
-}
 
-void Desktop::keyClick()
-{
-  if ( keyclick )
-    ODevice::inst ( ) -> keySound ( );
+        m_screentap_sound = cfg. readBoolEntry ( "TouchSound" );
+        m_keyclick_sound  = cfg. readBoolEntry ( "KeySound" );
+        m_alarm_sound     = cfg. readBoolEntry ( "AlarmSound" );
 }
 
-void Desktop::screenClick()
+void DesktopApplication::soundAlarm()
 {
-  if ( touchclick )
-    ODevice::inst ( ) -> touchSound ( );
+        if ( me ( )-> m_alarm_sound )
+                ODevice::inst ( )-> alarmSound ( );
 }
 
-void Desktop::soundAlarm()
+DesktopApplication *DesktopApplication::me ( )
 {
-  if ( qpedesktop-> alarmsound )
-    ODevice::inst ( ) -> alarmSound ( );
+        return (DesktopApplication *) qApp;
 }
 
diff --git a/core/launcher/desktop.h b/core/launcher/desktop.h
index 1f8daa0..6cb7ab2 100644
--- a/core/launcher/desktop.h
+++ b/core/launcher/desktop.h
@@ -25,6 +25,7 @@
 #include "shutdownimpl.h"
 
 #include <qpe/qpeapplication.h>
+#include <opie/odevicebutton.h>
 
 #include <qwidget.h>
 #include <qdatetime.h>
@@ -48,13 +49,12 @@ public:
 
   static void switchLCD ( bool on ); // only for togglePower in Desktop
 
+        static void soundAlarm(); // only because QCop soundAlarm() is defined in QPE/TaskBar
+
 signals:
   void menu();
   void home();
-  void datebook();
-  void contacts();
   void launch();
-  void email();
   void backlight();
   void power();
   void symbol();
@@ -72,13 +72,22 @@ protected:
   void restart();
 
 public slots:
-  virtual void desktopMessage ( const QCString &msg, const QByteArray &data );
   virtual void systemMessage ( const QCString &msg, const QByteArray &data );
+        virtual void launcherMessage ( const QCString &msg, const QByteArray &data );
+        void rereadVolumes();
 
 protected slots:
   void shutdown( ShutdownImpl::Type );
   void apmTimeout();
-  void sendCard();
+        void sendHeldAction ( );
+
+protected:
+        virtual bool eventFilter ( QObject *o, QEvent *e );
+        void checkButtonAction ( const Opie::ODeviceButton *db, int keycode, bool press, bool autoRepeat );
+        
+private:
+        static DesktopApplication *me ( );
+        
 private:
     void reloadPowerWarnSettings();
     DesktopPowerAlerter *pa;
@@ -90,6 +99,13 @@ private:
     int m_powerVeryLow;
     int m_powerCritical;
     int m_currentPowerLevel;
+
+        const Opie::ODeviceButton *m_last_button;
+                QTimer *m_button_timer;
+
+        bool m_keyclick_sound  : 1;
+        bool m_screentap_sound : 1;
+        bool m_alarm_sound     : 1;
 };
 
 
@@ -105,16 +121,7 @@ public:
   void show();
   void checkMemory();
 
-  void keyClick();
-  void screenClick();
-  static void soundAlarm();
-
 public slots:
-  void raiseDatebook();
-  void raiseContacts();
-  void raiseMenu();
-  void raiseLauncher();
-  void raiseEmail();
   void execAutoStart();
   void togglePower();
   void toggleLight();
@@ -122,9 +129,6 @@ public slots:
   void toggleCapsLockState();
   void toggleSymbolInput();
   void terminateServers();
-  void rereadVolumes();
-
-  void home ( );
 
 protected:
   void executeOrModify( const QString& appLnkFile );
@@ -144,7 +148,6 @@ private:
   PackageSlave *packageSlave;
 
   QDateTime suspendTime;
-  bool keyclick, touchclick, alarmsound;
 };
 
 
diff --git a/core/launcher/launcher.cpp b/core/launcher/launcher.cpp
index 767efb2..6764338 100644
--- a/core/launcher/launcher.cpp
+++ b/core/launcher/launcher.cpp
@@ -1182,6 +1182,13 @@ void Launcher::launcherMessage( const QCString &msg, const QByteArray &data)
                 stream >> type;
         tabs->setBusyIndicatorType(type);
     }
+    else if ( msg == "home()" ) {
+        if ( isVisibleWindow( winId ( )))
+           nextView ( );
+        else
+           raise ( );
+            
+    }
 }
 
 void Launcher::storageChanged()
diff --git a/core/launcher/main.cpp b/core/launcher/main.cpp
index 8b91f5d..49b41d6 100644
--- a/core/launcher/main.cpp
+++ b/core/launcher/main.cpp
@@ -92,11 +92,6 @@ int initApplication( int argc, char ** argv )
 
     Desktop *d = new Desktop();
 
-    QObject::connect( &a, SIGNAL(menu()), d, SLOT(raiseMenu()) );
-    QObject::connect( &a, SIGNAL(datebook()), d, SLOT(raiseDatebook()) );
-    QObject::connect( &a, SIGNAL(contacts()), d, SLOT(raiseContacts()) );
-    QObject::connect( &a, SIGNAL(launch()),   d, SLOT(raiseLauncher()) );
-    QObject::connect( &a, SIGNAL(email()),   d, SLOT(raiseEmail()) );
     QObject::connect( &a, SIGNAL(power()),   d, SLOT(togglePower()) );
     QObject::connect( &a, SIGNAL(backlight()),   d, SLOT(toggleLight()) );
     QObject::connect( &a, SIGNAL(symbol()),   d, SLOT(toggleSymbolInput()) );
diff --git a/core/launcher/opie-taskbar.control b/core/launcher/opie-taskbar.control
index 13e5715..8bf2113 100644
--- a/core/launcher/opie-taskbar.control
+++ b/core/launcher/opie-taskbar.control
@@ -1,4 +1,4 @@
-Files: bin/qpe apps/Settings/Calibrate.desktop pics/launcher plugins/applets/libsuspendapplet.so* plugins/applets/libhomeapplet.so* plugins/applets/liblogoutapplet.so*
+Files: bin/qpe apps/Settings/Calibrate.desktop pics/launcher pics/devicebuttons/*.png plugins/applets/libsuspendapplet.so* plugins/applets/libhomeapplet.so* plugins/applets/liblogoutapplet.so*
 Priority: required
 Section: opie/system
 Maintainer: Project Opie <opie@handhelds.org>
diff --git a/core/launcher/runningappbar.cpp b/core/launcher/runningappbar.cpp
index 3ac66f2..356200b 100644
--- a/core/launcher/runningappbar.cpp
+++ b/core/launcher/runningappbar.cpp
@@ -124,15 +124,6 @@ void RunningAppBar::removeTask(const AppLnk& appLnk)
                         qDebug("Removing %s from app list.", appLnk.name().latin1());
                         m_AppList.remove();
 
-                        // grab the keyboard back, in case the app crashed/forgot
-
-                        QPEApplication *qpeapp = (QPEApplication *) qApp;
-
-                        if ( appLnk.exec() == qpeapp-> keyboardGrabbedBy ( )) {
-                                qDebug ( "grabbing keyboard back from %s", appLnk.name().latin1());
-                                qpeapp-> grabKeyboard ( );
-                        }
-
                         delete target;
                 }
         }
diff --git a/core/launcher/startmenu.cpp b/core/launcher/startmenu.cpp
index 88c6219..39e07c8 100644
--- a/core/launcher/startmenu.cpp
+++ b/core/launcher/startmenu.cpp
@@ -245,8 +245,9 @@ void StartMenu::launch()
 {
     int y = mapToGlobal( QPoint() ).y() - launchMenu->sizeHint().height();
 
-    if ( launchMenu->isVisible() ) 
+    if ( launchMenu-> isVisible ( )) {
         launchMenu->hide();
+    }
     else {
         QWidget *active = qApp->activeWindow();
         if ( active && active->isPopup() )
diff --git a/core/launcher/taskbar.cpp b/core/launcher/taskbar.cpp
index b4b7df6..77035a3 100644
--- a/core/launcher/taskbar.cpp
+++ b/core/launcher/taskbar.cpp
@@ -280,7 +280,7 @@ void TaskBar::receive( const QCString &msg, const QByteArray &data )
                 sysTray->addApplets();
                 sm->reloadApplets();
         } else if ( msg == "soundAlarm()" ) {
-                Desktop::soundAlarm();
+                DesktopApplication::soundAlarm ( );
         }
         else if ( msg == "setLed(int,bool)" ) {
                 int led, status;
@@ -294,6 +294,16 @@ void TaskBar::receive( const QCString &msg, const QByteArray &data )
                         ODevice::inst ( )-> setLedState ( l, status ? ( canblink ? Led_BlinkSlow : Led_On ) : Led_Off );
                 }
         }
+        else if ( msg == "toggleMenu()" ) {
+                if ( sm-> launchMenu-> isVisible ( ))
+                        sm-> launch ( );
+                else {
+                        QCopEnvelope e ( "QPE/System", "toggleApplicationMenu()" );
+                }
+        }
+        else if ( msg == "toggleStartMenu()" ) {
+                sm-> launch ( );
+        }
 }
 
 QWidget *TaskBar::calibrate(bool)