author | drw <drw> | 2005-04-14 18:29:44 (UTC) |
---|---|---|
committer | drw <drw> | 2005-04-14 18:29:44 (UTC) |
commit | 7a3b813cc3bfbb2f7c31f347c35405851e82aecf (patch) (unidiff) | |
tree | b9d384b6d33e396a0219386b4bf695b092bb606d | |
parent | 5f600ec21480d1d040203407a1d2446781702230 (diff) | |
download | opie-7a3b813cc3bfbb2f7c31f347c35405851e82aecf.zip opie-7a3b813cc3bfbb2f7c31f347c35405851e82aecf.tar.gz opie-7a3b813cc3bfbb2f7c31f347c35405851e82aecf.tar.bz2 |
Fix icon sizing for light and qpe styles
-rw-r--r-- | library/lightstyle.cpp | 30 | ||||
-rw-r--r-- | library/qpestyle.cpp | 8 |
2 files changed, 23 insertions, 15 deletions
diff --git a/library/lightstyle.cpp b/library/lightstyle.cpp index 3bd1623..c5073ca 100644 --- a/library/lightstyle.cpp +++ b/library/lightstyle.cpp | |||
@@ -567,7 +567,7 @@ void LightStyle::drawTab( QPainter *p, const QTabBar *tb, QTab *t, bool selected | |||
567 | QFont f = tb->font(); | 567 | QFont f = tb->font(); |
568 | f.setBold( selected ); | 568 | f.setBold( selected ); |
569 | p->setFont( f ); | 569 | p->setFont( f ); |
570 | #endif | 570 | #endif |
571 | QRect r( t->rect() ); | 571 | QRect r( t->rect() ); |
572 | if ( tb->shape() == QTabBar::RoundedAbove ) { | 572 | if ( tb->shape() == QTabBar::RoundedAbove ) { |
573 | p->setPen( tb->colorGroup().light() ); | 573 | p->setPen( tb->colorGroup().light() ); |
@@ -593,7 +593,7 @@ void LightStyle::drawTab( QPainter *p, const QTabBar *tb, QTab *t, bool selected | |||
593 | p->fillRect( QRect( r.left()+1, r.top()+2, r.width()-2, r.height()-3), | 593 | p->fillRect( QRect( r.left()+1, r.top()+2, r.width()-2, r.height()-3), |
594 | tb->colorGroup().brush( QColorGroup::Button )); | 594 | tb->colorGroup().brush( QColorGroup::Button )); |
595 | //do shading; will not work for pixmap brushes | 595 | //do shading; will not work for pixmap brushes |
596 | QColor bg = tb->colorGroup().button(); | 596 | QColor bg = tb->colorGroup().button(); |
597 | // int h,s,v; | 597 | // int h,s,v; |
598 | // bg.hsv( &h, &s, &v ); | 598 | // bg.hsv( &h, &s, &v ); |
599 | int n = r.height()/2; | 599 | int n = r.height()/2; |
@@ -606,7 +606,7 @@ void LightStyle::drawTab( QPainter *p, const QTabBar *tb, QTab *t, bool selected | |||
606 | int x2 = r.right()-1; | 606 | int x2 = r.right()-1; |
607 | p->drawLine( x1, y, x2, y ); | 607 | p->drawLine( x1, y, x2, y ); |
608 | } | 608 | } |
609 | 609 | ||
610 | } | 610 | } |
611 | 611 | ||
612 | p->setPen( tb->colorGroup().light() ); | 612 | p->setPen( tb->colorGroup().light() ); |
@@ -686,7 +686,7 @@ void LightStyle::drawTab(QPainter *p, const QTabBar *tabbar, QTab *tab, | |||
686 | QRegion trir(cliptri); | 686 | QRegion trir(cliptri); |
687 | p->setClipRegion(tabr - trir); | 687 | p->setClipRegion(tabr - trir); |
688 | 688 | ||
689 | p->setPen( NoPen ); | 689 | p->setPen( NoPen ); |
690 | p->setBrush(g.brush(selected ? QColorGroup::Background : QColorGroup::Mid)); | 690 | p->setBrush(g.brush(selected ? QColorGroup::Background : QColorGroup::Mid)); |
691 | 691 | ||
692 | fr.setWidth(fr.width() - 1); | 692 | fr.setWidth(fr.width() - 1); |
@@ -882,9 +882,9 @@ void LightStyle::drawScrollBarControls( QPainter* p, const QScrollBar* scrollbar | |||
882 | int extent = ((scrollbar->orientation() == Horizontal) ? | 882 | int extent = ((scrollbar->orientation() == Horizontal) ? |
883 | scrollbar->height() : scrollbar->width()); | 883 | scrollbar->height() : scrollbar->width()); |
884 | 884 | ||
885 | 885 | ||
886 | int fudge = 3; //####disgusting hack | 886 | int fudge = 3; //####disgusting hack |
887 | 887 | ||
888 | if (scrollbar->orientation() == Horizontal) { | 888 | if (scrollbar->orientation() == Horizontal) { |
889 | subR.setRect(0, defaultFrameWidth(), | 889 | subR.setRect(0, defaultFrameWidth(), |
890 | buttonDim + fudge, buttonDim); | 890 | buttonDim + fudge, buttonDim); |
@@ -968,13 +968,13 @@ void LightStyle::drawScrollBarControls( QPainter* p, const QScrollBar* scrollbar | |||
968 | if ( sliderR.isValid() ) { | 968 | if ( sliderR.isValid() ) { |
969 | p->fillRect( sliderR.x(), sliderR.y(), 2, 2, | 969 | p->fillRect( sliderR.x(), sliderR.y(), 2, 2, |
970 | g.brush( QColorGroup::Mid )); | 970 | g.brush( QColorGroup::Mid )); |
971 | p->fillRect( sliderR.x() + sliderR.width() - 2, | 971 | p->fillRect( sliderR.x() + sliderR.width() - 2, |
972 | sliderR.y(), 2, 2, | 972 | sliderR.y(), 2, 2, |
973 | g.brush( QColorGroup::Mid )); | 973 | g.brush( QColorGroup::Mid )); |
974 | p->fillRect( sliderR.x() + sliderR.width() - 2, | 974 | p->fillRect( sliderR.x() + sliderR.width() - 2, |
975 | sliderR.y() + sliderR.height() - 2, 2, 2, | 975 | sliderR.y() + sliderR.height() - 2, 2, 2, |
976 | g.brush( QColorGroup::Mid )); | 976 | g.brush( QColorGroup::Mid )); |
977 | p->fillRect( sliderR.x(), | 977 | p->fillRect( sliderR.x(), |
978 | sliderR.y() + sliderR.height() - 2, 2, 2, | 978 | sliderR.y() + sliderR.height() - 2, 2, 2, |
979 | g.brush( QColorGroup::Mid )); | 979 | g.brush( QColorGroup::Mid )); |
980 | 980 | ||
@@ -1118,7 +1118,7 @@ int LightStyle::extraPopupMenuItemWidth( bool checkable, int maxpmw, QMenuItem* | |||
1118 | */ | 1118 | */ |
1119 | int LightStyle::popupMenuItemHeight( bool /*checkable*/, QMenuItem* mi, const QFontMetrics& fm ) | 1119 | int LightStyle::popupMenuItemHeight( bool /*checkable*/, QMenuItem* mi, const QFontMetrics& fm ) |
1120 | { | 1120 | { |
1121 | #ifndef QT_NO_MENUDATA | 1121 | #ifndef QT_NO_MENUDATA |
1122 | int h = 0; | 1122 | int h = 0; |
1123 | if ( mi->isSeparator() ) // separator height | 1123 | if ( mi->isSeparator() ) // separator height |
1124 | h = motifSepHeight; | 1124 | h = motifSepHeight; |
@@ -1128,7 +1128,7 @@ int LightStyle::popupMenuItemHeight( bool /*checkable*/, QMenuItem* mi, const QF | |||
1128 | h = fm.height() + 2*motifItemVMargin + 2*motifItemFrame; | 1128 | h = fm.height() + 2*motifItemVMargin + 2*motifItemFrame; |
1129 | 1129 | ||
1130 | if ( !mi->isSeparator() && mi->iconSet() != 0 ) { | 1130 | if ( !mi->isSeparator() && mi->iconSet() != 0 ) { |
1131 | h = QMAX( h, mi->iconSet()->pixmap( QIconSet::Small, QIconSet::Normal ).height() + 2*motifItemFrame ); | 1131 | h = QMAX( h, mi->iconSet()->pixmap().height() + 2*motifItemFrame ); |
1132 | } | 1132 | } |
1133 | if ( mi->custom() ) | 1133 | if ( mi->custom() ) |
1134 | h = QMAX( h, mi->custom()->sizeHint().height() + 2*motifItemVMargin + 2*motifItemFrame ) - 1; | 1134 | h = QMAX( h, mi->custom()->sizeHint().height() + 2*motifItemVMargin + 2*motifItemFrame ) - 1; |
@@ -1140,7 +1140,7 @@ void LightStyle::drawPopupMenuItem( QPainter* p, bool checkable, int maxpmw, int | |||
1140 | const QPalette& pal, | 1140 | const QPalette& pal, |
1141 | bool act, bool enabled, int x, int y, int w, int h) | 1141 | bool act, bool enabled, int x, int y, int w, int h) |
1142 | { | 1142 | { |
1143 | #ifndef QT_NO_MENUDATA | 1143 | #ifndef QT_NO_MENUDATA |
1144 | const QColorGroup & g = pal.active(); | 1144 | const QColorGroup & g = pal.active(); |
1145 | bool dis = !enabled; | 1145 | bool dis = !enabled; |
1146 | QColorGroup itemg = dis ? pal.disabled() : pal.active(); | 1146 | QColorGroup itemg = dis ? pal.disabled() : pal.active(); |
@@ -1182,7 +1182,11 @@ void LightStyle::drawPopupMenuItem( QPainter* p, bool checkable, int maxpmw, int | |||
1182 | QIconSet::Mode mode = dis ? QIconSet::Disabled : QIconSet::Normal; | 1182 | QIconSet::Mode mode = dis ? QIconSet::Disabled : QIconSet::Normal; |
1183 | if (act && !dis ) | 1183 | if (act && !dis ) |
1184 | mode = QIconSet::Active; | 1184 | mode = QIconSet::Active; |
1185 | QPixmap pixmap = mi->iconSet()->pixmap( QIconSet::Small, mode ); | 1185 | QPixmap pixmap; |
1186 | if ( mode == QIconSet::Disabled ) | ||
1187 | pixmap = mi->iconSet()->pixmap( QIconSet::Automatic, mode ); | ||
1188 | else | ||
1189 | pixmap = mi->iconSet()->pixmap(); | ||
1186 | int pixw = pixmap.width(); | 1190 | int pixw = pixmap.width(); |
1187 | int pixh = pixmap.height(); | 1191 | int pixh = pixmap.height(); |
1188 | if ( act && !dis ) { | 1192 | if ( act && !dis ) { |
diff --git a/library/qpestyle.cpp b/library/qpestyle.cpp index 0566f6b..9503e02 100644 --- a/library/qpestyle.cpp +++ b/library/qpestyle.cpp | |||
@@ -1035,7 +1035,7 @@ int QPEStyle::popupMenuItemHeight( bool /*checkable*/, QMenuItem* mi, const QFon | |||
1035 | h = fm.height() + 2*motifItemVMargin + 2*motifItemFrame - 1; | 1035 | h = fm.height() + 2*motifItemVMargin + 2*motifItemFrame - 1; |
1036 | 1036 | ||
1037 | if ( !mi->isSeparator() && mi->iconSet() != 0 ) { | 1037 | if ( !mi->isSeparator() && mi->iconSet() != 0 ) { |
1038 | h = QMAX( h, mi->iconSet()->pixmap( QIconSet::Small, QIconSet::Normal ).height() + 2*motifItemFrame ); | 1038 | h = QMAX( h, mi->iconSet()->pixmap().height() + 2*motifItemFrame ); |
1039 | } | 1039 | } |
1040 | if ( mi->custom() ) | 1040 | if ( mi->custom() ) |
1041 | h = QMAX( h, mi->custom()->sizeHint().height() + 2*motifItemVMargin + 2*motifItemFrame ) - 1; | 1041 | h = QMAX( h, mi->custom()->sizeHint().height() + 2*motifItemVMargin + 2*motifItemFrame ) - 1; |
@@ -1089,7 +1089,11 @@ void QPEStyle::drawPopupMenuItem( QPainter* p, bool checkable, int maxpmw, int t | |||
1089 | QIconSet::Mode mode = dis ? QIconSet::Disabled : QIconSet::Normal; | 1089 | QIconSet::Mode mode = dis ? QIconSet::Disabled : QIconSet::Normal; |
1090 | if (act && !dis ) | 1090 | if (act && !dis ) |
1091 | mode = QIconSet::Active; | 1091 | mode = QIconSet::Active; |
1092 | QPixmap pixmap = mi->iconSet()->pixmap( QIconSet::Small, mode ); | 1092 | QPixmap pixmap; |
1093 | if ( mode == QIconSet::Disabled ) | ||
1094 | pixmap = mi->iconSet()->pixmap( QIconSet::Automatic, mode ); | ||
1095 | else | ||
1096 | pixmap = mi->iconSet()->pixmap(); | ||
1093 | int pixw = pixmap.width(); | 1097 | int pixw = pixmap.width(); |
1094 | int pixh = pixmap.height(); | 1098 | int pixh = pixmap.height(); |
1095 | if ( act && !dis ) { | 1099 | if ( act && !dis ) { |