Every file in this commit makes a call to a function which returns a value.

Each file also didn't check the return value.

This commit changes it so that every single non-checked call in these files
is checked.

14 files changed, 62 insertions, 45 deletions

diff --git a/core/multimedia/opieplayer/om3u.cpp b/core/multimedia/opieplayer/om3u.cpp
index 48aa47e..68ea015 100644
--- a/core/multimedia/opieplayer/om3u.cpp
+++ b/core/multimedia/opieplayer/om3u.cpp
@@ -47,7 +47,8 @@ Om3u::Om3u( const QString &filePath, int mode)
       : QStringList (){
 //odebug << "<<<<<<<new m3u "+filePath << oendl;
   f.setName(filePath);
-  f.open(mode);
+  if ( !f.open(mode) )
+      owarn << "Failed to open file " << f.name() << oendl;
 }
 
 Om3u::~Om3u(){}
diff --git a/libopie2/opiemm/opieexif.cpp b/libopie2/opiemm/opieexif.cpp
index de49937..653216c 100644
--- a/libopie2/opiemm/opieexif.cpp
+++ b/libopie2/opiemm/opieexif.cpp
@@ -205,7 +205,7 @@ int ExifData::ReadJpegSections (QFile & infile, ReadMode_t ReadMode)
                 if (ReadMode & READ_IMAGE){
                     unsigned long size;
 
-                    size = QMAX( 0ul, infile.size()-infile.at() );
+                    size = infile.size()-infile.at();
                     Data = (uchar *)malloc(size);
                     if (Data == NULL){
                         return false;
@@ -809,7 +809,11 @@ bool ExifData::scan(const QString & path)
     int ret;
 
     QFile f(path);
-    f.open(IO_ReadOnly);
+    if ( !f.open(IO_ReadOnly) ) {
+        owarn << "Unable to open file " << f.name() << " readonly" << oendl;
+        DiscardData();
+        return false;
+    }
 
     // Scan the JPEG headers.
     ret = ReadJpegSections(f, READ_EXIF);
diff --git a/noncore/apps/opie-console/filereceive.cpp b/noncore/apps/opie-console/filereceive.cpp
index 452be60..41e6888 100644
--- a/noncore/apps/opie-console/filereceive.cpp
+++ b/noncore/apps/opie-console/filereceive.cpp
@@ -3,6 +3,7 @@
 #include <signal.h>
 #include <errno.h>
 
+#include <opie2/odebug.h>
 #include <qsocketnotifier.h>
 
 #include "io_layer.h"
@@ -148,7 +149,8 @@ void FileReceive::slotRead() {
 }
 void FileReceive::slotExec() {
     char buf[2];
-    ::read(m_term[0], buf, 1 );
+    if (::read(m_term[0], buf, 1 ) == -1)
+        owarn << "read of m_term[0] failed" << oendl;
     delete m_proc;
     delete m_not;
     m_not = m_proc = 0l;
diff --git a/noncore/apps/opie-console/filetransfer.cpp b/noncore/apps/opie-console/filetransfer.cpp
index 7eebc65..6e2d2d5 100644
--- a/noncore/apps/opie-console/filetransfer.cpp
+++ b/noncore/apps/opie-console/filetransfer.cpp
@@ -4,6 +4,7 @@
 #include <fcntl.h>
 #include <unistd.h>
 
+#include <opie2/odebug.h>
 #include <qsocketnotifier.h>
 
 #include "procctl.h"
@@ -234,7 +235,8 @@ void FileTransfer::cancel() {
 }
 void FileTransfer::slotExec() {
     char buf[2];
-    ::read(m_term[0], buf, 1 );
+    if (::read(m_term[0], buf, 1 ) == -1)
+        owarn << "read of m_term[0] failed" << oendl;
     delete m_proc;
     delete m_not;
     m_proc = m_not = 0l;
diff --git a/noncore/apps/opie-console/logger.cpp b/noncore/apps/opie-console/logger.cpp
index 6620faf..0fdeca0 100644
--- a/noncore/apps/opie-console/logger.cpp
+++ b/noncore/apps/opie-console/logger.cpp
@@ -1,5 +1,6 @@
 #include <qfile.h>
 #include <qtextstream.h>
+#include <opie2/odebug.h>
 
 #include "logger.h"
 
@@ -8,7 +9,8 @@ Logger::Logger() {}
 
 Logger::Logger(const QString fileName) {
         m_file.setName(fileName);
-        m_file.open(IO_ReadWrite);
+        if ( !m_file.open(IO_ReadWrite) )
+            owarn << "failed to open " << m_file.name() << oendl;
 }
 
 Logger::~Logger() {
diff --git a/noncore/apps/opie-console/mainwindow.cpp b/noncore/apps/opie-console/mainwindow.cpp
index 18c0434..aba7244 100644
--- a/noncore/apps/opie-console/mainwindow.cpp
+++ b/noncore/apps/opie-console/mainwindow.cpp
@@ -824,7 +824,8 @@ void MainWindow::slotSaveHistory() {
 
 
     QFile file(filename);
-    file.open(IO_WriteOnly );
+    if ( !file.open(IO_WriteOnly ) ) return;
+
     QTextStream str(&file );
     if ( currentSession() )
         currentSession()->emulationHandler()->emulation()->streamHistory(&str);
diff --git a/noncore/apps/opie-console/script.cpp b/noncore/apps/opie-console/script.cpp
index faea412..8d35776 100644
--- a/noncore/apps/opie-console/script.cpp
+++ b/noncore/apps/opie-console/script.cpp
@@ -6,13 +6,15 @@ Script::Script() {
 
 Script::Script(const QString fileName) {
     QFile file(fileName);
-    file.open(IO_ReadOnly );
+    if ( !file.open(IO_ReadOnly ) )
+        return;
     m_script = file.readAll();
 }
 
 void Script::saveTo(const QString fileName) const {
     QFile file(fileName);
-    file.open(IO_WriteOnly);
+    if ( !file.open(IO_WriteOnly) )
+        return;
     file.writeBlock(m_script);
     file.close();
 }
diff --git a/noncore/apps/opie-gutenbrowser/gutenbrowser.cpp b/noncore/apps/opie-gutenbrowser/gutenbrowser.cpp
index 733db17..8b02f9f 100644
--- a/noncore/apps/opie-gutenbrowser/gutenbrowser.cpp
+++ b/noncore/apps/opie-gutenbrowser/gutenbrowser.cpp
@@ -845,13 +845,9 @@ bool Gutenbrowser::load( const char *fileName) {
 } // end load
 
 void Gutenbrowser::Search() {
-
-                        //    if( searchDlg->isHidden())
-                {
                                 odebug << "Starting search dialog" << oendl;
                                 searchDlg = new SearchDialog( this, "Etext Search", true);
                                 searchDlg->setCaption( tr( "Etext Search" ));
-                                        //        searchDlg->setLabel( "- searches etext");
                                 connect( searchDlg,SIGNAL( search_signal()),this,SLOT( search_slot()));
                                 connect( searchDlg,SIGNAL( search_done_signal()),this,SLOT( searchdone_slot()));
 
@@ -859,8 +855,6 @@ void Gutenbrowser::Search() {
                                 QString string = searchDlg->searchString;
                                 Lview->deselect();
                                 searchDlg->show();
-                                searchDlg->result();
-                }
 }
 
 void Gutenbrowser::search_slot( ) {
diff --git a/noncore/apps/opie-gutenbrowser/helpwindow.cpp b/noncore/apps/opie-gutenbrowser/helpwindow.cpp
index 4bdac02..f444a2e 100644
--- a/noncore/apps/opie-gutenbrowser/helpwindow.cpp
+++ b/noncore/apps/opie-gutenbrowser/helpwindow.cpp
@@ -196,10 +196,11 @@ HelpWindow::~HelpWindow()
   history.append( *it );
 
     QFile f( QDir::currentDirPath() + "/.history" );
-    f.open( IO_WriteOnly );
+    if ( f.open( IO_WriteOnly ) ) {
     QDataStream s( &f );
     s << history;
     f.close();
+    }
 
     bookmarks.clear();
     QMap<int, QString>::Iterator it2 = mBookmarks.begin();
@@ -207,22 +208,14 @@ HelpWindow::~HelpWindow()
   bookmarks.append( *it2 );
 
     QFile f2( QDir::currentDirPath() + "/.bookmarks" );
-    f2.open( IO_WriteOnly );
+    if ( !f2.open( IO_WriteOnly ) )
+        return;
+
     QDataStream s2( &f2 );
     s2 << bookmarks;
     f2.close();
 }
 
-//  void HelpWindow::about()
-//  {
-//      QMessageBox::about( this, "Gutenbrowser", "<p>Thanks to Trolltech for this</p>" );
-//  }
-
-//  void HelpWindow::aboutQt()
-//  {
-//      QMessageBox::aboutQt( this, "QBrowser" );
-//  }
-
 void HelpWindow::openFile()
 {
 #ifndef QT_NO_FILEDIALOG
@@ -292,27 +285,32 @@ void HelpWindow::pathSelected( const QString &_path )
 
 void HelpWindow::readHistory()
 {
-    if ( QFile::exists( QDir::currentDirPath() + "/.history" ) ) {
+    if ( !QFile::exists( QDir::currentDirPath() + "/.history" ) )
+        return;
+
   QFile f( QDir::currentDirPath() + "/.history" );
-  f.open( IO_ReadOnly );
+    if ( !f.open( IO_ReadOnly ) )
+        return;
+
   QDataStream s( &f );
   s >> history;
   f.close();
   while ( history.count() > 20 )
       history.remove( history.begin() );
     }
-}
 
 void HelpWindow::readBookmarks()
 {
-    if ( QFile::exists( QDir::currentDirPath() + "/.bookmarks" ) ) {
+    if ( !QFile::exists( QDir::currentDirPath() + "/.bookmarks" ) )
+        return;
+
   QFile f( QDir::currentDirPath() + "/.bookmarks" );
-  f.open( IO_ReadOnly );
+    if ( !f.open( IO_ReadOnly ) )
+        return;
   QDataStream s( &f );
   s >> bookmarks;
   f.close();
     }
-}
 
 void HelpWindow::histChosen( int i )
 {
diff --git a/noncore/graphics/opie-eye/slave/bmp_slave.cpp b/noncore/graphics/opie-eye/slave/bmp_slave.cpp
index 2fa825f..0efadac 100644
--- a/noncore/graphics/opie-eye/slave/bmp_slave.cpp
+++ b/noncore/graphics/opie-eye/slave/bmp_slave.cpp
@@ -82,10 +82,8 @@ namespace {
 
     void BmpHeader::read_data() {
         memset(&m_Header,0,sizeof(pBmpHeader));
-        _inputfile.open(IO_Raw|IO_ReadOnly);
-        if (!_inputfile.isOpen()) {
+        if (!_inputfile.open(IO_Raw|IO_ReadOnly))
             return;
-        }
         QDataStream s(&_inputfile);
         s.setByteOrder( QDataStream::LittleEndian );
         s.readRawBytes(m_Header.type,2);
diff --git a/noncore/net/ftplib/ftplib.c b/noncore/net/ftplib/ftplib.c
index 421f855..efcd6f0 100644
--- a/noncore/net/ftplib/ftplib.c
+++ b/noncore/net/ftplib/ftplib.c
@@ -958,7 +958,8 @@ GLOBALDEF int FtpWrite(void *buf, int len, netbuf *nData)
         i = writeline(buf, len, nData);
     else
       {
-          socket_wait(nData);
+          if (socket_wait(nData) < 0)
+              fprintf(stderr, "FtpWrite: socket_wait failed with %s\n", nData->ctrl->response);
           i = net_write(nData->handle, buf, len);
       }
     if (i == -1)
@@ -1339,7 +1340,10 @@ GLOBALDEF void FtpQuit(netbuf *nControl)
 {
     if (nControl->dir != FTPLIB_CONTROL)
         return;
-    FtpSendCmd("QUIT",'2',nControl);
+    if (FtpSendCmd("QUIT",'2',nControl) == 1) {
+        if (ftplib_debug > 2)
+            fprintf(stderr, "FtpQuit: FtpSendCmd(QUIT) failed\n");
+    }
     net_close(nControl->handle);
     free(nControl->buf);
     free(nControl);
diff --git a/noncore/todayplugins/stockticker/stockticker/helpwindow.cpp b/noncore/todayplugins/stockticker/stockticker/helpwindow.cpp
index 410d642..2498bf9 100644
--- a/noncore/todayplugins/stockticker/stockticker/helpwindow.cpp
+++ b/noncore/todayplugins/stockticker/stockticker/helpwindow.cpp
@@ -182,10 +182,11 @@ HelpWindow::~HelpWindow()
   history.append( *it );
 
     QFile f( QDir::currentDirPath() + "/.history" );
-    f.open( IO_WriteOnly );
+    if ( f.open( IO_WriteOnly ) ) {
     QDataStream s( &f );
     s << history;
     f.close();
+    }
 
     bookmarks.clear();
     QMap<int, QString>::Iterator it2 = mBookmarks.begin();
@@ -193,7 +194,8 @@ HelpWindow::~HelpWindow()
   bookmarks.append( *it2 );
 
     QFile f2( QDir::currentDirPath() + "/.bookmarks" );
-    f2.open( IO_WriteOnly );
+    if ( !f2.open( IO_WriteOnly ) )
+        return;
     QDataStream s2( &f2 );
     s2 << bookmarks;
     f2.close();
@@ -232,7 +234,8 @@ void HelpWindow::readHistory()
 {
     if ( QFile::exists( QDir::currentDirPath() + "/.history" ) ) {
   QFile f( QDir::currentDirPath() + "/.history" );
-  f.open( IO_ReadOnly );
+        if ( !f.open( IO_ReadOnly ) )
+            return;
   QDataStream s( &f );
   s >> history;
   f.close();
@@ -245,7 +248,8 @@ void HelpWindow::readBookmarks()
 {
     if ( QFile::exists( QDir::currentDirPath() + "/.bookmarks" ) ) {
   QFile f( QDir::currentDirPath() + "/.bookmarks" );
-  f.open( IO_ReadOnly );
+            if ( !f.open( IO_ReadOnly ) )
+                return;
   QDataStream s( &f );
   s >> bookmarks;
   f.close();
diff --git a/noncore/todayplugins/weather/weatherpluginwidget.cpp b/noncore/todayplugins/weather/weatherpluginwidget.cpp
index fe54051..27624c5 100644
--- a/noncore/todayplugins/weather/weatherpluginwidget.cpp
+++ b/noncore/todayplugins/weather/weatherpluginwidget.cpp
@@ -104,7 +104,8 @@ void WeatherPluginWidget::retreiveData()
 
         *proc << "wget" << "-q" << remoteFile << "-O" << localFile;
         connect( proc, SIGNAL( processExited(Opie::Core::OProcess*) ), this, SLOT( dataRetrieved(Opie::Core::OProcess*) ) );
-        proc->start();
+        if ( !proc->start() )
+            weatherLabel->setText( tr( "Could not start wget process." ) );
 }
 
 void WeatherPluginWidget::displayWeather()
diff --git a/noncore/tools/opie-sh/inputdialog.cpp b/noncore/tools/opie-sh/inputdialog.cpp
index 8046795..1dd8bf7 100644
--- a/noncore/tools/opie-sh/inputdialog.cpp
+++ b/noncore/tools/opie-sh/inputdialog.cpp
@@ -40,12 +40,14 @@ InputDialog::InputDialog(int w, int h, int newtype, QString labelString, QString
                 if(!filename.isNull())
                 {
                         QFile file(filename);
-                        file.open(IO_ReadOnly);
+                        if (file.open(IO_ReadOnly))
+                        {
                         QTextStream stream(&file);
                         QString string = stream.read();
 
                         comboBox->insertStringList(QStringList::split('\n', string));
                 }
+                }
                 else
                 {
                         QFile file;
@@ -63,12 +65,14 @@ InputDialog::InputDialog(int w, int h, int newtype, QString labelString, QString
                 if(!filename.isNull())
                 {
                         QFile file(filename);
-                        file.open(IO_ReadOnly);
+                        if (file.open(IO_ReadOnly))
+                        {
                         QTextStream stream(&file);
                         QString string = stream.read();
 
                         listBox->insertStringList(QStringList::split('\n', string));
                 }
+                }
                 else
                 {
                         QFile file;