All day events are not from 00:00 to 23:59 they're all day now.

5 files changed, 107 insertions, 49 deletions

diff --git a/core/pim/datebook/datebookday.cpp b/core/pim/datebook/datebookday.cpp
index 9cc5fcd..5474cfc 100644
--- a/core/pim/datebook/datebookday.cpp
+++ b/core/pim/datebook/datebookday.cpp
@@ -568,3 +568,3 @@ DateBookDayWidget::DateBookDayWidget( const EffectiveEvent &e,
 {
-    bool whichClock = db->dayView()->whichClock();
+
 
@@ -599,23 +599,10 @@ DateBookDayWidget::DateBookDayWidget( const EffectiveEvent &e,
     text = "<b>" + strDesc + "</b><br>" + "<i>"
-        + strCat + "</i>"
-        + "<br><b>" + tr("Start") + "</b>: ";
-
-
-    if ( e.startDate() != ev.date() ) {
-        // multi-day event.  Show start date
-        text += TimeString::longDateString( e.startDate() );
-    } else {
-        // Show start time.
-        text += TimeString::timeString( ev.start(), whichClock, FALSE );
-    }
+           + strCat + "</i><br>";
+    if (ev.event().type() == Event::Normal )
+        setEventText( text );
+    else
+        setAllDayText( text );
 
-    text += "<br><b>" + tr("End") + "</b>: ";
-    if ( e.endDate() != ev.date() ) {
-        // multi-day event.  Show end date
-        text += TimeString::longDateString( e.endDate() );
-    } else {
-        // Show end time.
-        text += TimeString::timeString( ev.end(), whichClock, FALSE );
-    }
     text += "<br><br>" + strNote;
+
     setBackgroundMode( PaletteBase );
@@ -637,2 +624,26 @@ DateBookDayWidget::DateBookDayWidget( const EffectiveEvent &e,
 }
+void DateBookDayWidget::setAllDayText( QString &text ) {
+    text += "<b>" + tr("This is an all day event.") + "</b><br>";
+}
+void DateBookDayWidget::setEventText( QString& text ) {
+    bool whichClock = dateBook->dayView()->whichClock();
+    text += "<b>" + tr("Start") + "</b>: ";
+    if ( ev.startDate() != ev.date() ) {
+        // multi-day event.  Show start date
+        text += TimeString::longDateString( ev.startDate() );
+    } else {
+        // Show start time.
+        text += TimeString::timeString( ev.start(), whichClock, FALSE );
+    }
+
+    text += "<br><b>" + tr("End") + "</b>: ";
+    if ( ev.endDate() != ev.date() ) {
+        // multi-day event.  Show end date
+        text += TimeString::longDateString( ev.endDate() );
+    } else {
+        // Show end time.
+        text += TimeString::timeString( ev.end(), whichClock, FALSE );
+    }
+
+}
 
@@ -691,2 +702,3 @@ void DateBookDayWidget::paintEvent( QPaintEvent *e )
         d = 20;
+        y += 20;
     }
diff --git a/core/pim/datebook/datebookday.h b/core/pim/datebook/datebookday.h
index be7cc45..db1cd04 100644
--- a/core/pim/datebook/datebookday.h
+++ b/core/pim/datebook/datebookday.h
@@ -42,3 +42,3 @@ public:
     bool whichClock() const;
-    
+
     void setRowStyle( int style );
@@ -57,3 +57,3 @@ protected:
     virtual void paintFocus( QPainter *p, const QRect &cr );
-      
+
     virtual void resizeEvent( QResizeEvent *e );
@@ -78,3 +78,3 @@ public:
     const EffectiveEvent &event() const { return ev; }
-        
+
 signals:
@@ -89,2 +89,13 @@ protected:
 private:
+    /**
+     * Sets the text for an all day Event
+     * All day events have no time associated
+     */
+    void setAllDayText( QString& text );
+
+    /**
+     * Sets the EventText
+     * it got a start and an end Time
+     */
+    void setEventText( QString& text );
     const EffectiveEvent ev;
@@ -108,3 +119,3 @@ public:
 
-signals: 
+signals:
 
@@ -121,10 +132,10 @@ private:
 class WidgetListClass : public QList<DateBookDayWidget>
-        {
+{
         private:
-                
-        int compareItems( QCollection::Item s1, QCollection::Item s2 ) 
-        { 
+
+        int compareItems( QCollection::Item s1, QCollection::Item s2 )
+        {
                 //hmm, don't punish me for that ;)
                 if (reinterpret_cast<DateBookDayWidget*>(s1)->geometry().height() > reinterpret_cast<DateBookDayWidget*>(s2)->geometry().height())
-                { 
+                {
                         return -1;
@@ -135,3 +146,3 @@ class WidgetListClass : public QList<DateBookDayWidget>
         }
-        
+
 
diff --git a/core/pim/datebook/datebookweek.cpp b/core/pim/datebook/datebookweek.cpp
index 6532ba4..e16f516 100644
--- a/core/pim/datebook/datebookweek.cpp
+++ b/core/pim/datebook/datebookweek.cpp
@@ -463,2 +463,29 @@ void DateBookWeek::getEvents()
 
+void DateBookWeek::generateAllDayTooltext( QString& text ) {
+    text += "<b>" + tr("This is an all day event.") + "</b><br>";
+}
+
+void DateBookWeek::generateNormalTooltext( QString& str,
+                                           const EffectiveEvent &ev ) {
+    str += "<b>" + QObject::tr("Start") + "</b>: ";
+
+    if ( ev.startDate() != ev.date() ) {
+        // multi-day event.  Show start date
+        str += TimeString::longDateString( ev.startDate() );
+    } else {
+        // Show start time.
+        str += TimeString::timeString(ev.start(), ampm, FALSE );
+    }
+
+
+    str += "<br><b>" + QObject::tr("End") + "</b>: ";
+    if ( ev.endDate() != ev.date() ) {
+        // multi-day event.  Show end date
+        str += TimeString::longDateString( ev.endDate() );
+    } else {
+        // Show end time.
+        str += TimeString::timeString( ev.end(), ampm, FALSE );
+    }
+}
+
 void DateBookWeek::slotShowEvent( const EffectiveEvent &ev )
@@ -497,22 +524,11 @@ void DateBookWeek::slotShowEvent( const EffectiveEvent &ev )
     QString str = "<b>" + strDesc + "</b><br>" + "<i>"
-            + strCat + "</i>"
-            + "<br>" + TimeString::longDateString( ev.date() )
-            + "<br><b>" + QObject::tr("Start") + "</b>: ";
+                  + strCat + "</i>"
+                  + "<br>" + TimeString::longDateString( ev.date() )
+                  + "<br>";
 
-    if ( ev.startDate() != ev.date() ) {
-        // multi-day event.  Show start date
-        str += TimeString::longDateString( ev.startDate() );
-    } else {
-        // Show start time.
-        str += TimeString::timeString(ev.start(), ampm, FALSE );
-    }
+    if (ev.event().type() == Event::Normal )
+        generateNormalTooltext( str, ev );
+    else
+        generateAllDayTooltext( str );
 
-    str += "<br><b>" + QObject::tr("End") + "</b>: ";
-    if ( ev.endDate() != ev.date() ) {
-        // multi-day event.  Show end date
-        str += TimeString::longDateString( ev.endDate() );
-    } else {
-        // Show end time.
-        str += TimeString::timeString( ev.end(), ampm, FALSE );
-    }
     str += "<br><br>" + strNote;
diff --git a/core/pim/datebook/datebookweek.h b/core/pim/datebook/datebookweek.h
index 6e675f1..acbc2c7 100644
--- a/core/pim/datebook/datebookweek.h
+++ b/core/pim/datebook/datebookweek.h
@@ -135,2 +135,18 @@ private:
     void getEvents();
+
+    /**
+     * Wow that's a hell lot of code duplication
+     * in datebook. I vote for a common base class
+     * but never the less. This add a note
+     * that the Event is an all day event
+     *
+     */
+    void generateAllDayTooltext( QString& text );
+
+    /**
+     * This will add the times to the text
+     * It will be shown in the Tooltip bubble
+     */
+    void generateNormalTooltext( QString& text,
+                                 const EffectiveEvent &ev);
     int year;
diff --git a/core/pim/datebook/datebookweeklst.cpp b/core/pim/datebook/datebookweeklst.cpp
index 29519c1..5eefc27 100644
--- a/core/pim/datebook/datebookweeklst.cpp
+++ b/core/pim/datebook/datebookweeklst.cpp
@@ -156,3 +156,6 @@ DateBookWeekLstEvent::DateBookWeekLstEvent(const EffectiveEvent &ev,
     } else {
-      sprintf(s,"%.2d:%.2d",ev.start().hour(),ev.start().minute());
+      if(ev.event().type() == Event::Normal )
+        sprintf(s,"%.2d:%.2d",ev.start().hour(),ev.start().minute());
+      else
+        sprintf(s,"     ");
     }