- refactor the distribution detection code

- add detection of OpenEmbedded and generic linux distributions
- simplify the zaurus model detection code

8 files changed, 141 insertions, 189 deletions

diff --git a/libopie2/opiecore/device/odevice.cpp b/libopie2/opiecore/device/odevice.cpp
index cef7f63..5b73e59 100644
--- a/libopie2/opiecore/device/odevice.cpp
+++ b/libopie2/opiecore/device/odevice.cpp
@@ -1,25 +1,25 @@
 /*
-                     This file is part of the Opie Project
-                      Copyright (C) The Opie Team <opie-devel@handhelds.org>
+                             This file is part of the Opie Project
+                             Copyright (C) The Opie Team <opie-devel@handhelds.org>
               =.
             .=l.
-     .>+-=
-_;:,   .>  :=|.         This program is free software; you can
-.> <`_,  > .  <=          redistribute it and/or  modify it under
-:`=1 )Y*s>-.--  :           the terms of the GNU Library General Public
-.="- .-=="i,   .._         License as published by the Free Software
-- .  .-<_>   .<>         Foundation; either version 2 of the License,
-  ._= =}    :          or (at your option) any later version.
-  .%`+i>    _;_.
-  .i_,=:_.   -<s.       This program is distributed in the hope that
-  + . -:.    =       it will be useful,  but WITHOUT ANY WARRANTY;
-  : ..  .:,   . . .    without even the implied warranty of
-  =_    +   =;=|`    MERCHANTABILITY or FITNESS FOR A
- _.=:.    :  :=>`:     PARTICULAR PURPOSE. See the GNU
-..}^=.=    =    ;      Library General Public License for more
-++=  -.   .`   .:       details.
-:   = ...= . :.=-
--.  .:....=;==+<;          You should have received a copy of the GNU
- -_. . .  )=. =           Library General Public License along with
-  --    :-=`           this library; see the file COPYING.LIB.
+           .>+-=
+ _;:,     .>    :=|.         This program is free software; you can
+.> <`_,   >  .   <=          redistribute it and/or  modify it under
+:`=1 )Y*s>-.--   :           the terms of the GNU Library General Public
+.="- .-=="i,     .._         License as published by the Free Software
+ - .   .-<_>     .<>         Foundation; either version 2 of the License,
+     ._= =}       :          or (at your option) any later version.
+    .%`+i>       _;_.
+    .i_,=:_.      -<s.       This program is distributed in the hope that
+     +  .  -:.       =       it will be useful,  but WITHOUT ANY WARRANTY;
+    : ..    .:,     . . .    without even the implied warranty of
+    =_        +     =;=|`    MERCHANTABILITY or FITNESS FOR A
+  _.=:.       :    :=>`:     PARTICULAR PURPOSE. See the GNU
+..}^=.=       =       ;      Library General Public License for more
+++=   -.     .`     .:       details.
+ :     =  ...= . :.=-
+ -.   .:....=;==+<;          You should have received a copy of the GNU
+  -_. . .   )=.  =           Library General Public License along with
+    --        :-=`           this library; see the file COPYING.LIB.
                              If not, write to the Free Software Foundation,
@@ -145,5 +145,26 @@ ODevice::ODevice()
     d->m_cpu_frequencies = new QStrList;
+
+    // New distribution detection code first checks for legacy distributions,
+    // identified by /etc/familiar-version or /etc/oz_version.
+    // Then check for OpenEmbedded and lastly, read /etc/issue
+
+    for ( unsigned int i = 0; i < sizeof distributions; ++i )
+    {
+        if ( QFile::exists( distributions[i].sysvfile ) )
+        {
+            d->m_systemstr = distributions[i].sysstr;
+            d->m_system = distributions[i].system;
+            d->m_sysverstr = "<Unknown>";
+            QFile f( distributions[i].sysvfile );
+            if ( f.open( IO_ReadOnly ) )
+            {
+                QTextStream ts( &f );
+                d->m_sysverstr = ts.readLine();
+            }
+            break;
+        }
+    }
 }
 
-void ODevice::systemMessage ( const QCString &msg, const QByteArray & )
+void ODevice::systemMessage( const QCString &msg, const QByteArray & )
 {
diff --git a/libopie2/opiecore/device/odevice.h b/libopie2/opiecore/device/odevice.h
index aaebde3..474d792 100644
--- a/libopie2/opiecore/device/odevice.h
+++ b/libopie2/opiecore/device/odevice.h
@@ -1,25 +1,25 @@
 /*
-                     This file is part of the Opie Project
-                      Copyright (C) The Opie Team <opie-devel@handhelds.org>
+                             This file is part of the Opie Project
+                             Copyright (C) The Opie Team <opie-devel@handhelds.org>
               =.
             .=l.
-     .>+-=
-_;:,   .>  :=|.         This program is free software; you can
-.> <`_,  > .  <=          redistribute it and/or  modify it under
-:`=1 )Y*s>-.--  :           the terms of the GNU Library General Public
-.="- .-=="i,   .._         License as published by the Free Software
-- .  .-<_>   .<>         Foundation; either version 2 of the License,
-  ._= =}    :          or (at your option) any later version.
-  .%`+i>    _;_.
-  .i_,=:_.   -<s.       This program is distributed in the hope that
-  + . -:.    =       it will be useful,  but WITHOUT ANY WARRANTY;
-  : ..  .:,   . . .    without even the implied warranty of
-  =_    +   =;=|`    MERCHANTABILITY or FITNESS FOR A
- _.=:.    :  :=>`:     PARTICULAR PURPOSE. See the GNU
-..}^=.=    =    ;      Library General Public License for more
-++=  -.   .`   .:       details.
-:   = ...= . :.=-
--.  .:....=;==+<;          You should have received a copy of the GNU
- -_. . .  )=. =           Library General Public License along with
-  --    :-=`           this library; see the file COPYING.LIB.
+           .>+-=
+ _;:,     .>    :=|.         This program is free software; you can
+.> <`_,   >  .   <=          redistribute it and/or  modify it under
+:`=1 )Y*s>-.--   :           the terms of the GNU Library General Public
+.="- .-=="i,     .._         License as published by the Free Software
+ - .   .-<_>     .<>         Foundation; either version 2 of the License,
+     ._= =}       :          or (at your option) any later version.
+    .%`+i>       _;_.
+    .i_,=:_.      -<s.       This program is distributed in the hope that
+     +  .  -:.       =       it will be useful,  but WITHOUT ANY WARRANTY;
+    : ..    .:,     . . .    without even the implied warranty of
+    =_        +     =;=|`    MERCHANTABILITY or FITNESS FOR A
+  _.=:.       :    :=>`:     PARTICULAR PURPOSE. See the GNU
+..}^=.=       =       ;      Library General Public License for more
+++=   -.     .`     .:       details.
+ :     =  ...= . :.=-
+ -.   .:....=;==+<;          You should have received a copy of the GNU
+  -_. . .   )=.  =           Library General Public License along with
+    --        :-=`           this library; see the file COPYING.LIB.
                              If not, write to the Free Software Foundation,
@@ -96,2 +96,7 @@ enum OModel {
 
+    Model_Beagle        = ( 6 << 24 ),
+
+    Model_Beagle_All    = ( Model_Beagle | 0xffffff ),
+    Model_Beagle_PA100  = ( Model_Beagle | 0x000001 ),
+
 };
@@ -109,2 +114,3 @@ enum OVendor {
     Vendor_GMate,
+    Vendor_MasterIA,
 };
@@ -121,2 +127,18 @@ enum OSystem {
     System_Linupy,
+    System_OpenEmbedded,
+};
+
+typedef struct {
+    OSystem system;
+    char* sysstr;
+    char* sysvfile;
+} ODistribution;
+
+static ODistribution distributions[] =
+{
+    { System_Familiar,        "FamiliarLinux",   "/etc/familiar-version" },
+    { System_OpenZaurus,      "OpenZaurus",      "/etc/oz_version" },
+    { System_OpenEmbedded,    "OpenEmbedded",    "/etc/oe-version" },
+    { System_Unknown,         "Linux",           "/etc/issue" },
+
 };
diff --git a/libopie2/opiecore/device/odevice_ipaq.cpp b/libopie2/opiecore/device/odevice_ipaq.cpp
index efe35e7..16c0538 100644
--- a/libopie2/opiecore/device/odevice_ipaq.cpp
+++ b/libopie2/opiecore/device/odevice_ipaq.cpp
@@ -140,4 +140,2 @@ void iPAQ::init(const QString& model)
 
-
-
     switch ( d->m_model ) {
@@ -160,25 +158,2 @@ void iPAQ::init(const QString& model)
 
-    QFile f( "/etc/familiar-version" );
-    if ( f. open ( IO_ReadOnly )) {
-        d->m_systemstr = "Familiar";
-        d->m_system = System_Familiar;
-
-        QTextStream ts ( &f );
-        d->m_sysverstr = ts. readLine(). mid ( 10 );
-
-        f. close();
-    } else {
-        f. setName ( "/etc/oz_version" );
-
-                    if ( f. open ( IO_ReadOnly )) {
-            d->m_systemstr = "OpenEmbedded/iPaq";
-            d->m_system = System_Familiar;
-
-            QTextStream ts ( &f );
-            ts.setDevice ( &f );
-            d->m_sysverstr = ts. readLine();
-            f. close();
-        }
-    }
-
     m_leds [0] = m_leds [1] = Led_Off;
diff --git a/libopie2/opiecore/device/odevice_jornada.cpp b/libopie2/opiecore/device/odevice_jornada.cpp
index 1f69326..5d32901 100644
--- a/libopie2/opiecore/device/odevice_jornada.cpp
+++ b/libopie2/opiecore/device/odevice_jornada.cpp
@@ -116,15 +116,4 @@ void Jornada::init(const QString&)
     d->m_model = Model_Jornada_56x;
-    d->m_systemstr = "Familiar";
-    d->m_system = System_Familiar;
     d->m_rotation = Rot0;
-
-    QFile f ( "/etc/familiar-version" );
-    f.setName ( "/etc/familiar-version" );
-    if ( f.open ( IO_ReadOnly )) {
-
-        QTextStream ts ( &f );
-        d->m_sysverstr = ts.readLine().mid( 10 );
-
-        f. close();
-    }
+    //Distribution detecting code is now in base class
 }
@@ -180,5 +169,5 @@ bool Jornada::setDisplayBrightness( int bright )
     	cmdline = QString().sprintf( "echo 0 > /sys/class/backlight/sa1100fb/power; echo %d > /sys/class/backlight/sa1100fb/brightness", value );
-    
+
     res = ( ::system( (const char*) cmdline ) == 0 );
-    
+
     return res;
@@ -211,3 +200,3 @@ bool Jornada::setDisplayStatus ( bool on )
     bool res = false;
- 
+
     QString cmdline = QString().sprintf( "echo %d > /sys/class/lcd/sa1100fb/power; echo %d > /sys/class/backlight/sa1100fb/power", on ? "0" : "4", on? "0" : "4" );
diff --git a/libopie2/opiecore/device/odevice_ramses.cpp b/libopie2/opiecore/device/odevice_ramses.cpp
index 32467f1..7db2af1 100644
--- a/libopie2/opiecore/device/odevice_ramses.cpp
+++ b/libopie2/opiecore/device/odevice_ramses.cpp
@@ -84,13 +84,3 @@ void Ramses::init(const QString&)
 
-    f.setName("/etc/oz_version");
-
-    if (f.open(IO_ReadOnly)) {
-        d->m_systemstr = "OpenEmbedded/Ramses";
-            d->m_system = System_OpenZaurus;
-
-        QTextStream ts(&f);
-        ts.setDevice(&f);
-        d->m_sysverstr = ts.readLine();
-        f.close();
-    }
+    // Distribution detection code now in the base class
 
diff --git a/libopie2/opiecore/device/odevice_simpad.cpp b/libopie2/opiecore/device/odevice_simpad.cpp
index 6630763..6d4624b 100644
--- a/libopie2/opiecore/device/odevice_simpad.cpp
+++ b/libopie2/opiecore/device/odevice_simpad.cpp
@@ -1,25 +1,25 @@
 /*
-                     This file is part of the Opie Project
-                      Copyright (C) The Opie Team <opie-devel@handhelds.org>
+                             This file is part of the Opie Project
+                             Copyright (C) The Opie Team <opie-devel@handhelds.org>
               =.
             .=l.
-     .>+-=
-_;:,   .>  :=|.         This program is free software; you can
-.> <`_,  > .  <=          redistribute it and/or  modify it under
-:`=1 )Y*s>-.--  :           the terms of the GNU Library General Public
-.="- .-=="i,   .._         License as published by the Free Software
-- .  .-<_>   .<>         Foundation; either version 2 of the License,
-  ._= =}    :          or (at your option) any later version.
-  .%`+i>    _;_.
-  .i_,=:_.   -<s.       This program is distributed in the hope that
-  + . -:.    =       it will be useful,  but WITHOUT ANY WARRANTY;
-  : ..  .:,   . . .    without even the implied warranty of
-  =_    +   =;=|`    MERCHANTABILITY or FITNESS FOR A
- _.=:.    :  :=>`:     PARTICULAR PURPOSE. See the GNU
-..}^=.=    =    ;      Library General Public License for more
-++=  -.   .`   .:       details.
-:   = ...= . :.=-
--.  .:....=;==+<;          You should have received a copy of the GNU
- -_. . .  )=. =           Library General Public License along with
-  --    :-=`           this library; see the file COPYING.LIB.
+           .>+-=
+ _;:,     .>    :=|.         This program is free software; you can
+.> <`_,   >  .   <=          redistribute it and/or  modify it under
+:`=1 )Y*s>-.--   :           the terms of the GNU Library General Public
+.="- .-=="i,     .._         License as published by the Free Software
+ - .   .-<_>     .<>         Foundation; either version 2 of the License,
+     ._= =}       :          or (at your option) any later version.
+    .%`+i>       _;_.
+    .i_,=:_.      -<s.       This program is distributed in the hope that
+     +  .  -:.       =       it will be useful,  but WITHOUT ANY WARRANTY;
+    : ..    .:,     . . .    without even the implied warranty of
+    =_        +     =;=|`    MERCHANTABILITY or FITNESS FOR A
+  _.=:.       :    :=>`:     PARTICULAR PURPOSE. See the GNU
+..}^=.=       =       ;      Library General Public License for more
+++=   -.     .`     .:       details.
+ :     =  ...= . :.=-
+ -.   .:....=;==+<;          You should have received a copy of the GNU
+  -_. . .   )=.  =           Library General Public License along with
+    --        :-=`           this library; see the file COPYING.LIB.
                              If not, write to the Free Software Foundation,
@@ -136,24 +136,3 @@ void SIMpad::init(const QString&)
 
-    f. setName ( "/etc/familiar-version" );
-    if ( f. open ( IO_ReadOnly )) {
-        d->m_systemstr = "Familiar";
-        d->m_system = System_Familiar;
-
-        QTextStream ts ( &f );
-        d->m_sysverstr = ts. readLine(). mid ( 10 );
-
-        f. close();
-    } else {
-        f. setName ( "/etc/oz_version" );
-
-                    if ( f. open ( IO_ReadOnly )) {
-            d->m_systemstr = "OpenEmbedded/SIMpad";
-            d->m_system = System_OpenZaurus;
-
-            QTextStream ts ( &f );
-            ts.setDevice ( &f );
-            d->m_sysverstr = ts. readLine();
-            f. close();
-        }
-    }
+    //Distribution detecting code is now in base class
 
diff --git a/libopie2/opiecore/device/odevice_yopy.cpp b/libopie2/opiecore/device/odevice_yopy.cpp
index 493ed25..223aa76 100644
--- a/libopie2/opiecore/device/odevice_yopy.cpp
+++ b/libopie2/opiecore/device/odevice_yopy.cpp
@@ -80,14 +80,5 @@ void Yopy::init(const QString&)
     d->m_rotation = Rot0;
-
     d->m_systemstr = "Linupy";
     d->m_system = System_Linupy;
-
-    QFile f ( "/etc/issue" );
-    if ( f. open ( IO_ReadOnly ) )
-    {
-        QTextStream ts ( &f );
-        ts.readLine();
-        d->m_sysverstr = ts. readLine();
-        f. close();
-    }
+    // Distribution detection code now in the base class
 }
diff --git a/libopie2/opiecore/device/odevice_zaurus.cpp b/libopie2/opiecore/device/odevice_zaurus.cpp
index e8b813e..6ac3157 100644
--- a/libopie2/opiecore/device/odevice_zaurus.cpp
+++ b/libopie2/opiecore/device/odevice_zaurus.cpp
@@ -117,19 +117,16 @@ struct z_button z_buttons_c700 [] = {
 
-void Zaurus::init(const QString&)
+void Zaurus::init(const QString& cpu_info)
 {
-    d->m_vendorstr = "Sharp";
-    d->m_vendor = Vendor_Sharp;
-    m_embedix = true;  // Not openzaurus means: It has an embedix kernel !
-
-    // QFile f ( "/proc/filesystems" );
-    QString model;
-
-    // It isn't a good idea to check the system configuration to
-    // detect the distribution !
-    // Otherwise it may happen that any other distribution is detected as openzaurus, just
-    // because it uses a jffs2 filesystem..
-    // (eilers)
-    // if ( f. open ( IO_ReadOnly ) && ( QTextStream ( &f ). read(). find ( "\tjffs2\n" ) >= 0 )) {
-    QFile f ("/etc/oz_version");
-    if ( f.exists() ){
+    // generic distribution code already scanned /etc/issue at that point -
+    // embedix releases contain "Embedix <version> | Linux for Embedded Devices"
+    if ( d->m_sysverstr.contains( "embedix", false ) )
+    {
+        d->m_vendorstr = "Sharp";
+        d->m_vendor = Vendor_Sharp;
+        d->m_systemstr = "Zaurus";
+        d->m_system = System_Zaurus;
+        m_embedix = true;
+    }
+    else
+    {
         d->m_vendorstr = "OpenZaurus Team";
@@ -137,12 +134,7 @@ void Zaurus::init(const QString&)
         d->m_system = System_OpenZaurus;
+        // sysver already gathered
 
-        if ( f. open ( IO_ReadOnly )) {
-            QTextStream ts ( &f );
-            d->m_sysverstr = ts. readLine();//. mid ( 10 );
-            f. close();
-        }
-
-        // Openzaurus sometimes uses the embedix kernel!
-        // => Check whether this is an embedix kernel
+        // Openzaurus sometimes uses the embedix kernel, check if this is one
         FILE *uname = popen("uname -r", "r");
+        QFile f;
         QString line;
@@ -156,3 +148,3 @@ void Zaurus::init(const QString&)
                 m_embedix = false;
-            f. close();
+            f.close();
         }
@@ -160,19 +152,10 @@ void Zaurus::init(const QString&)
     }
-    else {
-        d->m_systemstr = "Zaurus";
-        d->m_system = System_Zaurus;
-    }
 
-    f. setName ( "/proc/cpuinfo" );
-    if ( f. open ( IO_ReadOnly ) ) {
-        QTextStream ts ( &f );
-        QString line;
-        while( line = ts. readLine() ) {
-            if ( line. left ( 8 ) == "Hardware" )
-                break;
-        }
-        int loc = line. find ( ":" );
-        if ( loc != -1 )
-            model = line. mid ( loc + 2 ). simplifyWhiteSpace( );
-    }
+    // check the Zaurus model
+    QString model;
+    int loc = cpu_info.find( ":" );
+    if ( loc != -1 )
+        model = cpu_info.mid( loc+2 ).simplifyWhiteSpace();
+    else
+        model = cpu_info;
 
@@ -195,5 +178,7 @@ void Zaurus::init(const QString&)
         d->m_model = Model_Zaurus_SL5500;
-        d->m_modelstr = "Zaurus (Model unknown)";
+        d->m_modelstr = "Unkown Zaurus";
     }
 
+    // set initial rotation
+
     bool flipstate = false;