toExtraMap is no more virtual

we save custom entries now

setExtraMap added as well

8 files changed, 37 insertions, 16 deletions

diff --git a/libopie/pim/ocontact.cpp b/libopie/pim/ocontact.cpp
index a2fb68c..be4ce0a 100644
--- a/libopie/pim/ocontact.cpp
+++ b/libopie/pim/ocontact.cpp
@@ -981,15 +981,9 @@ QString OContact::type() const
 {
 	return QString::fromLatin1( "OContact" );
 }
 
-// Definition is missing ! (se)
-QMap<QString,QString> OContact::toExtraMap() const
-{
-	qWarning ("Function not implemented: OContact::toExtraMap()");
-	QMap <QString,QString> useless;
-	return useless;
-}
+
 
 class QString OContact::recordField( int pos ) const
 {
 	QStringList SLFIELDS = fields(); // ?? why this ? (se)
diff --git a/libopie/pim/oevent.cpp b/libopie/pim/oevent.cpp
index e4f5d92..7bcf944 100644
--- a/libopie/pim/oevent.cpp
+++ b/libopie/pim/oevent.cpp
@@ -359,11 +359,8 @@ void OEvent::deref() {
 // FIXME
 QMap<int, QString> OEvent::toMap()const {
     return QMap<int, QString>();
 }
-QMap<QString, QString> OEvent::toExtraMap()const {
-    return QMap<QString, QString>();
-}
 int OEvent::parent()const {
     return data->parent;
 }
 void OEvent::setParent( int uid ) {
diff --git a/libopie/pim/oevent.h b/libopie/pim/oevent.h
index b696d81..30f442e 100644
--- a/libopie/pim/oevent.h
+++ b/libopie/pim/oevent.h
@@ -131,9 +131,8 @@ public:
     QString toShortText()const;
     QString type()const;
 
     QMap<int, QString> toMap()const;
-    QMap<QString, QString> toExtraMap()const;
     QString recordField(int )const;
 
     static int rtti();
 
diff --git a/libopie/pim/opimrecord.cpp b/libopie/pim/opimrecord.cpp
index 0c9734d..2365748 100644
--- a/libopie/pim/opimrecord.cpp
+++ b/libopie/pim/opimrecord.cpp
@@ -173,4 +173,10 @@ void OPimRecord::setLastHitField( int lastHit )const {
 }
 int OPimRecord::lastHitField()const{
     return m_lastHit;
 }
+QMap<QString, QString> OPimRecord::toExtraMap()const {
+    return customMap;
+}
+void OPimRecord::setExtraMap( const QMap<QString, QString>& map) {
+    customMap = map;
+}
diff --git a/libopie/pim/opimrecord.h b/libopie/pim/opimrecord.h
index 494c78e..563b19c 100644
--- a/libopie/pim/opimrecord.h
+++ b/libopie/pim/opimrecord.h
@@ -5,9 +5,14 @@
 #include <qmap.h>
 #include <qstring.h>
 #include <qstringlist.h>
 
+/*
+ * we need to get customMap which is private...
+ */
+#define private protected
 #include <qpe/palmtoprecord.h>
+#undef private
 
 #include <opie/opimxrefmanager.h>
 
 /**
@@ -93,9 +98,10 @@ public:
 
     /**
      * key value representation of extra items
      */
-    virtual QMap<QString, QString> toExtraMap()const = 0;
+    QMap<QString, QString> toExtraMap()const;
+    void setExtraMap( const QMap<QString, QString>& );
 
     /**
      * the name for a recordField
      */
diff --git a/libopie/pim/otodo.cpp b/libopie/pim/otodo.cpp
index c84eeeb..38b93f7 100644
--- a/libopie/pim/otodo.cpp
+++ b/libopie/pim/otodo.cpp
@@ -459,11 +459,8 @@ QMap<int, QString> OTodo::toMap() const {
     */
     return map;
 }
 
-QMap<QString, QString> OTodo::toExtraMap()const {
-    return data->extra;
-}
 /**
  *  change or modify looks at the ref count and either
  *  creates a new QShared Object or it can modify it
  * right in place
diff --git a/libopie/pim/otodo.h b/libopie/pim/otodo.h
index 4d5ee36..f9a345a 100644
--- a/libopie/pim/otodo.h
+++ b/libopie/pim/otodo.h
@@ -192,9 +192,8 @@ public:
      * reimplementations
      */
     QString type()const;
     QString toShortText()const;
-    QMap<QString, QString> toExtraMap()const;
     QString recordField(int id )const;
 
     /**
      * toMap puts all data into the map. int relates
diff --git a/libopie/pim/otodoaccessxml.cpp b/libopie/pim/otodoaccessxml.cpp
index 2b62f0d..3d15354 100644
--- a/libopie/pim/otodoaccessxml.cpp
+++ b/libopie/pim/otodoaccessxml.cpp
@@ -496,11 +496,33 @@ void OTodoAccessXML::todo( QAsciiDict<int>* dict, OTodo& ev,
         rp_end = (time_t) val.toLong();
         break;
     }
     default:
+        ev.setCustomField( attr, val );
         break;
     }
 }
+
+// from PalmtopRecord... GPL ### FIXME
+namespace {
+QString customToXml(const QMap<QString, QString>& customMap )
+{
+    //qWarning(QString("writing custom %1").arg(customMap.count()));
+    QString buf(" ");
+    for ( QMap<QString, QString>::ConstIterator cit = customMap.begin();
+	    cit != customMap.end(); ++cit) {
+// 	qWarning(".ITEM.");
+	buf += cit.key();
+	buf += "=\"";
+	buf += Qtopia::escapeString(cit.data());
+	buf += "\" ";
+    }
+    return buf;
+}
+
+
+}
+
 QString OTodoAccessXML::toString( const OTodo& ev )const {
     QString str;
 
     str += "Completed=\"" + QString::number( ev.isCompleted() ) + "\" ";
@@ -580,8 +602,9 @@ QString OTodoAccessXML::toString( const OTodo& ev )const {
             }
             str += "Reminders=\""+ records.join(";") +"\" ";
         }
     }
+    str += customToXml( ev.toExtraMap() );
 
 
     return str;
 }