Fix icon sizing for light and qpe styles

1 files changed, 6 insertions, 2 deletions

diff --git a/library/qpestyle.cpp b/library/qpestyle.cpp
index 0566f6b..9503e02 100644
--- a/library/qpestyle.cpp
+++ b/library/qpestyle.cpp
@@ -654,538 +654,542 @@ void QPEStyle::scrollBarMetrics( const QScrollBar* sb, int &sliderMin, int &slid
         sliderLength = maxLength;
      } else {
         sliderLength = (sb->pageStep()*maxLength)/
                         (sb->maxValue()-sb->minValue()+sb->pageStep());
         uint range = sb->maxValue()-sb->minValue();
         if ( sliderLength < SLIDER_MIN || range > INT_MAX/2 )
             sliderLength = SLIDER_MIN;
         if ( sliderLength > maxLength )
             sliderLength = maxLength;
      }
 
     sliderMax = sliderMin + maxLength - sliderLength;
 }
 
 /*!\reimp
  */
 QStyle::ScrollControl QPEStyle::scrollBarPointOver( const QScrollBar* sb, int sliderStart, const QPoint& p )
 {
         if ( !sb->rect().contains( p ) )
         return NoScroll;
     int sliderMin, sliderMax, sliderLength, buttonDim, pos;
     scrollBarMetrics( sb, sliderMin, sliderMax, sliderLength, buttonDim );
 
     if (sb->orientation() == QScrollBar::Horizontal)
         pos = p.x();
     else
         pos = p.y();
 
     if (pos < sliderStart)
         return SubPage;
     if (pos < sliderStart + sliderLength)
         return Slider;
     if (pos < sliderMax + sliderLength)
         return AddPage;
     if (pos < sliderMax + sliderLength + buttonDim)
         return SubLine;
     return AddLine;
 }
 
 /*! \reimp */
 
 void QPEStyle::drawScrollBarControls( QPainter* p, const QScrollBar* sb, int sliderStart, uint controls, uint activeControl )
 {
 #define ADD_LINE_ACTIVE ( activeControl == AddLine )
 #define SUB_LINE_ACTIVE ( activeControl == SubLine )
     QColorGroup g  = sb->colorGroup();
 
     int sliderMin, sliderMax, sliderLength, buttonDim;
     scrollBarMetrics( sb, sliderMin, sliderMax, sliderLength, buttonDim );
 
     if ( controls == (AddLine | SubLine | AddPage | SubPage | Slider | First | Last ) )
         p->fillRect( 0, 0, sb->width(), sb->height(), g.brush( QColorGroup::Mid ));
 
     if (sliderStart > sliderMax) { // sanity check
         sliderStart = sliderMax;
     }
 
     int dimB = buttonDim;
     QRect addB;
     QRect subB;
     QRect addPageR;
     QRect subPageR;
     QRect sliderR;
     int addX, addY, subX, subY;
     int length = HORIZONTAL ? sb->width()  : sb->height();
     int extent = HORIZONTAL ? sb->height() : sb->width();
 
     if ( HORIZONTAL ) {
         subY = addY = ( extent - dimB ) / 2;
         subX = length - dimB - dimB;
         addX = length - dimB;
     } else {
         subX = addX = ( extent - dimB ) / 2;
         subY = length - dimB - dimB;
         addY = length - dimB;
     }
 
     int sliderEnd = sliderStart + sliderLength;
     int sliderW = extent;
     if ( HORIZONTAL ) {
         subB.setRect( subX,subY+1,dimB,dimB-1 );
         addB.setRect( addX,addY+1,dimB,dimB-1 );
 
         subPageR.setRect( 0, 0,
                           sliderStart+1, sliderW );
         addPageR.setRect( sliderEnd-1, 0, subX - sliderEnd+1, sliderW );
         sliderR .setRect( sliderStart, 1, sliderLength, sliderW-1 );
 
     } else {
         subB.setRect( subX+1,subY,dimB-1,dimB );
         addB.setRect( addX+1,addY,dimB-1,dimB );
 
         subPageR.setRect( 0, 0, sliderW,
                           sliderStart+1 );
         addPageR.setRect( 0, sliderEnd-1, sliderW, subY - sliderEnd+1 );
         sliderR .setRect( 1, sliderStart, sliderW-1, sliderLength );
     }
 
     bool maxedOut = (sb->maxValue() == sb->minValue());
     if ( controls & AddLine ) {
         drawBevelButton( p, addB.x(), addB.y(),
                          addB.width(), addB.height(), g,
                          ADD_LINE_ACTIVE);
         p->setPen(g.shadow());
         drawArrow( p, VERTICAL ? DownArrow : RightArrow,
                    FALSE, addB.x()+2, addB.y()+2,
                    addB.width()-4, addB.height()-4, g, !maxedOut,
                                      &g.brush( QColorGroup::Button ));
     }
     if ( controls & SubLine ) {
         drawBevelButton( p, subB.x(), subB.y(),
                          subB.width(), subB.height(), g,
                          SUB_LINE_ACTIVE );
         p->setPen(g.shadow());
         drawArrow( p, VERTICAL ? UpArrow : LeftArrow,
                     FALSE, subB.x()+2, subB.y()+2,
                    subB.width()-4, subB.height()-4, g, !maxedOut,
                                      &g.brush( QColorGroup::Button ));
     }
 
 
     if ( controls & SubPage )
         p->fillRect( subPageR.x(), subPageR.y(), subPageR.width(),
                     subPageR.height(), g.brush( QColorGroup::Mid ));
     if ( controls & AddPage )
         p->fillRect( addPageR.x(), addPageR.y(), addPageR.width(),
                      addPageR.height(), g.brush( QColorGroup::Mid ));
     if ( controls & Slider ) {
         QPoint bo = p->brushOrigin();
         p->setBrushOrigin(sliderR.topLeft());
         drawBevelButton( p, sliderR.x(), sliderR.y(),
                          sliderR.width(), sliderR.height(), g,
                          FALSE, &g.brush( QColorGroup::Button ) );
         p->setBrushOrigin(bo);
         drawRiffles( p, sliderR.x(), sliderR.y(),
                      sliderR.width(), sliderR.height(), g, HORIZONTAL );
     }
 
     // ### perhaps this should not be able to accept focus if maxedOut?
     if ( sb->hasFocus() && (controls & Slider) )
         p->drawWinFocusRect( sliderR.x()+2, sliderR.y()+2,
                              sliderR.width()-5, sliderR.height()-5,
                              sb->backgroundColor() );
 
 }
 
 void QPEStyle::drawRiffles( QPainter* p,  int x, int y, int w, int h,
                       const QColorGroup &g, bool horizontal )
 {
     if (!horizontal) {
         if (h > 20) {
             y += (h-20)/2 ;
             h = 20;
         }
         if (h > 12) {
             int n = 3;
             int my = y+h/2-4;
             int i ;
             p->setPen(g.light());
             for (i=0; i<n; i++) {
                 p->drawLine(x+2, my+3*i, x+w-4, my+3*i);
             }
             p->setPen(g.dark());
             my++;
             for (i=0; i<n; i++) {
                 p->drawLine(x+2, my+3*i, x+w-4, my+3*i);
             }
         }
     }
     else {
         if (w > 20) {
             x += (w-20)/2 ;
             w = 20;
         }
         if (w > 12) {
             int n = 3;
             int mx = x+w/2-4;
             int i ;
             p->setPen(g.light());
             for (i=0; i<n; i++) {
                 p->drawLine(mx+3*i, y+2, mx + 3*i, y+h-4);
             }
             p->setPen(g.dark());
             mx++;
             for (i=0; i<n; i++) {
                 p->drawLine(mx+3*i, y+2, mx + 3*i, y+h-4);
             }
         }
     }
 }
 
 int QPEStyle::sliderLength() const
 {
     return 12;
 }
 
 void QPEStyle::drawSlider( QPainter *p, int x, int y, int w, int h,
         const QColorGroup &g, Orientation o, bool tickAbove, bool tickBelow )
 {
     int a = tickAbove ? 3 : 0;
     int b = tickBelow ? 3 : 0;
 
     if ( o == Horizontal ) {
         drawBevelButton( p, x, y+a, w, h-a-b, g, FALSE, &g.brush( QColorGroup::Button ) );
         int xp = x + w/2;
         qDrawShadeLine( p, xp, y+a+2, xp, y+h-b-3, g );
     } else {
         drawBevelButton( p, x+a, y, w-a-b, h, g, FALSE, &g.brush( QColorGroup::Button ) );
         int yp = y + h/2;
         qDrawShadeLine( p, x+a+2, yp, x+w-b-3, yp, g );
     }
 }
 
 void QPEStyle::drawSliderMask ( QPainter * p, int x, int y, int w, int h,
         Orientation o, bool tickAbove, bool tickBelow )
 {
     int a = tickAbove ? 3 : 0;
     int b = tickBelow ? 3 : 0;
     if ( o == Horizontal )
         p->fillRect( x, y+a, w, h-a-b, color1 );
     else
         p->fillRect( x+a, y, w-a-b, h, color1 );
 }
 
 /*!\reimp
  */
 void QPEStyle::drawSliderGrooveMask( QPainter *p,
                                         int x, int y, int w, int h,
                                         const QColorGroup& , QCOORD c,
                                         Orientation orient )
 {
     if ( orient == Horizontal )
         p->fillRect( x, y + c - 2,  w, 4, color1 );
     else
         p->fillRect( x + c - 2, y, 4, h, color1 );
 }
 
 void QPEStyle::drawTab( QPainter *p, const QTabBar *tb, QTab *t, bool selected )
 {
     QRect r( t->rect() );
     if ( tb->shape()  == QTabBar::RoundedAbove ) {
         p->setPen( tb->colorGroup().light() );
         p->drawLine( r.left(), r.bottom(), r.right(), r.bottom() );
         if ( r.left() == 0 )
             p->drawPoint( tb->rect().bottomLeft() );
         else {
             p->setPen( tb->colorGroup().light() );
             p->drawLine( r.left(), r.bottom(), r.right(), r.bottom() );
         }
 
         if ( selected ) {
             p->setPen( tb->colorGroup().background() );
             p->drawLine( r.left()+2, r.top()+1, r.right()-2, r.top()+1 );
             p->fillRect( QRect( r.left()+1, r.top()+2, r.width()-2, r.height()-2),
                          tb->colorGroup().brush( QColorGroup::Background ));
         } else {
             r.setRect( r.left() + 2, r.top() + 2,
                        r.width() - 4, r.height() - 2 );
             p->setPen( tb->colorGroup().button() );
             p->drawLine( r.left()+2, r.top()+1, r.right()-2, r.top()+1 );
             p->fillRect( QRect( r.left()+1, r.top()+2, r.width()-2, r.height()-3),
                          tb->colorGroup().brush( QColorGroup::Button ));
 
             //do shading; will not work for pixmap brushes
             QColor bg = tb->colorGroup().button();
                     //    int h,s,v;
                     //    bg.hsv( &h, &s, &v );
             int n = r.height()/2;
             int dark = 100;
             for ( int i = 1; i < n; i++ ) {
                 dark = (dark * (100+(i*15)/n) )/100;
                 p->setPen( bg.dark( dark ) );
                 int y = r.bottom()-n+i;
                 int x1 = r.left()+1;
                 int x2 = r.right()-1;
                 p->drawLine( x1, y, x2, y );
             }
         }
 
         p->setPen( tb->colorGroup().light() );
         p->drawLine( r.left(), r.bottom()-1, r.left(), r.top() + 2 );
         p->drawPoint( r.left()+1, r.top() + 1 );
         p->drawLine( r.left()+2, r.top(),
                      r.right() - 2, r.top() );
 
         p->setPen( tb->colorGroup().dark() );
         p->drawPoint( r.right() - 1, r.top() + 1 );
         p->drawLine( r.right(), r.top() + 2, r.right(), r.bottom() - 1);
     } else if ( tb->shape() == QTabBar::RoundedBelow ) {
         if ( selected ) {
             p->setPen( tb->colorGroup().background() );
             p->drawLine( r.left()+2, r.bottom()-1, r.right()-2, r.bottom()-1 );
             p->fillRect( QRect( r.left()+1, r.top(), r.width()-2, r.height()-2),
                          tb->palette().normal().brush( QColorGroup::Background ));
         } else {
             p->setPen( tb->colorGroup().dark() );
             p->drawLine( r.left(), r.top(),
                          r.right(), r.top() );
             r.setRect( r.left() + 2, r.top(),
                        r.width() - 4, r.height() - 2 );
             p->setPen( tb->colorGroup().button() );
             p->drawLine( r.left()+2, r.bottom()-1, r.right()-2, r.bottom()-1 );
             p->fillRect( QRect( r.left()+1, r.top()+1, r.width()-2, r.height()-3),
                          tb->palette().normal().brush( QColorGroup::Button ));
         }
 
         p->setPen( tb->colorGroup().dark() );
         p->drawLine( r.right(), r.top(),
                      r.right(), r.bottom() - 2 );
         p->drawPoint( r.right() - 1, r.bottom() - 1 );
         p->drawLine( r.right() - 2, r.bottom(),
                      r.left() + 2, r.bottom() );
 
         p->setPen( tb->colorGroup().light() );
         p->drawLine( r.left(), r.top()+1,
                      r.left(), r.bottom() - 2 );
         p->drawPoint( r.left() + 1, r.bottom() - 1 );
         if ( r.left() == 0 )
             p->drawPoint( tb->rect().topLeft() );
 
     } else {
         QCommonStyle::drawTab( p, tb, t, selected );
     }
 }
 
         static const int motifItemFrame                 = 0;// menu item frame width
         static const int motifSepHeight                 = 2;// separator item height
         static const int motifItemHMargin       = 1;// menu item hor text margin
         static const int motifItemVMargin       = 2;// menu item ver text margin
         static const int motifArrowHMargin      = 0;// arrow horizontal margin
         static const int motifTabSpacing        = 12;// space between text and tab
         static const int motifCheckMarkHMargin  = 1;// horiz. margins of check mark
         static const int windowsRightBorder= 8;    // right border on windows
 static const int windowsCheckMarkWidth  = 2;    // checkmarks width on windows
 
 /*! \reimp
 */
 int QPEStyle::extraPopupMenuItemWidth( bool checkable, int maxpmw, QMenuItem* mi, const QFontMetrics& /*fm*/ )
 {
 #ifndef QT_NO_MENUDATA
     int w = 2*motifItemHMargin + 2*motifItemFrame; // a little bit of border can never harm
 
     if ( mi->isSeparator() )
         return 10; // arbitrary
     else if ( mi->pixmap() )
                 w += mi->pixmap()->width();// pixmap only
 
     if ( !mi->text().isNull() ) {
                 if ( mi->text().find('\t') >= 0 )// string contains tab
             w += motifTabSpacing;
     }
 
     if ( maxpmw ) { // we have iconsets
         w += maxpmw;
         w += 6; // add a little extra border around the iconset
     }
 
     if ( checkable && maxpmw < windowsCheckMarkWidth ) {
         w += windowsCheckMarkWidth - maxpmw; // space for the checkmarks
     }
 
     if ( maxpmw > 0 || checkable ) // we have a check-column ( iconsets or checkmarks)
         w += motifCheckMarkHMargin; // add space to separate the columns
 
     w += windowsRightBorder; // windows has a strange wide border on the right side
 
     return w;
 #endif
 }
 
 /*! \reimp
 */
 int QPEStyle::popupMenuItemHeight( bool /*checkable*/, QMenuItem* mi, const QFontMetrics& fm )
 {
 #ifndef QT_NO_MENUDATA
     int h = 0;
             if ( mi->isSeparator() )            // separator height
         h = motifSepHeight;
             else if ( mi->pixmap() )    // pixmap height
         h = mi->pixmap()->height() + 2*motifItemFrame;
             else                                // text height
         h = fm.height() + 2*motifItemVMargin + 2*motifItemFrame - 1;
 
     if ( !mi->isSeparator() && mi->iconSet() != 0 ) {
-        h = QMAX( h, mi->iconSet()->pixmap( QIconSet::Small, QIconSet::Normal ).height() + 2*motifItemFrame );
+        h = QMAX( h, mi->iconSet()->pixmap().height() + 2*motifItemFrame );
     }
     if ( mi->custom() )
         h = QMAX( h, mi->custom()->sizeHint().height() + 2*motifItemVMargin + 2*motifItemFrame ) - 1;
     return h;
 #endif
 }
 
 void QPEStyle::drawPopupMenuItem( QPainter* p, bool checkable, int maxpmw, int tab, QMenuItem* mi,
                                        const QPalette& pal,
                                        bool act, bool enabled, int x, int y, int w, int h)
 {
 #ifndef QT_NO_MENUDATA
     const QColorGroup & g = pal.active();
             bool dis  = !enabled;
     QColorGroup itemg = dis ? pal.disabled() : pal.active();
 
     if ( checkable )
         maxpmw = QMAX( maxpmw, 8 ); // space for the checkmarks
 
             int checkcol  =     maxpmw;
 
             if ( mi && mi->isSeparator() ) {            // draw separator
         p->setPen( g.dark() );
         p->drawLine( x, y, x+w, y );
         p->setPen( g.light() );
         p->drawLine( x, y+1, x+w, y+1 );
         return;
     }
 
     QBrush fill = act? g.brush( QColorGroup::Highlight ) :
                             g.brush( QColorGroup::Button );
     p->fillRect( x, y, w, h, fill);
 
     if ( !mi )
         return;
 
     if ( mi->isChecked() ) {
         if ( act && !dis ) {
             qDrawShadePanel( p, x, y, checkcol, h,
                              g, TRUE, 1, &g.brush( QColorGroup::Button ) );
         } else {
             qDrawShadePanel( p, x, y, checkcol, h,
                              g, TRUE, 1, &g.brush( QColorGroup::Midlight ) );
         }
     } else if ( !act ) {
         p->fillRect(x, y, checkcol , h,
                     g.brush( QColorGroup::Button ));
     }
 
             if ( mi->iconSet() ) {      // draw iconset
         QIconSet::Mode mode = dis ? QIconSet::Disabled : QIconSet::Normal;
         if (act && !dis )
             mode = QIconSet::Active;
-        QPixmap pixmap = mi->iconSet()->pixmap( QIconSet::Small, mode );
+    QPixmap pixmap;
+    if ( mode == QIconSet::Disabled )
+        pixmap = mi->iconSet()->pixmap( QIconSet::Automatic, mode );
+    else
+        pixmap = mi->iconSet()->pixmap();
         int pixw = pixmap.width();
         int pixh = pixmap.height();
         if ( act && !dis ) {
             if ( !mi->isChecked() )
                 qDrawShadePanel( p, x, y, checkcol, h, g, FALSE,  1, &g.brush( QColorGroup::Button ) );
         }
         QRect cr( x, y, checkcol, h );
         QRect pmr( 0, 0, pixw, pixh );
         pmr.moveCenter( cr.center() );
         p->setPen( itemg.text() );
         p->drawPixmap( pmr.topLeft(), pixmap );
 
         QBrush fill = act? g.brush( QColorGroup::Highlight ) :
                               g.brush( QColorGroup::Button );
         p->fillRect( x+checkcol + 1, y, w - checkcol - 1, h, fill);
             } else  if ( checkable ) {// just "checking"...
         int mw = checkcol + motifItemFrame;
         int mh = h - 2*motifItemFrame;
         if ( mi->isChecked() ) {
             drawCheckMark( p, x + motifItemFrame + 2,
                            y+motifItemFrame, mw, mh, itemg, act, dis );
         }
     }
 
     p->setPen( act ? g.highlightedText() : g.buttonText() );
 
     QColor discol;
     if ( dis ) {
         discol = itemg.text();
         p->setPen( discol );
     }
 
     int xm = motifItemFrame + checkcol + motifItemHMargin;
 
     if ( mi->custom() ) {
         int m = motifItemVMargin;
         p->save();
         if ( dis && !act ) {
             p->setPen( g.light() );
             mi->custom()->paint( p, itemg, act, enabled,
                                  x+xm+1, y+m+1, w-xm-tab+1, h-2*m );
             p->setPen( discol );
         }
         mi->custom()->paint( p, itemg, act, enabled,
                              x+xm, y+m, w-xm-tab+1, h-2*m );
         p->restore();
     }
     QString s = mi->text();
             if ( !s.isNull() ) {                // draw text
         int t = s.find( '\t' );
         int m = motifItemVMargin;
         const int text_flags = AlignVCenter|ShowPrefix | DontClip | SingleLine;
                 if ( t >= 0 ) {                         // draw tab text
             if ( dis && !act ) {
                 p->setPen( g.light() );
                 p->drawText( x+w-tab-windowsRightBorder-motifItemHMargin-motifItemFrame+1,
                              y+m+1, tab, h-2*m, text_flags, s.mid( t+1 ));
                 p->setPen( discol );
             }
             p->drawText( x+w-tab-windowsRightBorder-motifItemHMargin-motifItemFrame,
                          y+m, tab, h-2*m, text_flags, s.mid( t+1 ) );
         }
         if ( dis && !act ) {
             p->setPen( g.light() );
             p->drawText( x+xm+1, y+m+1, w-xm+1, h-2*m, text_flags, s, t );
             p->setPen( discol );
         }
         p->drawText( x+xm, y+m, w-xm-tab+1, h-2*m, text_flags, s, t );
             } else if ( mi->pixmap() ) {                // draw pixmap
         QPixmap *pixmap = mi->pixmap();
         if ( pixmap->depth() == 1 )
             p->setBackgroundMode( OpaqueMode );
         p->drawPixmap( x+xm, y+motifItemFrame, *pixmap );
         if ( pixmap->depth() == 1 )
             p->setBackgroundMode( TransparentMode );
     }
             if ( mi->popup() ) {                // draw sub menu arrow
         int dim = (h-2*motifItemFrame) / 2;
         if ( act ) {
             if ( !dis )
                 discol = white;
             QColorGroup g2( discol, g.highlight(),
                             white, white,
                             dis ? discol : white,
                             discol, white );
             drawArrow( p, RightArrow, FALSE,
                                x+w - motifArrowHMargin - motifItemFrame - dim,  y+h/2-dim/2,
                                dim, dim, g2, TRUE );
         } else {
             drawArrow( p, RightArrow,
                                FALSE,
                                x+w - motifArrowHMargin - motifItemFrame - dim,  y+h/2-dim/2,
                                dim, dim, g, mi->isEnabled() );
         }
     }
 #endif
 }
 
 #endif