- no default args in method impls

- don't return void in non-void functions

2 files changed, 2 insertions, 1 deletions

diff --git a/noncore/apps/tableviewer/db/common.cpp b/noncore/apps/tableviewer/db/common.cpp
index 71844a5..dbf9370 100644
--- a/noncore/apps/tableviewer/db/common.cpp
+++ b/noncore/apps/tableviewer/db/common.cpp
@@ -670,25 +670,25 @@ bool TVVariant::close(TVVariant n)
     return FALSE;
 }
 
 /*!
     \class Key
     \brief document me!
     
     document me!
 */
 
 Key::Key() : kname(), kexample(), kflags(0) { }
 
-Key::Key(QString name, TVVariant example, int flags = 0) :
+Key::Key(QString name, TVVariant example, int flags) :
     kname(name), kexample(example), kflags(flags) { } 
 
 Key::Key(const Key &other)
 {
   kname = other.kname;
   kexample = other.kexample;
   kflags = other.kflags;
 }
 
 Key& Key::operator=(const Key& key) 
 {
     kname = key.kname;
diff --git a/noncore/apps/tableviewer/db/csvsource.cpp b/noncore/apps/tableviewer/db/csvsource.cpp
index 2561b4b..ea36300 100644
--- a/noncore/apps/tableviewer/db/csvsource.cpp
+++ b/noncore/apps/tableviewer/db/csvsource.cpp
@@ -89,24 +89,25 @@ QStringList readElem(QString in)
         }
         /* we have our current elem */
         out << elem.stripWhiteSpace();
         firstChar = TRUE;
         quotedElem = FALSE;
         /* skip till a , or end of line */
         while (index < in.length() && in[index] != ',') index++;
         if(index == in.length())
             return out;
         else 
             index++;
     }
+    return out;
 }
 
 bool DBCsv::openSource(QIODevice *inDev)
 {
     QTextStream tsIn(inDev);
     QString in = tsIn.readLine().stripWhiteSpace();
     QStringList keys;
 
     keys = readElem(in);
 
     QMap<int,int> keyIndexes;