author | simon <simon> | 2002-12-02 18:01:00 (UTC) |
---|---|---|
committer | simon <simon> | 2002-12-02 18:01:00 (UTC) |
commit | 41fe383fe8b840de6dc0bcd47cd29b0d68bf760a (patch) (side-by-side diff) | |
tree | 238a6bc98e657ed32d4d71895265d8512013bb14 /noncore/multimedia/opieplayer2/audiowidget.cpp | |
parent | c31f9b59dba873739494fcd9916c7cb9120ce1d9 (diff) | |
download | opie-41fe383fe8b840de6dc0bcd47cd29b0d68bf760a.zip opie-41fe383fe8b840de6dc0bcd47cd29b0d68bf760a.tar.gz opie-41fe383fe8b840de6dc0bcd47cd29b0d68bf760a.tar.bz2 |
- added a missing const
- QImage and QPixmap are value based classes, so use them like that for
a couple of objects. simplifies the code and helps to avoid memory leaks
Diffstat (limited to 'noncore/multimedia/opieplayer2/audiowidget.cpp') (more/less context) (ignore whitespace changes)
-rw-r--r-- | noncore/multimedia/opieplayer2/audiowidget.cpp | 53 |
1 files changed, 23 insertions, 30 deletions
diff --git a/noncore/multimedia/opieplayer2/audiowidget.cpp b/noncore/multimedia/opieplayer2/audiowidget.cpp index 5cdfbf2..46d374d 100644 --- a/noncore/multimedia/opieplayer2/audiowidget.cpp +++ b/noncore/multimedia/opieplayer2/audiowidget.cpp @@ -76,3 +76,3 @@ MediaButton audioButtons[] = { -const char *skin_mask_file_names[10] = { +const char * const skin_mask_file_names[10] = { "play", "stop", "next", "prev", "up", @@ -105,8 +105,8 @@ AudioWidget::AudioWidget(QWidget* parent, const char* name, WFlags f) : QString skinPath = "opieplayer2/skins/" + skin; - pixBg = new QPixmap( Resource::loadPixmap( QString("%1/background").arg(skinPath) ) ); - imgUp = new QImage( Resource::loadImage( QString("%1/skin_up").arg(skinPath) ) ); - imgDn = new QImage( Resource::loadImage( QString("%1/skin_down").arg(skinPath) ) ); + pixBg = QPixmap( Resource::loadPixmap( QString("%1/background").arg(skinPath) ) ); + imgUp = QImage( Resource::loadImage( QString("%1/skin_up").arg(skinPath) ) ); + imgDn = QImage( Resource::loadImage( QString("%1/skin_down").arg(skinPath) ) ); - imgButtonMask = new QImage( imgUp->width(), imgUp->height(), 8, 255 ); - imgButtonMask->fill( 0 ); + imgButtonMask = QImage( imgUp.width(), imgUp.height(), 8, 255 ); + imgButtonMask.fill( 0 ); @@ -118,6 +118,6 @@ AudioWidget::AudioWidget(QWidget* parent, const char* name, WFlags f) : QImage imgMask = masks[i]->convertToImage(); - uchar **dest = imgButtonMask->jumpTable(); - for ( int y = 0; y < imgUp->height(); y++ ) { + uchar **dest = imgButtonMask.jumpTable(); + for ( int y = 0; y < imgUp.height(); y++ ) { uchar *line = dest[y]; - for ( int x = 0; x < imgUp->width(); x++ ) + for ( int x = 0; x < imgUp.width(); x++ ) if ( !qRed( imgMask.pixel( x, y ) ) ) @@ -134,3 +134,3 @@ AudioWidget::AudioWidget(QWidget* parent, const char* name, WFlags f) : - setBackgroundPixmap( *pixBg ); + setBackgroundPixmap( pixBg ); @@ -147,3 +147,3 @@ AudioWidget::AudioWidget(QWidget* parent, const char* name, WFlags f) : slider.setFocusPolicy( QWidget::NoFocus ); - slider.setBackgroundPixmap( *pixBg ); + slider.setBackgroundPixmap( pixBg ); @@ -187,6 +187,2 @@ AudioWidget::~AudioWidget() { } - delete pixBg; - delete imgUp; - delete imgDn; - delete imgButtonMask; for ( int i = 0; i < 10; i++ ) { @@ -199,3 +195,3 @@ namespace { -QPixmap *combineImageWithBackground( QImage img, QPixmap bg, QPoint offset ) { +QPixmap combineImageWithBackground( QImage img, QPixmap bg, QPoint offset ) { QPixmap pix( img.width(), img.height() ); @@ -204,3 +200,3 @@ QPixmap *combineImageWithBackground( QImage img, QPixmap bg, QPoint offset ) { p.drawImage( 0, 0, img ); - return new QPixmap( pix ); + return pix; } @@ -226,8 +222,8 @@ void AudioWidget::resizeEvent( QResizeEvent * ) { - xoff = ( w - imgUp->width() ) / 2; - yoff = (( h - imgUp->height() ) / 2) - 10; + xoff = ( w - imgUp.width() ) / 2; + yoff = (( h - imgUp.height() ) / 2) - 10; QPoint p( xoff, yoff ); - QPixmap *pixUp = combineImageWithBackground( *imgUp, *pixBg, p ); - QPixmap *pixDn = combineImageWithBackground( *imgDn, *pixBg, p ); + QPixmap pixUp = combineImageWithBackground( imgUp, pixBg, p ); + QPixmap pixDn = combineImageWithBackground( imgDn, pixBg, p ); @@ -237,9 +233,6 @@ void AudioWidget::resizeEvent( QResizeEvent * ) { delete buttonPixDown[i]; - buttonPixUp[i] = maskPixToMask( *pixUp, *masks[i] ); - buttonPixDown[i] = maskPixToMask( *pixDn, *masks[i] ); + buttonPixUp[i] = maskPixToMask( pixUp, *masks[i] ); + buttonPixDown[i] = maskPixToMask( pixDn, *masks[i] ); } } - - delete pixUp; - delete pixDn; } @@ -399,5 +392,5 @@ void AudioWidget::mouseMoveEvent( QMouseEvent *event ) { - bool isOnButton = ( x > 0 && y > 0 && x < imgButtonMask->width() - && y < imgButtonMask->height() - && imgButtonMask->pixelIndex( x, y ) == i + 1 ); + bool isOnButton = ( x > 0 && y > 0 && x < imgButtonMask.width() + && y < imgButtonMask.height() + && imgButtonMask.pixelIndex( x, y ) == i + 1 ); @@ -483,3 +476,3 @@ void AudioWidget::paintEvent( QPaintEvent * pe ) { p.translate( -pe->rect().topLeft().x(), -pe->rect().topLeft().y() ); - p.drawTiledPixmap( pe->rect(), *pixBg, pe->rect().topLeft() ); + p.drawTiledPixmap( pe->rect(), pixBg, pe->rect().topLeft() ); for ( int i = 0; i < numButtons; i++ ) |