fixed problem with remote directory not being listed after an upload, and fixed

problem with temp file poop with strewn throughout the local filesystem.

2 files changed, 53 insertions, 32 deletions

diff --git a/noncore/net/opieftp/opieftp.cpp b/noncore/net/opieftp/opieftp.cpp
index 042ed59..6a3a64d 100644
--- a/noncore/net/opieftp/opieftp.cpp
+++ b/noncore/net/opieftp/opieftp.cpp
@@ -71,22 +71,22 @@ OpieFtp::OpieFtp( )
     connect( qApp,SIGNAL( aboutToQuit()),SLOT( cleanUp()) );
 
     QPEMenuBar *menuBar = new QPEMenuBar(this);
     connectionMenu  = new QPopupMenu( this );
     localMenu  = new QPopupMenu( this );
     remoteMenu  = new QPopupMenu( this );
-        tabMenu = new QPopupMenu( this );
+  tabMenu = new QPopupMenu( this );
 
     layout->addMultiCellWidget( menuBar, 0, 0, 0, 3 );
 
     menuBar->insertItem( tr( "Connection" ), connectionMenu);
     menuBar->insertItem( tr( "Local" ), localMenu);
     menuBar->insertItem( tr( "Remote" ), remoteMenu);
     menuBar->insertItem( tr( "View" ), tabMenu);
 
-        connectionMenu->insertItem( tr( "New" ), this,  SLOT( newConnection() ));
+  connectionMenu->insertItem( tr( "New" ), this,  SLOT( newConnection() ));
     connectionMenu->insertItem( tr( "Connect" ), this,  SLOT( connector() ));
     connectionMenu->insertItem( tr( "Disconnect" ), this,  SLOT( disConnector() ));
 
     localMenu->insertItem( tr( "Show Hidden Files" ), this,  SLOT( showHidden() ));
     localMenu->insertSeparator();
     localMenu->insertItem( tr( "Upload" ), this, SLOT( localUpload() ));
@@ -102,13 +102,13 @@ OpieFtp::OpieFtp( )
     remoteMenu->insertItem( tr( "Delete" ), this, SLOT( remoteDelete() ));
 
     tabMenu->insertItem( tr( "Switch to Local" ), this, SLOT( switchToLocalTab() ));
     tabMenu->insertItem( tr( "Switch to Remote" ), this, SLOT( switchToRemoteTab() ));
     tabMenu->insertItem( tr( "Switch to Config" ), this, SLOT( switchToConfigTab() ));
 
-        TabWidget = new QTabWidget( this, "TabWidget" );
+  TabWidget = new QTabWidget( this, "TabWidget" );
     layout->addMultiCellWidget( TabWidget, 1, 1, 0, 3 );
 
     TabWidget->setTabShape(QTabWidget::Triangular);
 
     tab = new QWidget( TabWidget, "tab" );
     tabLayout = new QGridLayout( tab );
@@ -145,20 +145,20 @@ OpieFtp::OpieFtp( )
     Remote_View->setColumnAlignment(1,QListView::AlignRight);
     Remote_View->addColumn( "Date",-1);
     Remote_View->setColumnAlignment(2,QListView::AlignRight);
     Remote_View->setAllColumnsShowFocus(TRUE);
     QPEApplication::setStylusOperation( Remote_View->viewport(),QPEApplication::RightOnHold);
 
-        connect( Remote_View, SIGNAL( doubleClicked( QListViewItem*)),
+  connect( Remote_View, SIGNAL( doubleClicked( QListViewItem*)),
              this,SLOT( remoteListClicked(QListViewItem *)) );
     connect( Remote_View, SIGNAL( mouseButtonPressed( int, QListViewItem *, const QPoint&, int)),
              this,SLOT( RemoteListPressed(int, QListViewItem *, const QPoint&, int)) );
 
     tabLayout_2->addWidget( Remote_View, 0, 0 );
 
-        TabWidget->insertTab( tab_2, tr( "Remote" ) );
+  TabWidget->insertTab( tab_2, tr( "Remote" ) );
 
     tab_3 = new QWidget( TabWidget, "tab_3" );
     tabLayout_3 = new QGridLayout( tab_3 );
     tabLayout_3->setSpacing( 2);
     tabLayout_3->setMargin( 2);
 
@@ -202,36 +202,36 @@ OpieFtp::OpieFtp( )
     remotePath->setText( currentRemoteDir = "/");
     tabLayout_3->addMultiCellWidget( remotePath, 3, 3, 2, 3 );
 //    remotePath->setText( currentRemoteDir = "/home/llornkcor/");
 
     TextLabel4 = new QLabel( tab_3, "TextLabel4" );
     TextLabel4->setText( tr( "Port" ) );
-        tabLayout_3->addMultiCellWidget( TextLabel4, 4, 4, 0, 1 );
+  tabLayout_3->addMultiCellWidget( TextLabel4, 4, 4, 0, 1 );
 
-        PortSpinBox = new QSpinBox( tab_3, "PortSpinBox" );
+  PortSpinBox = new QSpinBox( tab_3, "PortSpinBox" );
     PortSpinBox->setButtonSymbols( QSpinBox::UpDownArrows );
     PortSpinBox->setMaxValue(32786);
     PortSpinBox->setValue( 4242);
 //    PortSpinBox->setValue( 21);
-        tabLayout_3->addMultiCellWidget( PortSpinBox, 4, 4, 1, 1);
+  tabLayout_3->addMultiCellWidget( PortSpinBox, 4, 4, 1, 1);
 
     QSpacerItem* spacer = new QSpacerItem( 20, 20, QSizePolicy::Minimum, QSizePolicy::Expanding );
     tabLayout_3->addItem( spacer, 5, 0 );
 
-        TabWidget->insertTab( tab_3, tr( "Config" ) );
+  TabWidget->insertTab( tab_3, tr( "Config" ) );
 
     connect(TabWidget,SIGNAL(currentChanged(QWidget *)),
             this,SLOT(tabChanged(QWidget*)));
 
     currentDir.setFilter( QDir::Files | QDir::Dirs/* | QDir::Hidden*/ | QDir::All);
     currentDir.setPath( QDir::currentDirPath());
 //      currentDir.setSorting(/* QDir::Size*/ /*| QDir::Reversed | */QDir::DirsFirst);
     currentPathEdit = new QLineEdit( "/", this, "currentPathEdit" );
     layout->addMultiCellWidget( currentPathEdit, 3, 3, 0, 3 );
 
-        currentPathEdit->setText( currentDir.canonicalPath());
+  currentPathEdit->setText( currentDir.canonicalPath());
     connect( currentPathEdit,SIGNAL(returnPressed()),this,SLOT(currentPathEditChanged()));
 
     ProgressBar = new QProgressBar( this, "ProgressBar" );
     layout->addMultiCellWidget( ProgressBar, 4, 4, 0, 3 );
 
     filterStr="*";
@@ -243,26 +243,31 @@ OpieFtp::~OpieFtp()
 }
 
 void OpieFtp::cleanUp()
 {
     if(conn)
         FtpQuit(conn);
-   QFile f("./._temp");
-   if(f.exists())
-       f. remove();
+    QString sfile=QDir::homeDirPath();
+    if(sfile.right(1) != "/")
+        sfile+="/._temp";
+    else
+        sfile+="._temp";
+    QFile file( sfile);
+    if(file.exists())
+        file.remove();
 }
 
 void OpieFtp::tabChanged(QWidget *w)
 {
     if (TabWidget->currentPageIndex() == 0) {
             currentPathEdit->setText( currentDir.canonicalPath());
     }
-        if (TabWidget->currentPageIndex() == 1) {
+  if (TabWidget->currentPageIndex() == 1) {
             currentPathEdit->setText( currentRemoteDir );
     }
-        if (TabWidget->currentPageIndex() == 2) {
+  if (TabWidget->currentPageIndex() == 2) {
     }
 }
 
 void OpieFtp::localUpload()
 {
     int fsz;
@@ -292,13 +297,13 @@ void OpieFtp::localUpload()
         ProgressBar->reset();
         nullifyCallBack();
     } else {
         QMessageBox::message("Note","Cannot upload directories");
     }
     TabWidget->setCurrentPage(1);
-    populateRemoteView();
+    remoteDirList( (const QString &)currentRemoteDir); //this also calls populate
     QCopEnvelope ( "QPE/System", "notBusy()" );
 }
 
 void OpieFtp::nullifyCallBack()
 {
         FtpOptions(FTPLIB_CALLBACK, NULL, conn);
@@ -394,22 +399,28 @@ void OpieFtp::disConnector()
     currentRemoteDir="/";
     Remote_View->clear();
 }
 
 bool OpieFtp::remoteDirList(const QString &dir)
 {
+    QString tmp = QDir::homeDirPath();
+    if(tmp.right(1) != "/")
+        tmp+="/._temp";
+    else
+        tmp+="._temp";
+//    qDebug("Listing remote dir "+tmp);
     QCopEnvelope ( "QPE/System", "busy()" );
-    if (!FtpDir( "./._temp", dir.latin1(), conn) ) {
+    if (!FtpDir( tmp.latin1(), dir.latin1(), conn) ) {
         QString msg;
         msg.sprintf("Unable to list the directory\n"+dir+"\n%s",FtpLastResponse(conn) );
         msg.replace(QRegExp(":"),"\n");
         QMessageBox::message("Note",msg);
 //        FtpQuit(conn);
         return false;
     }
-    populateRemoteView();
+    populateRemoteView() ;
     QCopEnvelope ( "QPE/System", "notBusy()" );
     return true;
 }
 
 bool OpieFtp::remoteChDir(const QString &dir)
 {
@@ -460,21 +471,27 @@ void OpieFtp::populateLocalView()
         ++it;
      }
     Local_View->setSorting( 3,FALSE);
     currentPathEdit->setText( currentDir.canonicalPath() );
 }
 
-bool OpieFtp::populateRemoteView()
+bool OpieFtp::populateRemoteView( )
 {
+//    qDebug("populate remoteview");
+    QString sfile=QDir::homeDirPath();
+    if(sfile.right(1) != "/")
+        sfile+="/._temp";
+    else
+        sfile+="._temp";
+    QFile file( sfile);
     Remote_View->clear();
-    QFile tmp("./._temp");
     QString s, File_Name;
     QString fileL, fileS, fileDate;
     new QListViewItem( Remote_View, "../");
-    if (tmp.open(IO_ReadOnly)) {
-        QTextStream t( &tmp );   // use a text stream
+    if ( file.open(IO_ReadOnly)) {
+        QTextStream t( &file );   // use a text stream
         while ( !t.eof()) {
             s = t.readLine();
             fileL = s.right(s.length()-55);
             fileL = fileL.stripWhiteSpace();
             if(s.left(1) == "d")
                 fileL = fileL+"/";
@@ -482,15 +499,18 @@ bool OpieFtp::populateRemoteView()
             fileS = fileS.stripWhiteSpace();
             fileDate = s.mid( 42, 55-42);
             fileDate = fileDate.stripWhiteSpace();
             if(fileL.find("total",0,TRUE) == -1)          
              new QListViewItem( Remote_View, fileL, fileS, fileDate);
         }
-        tmp.close();
+        file.close();
+        if( file.exists())
+            file. remove();
     } else
-        qDebug("temp file not opened successfullly");
+        qDebug("temp file not opened successfullly "+sfile);
+    
     return true;        
 }
 
 void OpieFtp::remoteListClicked(QListViewItem *selectedItem)
 {
     QCopEnvelope ( "QPE/System", "busy()" );
@@ -519,34 +539,32 @@ void OpieFtp::remoteListClicked(QListViewItem *selectedItem)
             strItem=strItem.right( strItem.length() - strItem.find("->",0,TRUE) - 2 );
             strItem = strItem.stripWhiteSpace();
             currentRemoteDir = strItem;
             if( !remoteChDir( (const QString &)strItem)) {
                 currentRemoteDir = oldRemoteCurrentDir;
                 strItem="";
-                populateRemoteView();
                 qDebug("RemoteCurrentDir1 "+oldRemoteCurrentDir);
             }
         } else if(strItem.find("/",0,TRUE) != -1) { // this is a directory
             qDebug("trying directory");
             if( !remoteChDir( (const QString &)currentRemoteDir + strItem)) {
                 currentRemoteDir = oldRemoteCurrentDir;
                 strItem="";
                 qDebug("RemoteCurrentDir1 "+oldRemoteCurrentDir);
 
-                populateRemoteView();
             } else {
             currentRemoteDir = currentRemoteDir+strItem;
             }
         } else {
             qDebug("download "+strItem);
         }
     }
+    remoteDirList( (const QString &)currentRemoteDir); //this also calls populate
     if(currentRemoteDir.right(1) !="/")
         currentRemoteDir +="/";
     currentPathEdit->setText( currentRemoteDir );
-    remoteDirList( (const QString &)currentRemoteDir);
     QCopEnvelope ( "QPE/System", "notBusy()" );
 }
 
 void OpieFtp::localListClicked(QListViewItem *selectedItem)
 {
     QString strItem=selectedItem->text(0);
@@ -721,14 +739,14 @@ void OpieFtp::remoteMakDir()
            QString msg;
            msg.sprintf("Unable to make directory\n%s",FtpLastResponse(conn));
            msg.replace(QRegExp(":"),"\n");
            QMessageBox::message("Note",msg);
        }
        QCopEnvelope ( "QPE/System", "notBusy()" );
+    remoteDirList( (const QString &)currentRemoteDir); //this also calls populate
     }
-    populateRemoteView();
 }
 
 void OpieFtp::remoteDelete()
 {
     QString f = Remote_View->currentItem()->text(0);
     QCopEnvelope ( "QPE/System", "busy()" );
@@ -741,12 +759,14 @@ void OpieFtp::remoteDelete()
               if(FtpRmdir( path.latin1(), conn) ==0) {
                   QString msg;
                   msg.sprintf("Unable to remove directory\n%s",FtpLastResponse(conn));
                   msg.replace(QRegExp(":"),"\n");
                   QMessageBox::message("Note",msg);
               }
+              remoteDirList( (const QString &)currentRemoteDir); //this also calls populate
+              
           }
           break;
         };
     } else {
         switch ( QMessageBox::warning(this,"Delete","Do you really want to delete\n"+f+"?"
                                       ,"Yes","No",0,0,1) ) {
@@ -755,12 +775,13 @@ void OpieFtp::remoteDelete()
               if(FtpDelete( path.latin1(), conn)==0) {
                   QString msg;
                   msg.sprintf("Unable to delete file\n%s",FtpLastResponse(conn));
                   msg.replace(QRegExp(":"),"\n");
                   QMessageBox::message("Note",msg);
               }
+              remoteDirList( (const QString &)currentRemoteDir); //this also calls populate
           }
           break;
         };
     }
     QCopEnvelope ( "QPE/System", "notBusy()" );
 }
@@ -780,14 +801,14 @@ void OpieFtp::remoteRename()
             QString msg;
             msg.sprintf("Unable to rename file\n%s",FtpLastResponse(conn));
             msg.replace(QRegExp(":"),"\n");
             QMessageBox::message("Note",msg);
         }
         QCopEnvelope ( "QPE/System", "notBusy()" );
+    remoteDirList( (const QString &)currentRemoteDir); //this also calls populate
     }
-    populateRemoteView();
 }
 
 void OpieFtp::localRename()
 {
     QString curFile = Local_View->currentItem()->text(0);
     InputDialog *fileDlg;
diff --git a/noncore/net/opieftp/opieftp.h b/noncore/net/opieftp/opieftp.h
index e3ff334..1e5fffa 100644
--- a/noncore/net/opieftp/opieftp.h
+++ b/noncore/net/opieftp/opieftp.h
@@ -86,15 +86,15 @@ protected slots:
     bool remoteChDir(const QString &);
     void tabChanged(QWidget*);
     void cleanUp();
     void remoteRename();
     void localRename();
     void currentPathEditChanged();
-        void switchToLocalTab();
-        void switchToRemoteTab();
-        void switchToConfigTab();
+  void switchToLocalTab();
+  void switchToRemoteTab();
+  void switchToConfigTab();
 protected:
     void nullifyCallBack();
     QGridLayout* tabLayout;
     QGridLayout* tabLayout_2;
     QGridLayout* tabLayout_3;