author | erik <erik> | 2007-01-24 19:57:51 (UTC) |
---|---|---|
committer | erik <erik> | 2007-01-24 19:57:51 (UTC) |
commit | 48d9219a96096cf44df8ac24413b36d1b718b1d5 (patch) (unidiff) | |
tree | ef49f0d2b778283221ebbb8634f1a59710ddd108 /noncore/todayplugins | |
parent | 89e81059e832ff77c2f0ac8b9db12f80eafa03fc (diff) | |
download | opie-48d9219a96096cf44df8ac24413b36d1b718b1d5.zip opie-48d9219a96096cf44df8ac24413b36d1b718b1d5.tar.gz opie-48d9219a96096cf44df8ac24413b36d1b718b1d5.tar.bz2 |
Each file in this commit has the issue where a function can return a
negative result but the result is used in a context that can only be
positive.
-rw-r--r-- | noncore/todayplugins/stockticker/libstocks/http.c | 95 |
1 files changed, 47 insertions, 48 deletions
diff --git a/noncore/todayplugins/stockticker/libstocks/http.c b/noncore/todayplugins/stockticker/libstocks/http.c index cc78ab7..155ce4b 100644 --- a/noncore/todayplugins/stockticker/libstocks/http.c +++ b/noncore/todayplugins/stockticker/libstocks/http.c | |||
@@ -86,10 +86,10 @@ libstocks_return_code http_get(char *http_file, char *http_server, char **pdata) | |||
86 | 86 | ||
87 | } else | 87 | } |
88 | { | 88 | else |
89 | 89 | { | |
90 | #ifdef DEBUG | 90 | #ifdef DEBUG |
91 | printf(" gethostbyname : NOK\n"); | 91 | printf(" gethostbyname : NOK\n"); |
92 | #endif | 92 | #endif |
93 | return ERRHOST; | 93 | return ERRHOST; |
94 | } | 94 | } |
95 | 95 | ||
@@ -98,3 +98,2 @@ libstocks_return_code http_get(char *http_file, char *http_server, char **pdata) | |||
98 | { | 98 | { |
99 | |||
100 | #ifdef DEBUG | 99 | #ifdef DEBUG |
@@ -126,3 +125,3 @@ libstocks_return_code http_get(char *http_file, char *http_server, char **pdata) | |||
126 | sprintf(header,"GET http://%.128s:80%.256s HTTP/1.0\015\012\015\012", | 125 | sprintf(header,"GET http://%.128s:80%.256s HTTP/1.0\015\012\015\012", |
127 | http_server, http_file); | 126 | http_server, http_file); |
128 | } | 127 | } |
@@ -143,3 +142,3 @@ libstocks_return_code http_get(char *http_file, char *http_server, char **pdata) | |||
143 | #ifdef DEBUG | 142 | #ifdef DEBUG |
144 | printf(" send header : NOK\n"); | 143 | printf(" send header : NOK\n"); |
145 | #endif | 144 | #endif |
@@ -161,33 +160,33 @@ libstocks_return_code http_get(char *http_file, char *http_server, char **pdata) | |||
161 | 160 | ||
162 | if (r) | 161 | if (r > 0) |
163 | { | 162 | { |
164 | if(!data_lgr) | 163 | if(!data_lgr) |
165 | { | 164 | { |
166 | if((data = malloc(r+1))==NULL) | 165 | if((data = malloc(r+1))==NULL) |
167 | { | 166 | { |
168 | fprintf(stderr,"Memory allocating error (%s line %d)\n" | 167 | fprintf(stderr,"Memory allocating error (%s line %d)\n", |
169 | ,__FILE__, __LINE__); | 168 | __FILE__, __LINE__); |
170 | exit(1); | 169 | exit(1); |
171 | } | 170 | } |
172 | 171 | ||
173 | memcpy(data,buf,r); | 172 | memcpy(data,buf,r); |
174 | data_lgr = r; | 173 | data_lgr = r; |
175 | data[r]=0; | 174 | data[r]=0; |
176 | } | 175 | } |
177 | else | 176 | else |
178 | { | 177 | { |
179 | if((temp = malloc(r+data_lgr+1))==NULL) | 178 | if((temp = malloc(r+data_lgr+1))==NULL) |
180 | { | 179 | { |
181 | fprintf(stderr,"Memory allocating error (%s line %d)\n" | 180 | fprintf(stderr,"Memory allocating error (%s line %d)\n", |
182 | ,__FILE__, __LINE__); | 181 | __FILE__, __LINE__); |
183 | exit(1); | 182 | exit(1); |
184 | } | 183 | } |
185 | memcpy(temp, data, data_lgr); | 184 | memcpy(temp, data, data_lgr); |
186 | memcpy(temp+data_lgr, buf, r); | 185 | memcpy(temp+data_lgr, buf, r); |
187 | temp[r+data_lgr]=0; | 186 | temp[r+data_lgr]=0; |
188 | data_lgr += r; | 187 | data_lgr += r; |
189 | free(data); | 188 | free(data); |
190 | data = temp; | 189 | data = temp; |
191 | } | 190 | } |
192 | } | 191 | } |
193 | } | 192 | } |
@@ -215,10 +214,10 @@ libstocks_return_code http_get(char *http_file, char *http_server, char **pdata) | |||
215 | if( *temp==0x0A ) | 214 | if( *temp==0x0A ) |
216 | { | 215 | { |
217 | /* test if it is the header end */ | 216 | /* test if it is the header end */ |
218 | temp ++; | 217 | temp ++; |
219 | if (*temp == 0x0D) temp++; | 218 | if (*temp == 0x0D) temp++; |
220 | if (*temp == 0x0A) header_founded = 1; | 219 | if (*temp == 0x0A) header_founded = 1; |
221 | } | 220 | } |
222 | else | 221 | else |
223 | temp++; | 222 | temp++; |
224 | } | 223 | } |
@@ -242,4 +241,4 @@ libstocks_return_code http_get(char *http_file, char *http_server, char **pdata) | |||
242 | free(data); | 241 | free(data); |
243 | fprintf(stderr,"Memory allocating error (%s line %d)\n" | 242 | fprintf(stderr,"Memory allocating error (%s line %d)\n", |
244 | ,__FILE__, __LINE__); | 243 | __FILE__, __LINE__); |
245 | exit(1); | 244 | exit(1); |