fix for a few crashes. one being stack overwrite. please test before I commit to 0_99

6 files changed, 42 insertions, 34 deletions

diff --git a/noncore/net/mailit/emailclient.cpp b/noncore/net/mailit/emailclient.cpp
index 2102ba7..da1226c 100644
--- a/noncore/net/mailit/emailclient.cpp
+++ b/noncore/net/mailit/emailclient.cpp
@@ -471,6 +471,6 @@ void EmailClient::mailArrived(const Email &mail, bool fromDisk)
   }
-      if (item->getMail()->files.count()>0)
-      {
-      item->setPixmap(0, Resource::loadPixmap("mailit/attach"));
-      }  
+//        if (item->getMail()->files.count()>0)
+//        {
+//        item->setPixmap(0, Resource::loadPixmap("mailit/attach"));
+//        }  
     /*if (!newMail.downloaded)
diff --git a/noncore/net/mailit/emailhandler.cpp b/noncore/net/mailit/emailhandler.cpp
index 59ccd90..39f693d 100644
--- a/noncore/net/mailit/emailhandler.cpp
+++ b/noncore/net/mailit/emailhandler.cpp
@@ -177,4 +177,6 @@ bool EmailHandler::parse(const QString &in, const QString &lineShift, Email *mai
   
-  TextParser p(header, lineShift);
-  
+  //  TextParser p(header, lineShift);
+  TextParser * lp = new TextParser(header, lineShift);
+#define p (*lp)
+
   if ((pos = p.find("FROM",':', 0, TRUE)) != -1) {
@@ -272,2 +274,3 @@ bool EmailHandler::parse(const QString &in, const QString &lineShift, Email *mai
       mail->bodyPlain = body;
+     delete lp;
       return mail;
@@ -340,2 +343,3 @@ bool EmailHandler::parse(const QString &in, const QString &lineShift, Email *mai
   }
+  delete lp;
   return TRUE;
diff --git a/noncore/net/mailit/mailitwindow.cpp b/noncore/net/mailit/mailitwindow.cpp
index a111241..f945a0f 100644
--- a/noncore/net/mailit/mailitwindow.cpp
+++ b/noncore/net/mailit/mailitwindow.cpp
@@ -124,6 +124,6 @@ void MailItWindow::viewMail(QListView *view, Email *mail)
   {   
-  	QMessageBox mb( tr("Mail not downloaded"),
+    QMessageBox mb( tr("Mail not downloaded"),
                     tr("The mail you have clicked \n"
-		    "has not been downloaded yet.\n "
-		    "Would you like to do it now ?"),
+        "has not been downloaded yet.\n "
+        "Would you like to do it now ?"),
                     QMessageBox::Information,
@@ -131,9 +131,9 @@ void MailItWindow::viewMail(QListView *view, Email *mail)
                     QMessageBox::No | QMessageBox::Escape,0 );
-		 
-	result=mb.exec();
-	
-	if (result==QMessageBox::Yes)
-	{
-		emailClient->download(mail);
-	}
+     
+  result=mb.exec();
+  
+  if (result==QMessageBox::Yes)
+  {
+    emailClient->download(mail);
+  }
   }
@@ -142,3 +142,3 @@ void MailItWindow::viewMail(QListView *view, Email *mail)
   views->raiseWidget(readMail);
-  setCaption( tr( "Examine mail"  ) );
+  setCaption( tr( "Read Mail"  ) );
 }
diff --git a/noncore/unsupported/mailit/emailclient.cpp b/noncore/unsupported/mailit/emailclient.cpp
index 2102ba7..da1226c 100644
--- a/noncore/unsupported/mailit/emailclient.cpp
+++ b/noncore/unsupported/mailit/emailclient.cpp
@@ -471,6 +471,6 @@ void EmailClient::mailArrived(const Email &mail, bool fromDisk)
   }
-      if (item->getMail()->files.count()>0)
-      {
-      item->setPixmap(0, Resource::loadPixmap("mailit/attach"));
-      }  
+//        if (item->getMail()->files.count()>0)
+//        {
+//        item->setPixmap(0, Resource::loadPixmap("mailit/attach"));
+//        }  
     /*if (!newMail.downloaded)
diff --git a/noncore/unsupported/mailit/emailhandler.cpp b/noncore/unsupported/mailit/emailhandler.cpp
index 59ccd90..39f693d 100644
--- a/noncore/unsupported/mailit/emailhandler.cpp
+++ b/noncore/unsupported/mailit/emailhandler.cpp
@@ -177,4 +177,6 @@ bool EmailHandler::parse(const QString &in, const QString &lineShift, Email *mai
   
-  TextParser p(header, lineShift);
-  
+  //  TextParser p(header, lineShift);
+  TextParser * lp = new TextParser(header, lineShift);
+#define p (*lp)
+
   if ((pos = p.find("FROM",':', 0, TRUE)) != -1) {
@@ -272,2 +274,3 @@ bool EmailHandler::parse(const QString &in, const QString &lineShift, Email *mai
       mail->bodyPlain = body;
+     delete lp;
       return mail;
@@ -340,2 +343,3 @@ bool EmailHandler::parse(const QString &in, const QString &lineShift, Email *mai
   }
+  delete lp;
   return TRUE;
diff --git a/noncore/unsupported/mailit/mailitwindow.cpp b/noncore/unsupported/mailit/mailitwindow.cpp
index a111241..f945a0f 100644
--- a/noncore/unsupported/mailit/mailitwindow.cpp
+++ b/noncore/unsupported/mailit/mailitwindow.cpp
@@ -124,6 +124,6 @@ void MailItWindow::viewMail(QListView *view, Email *mail)
   {   
-  	QMessageBox mb( tr("Mail not downloaded"),
+    QMessageBox mb( tr("Mail not downloaded"),
                     tr("The mail you have clicked \n"
-		    "has not been downloaded yet.\n "
-		    "Would you like to do it now ?"),
+        "has not been downloaded yet.\n "
+        "Would you like to do it now ?"),
                     QMessageBox::Information,
@@ -131,9 +131,9 @@ void MailItWindow::viewMail(QListView *view, Email *mail)
                     QMessageBox::No | QMessageBox::Escape,0 );
-		 
-	result=mb.exec();
-	
-	if (result==QMessageBox::Yes)
-	{
-		emailClient->download(mail);
-	}
+     
+  result=mb.exec();
+  
+  if (result==QMessageBox::Yes)
+  {
+    emailClient->download(mail);
+  }
   }
@@ -142,3 +142,3 @@ void MailItWindow::viewMail(QListView *view, Email *mail)
   views->raiseWidget(readMail);
-  setCaption( tr( "Examine mail"  ) );
+  setCaption( tr( "Read Mail"  ) );
 }