- cleanup and code refactoring towards 1.0

- match IP addresses to MAC addresses by looking @ ARP packets
- show IP addresses
- reduce debug output

8 files changed, 158 insertions, 42 deletions

diff --git a/noncore/net/wellenreiter/gui/gui.pro b/noncore/net/wellenreiter/gui/gui.pro
index 927f4b7..62e1d9a 100644
--- a/noncore/net/wellenreiter/gui/gui.pro
+++ b/noncore/net/wellenreiter/gui/gui.pro
@@ -46,2 +46,20 @@ contains( platform, x11 ) {
 }
 
+TRANSLATIONS  = ../../../../i18n/de/wellenreiter.ts \
+                ../../../../i18n/nl/wellenreiter.ts \
+                ../../../../i18n/da/wellenreiter.ts \
+                ../../../../i18n/xx/wellenreiter.ts \
+                ../../../../i18n/en/wellenreiter.ts \
+                ../../../../i18n/es/wellenreiter.ts \
+                ../../../../i18n/fr/wellenreiter.ts \
+                ../../../../i18n/hu/wellenreiter.ts \
+                ../../../../i18n/ja/wellenreiter.ts \
+                ../../../../i18n/ko/wellenreiter.ts \
+                ../../../../i18n/no/wellenreiter.ts \
+                ../../../../i18n/pl/wellenreiter.ts \
+                ../../../../i18n/pt/wellenreiter.ts \
+                ../../../../i18n/pt_BR/wellenreiter.ts \
+                ../../../../i18n/sl/wellenreiter.ts \
+                ../../../../i18n/zh_CN/wellenreiter.ts \
+                ../../../../i18n/zh_TW/wellenreiter.ts
+
diff --git a/noncore/net/wellenreiter/gui/logwindow.cpp b/noncore/net/wellenreiter/gui/logwindow.cpp
index 12f74fd..6078fa2 100644
--- a/noncore/net/wellenreiter/gui/logwindow.cpp
+++ b/noncore/net/wellenreiter/gui/logwindow.cpp
@@ -18,4 +18,6 @@
 #include <qdatetime.h>
 
+MLogWindow* MLogWindow::_instance;
+
 MLogWindow::MLogWindow( QWidget * parent, const char * name, WFlags f )
            :QVBox( parent, name, f )
@@ -23,4 +25,6 @@ MLogWindow::MLogWindow( QWidget * parent, const char * name, WFlags f )
     ledit = new QMultiLineEdit( this );
     ledit->setReadOnly( true );
+
+    MLogWindow::_instance = this;
 }
 
diff --git a/noncore/net/wellenreiter/gui/logwindow.h b/noncore/net/wellenreiter/gui/logwindow.h
index 6e0fe50..da8c274 100644
--- a/noncore/net/wellenreiter/gui/logwindow.h
+++ b/noncore/net/wellenreiter/gui/logwindow.h
@@ -32,7 +32,12 @@ class MLogWindow: public QVBox
     void clear();
 
+    static MLogWindow* logwindow() { return MLogWindow::_instance; };
+
   protected:
     QMultiLineEdit* ledit;
 
+  private:
+    static MLogWindow* _instance;
+
 };
 
diff --git a/noncore/net/wellenreiter/gui/mainwindow.cpp b/noncore/net/wellenreiter/gui/mainwindow.cpp
index c4a8fbc..773d825 100644
--- a/noncore/net/wellenreiter/gui/mainwindow.cpp
+++ b/noncore/net/wellenreiter/gui/mainwindow.cpp
@@ -133,9 +133,9 @@ WellenreiterMainWindow::WellenreiterMainWindow( QWidget * parent, const char * n
 
     id = mb->insertItem( tr( "&File" ), file );
-    id = mb->insertItem( tr( "&View" ), view );
-    mb->setItemEnabled( id, false );
+    //id = mb->insertItem( tr( "&View" ), view );
+    //mb->setItemEnabled( id, false );
     id = mb->insertItem( tr( "&Sniffer" ), sniffer );
-    id = mb->insertItem( tr( "&Demo" ), demo );
-    mb->setItemEnabled( id, true );
+    //id = mb->insertItem( tr( "&Demo" ), demo );
+    //mb->setItemEnabled( id, true );
 
     #ifdef QWS
diff --git a/noncore/net/wellenreiter/gui/scanlist.cpp b/noncore/net/wellenreiter/gui/scanlist.cpp
index 3a6aa15..d5665b4 100644
--- a/noncore/net/wellenreiter/gui/scanlist.cpp
+++ b/noncore/net/wellenreiter/gui/scanlist.cpp
@@ -16,4 +16,5 @@
 #include "scanlist.h"
 #include "configwindow.h"
+#include "logwindow.h"
 
 #include <assert.h>
@@ -41,7 +42,8 @@ const int col_channel = 3;
 const int col_wep = 4;
 const int col_traffic = 5;
-const int col_manuf = 6;
-const int col_firstseen = 7;
-const int col_lastseen = 8;
+const int col_ip = 6;
+const int col_manuf = 7;
+const int col_firstseen = 8;
+const int col_lastseen = 9;
 
 MScanListView::MScanListView( QWidget* parent, const char* name )
@@ -53,21 +55,23 @@ MScanListView::MScanListView( QWidget* parent, const char* name )
 
     addColumn( tr( "Net/Station" ) );
-    setColumnAlignment( 0, AlignLeft || AlignVCenter );
+    setColumnAlignment( col_essid, AlignLeft || AlignVCenter );
     addColumn( tr( "#" ) );
-    setColumnAlignment( 1, AlignCenter );
+    setColumnAlignment( col_sig, AlignCenter );
     addColumn( tr( "MAC" ) );
-    setColumnAlignment( 2, AlignCenter );
+    setColumnAlignment( col_ap, AlignCenter );
     addColumn( tr( "Chn" ) );
-    setColumnAlignment( 3, AlignCenter );
+    setColumnAlignment( col_channel, AlignCenter );
     addColumn( tr( "W" ) );
-    setColumnAlignment( 4, AlignCenter );
+    setColumnAlignment( col_wep, AlignCenter );
     addColumn( tr( "T" ) );
-    setColumnAlignment( 5, AlignCenter );
+    setColumnAlignment( col_traffic, AlignCenter );
+    addColumn( tr( "IP" ) );
+    setColumnAlignment( col_ip, AlignCenter );
     addColumn( tr( "Manufacturer" ) );
-    setColumnAlignment( 6, AlignCenter );
+    setColumnAlignment( col_manuf, AlignCenter );
     addColumn( tr( "First Seen" ) );
-    setColumnAlignment( 7, AlignCenter );
+    setColumnAlignment( col_firstseen, AlignCenter );
     addColumn( tr( "Last Seen" ) );
-    setColumnAlignment( 8, AlignCenter );
+    setColumnAlignment( col_lastseen, AlignCenter );
     setRootIsDecorated( true );
     setAllColumnsShowFocus( true );
@@ -104,9 +108,8 @@ void MScanListView::addNewItem( QString type, QString essid, QString macaddr, bo
     // FIXME: scanlistitem needs a proper encapsulation and not such a damn dealing with text(...)
 
-        qDebug( "MScanList::addNewItem( %s / %s / %s [%d]",
-        (const char*) type,
-        (const char*) essid,
-        (const char*) macaddr,
-        channel );
+    #ifdef DEBUG
+    qDebug( "MScanList::addNewItem( %s / %s / %s [%d]", (const char*) type,
+            (const char*) essid, (const char*) macaddr, channel );
+    #endif
 
     // search, if we already have seen this net
@@ -118,5 +121,7 @@ void MScanListView::addNewItem( QString type, QString essid, QString macaddr, bo
     while ( item && ( item->text( col_essid ) != essid ) )
     {
+        #ifdef DEBUG
         qDebug( "itemtext: %s", (const char*) item->text( col_essid ) );
+        #endif
         item = static_cast<MScanListItem*> ( item->nextSibling() );
     }
@@ -132,5 +137,7 @@ void MScanListView::addNewItem( QString type, QString essid, QString macaddr, bo
         while ( item && ( item->text( col_ap ) != macaddr ) )
         {
+            #ifdef DEBUG
             qDebug( "subitemtext: %s", (const char*) item->text( col_ap ) );
+            #endif
             item = static_cast<MScanListItem*> ( item->nextSibling() );
         }
@@ -148,6 +155,6 @@ void MScanListView::addNewItem( QString type, QString essid, QString macaddr, bo
     else
     {
-        s.sprintf( "(i) new network: '%s'", (const char*) essid );
-        //TODO send s to logwindow
+        s.sprintf( "(i) New network: ESSID '%s'", (const char*) essid );
+        MLogWindow::logwindow()->log( s );
         network = new MScanListItem( this, "network", essid, QString::null, 0, 0, 0 );
     }
@@ -157,5 +164,7 @@ void MScanListView::addNewItem( QString type, QString essid, QString macaddr, bo
     // no essid to reduce clutter, maybe later we have a nick or stationname to display!?
 
+    #ifdef DEBUG
     qDebug( "inserting new station %s", (const char*) macaddr );
+    #endif
 
     MScanListItem* station = new MScanListItem( network, type, "", macaddr, wep, channel, signal );
@@ -165,11 +174,11 @@ void MScanListView::addNewItem( QString type, QString essid, QString macaddr, bo
     if ( type == "managed" )
     {
-        s.sprintf( "(i) new AP in '%s' [%d]", (const char*) essid, channel );
+        s.sprintf( "(i) New Access Point in '%s' [%d]", (const char*) essid, channel );
     }
     else
     {
-        s.sprintf( "(i) new adhoc station in '%s' [%d]", (const char*) essid, channel );
+        s.sprintf( "(i) New AdHoc station in '%s' [%d]", (const char*) essid, channel );
     }
-    //TODO send s to logwindow
+    MLogWindow::logwindow()->log( s );
 
 }
@@ -182,5 +191,7 @@ void MScanListView::addIfNotExisting( MScanListItem* network, QString addr, cons
     while ( subitem && ( subitem->text( col_ap ) != addr ) )
     {
+        #ifdef DEBUG
         qDebug( "subitemtext: %s", (const char*) subitem->text( col_ap ) );
+        #endif
         subitem = static_cast<MScanListItem*> ( subitem->nextSibling() );
     }
@@ -204,11 +215,11 @@ void MScanListView::addIfNotExisting( MScanListItem* network, QString addr, cons
     if ( type == "station" )
     {
-        s.sprintf( "(i) new station in '%s' [??]", (const char*) network->text( col_essid ) );
+        s.sprintf( "(i) New Station in '%s' [xx]", (const char*) network->text( col_essid ) );
     }
     else
     {
-        s.sprintf( "(i) new wireless station in '%s' [??]", (const char*) network->text( col_essid ) );
+        s.sprintf( "(i) New Wireless Station in '%s' [xx]", (const char*) network->text( col_essid ) );
     }
-    //TODO send s to logwindow
+    MLogWindow::logwindow()->log( s );
 }
 
@@ -234,4 +245,5 @@ void MScanListView::WDStraffic( QString from, QString to, QString viaFrom, QStri
     {
         qDebug( "D'Oh! Stations without AP... ignoring for now... will handle this in 1.1 version :-D" );
+        MLogWindow::logwindow()->log( "WARNING: Unhandled WSD traffic!" );
     }
 }
@@ -255,7 +267,10 @@ void MScanListView::toDStraffic( QString from, QString to, QString via )
     {
         qDebug( "D'Oh! Station without AP... ignoring for now... will handle this in 1.1 :-D" );
+        MLogWindow::logwindow()->log( "WARNING: Unhandled toDS traffic!" );
+
     }
 }
 
+
 void MScanListView::fromDStraffic( QString from, QString to, QString via )
 {
@@ -275,12 +290,35 @@ void MScanListView::fromDStraffic( QString from, QString to, QString via )
     {
         qDebug( "D'Oh! Station without AP... ignoring for now... will handle this in 1.1 :-D" );
+        MLogWindow::logwindow()->log( "WARNING: Unhandled fromDS traffic!" );
     }
 }
 
+
 void MScanListView::IBSStraffic( QString from, QString to, QString via )
 {
     qWarning( "D'oh! Not yet implemented..." );
+    MLogWindow::logwindow()->log( "WARNING: Unhandled IBSS traffic!" );
 }
 
+
+void MScanListView::identify( const QString& macaddr, const QString& ip )
+{
+    qDebug( "identify %s = %s", (const char*) macaddr, (const char*) ip );
+
+    QListViewItemIterator it( this );
+    for ( ; it.current(); ++it )
+    {
+        if ( it.current()->text( col_ap ) == macaddr )
+        {
+            it.current()->setText( col_ip, ip );
+            return;
+        }
+    }
+    qDebug( "D'oh! Received identification, but item not yet in list... ==> Handle this!" );
+    MLogWindow::logwindow()->log( QString().sprintf( "WARNING: Unhandled identification %s = %s!",
+                                                     (const char*) macaddr, (const char*) ip ) );
+}
+
+
 //============================================================
 // MScanListItem
@@ -293,5 +331,7 @@ MScanListItem::MScanListItem( QListView* parent, QString type, QString essid, QS
                 _channel( channel ), _signal( signal ), _beacons( 1 )
 {
+    #ifdef DEBUG
     qDebug( "creating scanlist item" );
+    #endif
     if ( WellenreiterConfigWindow::instance() && type == "network" )
         playSound( WellenreiterConfigWindow::instance()->soundOnNetwork() );
@@ -303,5 +343,7 @@ MScanListItem::MScanListItem( QListViewItem* parent, QString type, QString essid
                :OListViewItem( parent, essid, QString::null, macaddr, QString::null, QString::null )
 {
+    #ifdef DEBUG
     qDebug( "creating scanlist item" );
+    #endif
     decorateItem( type, essid, macaddr, wep, channel, signal );
 }
@@ -314,5 +356,7 @@ OListViewItem* MScanListItem::childFactory()
 void MScanListItem::serializeTo( QDataStream& s ) const
 {
+    #ifdef DEBUG
     qDebug( "serializing MScanListItem" );
+    #endif
     OListViewItem::serializeTo( s );
 
@@ -323,5 +367,7 @@ void MScanListItem::serializeTo( QDataStream& s ) const
 void MScanListItem::serializeFrom( QDataStream& s )
 {
+    #ifdef DEBUG
     qDebug( "serializing MScanListItem" );
+    #endif
     OListViewItem::serializeFrom( s );
 
@@ -341,4 +387,5 @@ void MScanListItem::serializeFrom( QDataStream& s )
 void MScanListItem::decorateItem( QString type, QString essid, QString macaddr, bool wep, int channel, int signal )
 {
+    #ifdef DEBUG
     qDebug( "decorating scanlist item %s / %s / %s [%d]",
         (const char*) type,
@@ -346,4 +393,5 @@ void MScanListItem::decorateItem( QString type, QString essid, QString macaddr,
         (const char*) macaddr,
         channel );
+    #endif
 
     // set icon for managed or adhoc mode
diff --git a/noncore/net/wellenreiter/gui/scanlist.h b/noncore/net/wellenreiter/gui/scanlist.h
index 56bf837..4cb9216 100644
--- a/noncore/net/wellenreiter/gui/scanlist.h
+++ b/noncore/net/wellenreiter/gui/scanlist.h
@@ -47,4 +47,6 @@ class MScanListView: public OListView
     void IBSStraffic( QString from, QString to, QString via ); // NYI
 
+    void identify( const QString& macaddr, const QString& ipaddr );
+
   protected:
     void addIfNotExisting( MScanListItem* parent, QString addr, const QString& type = "station" );
diff --git a/noncore/net/wellenreiter/gui/wellenreiter.cpp b/noncore/net/wellenreiter/gui/wellenreiter.cpp
index 62bda91..9e1010b 100644
--- a/noncore/net/wellenreiter/gui/wellenreiter.cpp
+++ b/noncore/net/wellenreiter/gui/wellenreiter.cpp
@@ -138,11 +138,5 @@ void Wellenreiter::channelHopped(int c)
 
 
-void Wellenreiter::receivePacket(OPacket* p)
-{
-    hexWindow()->log( p->dump( 8 ) );
-
-    // check if we received a beacon frame
-    OWaveLanManagementPacket* beacon = static_cast<OWaveLanManagementPacket*>( p->child( "802.11 Management" ) );
-    if ( beacon && beacon->managementType() == "Beacon" )
+void Wellenreiter::handleBeacon( OPacket* p, OWaveLanManagementPacket* beacon )
     {
         QString type;
@@ -157,5 +151,5 @@ void Wellenreiter::receivePacket(OPacket* p)
         else
         {
-            qDebug( "Wellenreiter::invalid frame detected: '%s'", (const char*) p->dump( 16 ) );
+        qWarning( "Wellenreiter::invalid frame [possibly noise] detected!" );
             return;
         }
@@ -178,10 +172,8 @@ void Wellenreiter::receivePacket(OPacket* p)
                 graphwindow->traffic( ds->channel(), 95 );
         }
-        return;
     }
 
-    // check for a data frame
-    OWaveLanDataPacket* data = static_cast<OWaveLanDataPacket*>( p->child( "802.11 Data" ) );
-    if ( data )
+
+void Wellenreiter::handleData( OPacket* p, OWaveLanDataPacket* data )
     {
         OWaveLanPacket* wlan = (OWaveLanPacket*) p->child( "802.11" );
@@ -230,6 +222,48 @@ void Wellenreiter::receivePacket(OPacket* p)
                                     wlan->macAddress3().toString() );
         }
+
+    OARPPacket* arp = (OARPPacket*) p->child( "ARP" );
+    if ( arp )
+    {
+        qDebug( "Received ARP traffic (type '%s'): ", (const char*) arp->type() );
+        if ( arp->type() == "REQUEST" )
+        {
+            netView()->identify( arp->senderMacAddress().toString(), arp->senderIPV4Address().toString() );
+        }
+        else if ( arp->type() == "REPLY" )
+        {
+            netView()->identify( arp->senderMacAddress().toString(), arp->senderIPV4Address().toString() );
+            netView()->identify( arp->targetMacAddress().toString(), arp->targetIPV4Address().toString() );
+        }
+    }
+
+    OIPPacket* ip = (OIPPacket*) p->child( "IP" );
+    if ( ip )
+    {
+        qDebug( "Received IP packet." );
+    }
+}
+
+
+void Wellenreiter::receivePacket( OPacket* p )
+{
+    hexWindow()->log( p->dump( 8 ) );
+
+    // check if we received a beacon frame
+    OWaveLanManagementPacket* beacon = static_cast<OWaveLanManagementPacket*>( p->child( "802.11 Management" ) );
+    if ( beacon && beacon->managementType() == "Beacon" )
+    {
+        handleBeacon( p, beacon );
         return;
     }
+
+    //TODO: WEP check here
+
+    // check for a data frame
+    OWaveLanDataPacket* data = static_cast<OWaveLanDataPacket*>( p->child( "802.11 Data" ) );
+    if ( data )
+    {
+        handleData( p, data );
+    }
 }
 
diff --git a/noncore/net/wellenreiter/gui/wellenreiter.h b/noncore/net/wellenreiter/gui/wellenreiter.h
index c37a9f2..ea8a692 100644
--- a/noncore/net/wellenreiter/gui/wellenreiter.h
+++ b/noncore/net/wellenreiter/gui/wellenreiter.h
@@ -27,7 +27,8 @@ class QTimerEvent;
 class QPixmap;
 class OPacket;
+class OWaveLanManagementPacket;
+class OWaveLanDataPacket;
 class OPacketCapturer;
 class OWirelessNetworkInterface;
-
 class ManufacturerDB;
 class WellenreiterConfigWindow;
@@ -64,4 +65,8 @@ class Wellenreiter : public WellenreiterBase {
 
   private:
+    void handleBeacon( OPacket* p, OWaveLanManagementPacket* beacon );
+    void handleData( OPacket* p, OWaveLanDataPacket* data );
+
+  private:
     #ifdef QWS
     OSystem _system;                // Opie Operating System identifier