7 files changed, 395 insertions, 225 deletions
diff --git a/noncore/settings/networksettings/interfaces/interfaceinformationimp.cpp b/noncore/settings/networksettings/interfaces/interfaceinformationimp.cpp index 37c3a91..698dfd3 100644 --- a/noncore/settings/networksettings/interfaces/interfaceinformationimp.cpp +++ b/noncore/settings/networksettings/interfaces/interfaceinformationimp.cpp @@ -1,5 +1,11 @@ + #include "interfaceinformationimp.h" #include "interfaceadvanced.h" +/* OPIE */ +#include <qpe/config.h> +#include <qpe/qpeapplication.h> + +/* QT */ #include <qcheckbox.h> #include <qpushbutton.h> @@ -8,5 +14,4 @@ #include <qmessagebox.h> -#include <qpe/config.h> #ifdef QWS @@ -19,5 +24,6 @@ * just display's information about the interface that is passed to it. */ -InterfaceInformationImp::InterfaceInformationImp(QWidget *parent, const char *name, Interface *i, WFlags f):InterfaceInformation(parent, name, f), interface(i){ +InterfaceInformationImp::InterfaceInformationImp(QWidget *parent, const char *name, Interface *i, WFlags f):InterfaceInformation(parent, name, f), interface(i) +{ connect(i, SIGNAL(updateInterface(Interface *)), this, SLOT(updateInterface(Interface *))); connect(i, SIGNAL(updateMessage(const QString &)), this, SLOT(showMessage(const QString &))); @@ -45,11 +51,14 @@ InterfaceInformationImp::~InterfaceInformationImp() * know about). */ -void InterfaceInformationImp::updateInterface(Interface *){ - if(interface->getStatus()){ +void InterfaceInformationImp::updateInterface(Interface *) +{ + if(interface->getStatus()) + { startButton->setEnabled(false); stopButton->setEnabled(true); restartButton->setEnabled(true); } - else{ + else + { startButton->setEnabled(true); stopButton->setEnabled(false); @@ -66,5 +75,6 @@ void InterfaceInformationImp::updateInterface(Interface *){ * Display it. */ -void InterfaceInformationImp::advanced(){ +void InterfaceInformationImp::advanced() +{ InterfaceAdvanced *a = new InterfaceAdvanced(this, "InterfaceAdvanced", Qt::WType_Modal | Qt::WDestructiveClose | Qt::WStyle_Dialog); a->interfaceName->setText(interface->getInterfaceName()); @@ -77,5 +87,5 @@ void InterfaceInformationImp::advanced(){ a->leaseExpiresLabel->setText(interface->getLeaseExpires()); a->dhcpInformation->setEnabled(interface->isDhcp()); - a->showMaximized(); + QPEApplication::showWidget( a ); } @@ -85,5 +95,6 @@ void InterfaceInformationImp::advanced(){ * @param message the message to display. */ -void InterfaceInformationImp::showMessage(const QString &message){ +void InterfaceInformationImp::showMessage(const QString &message) +{ if (CheckBoxSilent->isChecked()) return; QMessageBox::information(this, "Message", message, QMessageBox::Ok); diff --git a/noncore/settings/networksettings/mainwindowimp.cpp b/noncore/settings/networksettings/mainwindowimp.cpp index d9752ce..b0a1dd9 100644 --- a/noncore/settings/networksettings/mainwindowimp.cpp +++ b/noncore/settings/networksettings/mainwindowimp.cpp @@ -1,2 +1,3 @@ + #include "mainwindowimp.h" #include "addconnectionimp.h" @@ -6,4 +7,12 @@ #include "module.h" +/* OPIE */ +#include <qpe/qcopenvelope_qws.h> +#include <qpe/qpeapplication.h> +#include <qpe/config.h> +#include <qpe/qlibrary.h> +#include <qpe/resource.h> + +/* QT */ #include <qpushbutton.h> #include <qlistbox.h> @@ -12,25 +21,7 @@ #include <qheader.h> #include <qlabel.h> -#include <qpe/qcopenvelope_qws.h> #include <qtabwidget.h> // in order to disable the profiles tab -#include <qpe/qpeapplication.h> - #include <qmessagebox.h> -#ifdef QWS - #include <qpe/config.h> - #include <qpe/qlibrary.h> - #include <qpe/resource.h> - #include <qpe/qpeapplication.h> -#else - #include <klibloader.h> - #define QLibrary KLibrary - #include <kconfig.h> - #define Config KConfig - #include <kapplication.h> - #include <kstandarddirs.h> - #include <kiconloader.h> - #define showMaximized show -#endif #if QT_VERSION < 300 @@ -44,4 +35,5 @@ #include <qregexp.h> +/* STD */ #include <net/if.h> #include <sys/ioctl.h> @@ -51,5 +43,6 @@ #define _PROCNETDEV "/proc/net/dev" -MainWindowImp::MainWindowImp(QWidget *parent, const char *name, WFlags) : MainWindow(parent, name, Qt::WStyle_ContextHelp), advancedUserMode(true), scheme(DEFAULT_SCHEME){ +MainWindowImp::MainWindowImp(QWidget *parent, const char *name, WFlags) : MainWindow(parent, name, Qt::WStyle_ContextHelp), advancedUserMode(true), scheme(DEFAULT_SCHEME) +{ connect(addConnectionButton, SIGNAL(clicked()), this, SLOT(addClicked())); connect(removeConnectionButton, SIGNAL(clicked()), this, SLOT(removeClicked())); @@ -79,20 +72,25 @@ MainWindowImp::MainWindowImp(QWidget *parent, const char *name, WFlags) : MainWi QStringList list = i.getInterfaceList(); QMap<QString, Interface*>::Iterator it; - for ( QStringList::Iterator ni = list.begin(); ni != list.end(); ++ni ) { + for ( QStringList::Iterator ni = list.begin(); ni != list.end(); ++ni ) + { /* * we skipped it in getAllInterfaces now * we need to ignore it as well */ - if (m_handledIfaces.contains( *ni) ) { + if (m_handledIfaces.contains( *ni) ) + { qDebug("Not up iface handled by module"); continue; } bool found = false; - for( it = interfaceNames.begin(); it != interfaceNames.end(); ++it ){ + for( it = interfaceNames.begin(); it != interfaceNames.end(); ++it ) + { if(it.key() == (*ni)) found = true; } - if(!found){ - if(!(*ni).contains("_")){ + if(!found) + { + if(!(*ni).contains("_")) + { Interface *i = new Interface(this, *ni, false); i->setAttached(false); @@ -118,9 +116,12 @@ MainWindowImp::MainWindowImp(QWidget *parent, const char *name, WFlags) : MainWi QFile file(scheme); - if ( file.open(IO_ReadOnly) ) { // file opened successfully + if ( file.open(IO_ReadOnly) ) + { // file opened successfully QTextStream stream( &file ); // use a text stream - while ( !stream.eof() ) { // until end of file... + while ( !stream.eof() ) + { // until end of file... QString line = stream.readLine(); // line of text excluding '\n' - if(line.contains("SCHEME")){ + if(line.contains("SCHEME")) + { line = line.mid(7, line.length()); currentProfileLabel->setText(line); @@ -136,5 +137,6 @@ MainWindowImp::MainWindowImp(QWidget *parent, const char *name, WFlags) : MainWi * Deconstructor. Save profiles. Delete loaded libraries. */ -MainWindowImp::~MainWindowImp(){ +MainWindowImp::~MainWindowImp() +{ // Save profiles. Config cfg("NetworkSetup"); @@ -144,5 +146,6 @@ MainWindowImp::~MainWindowImp(){ // Delete all interfaces that don't have owners. QMap<Interface*, QListViewItem*>::Iterator iIt; - for( iIt = items.begin(); iIt != items.end(); ++iIt ){ + for( iIt = items.begin(); iIt != items.end(); ++iIt ) + { if(iIt.key()->getModuleOwner() == NULL) delete iIt.key(); @@ -152,5 +155,6 @@ MainWindowImp::~MainWindowImp(){ // Delete Modules and Libraries QMap<Module*, QLibrary*>::Iterator it; - for( it = libraries.begin(); it != libraries.end(); ++it ){ + for( it = libraries.begin(); it != libraries.end(); ++it ) + { delete it.key(); // I wonder why I can't delete the libraries @@ -166,5 +170,6 @@ MainWindowImp::~MainWindowImp(){ * Query the kernel for all of the interfaces. */ -void MainWindowImp::getAllInterfaces(){ +void MainWindowImp::getAllInterfaces() +{ int sockfd = socket(PF_INET, SOCK_DGRAM, 0); if(sockfd == -1) @@ -177,5 +182,6 @@ void MainWindowImp::getAllInterfaces(){ Interface *i; - if (! procFile.exists()) { + if (! procFile.exists()) + { struct ifreq ifrs[100]; struct ifconf ifc; @@ -184,10 +190,13 @@ void MainWindowImp::getAllInterfaces(){ result = ioctl(sockfd, SIOCGIFCONF, &ifc); - for (unsigned int i = 0; i < ifc.ifc_len / sizeof(struct ifreq); i++) { + for (unsigned int i = 0; i < ifc.ifc_len / sizeof(struct ifreq); i++) + { struct ifreq *pifr = &ifrs[i]; ifaces += pifr->ifr_name; } - } else { + } + else + { procFile.open(IO_ReadOnly); QString line; @@ -197,6 +206,8 @@ void MainWindowImp::getAllInterfaces(){ procTs.readLine(); // eat a line procTs.readLine(); // eat a line - while((line = procTs.readLine().simplifyWhiteSpace()) != QString::null) { - if((loc = line.find(":")) != -1) { + while((line = procTs.readLine().simplifyWhiteSpace()) != QString::null) + { + if((loc = line.find(":")) != -1) + { ifaces += line.left(loc); } @@ -204,7 +215,9 @@ void MainWindowImp::getAllInterfaces(){ } - for (QStringList::Iterator it = ifaces.begin(); it != ifaces.end(); ++it) { + for (QStringList::Iterator it = ifaces.begin(); it != ifaces.end(); ++it) + { int flags = 0; - if ( m_handledIfaces.contains( (*it) ) ) { + if ( m_handledIfaces.contains( (*it) ) ) + { qDebug(" %s is handled by a module", (*it).latin1() ); continue; @@ -246,8 +259,11 @@ void MainWindowImp::getAllInterfaces(){ QMap<Module*, QLibrary*>::Iterator it; QList<Interface> ilist; - for( it = libraries.begin(); it != libraries.end(); ++it ){ - if(it.key()){ + for( it = libraries.begin(); it != libraries.end(); ++it ) + { + if(it.key()) + { ilist = it.key()->getInterfaces(); - for( i = ilist.first(); i != 0; i = ilist.next() ){ + for( i = ilist.first(); i != 0; i = ilist.next() ) + { qWarning("Adding interface %s to interfaceNames\n", i->getInterfaceName().latin1() ); interfaceNames.insert(i->getInterfaceName(), i); @@ -265,5 +281,6 @@ void MainWindowImp::getAllInterfaces(){ * and attempts to load them */ -void MainWindowImp::loadModules(const QString &path){ +void MainWindowImp::loadModules(const QString &path) +{ #ifdef DEBUG qDebug("MainWindowImp::loadModules: %s", path.latin1()); @@ -278,9 +295,12 @@ void MainWindowImp::loadModules(const QString &path){ QFileInfoListIterator it( *list ); QFileInfo *fi; - while ( (fi=it.current()) ) { + while ( (fi=it.current()) ) + { #ifdef QWS - if(fi->fileName().contains(".so")){ + if(fi->fileName().contains(".so")) + { #else - if(fi->fileName().contains(".so") && fi->fileName().contains("networksettings_")){ + if(fi->fileName().contains(".so") && fi->fileName().contains("networksettings_")) + { #endif loadPlugin(path + "/" + fi->fileName()); @@ -297,5 +317,6 @@ void MainWindowImp::loadModules(const QString &path){ * @return pointer to the function with name resolveString or NULL */ -Module* MainWindowImp::loadPlugin(const QString &pluginFileName, const QString &resolveString){ +Module* MainWindowImp::loadPlugin(const QString &pluginFileName, const QString &resolveString) +{ #ifdef DEBUG qDebug("MainWindowImp::loadPlugin: %s: resolving %s", pluginFileName.latin1(), resolveString.latin1()); @@ -304,5 +325,6 @@ Module* MainWindowImp::loadPlugin(const QString &pluginFileName, const QString & QLibrary *lib = new QLibrary(pluginFileName); void *functionPointer = lib->resolve(resolveString); - if( !functionPointer ){ + if( !functionPointer ) + { #ifdef DEBUG qDebug("MainWindowImp::loadPlugin: Warning: %s is not a plugin", pluginFileName.latin1()); @@ -313,5 +335,6 @@ Module* MainWindowImp::loadPlugin(const QString &pluginFileName, const QString & // Try to get an object. Module *object = ((Module* (*)()) functionPointer)(); - if(object == NULL){ + if(object == NULL) + { #ifdef DEBUG qDebug("MainWindowImp: Couldn't create object, but did load library!"); @@ -328,5 +351,6 @@ Module* MainWindowImp::loadPlugin(const QString &pluginFileName, const QString & #else QLibrary *lib = loader->library(pluginFileName); - if( !lib || !lib->hasSymbol(resolveString) ){ + if( !lib || !lib->hasSymbol(resolveString) ) + { qDebug(QString("MainWindowImp::loadPlugin: File: %1 is not a plugin, but though was.").arg(pluginFileName).latin1()); return NULL; @@ -334,5 +358,6 @@ Module* MainWindowImp::loadPlugin(const QString &pluginFileName, const QString & // Try to get an object. Module *object = ((Module* (*)()) lib->symbol(resolveString))(); - if(object == NULL){ + if(object == NULL) + { #ifdef DEBUG qDebug("MainWindowImp: Couldn't create object, but did load library!"); @@ -353,16 +378,20 @@ Module* MainWindowImp::loadPlugin(const QString &pluginFileName, const QString & * load the plugin and append it to the list */ -void MainWindowImp::addClicked(){ +void MainWindowImp::addClicked() +{ QMap<Module*, QLibrary*>::Iterator it; QMap<QString, QString> list; QMap<QString, Module*> newInterfaceOwners; - for( it = libraries.begin(); it != libraries.end(); ++it ){ - if(it.key()){ + for( it = libraries.begin(); it != libraries.end(); ++it ) + { + if(it.key()) + { (it.key())->possibleNewInterfaces(list); } } // See if the list has anything that we can add. - if(list.count() == 0){ + if(list.count() == 0) + { QMessageBox::information(this, "Sorry", "Nothing to add.", QMessageBox::Ok); return; @@ -370,14 +399,17 @@ void MainWindowImp::addClicked(){ AddConnectionImp addNewConnection(this, "AddConnectionImp", true); addNewConnection.addConnections(list); - addNewConnection.showMaximized(); - if(QDialog::Accepted == addNewConnection.exec()){ + if( QDialog::Accepted == QPEApplication::execDialog( &addNewConnection ) ) + { QListViewItem *item = addNewConnection.registeredServicesList->currentItem(); if(!item) return; - for( it = libraries.begin(); it != libraries.end(); ++it ){ - if(it.key()){ + for( it = libraries.begin(); it != libraries.end(); ++it ) + { + if(it.key()) + { Interface *i = (it.key())->addNewInterface(item->text(0)); - if(i){ + if(i) + { qDebug("iface name %s",i->getInterfaceName().latin1()); interfaceNames.insert(i->getInterfaceName(), i); @@ -393,7 +425,9 @@ void MainWindowImp::addClicked(){ * If they do then remove from the list and unload. */ -void MainWindowImp::removeClicked(){ +void MainWindowImp::removeClicked() +{ QListViewItem *item = connectionList->currentItem(); - if(!item) { + if(!item) + { QMessageBox::information(this, "Sorry","Please select an interface First.", QMessageBox::Ok); return; @@ -401,11 +435,14 @@ void MainWindowImp::removeClicked(){ Interface *i = interfaceItems[item]; - if(i->getModuleOwner() == NULL){ + if(i->getModuleOwner() == NULL) + { QMessageBox::information(this, "Can't remove interface.", "Interface is built in.", QMessageBox::Ok); } - else{ + else + { if(!i->getModuleOwner()->remove(i)) QMessageBox::information(this, tr("Error"), tr("Unable to remove."), QMessageBox::Ok); - else{ + else + { delete item; // QMessageBox::information(this, "Success", "Interface was removed.", QMessageBox::Ok); @@ -419,7 +456,9 @@ void MainWindowImp::removeClicked(){ * If the interface has a module owner then request its configure. */ -void MainWindowImp::configureClicked(){ +void MainWindowImp::configureClicked() +{ QListViewItem *item = connectionList->currentItem(); - if(!item){ + if(!item) + { QMessageBox::information(this, tr("Sorry"),tr("Please select an interface first."), QMessageBox::Ok); return; @@ -432,9 +471,11 @@ void MainWindowImp::configureClicked(){ Interface *i = interfaceItems[item]; - if(i->getModuleOwner()){ + if(i->getModuleOwner()) + { QWidget *moduleConfigure = i->getModuleOwner()->configure(i); - if(moduleConfigure != NULL){ + if(moduleConfigure != NULL) + { i->getModuleOwner()->setProfile(currentProfileText); - moduleConfigure->showMaximized(); + QPEApplication::showWidget( moduleConfigure ); return; } @@ -443,5 +484,5 @@ void MainWindowImp::configureClicked(){ InterfaceSetupImpDialog *configure = new InterfaceSetupImpDialog(this, "InterfaceSetupImp", i, true, Qt::WDestructiveClose | Qt::WStyle_ContextHelp ); configure->setProfile(currentProfileText); - configure->showMaximized(); + QPEApplication::showDialog( configure ); } @@ -451,7 +492,9 @@ void MainWindowImp::configureClicked(){ * If the interface has a module owner then request its configure. */ -void MainWindowImp::informationClicked(){ +void MainWindowImp::informationClicked() +{ QListViewItem *item = connectionList->currentItem(); - if(!item){ + if(!item) + { QMessageBox::information(this, "Sorry","Please select an interface First.", QMessageBox::Ok); return; @@ -464,8 +507,10 @@ void MainWindowImp::informationClicked(){ // } - if(i->getModuleOwner()){ + if(i->getModuleOwner()) + { QWidget *moduleInformation = i->getModuleOwner()->information(i); - if(moduleInformation != NULL){ - moduleInformation->showMaximized(); + if(moduleInformation != NULL) + { + QPEApplication::showWidget( moduleInformation ); #ifdef DEBUG qDebug("MainWindowImp::informationClicked:: Module owner has created, we showed."); @@ -475,5 +520,5 @@ void MainWindowImp::informationClicked(){ } InterfaceInformationImp *information = new InterfaceInformationImp(this, "InterfaceSetupImp", i, Qt::WType_Modal | Qt::WDestructiveClose | Qt::WStyle_Dialog | Qt::WStyle_ContextHelp); - information->showMaximized(); + QPEApplication::showWidget( information ); } @@ -482,6 +527,8 @@ void MainWindowImp::informationClicked(){ * @param Interface* pointer to the interface that needs to be updated. */ -void MainWindowImp::updateInterface(Interface *i){ - if(!advancedUserMode){ +void MainWindowImp::updateInterface(Interface *i) +{ + if(!advancedUserMode) + { if(i->getInterfaceName() == "lo") return; @@ -491,9 +538,11 @@ void MainWindowImp::updateInterface(Interface *i){ // Find the interface, making it if needed. - if(items.find(i) == items.end()){ + if(items.find(i) == items.end()) + { item = new QListViewItem(connectionList, "", "", ""); // See if you can't find a module owner for this interface QMap<Module*, QLibrary*>::Iterator it; - for( it = libraries.begin(); it != libraries.end(); ++it ){ + for( it = libraries.begin(); it != libraries.end(); ++it ) + { if(it.key()->isOwner(i)) i->setModuleOwner(it.key()); @@ -538,5 +587,6 @@ void MainWindowImp::updateInterface(Interface *i){ } -void MainWindowImp::newProfileChanged(const QString& newText){ +void MainWindowImp::newProfileChanged(const QString& newText) +{ if(newText.length() > 0) newProfileButton->setEnabled(true); @@ -550,7 +600,9 @@ void MainWindowImp::newProfileChanged(const QString& newText){ * Appends to the list and QStringList */ -void MainWindowImp::addProfile(){ +void MainWindowImp::addProfile() +{ QString newProfileName = newProfile->text(); - if(profiles.grep(newProfileName).count() > 0){ + if(profiles.grep(newProfileName).count() > 0) + { QMessageBox::information(this, "Can't Add","Profile already exists.", QMessageBox::Ok); return; @@ -564,16 +616,20 @@ void MainWindowImp::addProfile(){ * Doesn't delete if there are less then 2 profiles. */ -void MainWindowImp::removeProfile(){ - if(profilesList->count() <= 1){ +void MainWindowImp::removeProfile() +{ + if(profilesList->count() <= 1) + { QMessageBox::information(this, "Can't remove.","At least one profile\nis needed.", QMessageBox::Ok); return; } QString profileToRemove = profilesList->currentText(); - if(profileToRemove == "All"){ + if(profileToRemove == "All") + { QMessageBox::information(this, "Can't remove.","Can't remove default.", QMessageBox::Ok); return; } // Can't remove the curent profile - if(profileToRemove == currentProfileLabel->text()){ + if(profileToRemove == currentProfileLabel->text()) + { QMessageBox::information(this, "Can't remove.",QString("%1 is the current profile.").arg(profileToRemove), QMessageBox::Ok); return; @@ -581,5 +637,6 @@ void MainWindowImp::removeProfile(){ } - if(QMessageBox::information(this, "Question",QString("Remove profile: %1").arg(profileToRemove), QMessageBox::Ok, QMessageBox::Cancel) == QMessageBox::Ok){ + if(QMessageBox::information(this, "Question",QString("Remove profile: %1").arg(profileToRemove), QMessageBox::Ok, QMessageBox::Cancel) == QMessageBox::Ok) + { profiles = QStringList::split(" ", profiles.join(" ").replace(QRegExp(profileToRemove), "")); profilesList->clear(); @@ -591,13 +648,17 @@ void MainWindowImp::removeProfile(){ // Go through them one by one QMap<Interface*, QListViewItem*>::Iterator it; - for( it = items.begin(); it != items.end(); ++it ){ + for( it = items.begin(); it != items.end(); ++it ) + { QString interfaceName = it.key()->getInterfaceName(); qDebug(interfaceName.latin1()); - if(interfaces.setInterface(interfaceName + "_" + profileToRemove)){ + if(interfaces.setInterface(interfaceName + "_" + profileToRemove)) + { interfaces.removeInterface(); - if(interfaces.setMapping(interfaceName)){ + if(interfaces.setMapping(interfaceName)) + { if(profilesList->count() == 1) interfaces.removeMapping(); - else{ + else + { interfaces.removeMap("map", interfaceName + "_" + profileToRemove); } @@ -614,15 +675,19 @@ void MainWindowImp::removeProfile(){ * @param newProfile the new profile. */ -void MainWindowImp::changeProfile(){ - if(profilesList->currentItem() == -1){ +void MainWindowImp::changeProfile() +{ + if(profilesList->currentItem() == -1) + { QMessageBox::information(this, "Can't Change.","Please select a profile.", QMessageBox::Ok); return; } QString newProfile = profilesList->text(profilesList->currentItem()); - if(newProfile != currentProfileLabel->text()){ + if(newProfile != currentProfileLabel->text()) + { currentProfileLabel->setText(newProfile); QFile::remove(scheme); QFile file(scheme); - if ( file.open(IO_ReadWrite) ) { + if ( file.open(IO_ReadWrite) ) + { QTextStream stream( &file ); stream << QString("SCHEME=%1").arg(newProfile); @@ -630,8 +695,10 @@ void MainWindowImp::changeProfile(){ } // restart all up devices? - if(QMessageBox::information(this, "Question","Restart all running interfaces?", QMessageBox::Ok, QMessageBox::No) == QMessageBox::Ok){ + if(QMessageBox::information(this, "Question","Restart all running interfaces?", QMessageBox::Ok, QMessageBox::No) == QMessageBox::Ok) + { // Go through them one by one QMap<Interface*, QListViewItem*>::Iterator it; - for( it = items.begin(); it != items.end(); ++it ){ + for( it = items.begin(); it != items.end(); ++it ) + { if(it.key()->getStatus() == true) it.key()->restart(); @@ -654,5 +721,6 @@ void MainWindowImp::receive(const QCString &msg, const QByteArray &arg) bool found = false; qDebug("MainWindowImp::receive QCop msg >"+msg+"<"); - if (msg == "raise") { + if (msg == "raise") + { raise(); return; @@ -665,7 +733,9 @@ void MainWindowImp::receive(const QCString &msg, const QByteArray &arg) QMap<Module*, QLibrary*>::Iterator it; - for( it = libraries.begin(); it != libraries.end(); ++it ){ + for( it = libraries.begin(); it != libraries.end(); ++it ) + { qDebug("plugin >%s<", it.key()->type().latin1() ); - if(it.key()->type() == dest){ + if(it.key()->type() == dest) + { it.key()->receive( param, arg ); found = true; diff --git a/noncore/settings/networksettings/ppp/accounts.cpp b/noncore/settings/networksettings/ppp/accounts.cpp index 28d8732..b8a1925a 100644 --- a/noncore/settings/networksettings/ppp/accounts.cpp +++ b/noncore/settings/networksettings/ppp/accounts.cpp @@ -25,6 +25,14 @@ */ +#include "accounts.h" +#include "authwidget.h" +#include "pppdata.h" +#include "edit.h" + +/* OPIE */ +#include <qpe/qpeapplication.h> + +/* QT */ #include <qdir.h> -#include <stdlib.h> #include <qlayout.h> #include <qtabwidget.h> @@ -32,5 +40,4 @@ #include <qwhatsthis.h> #include <qmessagebox.h> - #include <qapplication.h> #include <qbuttongroup.h> @@ -38,8 +45,6 @@ #include <qvgroupbox.h> -#include "accounts.h" -#include "authwidget.h" -#include "pppdata.h" -#include "edit.h" +/* STD */ +#include <stdlib.h> void parseargs(char* buf, char** args); @@ -69,5 +74,6 @@ AccountWidget::AccountWidget( PPPData *pd, QWidget *parent, const char *name, WF listListbox->insertStringList(_pppdata->getAccountList()); - for (uint i = 0; i < listListbox->count(); i++){ + for (uint i = 0; i < listListbox->count(); i++) + { if ( listListbox->text(i) == _pppdata->accname() ) listListbox->setCurrentItem( i ); @@ -77,5 +83,6 @@ AccountWidget::AccountWidget( PPPData *pd, QWidget *parent, const char *name, WF -void AccountWidget::slotListBoxSelect(int idx) { +void AccountWidget::slotListBoxSelect(int idx) +{ bool ok = _pppdata->setAccount( listListbox->text(idx) ); ok = (bool)(idx != -1); @@ -85,10 +92,12 @@ void AccountWidget::slotListBoxSelect(int idx) { } -void AccountWidget::edit() { +void AccountWidget::edit() +{ _pppdata->setAccount(listListbox->text(listListbox->currentItem())); int result = doTab(); - if(result == QDialog::Accepted) { + if(result == QDialog::Accepted) + { listListbox->changeItem(_pppdata->accname(),listListbox->currentItem()); // emit resetaccounts(); @@ -98,5 +107,6 @@ void AccountWidget::edit() { -void AccountWidget::create() { +void AccountWidget::create() +{ // if(listListbox->count() == MAX_ACCOUNTS) { @@ -107,5 +117,6 @@ void AccountWidget::create() { int result; - if (_pppdata->newaccount() == -1){ + if (_pppdata->newaccount() == -1) + { qDebug("_pppdata->newaccount() == -1"); return; @@ -113,15 +124,18 @@ void AccountWidget::create() { result = doTab(); - if(result == QDialog::Accepted) { + if(result == QDialog::Accepted) + { listListbox->insertItem(_pppdata->accname()); listListbox->setSelected(listListbox->findItem(_pppdata->accname()),true); _pppdata->save(); - } else + } + else _pppdata->deleteAccount(); } -void AccountWidget::copy() { +void AccountWidget::copy() +{ // if(listListbox->count() == MAX_ACCOUNTS) { // QMessageBox::information(this, "sorry", tr("Maximum number of accounts reached.")); @@ -129,5 +143,6 @@ void AccountWidget::copy() { // } - if(listListbox->currentItem()<0) { + if(listListbox->currentItem()<0) + { QMessageBox::information(this, "sorry", tr("No account selected.")); return; @@ -142,5 +157,6 @@ void AccountWidget::copy() { -void AccountWidget::remove() { +void AccountWidget::remove() +{ QString s = tr("Are you sure you want to delete\nthe account \"%1\"?") @@ -165,5 +181,6 @@ void AccountWidget::remove() { -int AccountWidget::doTab(){ +int AccountWidget::doTab() +{ QDialog *dlg = new QDialog( 0, "newAccount", true, Qt::WStyle_ContextHelp ); QVBoxLayout *layout = new QVBoxLayout( dlg ); @@ -176,8 +193,11 @@ int AccountWidget::doTab(){ bool isnewaccount; - if(_pppdata->accname().isEmpty()) { + if(_pppdata->accname().isEmpty()) + { dlg->setCaption(tr("New Account")); isnewaccount = true; - } else { + } + else + { QString tit = tr("Edit Account: "); tit += _pppdata->accname(); @@ -213,16 +233,22 @@ int AccountWidget::doTab(){ bool ok = false; - while (!ok){ - dlg->showMaximized(); - result = dlg->exec(); + while (!ok) + { + result = QPEApplication::execDialog( dlg ); ok = true; - if(result == QDialog::Accepted) { - if (!auth_w->check()){ + if(result == QDialog::Accepted) + { + if (!auth_w->check()) + { ok = false; - } else if(!dial_w->save()) { + } + else if(!dial_w->save()) + { QMessageBox::critical(this, "error", tr( "You must enter a unique account name")); ok = false; - }else{ + } + else + { ip_w->save(); dns_w->save(); diff --git a/noncore/settings/networksettings/ppp/general.cpp b/noncore/settings/networksettings/ppp/general.cpp index 5540946..ff1b11b 100644 --- a/noncore/settings/networksettings/ppp/general.cpp +++ b/noncore/settings/networksettings/ppp/general.cpp @@ -25,7 +25,15 @@ */ -#include <termios.h> -#include <string.h> +#include "general.h" +#include "interfaceppp.h" +#include "modeminfo.h" +#include "modemcmds.h" +#include "pppdata.h" +/* OPIE */ +#include <qpe/config.h> +#include <qpe/qpeapplication.h> + +/* QT */ #include <qcheckbox.h> #include <qcombobox.h> @@ -36,18 +44,8 @@ #include <qspinbox.h> #include <qwhatsthis.h> -#include <qpe/config.h> -// #include <qgroupbox.h> - - -#include "general.h" -#include "interfaceppp.h" -//#include "miniterm.h" -#include "modeminfo.h" -#include "modemcmds.h" -//#include "devices.h" -#include "pppdata.h" -//#include <klocale.h> - +/* STD */ +#include <termios.h> +#include <string.h> @@ -149,5 +147,6 @@ ModemWidget::ModemWidget( PPPData *pd, QWidget *parent, const char *name ) baud_label->setBuddy(baud_c); - static const char *baudrates[] = { + static const char *baudrates[] = + { #ifdef B460800 @@ -171,5 +170,6 @@ ModemWidget::ModemWidget( PPPData *pd, QWidget *parent, const char *name ) "9600", "2400", - 0}; + 0 + }; for(k = 0; baudrates[k]; k++) @@ -191,5 +191,6 @@ ModemWidget::ModemWidget( PPPData *pd, QWidget *parent, const char *name ) QWhatsThis::add(baud_c,tmp); - for(int i=0; i <= enter->count()-1; i++) { + for(int i=0; i <= enter->count()-1; i++) + { if(_pppdata->enter() == enter->text(i)) enter->setCurrentItem(i); @@ -238,15 +239,18 @@ ModemWidget::ModemWidget( PPPData *pd, QWidget *parent, const char *name ) //set stuff from gpppdata - for(int i=0; i <= enter->count()-1; i++) { + for(int i=0; i <= enter->count()-1; i++) + { if(_pppdata->enter() == enter->text(i)) enter->setCurrentItem(i); } - for(int i=0; i <= modemdevice->count()-1; i++) { + for(int i=0; i <= modemdevice->count()-1; i++) + { if(_pppdata->modemDevice() == modemdevice->text(i)) modemdevice->setCurrentItem(i); } - for(int i=0; i <= flowcontrol->count()-1; i++) { + for(int i=0; i <= flowcontrol->count()-1; i++) + { if(_pppdata->flowcontrol() == flowcontrol->text(i)) flowcontrol->setCurrentItem(i); @@ -274,7 +278,9 @@ ModemWidget::~ModemWidget() QString edited = modemdevice->currentText(); - if ( !( edited ).isEmpty() ) { + if ( !( edited ).isEmpty() ) + { edited.simplifyWhiteSpace(); - if ( devs.contains( edited ) == 0 ) { + if ( devs.contains( edited ) == 0 ) + { devs << edited; } @@ -471,12 +477,14 @@ ModemWidget2::ModemWidget2( PPPData *pd, InterfacePPP *ip, QWidget *parent, -void ModemWidget2::modemcmdsbutton() { +void ModemWidget2::modemcmdsbutton() +{ ModemCommands mc(_ifaceppp->data(), this, "commands" , true, Qt::WStyle_ContextHelp); - mc.showMaximized(); - mc.exec(); + + QPEApplication::execDialog( &mc ); } -void ModemWidget2::query_modem() { +void ModemWidget2::query_modem() +{ ModemTransfer mt(_ifaceppp->modem(), this); mt.exec(); diff --git a/noncore/settings/networksettings/ppp/modeminfo.cpp b/noncore/settings/networksettings/ppp/modeminfo.cpp index dbb26db..df0bf9b 100644 --- a/noncore/settings/networksettings/ppp/modeminfo.cpp +++ b/noncore/settings/networksettings/ppp/modeminfo.cpp @@ -25,14 +25,18 @@ */ -#include <unistd.h> +#include "modeminfo.h" +#include "modem.h" + +/* OPIE */ +#include <qpe/qpeapplication.h> + +/* QT */ #include <qregexp.h> #include <qlayout.h> -// #include <kwin.h> -// #include <kmessagebox.h> -// #include <kapplication.h> #include <qmessagebox.h> #include <qapplication.h> -#include "modeminfo.h" -#include "modem.h" + +/* STD */ +#include <unistd.h> ModemTransfer::ModemTransfer(Modem *mo, QWidget *parent, const char *name) @@ -94,5 +98,6 @@ ModemTransfer::ModemTransfer(Modem *mo, QWidget *parent, const char *name) -void ModemTransfer::ati_done() { +void ModemTransfer::ati_done() +{ scripttimer->stop(); timeout_timer->stop(); @@ -105,6 +110,6 @@ void ModemTransfer::ati_done() { for(int i = 0; i < NUM_OF_ATI; i++) mi->setAtiString(i, ati_query_strings[i]); - mi->showMaximized(); - mi->exec(); + + QPEApplication::execDialog( mi ); delete mi; @@ -113,5 +118,6 @@ void ModemTransfer::ati_done() { -void ModemTransfer::time_out_slot() { +void ModemTransfer::time_out_slot() +{ timeout_timer->stop(); scripttimer->stop(); @@ -122,10 +128,12 @@ void ModemTransfer::time_out_slot() { -void ModemTransfer::init() { +void ModemTransfer::init() +{ qApp->processEvents(); int lock = _modem->lockdevice(); - if (lock == 1) { + if (lock == 1) + { statusBar->setText(QObject::tr("Modem device is locked.")); @@ -133,5 +141,6 @@ void ModemTransfer::init() { } - if (lock == -1) { + if (lock == -1) + { statusBar->setText(QObject::tr("Unable to create modem lock file.")); @@ -140,6 +149,8 @@ void ModemTransfer::init() { - if(_modem->opentty()) { - if(_modem->hangup()) { + if(_modem->opentty()) + { + if(_modem->hangup()) + { usleep(100000); // wait 0.1 secs _modem->writeLine("ATE0Q1V1"); // E0 don't echo the commands I send ... @@ -166,9 +177,11 @@ void ModemTransfer::init() { -void ModemTransfer::do_script() { +void ModemTransfer::do_script() +{ QString msg; QString query; - switch(step) { + switch(step) + { case 0: readtty(); @@ -200,10 +213,12 @@ void ModemTransfer::do_script() { } -void ModemTransfer::readChar(unsigned char c) { +void ModemTransfer::readChar(unsigned char c) +{ if(readbuffer.length() < 255) readbuffer += c; } -void ModemTransfer::readtty() { +void ModemTransfer::readtty() +{ if (step == 0) @@ -221,5 +236,6 @@ void ModemTransfer::readtty() { -void ModemTransfer::cancelbutton() { +void ModemTransfer::cancelbutton() +{ scripttimer->stop(); _modem->stop(); @@ -237,5 +253,6 @@ void ModemTransfer::cancelbutton() { -void ModemTransfer::closeEvent( QCloseEvent *e ) { +void ModemTransfer::closeEvent( QCloseEvent *e ) +{ cancelbutton(); e->accept(); @@ -255,5 +272,6 @@ ModemInfo::ModemInfo(QWidget *parent, const char* name) QGridLayout *l1 = new QGridLayout(NUM_OF_ATI, 2, 5); tl->addLayout(l1, 1); - for(int i = 0 ; i < NUM_OF_ATI ; i++) { + for(int i = 0 ; i < NUM_OF_ATI ; i++) + { label_text = ""; @@ -287,5 +305,6 @@ ModemInfo::ModemInfo(QWidget *parent, const char* name) -void ModemInfo::setAtiString(int i, QString s) { +void ModemInfo::setAtiString(int i, QString s) +{ if(i < NUM_OF_ATI) ati_label_result[i]->setText(s); diff --git a/noncore/settings/networksettings/ppp/pppmodule.cpp b/noncore/settings/networksettings/ppp/pppmodule.cpp index f7dacf6..a7caffe 100644 --- a/noncore/settings/networksettings/ppp/pppmodule.cpp +++ b/noncore/settings/networksettings/ppp/pppmodule.cpp @@ -1,7 +1,2 @@ -#include <errno.h> -#include <signal.h> - - -#include <qpe/config.h> #include "modem.h" @@ -12,6 +7,17 @@ #include "interfaceppp.h" +/* OPIE */ +#include <qpe/config.h> +#include <qpe/qpeapplication.h> + +/* QT */ + +/* STD */ +#include <errno.h> +#include <signal.h> + // don't polute global namespace -namespace { +namespace +{ /* * If network settings is qutting and we've ppp @@ -19,10 +25,12 @@ namespace { * and the interface number */ - struct Connection { + struct Connection + { pid_t pid; QString device; QString name; }; - class InterfaceKeeper { + class InterfaceKeeper + { public: InterfaceKeeper(); @@ -54,5 +62,6 @@ PPPModule::PPPModule() : Module() InterfacePPP *iface; qDebug("getting interfaces"); - for( it = ifaces.begin(); it != ifaces.end(); ++it ){ + for( it = ifaces.begin(); it != ifaces.end(); ++it ) + { qDebug("ifaces %s %s", it.key().latin1(), it.data().latin1() ); iface = new InterfacePPP( 0, it.key() ); @@ -61,5 +70,6 @@ PPPModule::PPPModule() : Module() // check if (*it) is one of the running ifaces - if ( running.contains( it.data() ) ) { + if ( running.contains( it.data() ) ) + { qDebug("iface is running %s", it.key().latin1() ); handledInterfaceNames << running[it.data()].device; @@ -77,12 +87,15 @@ PPPModule::PPPModule() : Module() * Delete any interfaces that we own. */ -PPPModule::~PPPModule(){ +PPPModule::~PPPModule() +{ qDebug("PPPModule::~PPPModule() " ); QMap<QString,QString> ifaces; InterfaceKeeper keeper; Interface *i; - for ( i=list.first(); i != 0; i=list.next() ){ + for ( i=list.first(); i != 0; i=list.next() ) + { /* if online save the state */ - if ( i->getStatus() ) { + if ( i->getStatus() ) + { qDebug("Iface %s is still up", i->getHardwareName().latin1() ); InterfacePPP* ppp = static_cast<InterfacePPP*>(i); @@ -98,5 +111,6 @@ PPPModule::~PPPModule(){ * Change the current profile */ -void PPPModule::setProfile(const QString &newProfile){ +void PPPModule::setProfile(const QString &newProfile) +{ profile = newProfile; } @@ -107,5 +121,6 @@ void PPPModule::setProfile(const QString &newProfile){ * @return QString the icon name (minus .png, .gif etc) */ -QString PPPModule::getPixmapName(Interface* ){ +QString PPPModule::getPixmapName(Interface* ) +{ return "ppp"; } @@ -116,5 +131,6 @@ QString PPPModule::getPixmapName(Interface* ){ * @return bool true if i is owned by this module, false otherwise. */ -bool PPPModule::isOwner(Interface *i){ +bool PPPModule::isOwner(Interface *i) +{ return list.find( i ) != -1; } @@ -124,5 +140,6 @@ bool PPPModule::isOwner(Interface *i){ * @return QWidget* pointer to this modules configure. */ -QWidget *PPPModule::configure(Interface *i){ +QWidget *PPPModule::configure(Interface *i) +{ qDebug("return ModemWidget"); PPPConfigWidget *pppconfig = new PPPConfigWidget( (InterfacePPP*)i, @@ -136,5 +153,6 @@ QWidget *PPPModule::configure(Interface *i){ * @return QWidget* pointer to this modules info. */ -QWidget *PPPModule::information(Interface *i){ +QWidget *PPPModule::information(Interface *i) +{ // We don't have any advanced pppd information widget yet :-D // TODO ^ @@ -148,5 +166,6 @@ QWidget *PPPModule::information(Interface *i){ * been called by isOwner() */ -QList<Interface> PPPModule::getInterfaces(){ +QList<Interface> PPPModule::getInterfaces() +{ // List all of the files in the peer directory qDebug("PPPModule::getInterfaces"); @@ -160,5 +179,6 @@ QList<Interface> PPPModule::getInterfaces(){ * @return Interface* NULL if it was unable to be created. */ -Interface *PPPModule::addNewInterface(const QString &newInterface){ +Interface *PPPModule::addNewInterface(const QString &newInterface) +{ InterfacePPP *ifaceppp; @@ -166,11 +186,14 @@ Interface *PPPModule::addNewInterface(const QString &newInterface){ ifaceppp = new InterfacePPP(); PPPConfigWidget imp(ifaceppp, 0, "PPPConfigImp", true); - imp.showMaximized(); - if(imp.exec() == QDialog::Accepted ){ + + if( QPEApplication::execDialog( &imp ) == QDialog::Accepted ) + { iface = (InterfacePPP*) ifaceppp; iface->setModuleOwner( this ); list.append( iface ); return iface; - }else { + } + else + { delete ifaceppp; iface = NULL; @@ -183,5 +206,6 @@ Interface *PPPModule::addNewInterface(const QString &newInterface){ * @return bool true if successful, false otherwise. */ -bool PPPModule::remove(Interface *i){ +bool PPPModule::remove(Interface *i) +{ return list.remove(i); } @@ -195,11 +219,14 @@ void PPPModule::possibleNewInterfaces(QMap<QString, QString> &newIfaces) -namespace { - InterfaceKeeper::InterfaceKeeper( ) { - } - InterfaceKeeper::~InterfaceKeeper() { +namespace +{ + InterfaceKeeper::InterfaceKeeper( ) + {} + InterfaceKeeper::~InterfaceKeeper() + { Config cfg("ppp_plugin_keeper"); QStringList lst = cfg.groupList(); - for (QStringList::Iterator it = lst.begin(); it != lst.end(); ++it ) { + for (QStringList::Iterator it = lst.begin(); it != lst.end(); ++it ) + { Connection con; cfg.setGroup( (*it) ); @@ -207,5 +234,6 @@ namespace { } - for (QMap<QString, Connection>::Iterator it = m_interfaces.begin(); it != m_interfaces.end(); ++it ) { + for (QMap<QString, Connection>::Iterator it = m_interfaces.begin(); it != m_interfaces.end(); ++it ) + { Connection con = it.data(); cfg.setGroup( con.name ); @@ -214,5 +242,6 @@ namespace { } } - void InterfaceKeeper::addInterface(pid_t pid, const QString& dev, const QString& name ) { + void InterfaceKeeper::addInterface(pid_t pid, const QString& dev, const QString& name ) + { Connection con; con.pid = pid; @@ -221,9 +250,11 @@ namespace { m_interfaces.insert( name, con ); } - QMap<QString, Connection> InterfaceKeeper::interfaces()const { + QMap<QString, Connection> InterfaceKeeper::interfaces()const + { Config cfg("ppp_plugin_keeper"); QMap<QString, Connection> ifaces; QStringList lst = cfg.groupList(); - for (QStringList::Iterator it = lst.begin(); it != lst.end(); ++it ) { + for (QStringList::Iterator it = lst.begin(); it != lst.end(); ++it ) + { Connection con; cfg.setGroup( (*it) ); @@ -238,6 +269,8 @@ namespace { return ifaces; } - bool InterfaceKeeper::isAvailable( pid_t p)const { - if (::kill(p, 0 ) == 0 || errno != ESRCH ) { + bool InterfaceKeeper::isAvailable( pid_t p)const + { + if (::kill(p, 0 ) == 0 || errno != ESRCH ) + { qDebug("isAvailable %d", p); return true; diff --git a/noncore/settings/networksettings/wlan/wlanmodule.cpp b/noncore/settings/networksettings/wlan/wlanmodule.cpp index 07bf73f..74d7f8e 100644 --- a/noncore/settings/networksettings/wlan/wlanmodule.cpp +++ b/noncore/settings/networksettings/wlan/wlanmodule.cpp @@ -1,2 +1,3 @@ + #include "wlanmodule.h" #include "wlanimp2.h" @@ -5,4 +6,8 @@ #include "interfaceinformationimp.h" +/* OPIE */ +#include <qpe/qpeapplication.h> + +/* QT */ #include <qcheckbox.h> #include <qcombobox.h> @@ -14,6 +19,4 @@ - - /** * Constructor, find all of the possible interfaces @@ -173,5 +176,5 @@ void WLANModule::receive(const QCString ¶m, const QByteArray &arg) // those should call the interface directly QWidget *info = getInfo( ifa ); - info->showMaximized(); + QPEApplication::showWidget( info ); if ( action.contains("start" ) ){ @@ -191,5 +194,5 @@ void WLANModule::receive(const QCString ¶m, const QByteArray &arg) toShow = (QDialog*) wlanconfigWiget; } - wlanconfigWiget->showMaximized(); + QPEApplication::showWidget( wlanconfigWiget ); stream >> value; qDebug("WLANModule (build 4) is setting %s of %s to %s", action.latin1(), interface.latin1(), value.latin1() ); |