| -rw-r--r-- | libopie/pim/ocontact.h | 26 | ||||
| -rw-r--r-- | libopie2/opiepim/ocontact.h | 26 |
2 files changed, 52 insertions, 0 deletions
diff --git a/libopie/pim/ocontact.h b/libopie/pim/ocontact.h index 81ac1c1..9643e8b 100644 --- a/libopie/pim/ocontact.h +++ b/libopie/pim/ocontact.h @@ -34,22 +34,37 @@ QPC_TEMPLATEEXTERN template class QPC_EXPORT QMap<int, QString>; // MOC_SKIP_END #endif class ContactPrivate; // Wozu ist das gut und wo ist das decrariert ? (se) + /* Stefan das ist eine forward declaration + * dann machst du in der private section + * ContactPrivate *d; + * + * und wenn du bei Opie1.1 was hinzufuegen moechtest + * packst du es in ContactPrivate damit Opie + * binaer kompatibel bleibt + * -zecke + */ class QPC_EXPORT OContact : public OPimRecord { friend class DataSet; public: OContact(); OContact( const QMap<int, QString> &fromMap ); virtual ~OContact(); + /* VCARD stuff should vanish! -zecke */ static void writeVCard( const QString &filename, const QValueList<OContact> &contacts); static void writeVCard( const QString &filename, const OContact &c ); static QValueList<OContact> readVCard( const QString &filename ); enum journal_action { ACTION_ADD, ACTION_REMOVE, ACTION_REPLACE }; + /* + * do we need to inline them + * if yes do we need to inline them this way? + * -zecke + */ void setTitle( const QString &v ) { replace( Qtopia::Title, v ); } void setFirstName( const QString &v ) { replace( Qtopia::FirstName, v ); } void setMiddleName( const QString &v ) { replace( Qtopia::MiddleName, v ); } void setLastName( const QString &v ) { replace( Qtopia::LastName, v ); } @@ -126,8 +141,13 @@ public: QString defaultEmail() const { return find( Qtopia::DefaultEmail ); } QStringList emailList() const; // home + /* + * OPimAddress address(enum Location)const; + * would be some how nicer... + * -zecke + */ QString homeStreet() const { return find( Qtopia::HomeStreet ); } QString homeCity() const { return find( Qtopia::HomeCity ); } QString homeState() const { return find( Qtopia::HomeState ); } QString homeZip() const { return find( Qtopia::HomeZip ); } @@ -195,11 +215,13 @@ public: QString field( int key ) const { return find( key ); } // journaling... + /* do we still need them? Stefan your backend takes care of these -zecke */ void saveJournal( journal_action action, const QString &key = QString::null ); void save( QString &buf ) const; + /* we shouldn't inline this one -zecke */ void setUid( int i ) { OPimRecord::setUid(i); replace( Qtopia::AddressUid , QString::number(i)); } QString toShortText()const; @@ -214,8 +236,12 @@ public: QString emails() const { return find( Qtopia::Emails ); } private: + /* I do not like friends ;) + * besides that I think we do not need them + * anymore -zecke + */ friend class AbEditor; friend class AbTable; friend class AddressBookAccessPrivate; friend class XMLIO; diff --git a/libopie2/opiepim/ocontact.h b/libopie2/opiepim/ocontact.h index 81ac1c1..9643e8b 100644 --- a/libopie2/opiepim/ocontact.h +++ b/libopie2/opiepim/ocontact.h @@ -34,22 +34,37 @@ QPC_TEMPLATEEXTERN template class QPC_EXPORT QMap<int, QString>; // MOC_SKIP_END #endif class ContactPrivate; // Wozu ist das gut und wo ist das decrariert ? (se) + /* Stefan das ist eine forward declaration + * dann machst du in der private section + * ContactPrivate *d; + * + * und wenn du bei Opie1.1 was hinzufuegen moechtest + * packst du es in ContactPrivate damit Opie + * binaer kompatibel bleibt + * -zecke + */ class QPC_EXPORT OContact : public OPimRecord { friend class DataSet; public: OContact(); OContact( const QMap<int, QString> &fromMap ); virtual ~OContact(); + /* VCARD stuff should vanish! -zecke */ static void writeVCard( const QString &filename, const QValueList<OContact> &contacts); static void writeVCard( const QString &filename, const OContact &c ); static QValueList<OContact> readVCard( const QString &filename ); enum journal_action { ACTION_ADD, ACTION_REMOVE, ACTION_REPLACE }; + /* + * do we need to inline them + * if yes do we need to inline them this way? + * -zecke + */ void setTitle( const QString &v ) { replace( Qtopia::Title, v ); } void setFirstName( const QString &v ) { replace( Qtopia::FirstName, v ); } void setMiddleName( const QString &v ) { replace( Qtopia::MiddleName, v ); } void setLastName( const QString &v ) { replace( Qtopia::LastName, v ); } @@ -126,8 +141,13 @@ public: QString defaultEmail() const { return find( Qtopia::DefaultEmail ); } QStringList emailList() const; // home + /* + * OPimAddress address(enum Location)const; + * would be some how nicer... + * -zecke + */ QString homeStreet() const { return find( Qtopia::HomeStreet ); } QString homeCity() const { return find( Qtopia::HomeCity ); } QString homeState() const { return find( Qtopia::HomeState ); } QString homeZip() const { return find( Qtopia::HomeZip ); } @@ -195,11 +215,13 @@ public: QString field( int key ) const { return find( key ); } // journaling... + /* do we still need them? Stefan your backend takes care of these -zecke */ void saveJournal( journal_action action, const QString &key = QString::null ); void save( QString &buf ) const; + /* we shouldn't inline this one -zecke */ void setUid( int i ) { OPimRecord::setUid(i); replace( Qtopia::AddressUid , QString::number(i)); } QString toShortText()const; @@ -214,8 +236,12 @@ public: QString emails() const { return find( Qtopia::Emails ); } private: + /* I do not like friends ;) + * besides that I think we do not need them + * anymore -zecke + */ friend class AbEditor; friend class AbTable; friend class AddressBookAccessPrivate; friend class XMLIO; |