5 files changed, 43 insertions, 29 deletions

diff --git a/noncore/settings/networksettings2/networksettings2/system.cpp b/noncore/settings/networksettings2/networksettings2/system.cpp
index 9512579..e642c08 100644
--- a/noncore/settings/networksettings2/networksettings2/system.cpp
+++ b/noncore/settings/networksettings2/networksettings2/system.cpp
@@ -43,8 +43,9 @@ static char Dig2Hex[] = {
 // get LOW nibble of byte
 #define LN(x)           Dig2Hex[((x)&0x0f)]
 
 System::System( void ) : QObject(), ProbedInterfaces() {
+    ProcDevNet = 0;
 }
 
 System::~System( void ) {
     if( ProcDevNet )
@@ -108,15 +109,15 @@ int System::runAsRoot( QStringList & S, MyProcess * Prc ) {
         owarn << "Error starting " << S << oendl;
         if( ! Prc )
           delete P;
         // error starting app
-        return 1;
+        return 0;
       }
       owarn << "Started " << S << oendl;
     }
 
     // all is fine
-    return 0;
+    return 1;
 }
 
 int System::execAsUser( QStringList & SL ) {
       MyProcess * P = new MyProcess();
@@ -160,9 +161,9 @@ int System::execAsUser( QStringList & SL ) {
         // if we come here, the exec was not successfull
         Log(("Could not exec : %d\n", errno ));
       }
 
-      return rv;
+      return ! rv;
 }
 
 void System::SLOT_ProcessExited( MyProcess * P ) {
       QString R;
diff --git a/noncore/settings/networksettings2/opie-networksettings2.control b/noncore/settings/networksettings2/opie-networksettings2.control
index e4bd29c..874833c 100644
--- a/noncore/settings/networksettings2/opie-networksettings2.control
+++ b/noncore/settings/networksettings2/opie-networksettings2.control
@@ -1,6 +1,6 @@
 Package: opie-networksettings2
-Files: bin/networksettings2 apps/Settings/networksettings2.desktop pics/networksettings2/*.png lib/libnetworksettings2.so* pics/networksettings2/Devices/*.png
+Files: bin/networksettings2 apps/Settings/networksettings2.desktop pics/networksettings2/*.png lib/libnetworksettings2.so* pics/networksettings2/Devices/*.png  etc/NS2templates/* etc/NS2templates/*/*
 Priority: optional
 Section: opie/settings
 Maintainer: wim delvaux <wimpie@handhelds.org>
 Architecture: arm
diff --git a/noncore/settings/networksettings2/opietooth2/OTSniffGUI.ui b/noncore/settings/networksettings2/opietooth2/OTSniffGUI.ui
index 9ef540e..ec0b387 100644
--- a/noncore/settings/networksettings2/opietooth2/OTSniffGUI.ui
+++ b/noncore/settings/networksettings2/opietooth2/OTSniffGUI.ui
@@ -11,9 +11,9 @@
         <rect>
             <x>0</x>
             <y>0</y>
             <width>274</width>
-            <height>160</height>
+            <height>173</height>
         </rect>
     </property>
     <property stdset="1">
         <name>caption</name>
@@ -21,16 +21,19 @@
     </property>
     <property>
         <name>layoutMargin</name>
     </property>
+    <property>
+        <name>layoutSpacing</name>
+    </property>
     <vbox>
         <property stdset="1">
             <name>margin</name>
             <number>3</number>
         </property>
         <property stdset="1">
             <name>spacing</name>
-            <number>6</number>
+            <number>2</number>
         </property>
         <widget>
             <class>QLayoutWidget</class>
             <property stdset="1">
@@ -123,16 +126,12 @@
                 </widget>
             </hbox>
         </widget>
         <widget>
-            <class>QListBox</class>
+            <class>QTextView</class>
             <property stdset="1">
                 <name>name</name>
-                <cstring>Output_LB</cstring>
-            </property>
-            <property stdset="1">
-                <name>selectionMode</name>
-                <enum>NoSelection</enum>
+                <cstring>Output_TV</cstring>
             </property>
         </widget>
         <widget>
             <class>QLayoutWidget</class>
diff --git a/noncore/settings/networksettings2/opietooth2/Opietooth.cpp b/noncore/settings/networksettings2/opietooth2/Opietooth.cpp
index 5a890da..b14cc2f 100644
--- a/noncore/settings/networksettings2/opietooth2/Opietooth.cpp
+++ b/noncore/settings/networksettings2/opietooth2/Opietooth.cpp
@@ -20,9 +20,11 @@ using namespace Opie::Ui;
 #include <qlistview.h>
 #include <qmessagebox.h>
 #include <qprogressbar.h>
 #include <qpushbutton.h>
+#include <qscrollbar.h>
 #include <qtextstream.h>
+#include <qtextview.h>
 
 #include <Opietooth.h>
 #include <OTDriver.h>
 #include <OTPeer.h>
@@ -119,25 +121,29 @@ private :
 OTSniffing::OTSniffing( QWidget * parent ) : OTSniffGUI( parent ) {
 
       OT = OTGateway::getOTGateway();
       HciDump = 0;
-      Sys = new System();
 }
 
 OTSniffing::~OTSniffing() {
-      printf( "CLOSE \n" );
-      if ( HciDump ) {
-        HciDump->process().kill();
-        delete HciDump;
-      }
-      delete Sys;
+      SLOT_Trace( 0 );
 }
 
-void OTSniffing::SLOT_Trace( bool ) {
+void OTSniffing::SLOT_Trace( bool Run ) {
+
+      if( ! Run ) {
+        if ( HciDump ) {
+          HciDump->process().kill();
+          delete HciDump;
+        }
+        HciDump = 0;
+        return;
+      }
+
       HciDump = new MyProcess();
       QStringList SL;
 
-      SL << "hcidump";
+      SL << "/usr/sbin/hcidump";
       switch( DataFormat_CB->currentItem() ) {
         case 0 : // Hex
           SL << "-x";
           break;
@@ -161,9 +167,13 @@ void OTSniffing::SLOT_Trace( bool ) {
                SIGNAL(processExited(MyProcess*) ),
                this, 
                SLOT( SLOT_ProcessExited(MyProcess*) ) );
 
-      if( ! Sys->runAsRoot( SL, HciDump ) ) {
+      HciDump->process() << SL;
+
+      if( ! HciDump->process().start( OProcess::DontCare, 
+                                      OProcess::AllOutput )
+        ) {
         QMessageBox::warning(0,
             tr("Run hcidump"),
             tr("Cannot start %1").arg(SL.join(" "))
         );
@@ -174,11 +184,15 @@ void OTSniffing::SLOT_Trace( bool ) {
 }
 
 void OTSniffing::SLOT_Show( const QString & S ) {
       printf( "%s\n", S.latin1() );
-      Output_LB->insertItem( S );
-      Output_LB->setCurrentItem( Output_LB->count()-1 );
-      Output_LB->ensureCurrentVisible();
+      Output_TV->setText( Output_TV->text() + S + "\n" );
+
+      QScrollBar *scroll = Output_TV->verticalScrollBar();
+      scroll->setValue(scroll->maxValue());
+      //Output_LB->insertItem( S );
+      //Output_LB->setCurrentItem( Output_LB->count()-1 );
+      //Output_LB->ensureCurrentVisible();
 }
 
 void OTSniffing::SLOT_ProcessExited( MyProcess * ) {
       printf( "Exited\n" );
@@ -227,14 +241,16 @@ void OTSniffing::SLOT_Load( void ) {
         }
         QTextStream TS ( &F );
         SLOT_ClearLog();
         S = TS.read(); 
-        Output_LB->insertStringList( QStringList::split( "\n", S ) );
+        // Output_LB->insertStringList( QStringList::split( "\n", S ) );
+        Output_TV->setText( S );
       }
 }
 
 void OTSniffing::SLOT_ClearLog( void ) {
-      Output_LB->clear();
+      // Output_LB->clear();
+      Output_TV->setText( "" );
 }
 
 //
 //
diff --git a/noncore/settings/networksettings2/opietooth2/Opietooth.h b/noncore/settings/networksettings2/opietooth2/Opietooth.h
index 2b20975..e66787f 100644
--- a/noncore/settings/networksettings2/opietooth2/Opietooth.h
+++ b/noncore/settings/networksettings2/opietooth2/Opietooth.h
@@ -3,9 +3,8 @@
 
 #include <OTIcons.h>
 
 class MyProcess;
-class System;
 
 namespace Opie { 
 
   namespace Ui { 
@@ -50,9 +49,8 @@ protected :
 private :
 
       OTGateway *       OT;
       MyProcess *       HciDump;
-      System *          Sys;
 };
 };
 
 #include <OTPairingGUI.h>