1 files changed, 60 insertions, 60 deletions

diff --git a/core/opie-login/loginwindowimpl.cpp b/core/opie-login/loginwindowimpl.cpp
index 3265b46..f24ebb3 100644
--- a/core/opie-login/loginwindowimpl.cpp
+++ b/core/opie-login/loginwindowimpl.cpp
@@ -22,2 +22,3 @@
 #include <stdlib.h>
+#include <signal.h>
 
@@ -38,6 +39,7 @@ LoginWindowImpl::LoginWindowImpl ( ) : LoginWindow ( 0, "LOGIN-WINDOW", WStyle_C
         QPopupMenu *pop = new QPopupMenu ( this );
-                pop-> insertItem ( tr( "Restart" ), this, SLOT( restart ( )));
+        pop-> insertItem ( tr( "Restart" ), this, SLOT( restart ( )));
+        pop-> insertItem ( tr( "Quit" ), this, SLOT( quit ( )));
         m_menu-> setPopup ( pop );
 
-        QHBoxLayout *lay = new QHBoxLayout ( m_taskbar, 4, 4 ); 
+        QHBoxLayout *lay = new QHBoxLayout ( m_taskbar, 4, 4 );
         m_input = new InputMethods ( m_taskbar );
@@ -45,3 +47,3 @@ LoginWindowImpl::LoginWindowImpl ( ) : LoginWindow ( 0, "LOGIN-WINDOW", WStyle_C
         lay-> addStretch ( 10 );
-        
+
         setActiveWindow ( );
@@ -50,12 +52,12 @@ LoginWindowImpl::LoginWindowImpl ( ) : LoginWindow ( 0, "LOGIN-WINDOW", WStyle_C
         m_user-> insertStringList ( getAllUsers ( ));
-        
+
         QTimer::singleShot ( 0, this, SLOT( showIM ( )));
-                
-                QString opiedir = ::getenv ( "OPIEDIR" );
+
+        QString opiedir = ::getenv ( "OPIEDIR" );
         QPixmap bgpix ( opiedir + "/pics/launcher/opie-background.jpg" );
-        
+
         if ( !bgpix. isNull ( ))
                 setBackgroundPixmap ( bgpix );
-        
-        m_caption-> setText ( m_caption-> text ( ) + tr( "<center><h1><u>%1 %2</u></h1></center>" ). arg ( ODevice::inst ( )-> systemString ( )). arg ( ODevice::inst ( )-> systemVersionString ( )));
+
+        m_caption-> setText ( m_caption-> text ( ) + tr( "<center>%1 %2</center>" ). arg ( ODevice::inst ( )-> systemString ( )). arg ( ODevice::inst ( )-> systemVersionString ( )));
 }
@@ -69,8 +71,8 @@ void LoginWindowImpl::keyPressEvent ( QKeyEvent *e )
         switch ( e-> key ( )) {
-                case Key_F34: suspend ( );
-                              break;
-                case Key_F35: backlight ( );
-                              break; 
-                default     : e-> ignore ( );
-                              break;
+                case HardKey_Suspend:   suspend ( );
+                                        break;
+                case HardKey_Backlight: backlight ( );
+                                        break;
+                default:                e-> ignore ( );
+                                        break;
         }
@@ -90,9 +92,9 @@ QStringList LoginWindowImpl::getAllUsers ( )
 
-        while (( pwd = getpwent ( ))) {
+        while (( pwd = ::getpwent ( ))) {
                 if (( pwd-> pw_uid == 0 ) || ( pwd-> pw_uid >= 500 && pwd-> pw_uid < 65534 ))
                         sl << QString ( pwd-> pw_name );
-                }       
-        
-        endpwent ( );
-        
+        }
+
+        ::endpwent ( );
+
         return sl;
@@ -110,10 +112,14 @@ void LoginWindowImpl::restart ( )
 
+void LoginWindowImpl::quit ( )
+{
+        qApp-> quit ( );
+        ::kill ( ::getppid ( ), SIGUSR1 );
+}
+
 void LoginWindowImpl::suspend ( )
 {
-        system ( "apm -s" );
-        usleep ( 1 * 1000 * 1000 );
-        {
-                QCopEnvelope e("QPE/System", "setBacklight(int)");
-                e << -3; // Force on
-        }
+        ODevice::inst ( )-> suspend ( );
+
+        QCopEnvelope e("QPE/System", "setBacklight(int)");
+        e << -3; // Force on
 }
@@ -122,6 +128,4 @@ void LoginWindowImpl::backlight ( )
 {
-        {
-                QCopEnvelope e("QPE/System", "setBacklight(int)");
-                e << -2; // toggle
-        }
+        QCopEnvelope e("QPE/System", "setBacklight(int)");
+        e << -2; // toggle
 }
@@ -160,3 +164,3 @@ static int PAM_conv( int num_msg, pam_message_type **msg,
   int size = sizeof(struct pam_response);
-    
+
   for( count = 0; count < num_msg; count++ ) {
@@ -195,3 +199,3 @@ static bool pwcheck_PAM( const char *user, const char *password )
   PAM_password = password;
-  
+
   pam_error = pam_start( _PAM_SERVICE, user, &PAM_conversation, &pamh );
@@ -224,14 +228,14 @@ static bool pwcheck_Unix( const char *user, const char *pass )
                 return false;
-        
+
         pw = getpwnam ( user );
-        
+
         if ( !pw )
                 return false;
-        
+
         if (( strcmp ( pw-> pw_passwd, "x" ) == 0 ) || ( strcmp ( pw-> pw_passwd, "*" ) == 0 )) {
                 struct spwd *sp = getspnam ( pw-> pw_name );
-                
+
                 if ( !sp )
                         return false;
-                
+
                 correct = sp-> sp_pwdp;
@@ -258,27 +262,17 @@ bool LoginWindowImpl::changeIdentity ( const char *user )
         struct passwd *pw = getpwnam ( user );
-        
+
         fail |= ( pw == 0 );
-        printf ( "1 %d\n", fail );
         fail |= ( initgroups ( pw-> pw_name, pw-> pw_gid ));
         endgrent ( );
-        printf ( "2 %d\n", fail );
         fail |= ( setgid ( pw-> pw_gid ));
-        printf ( "3 %d\n", fail );
         fail |= ( setuid ( pw-> pw_uid ));
-        
-        printf ( "4 %d\n", fail );
+
         fail |= ( chdir ( pw-> pw_dir ) && chdir ( "/" ));
 
-        printf ( "5 %d\n", fail );
         fail |= ( setenv ( "HOME",    pw-> pw_dir, 1 ));
-        printf ( "6 %d\n", fail );
         fail |= ( setenv ( "SHELL",   pw-> pw_shell, 1 ));
-        printf ( "7 %d\n", fail );
         fail |= ( setenv ( "USER",    pw-> pw_name, 1 ));
-        printf ( "8 %d\n", fail );
         fail |= ( setenv ( "LOGNAME", pw-> pw_name, 1 ));
-        printf ( "9 %d\n", fail );
         fail |= ( setenv ( "PATH",    ( pw-> pw_uid ? DEFAULT_LOGIN_PATH : DEFAULT_ROOT_LOGIN_PATH ), 1 ));
-        printf ( "10 %d\n", fail );
-        
+
         return !fail;
@@ -288,6 +282,6 @@ void LoginWindowImpl::login ( )
 {
-                const char *user = strdup ( m_user-> currentText ( ). local8Bit ( ));
-        const char *pass = strdup ( m_password-> text ( ). local8Bit ( ));
+        const char *user = ::strdup ( m_user-> currentText ( ). local8Bit ( ));
+        const char *pass = ::strdup ( m_password-> text ( ). local8Bit ( ));
         bool ok;
-        
+
         if ( !user || !user [0] )
@@ -304,9 +298,15 @@ void LoginWindowImpl::login ( )
         if ( ok ) {
-                        if ( changeIdentity ( user )) {         
-                        QString opie = getenv ( "OPIEDIR" );
-                        opie += "/bin/qpe";
-                
-                        execl ( opie. latin1 ( ), "qpe", 0 );
-                
-                        QMessageBox::critical ( this, tr( "Failure" ), tr( "Could not start OPIE." ));
+                if ( changeIdentity ( user )) {
+                        char *opie = ::getenv ( "OPIEDIR" );
+                        char *arg = new char [::strlen ( opie ) + 8 + 1];
+
+                        ::strcpy ( arg, opie );
+                        ::strcat ( arg, "/bin/qpe" );
+
+                        // start qpe via a login shell
+                        ::execl ( "/bin/sh", "-sh", "-c", arg, 0 );
+
+                        QMessageBox::critical ( this, tr( "Failure" ), tr( "Could not start OPIE\n(%1)." ). arg ( arg ));
+                        delete [] arg;
+
                         restart ( );