1 files changed, 55 insertions, 12 deletions

diff --git a/core/pim/addressbook/contacteditor.cpp b/core/pim/addressbook/contacteditor.cpp
index d14ac51..d830ad3 100644
--- a/core/pim/addressbook/contacteditor.cpp
+++ b/core/pim/addressbook/contacteditor.cpp
@@ -58,38 +58,45 @@ static inline bool constainsWhiteSpace( const QString &str );
 void parseEmailFrom( const QString &txt, QString &strDefaultEmail,
                      QString &strAll );
 
 // helper convert from file format to comma delimited...
 void parseEmailTo( const QString &strDefaultEmail,
                    const QString &strOtherEmail, QString &strBack );
 
         ContactEditor::ContactEditor(const OContact &entry,
                                 QWidget *parent,
                                 const char *name,
                                 WFlags fl )
         : QDialog( parent, name, TRUE, fl ),
-          m_personalView ( false )
-          
+          defaultEmailChooserPosition( -1 ),
+          m_personalView ( false ),
+          cmbDefaultEmail( 0 ),
+          initializing ( false )
 {
 
+        initializing = true;
+
         init();
         setEntry( entry );
-        cmbDefaultEmail = 0;
-        defaultEmailChooserPosition = -1;
+        // cmbDefaultEmail = 0;
+        // defaultEmailChooserPosition = -1;
+
+        initializing = false;
 }
 
 ContactEditor::~ContactEditor() {
 }
 
 void ContactEditor::init() {
+        qWarning("init() START");
         
         useFullName = true;
 
         uint i = 0;
 
         QStringList trlChooserNames;
 
         for (i = 0; i <= 6; i++) {
                 slHomeAddress.append( "" );
                 slBusinessAddress.append( "" );
         }
 
@@ -633,24 +640,26 @@ void ContactEditor::init() {
         connect( cmbChooserField2, SIGNAL(activated(int)),
                  this, SLOT(slotCmbChooser2Change(int)) );
         connect( cmbChooserField3, SIGNAL(activated(int)),
                  this, SLOT(slotCmbChooser3Change(int)) );
         connect( cmbChooserField4, SIGNAL(activated(int)),
                  this, SLOT(slotCmbChooser4Change(int)) );
         connect( cmbAddress, SIGNAL(activated(int)),
                  this, SLOT(slotAddressTypeChange(int)) );
 
         new QPEDialogListener(this);
 
         setPersonalView ( m_personalView );
+
+        qWarning("init() END");
 }
 
 void ContactEditor::defaultEmailChanged(int i){
         qDebug("defaultEmailChanged");
 
         // was sollte das ? (se)
         // int index = cmbChooserField1->currentItem();
         // slChooserValues[index] = cmbDefaultEmail->text(i);
 
         defaultEmail = cmbDefaultEmail->text(i);
         qDebug ("Changed to: %s", defaultEmail.latin1());
 
@@ -683,43 +692,52 @@ void ContactEditor::populateDefaultEmailCmb(){
         
         // If the current default email is not found in the list, we choose the
         // first one..
         if ( !found )
                 defaultEmail = cmbDefaultEmail->text(0);
 }
 
 // Called when any combobox was changed.
 // "true" returned if the change was chandled by this function, else it should
 // be handled by something else..
 bool ContactEditor::cmbChooserChange( int index, QLineEdit *inputWid, int widgetPos ) {
         QString type = slChooserNames[index];
-        qWarning("ContactEditor::cmbChooserChange -> Type: %s", type.latin1() );
+        qWarning("ContactEditor::cmbChooserChange -> Type: %s, WidgetPos: %d", type.latin1(), widgetPos );
+
+        if ( !initializing )
+                contactfields.setFieldOrder( widgetPos-1, index );
 
         // Create and connect combobox for selecting the default email 
         if ( type == "Default Email"){         
-                qWarning("Choosing default-email ");
+                qWarning("Choosing default-email (defaultEmailChooserPosition= %d) ", defaultEmailChooserPosition);
                 
                 // More than one defaul-email chooser is not allowed !
                 if ( ( defaultEmailChooserPosition != -1 ) && 
-                     defaultEmailChooserPosition != widgetPos ){
+                     defaultEmailChooserPosition != widgetPos && !initializing){
                         chooserError( widgetPos );
                         return true;
                 }
 
                 if ( cmbDefaultEmail ){  
                         delete cmbDefaultEmail;
                         cmbDefaultEmail = 0l;
                 }
                         cmbDefaultEmail = new QComboBox(inputWid->parentWidget());   
-                cmbDefaultEmail->setGeometry(inputWid->frameGeometry()); 
+                cmbDefaultEmail->setGeometry(inputWid->frameGeometry()); /* :SX */
+
+                QRect rect = inputWid->frameGeometry();
+                qWarning("Geometrie: X=%d, Y=%d, Left=%d, Top=%d, Right=%d, Bottom=%d", 
+                         rect.x(), rect.y(), rect.left(), rect.top(), rect.right(), rect.bottom());
+                QPoint pnt = inputWid->pos();
+                qWarning("Position : X=%d, Y=%d", pnt.x(), pnt.y() );
                 
                 connect( cmbDefaultEmail,SIGNAL( activated(int) ),
                          SLOT( defaultEmailChanged(int) ) ); 
 
                 cmbDefaultEmail->clear();    
                 cmbDefaultEmail->insertStringList( emails );
                 cmbDefaultEmail->show();
 
                 defaultEmailChooserPosition = widgetPos;
 
                 // Set current default email
                 populateDefaultEmailCmb();
@@ -935,24 +953,29 @@ void ContactEditor::slotCmbChooser4Change( int index ) {
         qWarning("ContactEditor::slotCmbChooser4Change( %d )", index);
 
         if ( !cmbChooserChange( cmbChooserField4->currentItem(), txtChooserField4, 4) ){
 
                 txtChooserField4->setText( slChooserValues[index] );
                 txtChooserField4->setFocus();
 
         }
 }
 
 void ContactEditor::slotAddressTypeChange( int index ) {
 
+
+        if ( !initializing )
+                contactfields.setFieldOrder( 4, index );
+
+
         if ( index == 0 ) {
 
                 txtAddress->setText( slBusinessAddress[0] );
                 //txtAddress2->setText( (*slBusinessAddress)[1] );
                 //txtPOBox->setText( (*slBusinessAddress)[2] );
                 txtCity->setText( slBusinessAddress[3] );
                 txtState->setText( slBusinessAddress[4] );
                 txtZip->setText( slBusinessAddress[5] );
                 QLineEdit *txtTmp = cmbCountry->lineEdit();
                 txtTmp->setText( slBusinessAddress[6] );
 
         } else {
@@ -1267,30 +1290,30 @@ void ContactEditor::cleanupFields() {
         txtCity->setText("");
         txtState->setText("");
         txtZip->setText("");
         QLineEdit *txtTmp = cmbCountry->lineEdit();
         txtTmp->setText("");
         txtTmp = cmbFileAs->lineEdit();
         txtTmp->setText("");
 
 }
 
 void ContactEditor::setEntry( const OContact &entry ) {
 
+        initializing = true;
+
         cleanupFields();
 
         ent = entry;
 
-
-
         emails = QStringList(ent.emailList());
         defaultEmail = ent.defaultEmail();
         if (defaultEmail.isEmpty()) defaultEmail = emails[0];
         qDebug("default email=%s",defaultEmail.latin1());
 
         useFullName = false;
         txtFirstName->setText( ent.firstName() );
         txtMiddleName->setText( ent.middleName() );
         txtLastName->setText( ent.lastName() );
         txtSuffix->setText( ent.suffix() );
 
         QString *tmpString = new QString;
@@ -1446,52 +1469,72 @@ void ContactEditor::setEntry( const OContact &entry ) {
 
 
         }
 
         
         cmbCat->setCategories( ent.categories(), "Contacts", tr("Contacts") );
 
         QString gender = ent.gender();
         cmbGender->setCurrentItem( gender.toInt() );
 
         txtNote->setText( ent.notes() );
 
+        slotAddressTypeChange( cmbAddress->currentItem() );
+
+        // Calling "show()" to arrange all widgets. Otherwise we will get
+        // a wrong position of the textfields and are unable to put our
+        // default-email combo over it.. This is very ugly !
+        // Does anybody has a better solution ? 
+        // Basically we should rethink the strategy to hide
+        // a textfield with overwriting.. (se)
+        show();
+
+        // Get combo-settings from contact and set preset..
+        contactfields.loadFromRecord( ent );
+        cmbChooserField1->setCurrentItem( contactfields.getFieldOrder(0, 0) );
+        cmbChooserField2->setCurrentItem( contactfields.getFieldOrder(1, 1) );
+        cmbChooserField3->setCurrentItem( contactfields.getFieldOrder(2, 2) );
+        cmbChooserField4->setCurrentItem( contactfields.getFieldOrder(3, 5) );
+        cmbAddress->setCurrentItem( contactfields.getFieldOrder(4, 1) );
         slotCmbChooser1Change( cmbChooserField1->currentItem() );
         slotCmbChooser2Change( cmbChooserField2->currentItem() );
         slotCmbChooser3Change( cmbChooserField3->currentItem() );
-
+        slotCmbChooser4Change( cmbChooserField4->currentItem() );
         slotAddressTypeChange( cmbAddress->currentItem() );
 
-        // loadFields(); :SX
         updateDatePicker();
+
+        initializing = false;
 }
 void ContactEditor::updateDatePicker()
 {
         // Set DatePicker
         if ( !ent.birthday().isNull() ){
                 birthdayButton->setText( TimeString::numberDateString( ent.birthday() ) );
                 birthdayPicker->setDate( ent.birthday() );
         } else
                 birthdayButton->setText( tr ("Unknown") );
                 
         if ( !ent.anniversary().isNull() ){
                 anniversaryButton->setText( TimeString::numberDateString( ent.anniversary() ) );
                 anniversaryPicker->setDate( ent.anniversary() );
         } else
                 anniversaryButton->setText( tr ("Unknown") );
 
 }
 
 void ContactEditor::saveEntry() {
 
+        // Store current combo into contact
+        contactfields.saveToRecord( ent );
 
         if ( useFullName ) {
                 txtFirstName->setText( parseName( txtFullName->text(), NAME_F ) );
                 txtMiddleName->setText( parseName( txtFullName->text(), NAME_M ) );
                 txtLastName->setText( parseName( txtFullName->text(), NAME_L ) );
                 txtSuffix->setText( parseName( txtFullName->text(), NAME_S ) );
 
                 useFullName = false;
         }
 
         ent.setFirstName( txtFirstName->text() );
         ent.setLastName( txtLastName->text() );